From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D814BC433F5 for ; Sun, 13 Feb 2022 04:19:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233393AbiBMETD (ORCPT ); Sat, 12 Feb 2022 23:19:03 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:60166 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232021AbiBMETB (ORCPT ); Sat, 12 Feb 2022 23:19:01 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 757934D627; Sat, 12 Feb 2022 20:18:56 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EA80E60EC8; Sun, 13 Feb 2022 04:18:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AF1CAC004E1; Sun, 13 Feb 2022 04:18:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1644725935; bh=p/ufFHAr6UeinZdHwhtVze3Hpr+rcfIupxTX/GoBTEs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=M7IiHT69weTTTjTQzLEW1+5HoFuEUmrLZr7MB3NMNKdWc/0ZUBwFpBQQn/eHyNkx7 nb44W6j+MgrZ42DxkbrYQI1114YnkLzGYU7zJMghexGRFhvvA6zM0ozFDoU9oXNk84 z7aMKZuTfkQFPQvJILH1LNlOc6MkVXh5M2chlsCTHV018TH6Wzsn5/G0zBJA4JgtLp JPYFDDHIX7v0dQYEjVQR50TO62/0Dx2Ciflfmjsn0APUL0iGEVBKYV4y/HeaUP4bD0 9r9Gzrr9D2ACEEuJiw6yDqXlfiJUArLmeymwt/PP5k+Uq9+qlqeB/uxLj/J+XV9g0m YPCsQyv/ZSsMg== Date: Sun, 13 Feb 2022 12:18:49 +0800 From: Shawn Guo To: Ariel D'Alessandro Cc: alsa-devel@alsa-project.org, devicetree@vger.kernel.org, kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, broonie@kernel.org, festevam@gmail.com, krzysztof.kozlowski@canonical.com, lgirdwood@gmail.com, michael@amarulasolutions.com, robh+dt@kernel.org, s.hauer@pengutronix.de Subject: Re: [PATCH v2 2/2] arm64: dts: imx8mn-bsh-smm-s2pro: Add tlv320aic31xx audio card node Message-ID: <20220213041823.GL4909@dragon> References: <20220210134049.32576-1-ariel.dalessandro@collabora.com> <20220210134049.32576-2-ariel.dalessandro@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220210134049.32576-2-ariel.dalessandro@collabora.com> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 10, 2022 at 10:40:49AM -0300, Ariel D'Alessandro wrote: > BSH SystemMaster (SMM) S2 PRO board comes with an audio card based on > tlv320aic31xx family codec. > > The audio card exposes two playback devices, one of them using the EASRC > (Enhanced Asynchronous Sample Rate Converter) module. Note that this > would require SDMA and EASRC firmware in order to work. > > Signed-off-by: Ariel D'Alessandro > Signed-off-by: Michael Trimarchi > --- > .../dts/freescale/imx8mn-bsh-smm-s2pro.dts | 94 +++++++++++++++++++ > 1 file changed, 94 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2pro.dts b/arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2pro.dts > index c6a8ed6745c1..3621354b4a92 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2pro.dts > +++ b/arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2pro.dts > @@ -7,6 +7,7 @@ > /dts-v1/; > > #include "imx8mn-bsh-smm-s2-common.dtsi" > +#include > > / { > model = "BSH SMM S2 PRO"; > @@ -16,6 +17,69 @@ memory@40000000 { > device_type = "memory"; > reg = <0x0 0x40000000 0x0 0x20000000>; > }; > + > + sound-tlv320aic31xx { > + compatible = "fsl,imx-audio-tlv320aic31xx"; > + model = "tlv320aic31xx-hifi"; > + audio-cpu = <&sai3>; > + audio-codec = <&codec>; > + audio-asrc = <&easrc>; > + audio-routing = > + "Ext Spk", "SPL", > + "Ext Spk", "SPR"; > + mclk-id = ; > + }; > + > + vdd_input: vdd_input { > + compatible = "regulator-fixed"; > + regulator-name = "vdd_input"; > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>; > + }; > +}; > + > +&easrc { > + fsl,asrc-rate = <48000>; Double spaces before '='. > + fsl,asrc-format = <10>; > + status = "okay"; > +}; > + > +&i2c2 { > + clock-frequency = <400000>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_i2c2>; > + status = "okay"; > + > + codec: tlv320dac3101@18 { tlv320dac3101: audio-codec@18 > + #sound-dai-cells = <0>; > + compatible = "ti,tlv320dac3101"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_dac_rst>; > + reg = <0x18>; > + > + ai31xx-micbias-vg = ; > + > + HPVDD-supply = <&buck4_reg>; > + SPRVDD-supply = <&vdd_input>; > + SPLVDD-supply = <&vdd_input>; > + AVDD-supply = <&buck4_reg>; > + IOVDD-supply = <&buck4_reg>; > + DVDD-supply = <&buck5_reg>; > + reset-gpios = <&gpio1 6 GPIO_ACTIVE_LOW>; > + > + clocks = <&clk IMX8MN_CLK_SAI3_ROOT>; > + clock-names = "mclk"; > + }; > +}; > + > +&sai3 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_sai3>; > + assigned-clocks = <&clk IMX8MN_CLK_SAI3>; > + assigned-clock-parents = <&clk IMX8MN_AUDIO_PLL1_OUT>; > + assigned-clock-rates = <24576000>; > + fsl,sai-mclk-direction-output; > + status = "okay"; > }; > > /* eMMC */ > @@ -30,6 +94,36 @@ &usdhc1 { > }; > > &iomuxc { > + pinctrl_dac_rst: dac_rst { Name the node more in the same style as other pinctrl nodes. Shawn > + fsl,pins = < > + MX8MN_IOMUXC_GPIO1_IO06_GPIO1_IO6 0x19 /* DAC_RST */ > + >; > + }; > + > + pinctrl_espi2: espi2grp { > + fsl,pins = < > + MX8MN_IOMUXC_ECSPI2_SCLK_ECSPI2_SCLK 0x082 > + MX8MN_IOMUXC_ECSPI2_MOSI_ECSPI2_MOSI 0x082 > + MX8MN_IOMUXC_ECSPI2_MISO_ECSPI2_MISO 0x082 > + MX8MN_IOMUXC_ECSPI2_SS0_ECSPI2_SS0 0x040 > + >; > + }; > + > + pinctrl_i2c2: i2c2grp { > + fsl,pins = < > + MX8MN_IOMUXC_I2C2_SCL_I2C2_SCL 0x400000c3 > + MX8MN_IOMUXC_I2C2_SDA_I2C2_SDA 0x400000c3 > + >; > + }; > + > + pinctrl_sai3: sai3grp { > + fsl,pins = < > + MX8MN_IOMUXC_SAI3_TXFS_SAI3_TX_SYNC 0xd6 > + MX8MN_IOMUXC_SAI3_TXC_SAI3_TX_BCLK 0xd6 > + MX8MN_IOMUXC_SAI3_TXD_SAI3_TX_DATA0 0xd6 > + >; > + }; > + > pinctrl_usdhc1: usdhc1grp { > fsl,pins = < > MX8MN_IOMUXC_SD1_CLK_USDHC1_CLK 0x40000090 > -- > 2.34.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 027DAC433EF for ; Sun, 13 Feb 2022 04:20:02 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 534481707; Sun, 13 Feb 2022 05:19:10 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 534481707 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1644726000; bh=p/ufFHAr6UeinZdHwhtVze3Hpr+rcfIupxTX/GoBTEs=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=oKOa/VXDVSYke67rYE1x6flxDf0JhVzYyWO+X5KVK6uWPHUk6jhEfkArAgUKeZbhh eSBNxlstObHwEhczheIq8yRXagWHNGtF75fMgcKHiOKqP2RGg8//KC8e4YjXDTXutX Vs0bEoQZkth2otp5pS0Y/uY17DNoEt7oz2e8Nc0Y= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id C1BA3F8019D; Sun, 13 Feb 2022 05:19:09 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 4C000F8025D; Sun, 13 Feb 2022 05:19:06 +0100 (CET) Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 1EDB5F8012F for ; Sun, 13 Feb 2022 05:18:59 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 1EDB5F8012F Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="M7IiHT69" Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B1C2BB80A09; Sun, 13 Feb 2022 04:18:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AF1CAC004E1; Sun, 13 Feb 2022 04:18:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1644725935; bh=p/ufFHAr6UeinZdHwhtVze3Hpr+rcfIupxTX/GoBTEs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=M7IiHT69weTTTjTQzLEW1+5HoFuEUmrLZr7MB3NMNKdWc/0ZUBwFpBQQn/eHyNkx7 nb44W6j+MgrZ42DxkbrYQI1114YnkLzGYU7zJMghexGRFhvvA6zM0ozFDoU9oXNk84 z7aMKZuTfkQFPQvJILH1LNlOc6MkVXh5M2chlsCTHV018TH6Wzsn5/G0zBJA4JgtLp JPYFDDHIX7v0dQYEjVQR50TO62/0Dx2Ciflfmjsn0APUL0iGEVBKYV4y/HeaUP4bD0 9r9Gzrr9D2ACEEuJiw6yDqXlfiJUArLmeymwt/PP5k+Uq9+qlqeB/uxLj/J+XV9g0m YPCsQyv/ZSsMg== Date: Sun, 13 Feb 2022 12:18:49 +0800 From: Shawn Guo To: Ariel D'Alessandro Subject: Re: [PATCH v2 2/2] arm64: dts: imx8mn-bsh-smm-s2pro: Add tlv320aic31xx audio card node Message-ID: <20220213041823.GL4909@dragon> References: <20220210134049.32576-1-ariel.dalessandro@collabora.com> <20220210134049.32576-2-ariel.dalessandro@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220210134049.32576-2-ariel.dalessandro@collabora.com> User-Agent: Mutt/1.9.4 (2018-02-28) Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, krzysztof.kozlowski@canonical.com, s.hauer@pengutronix.de, linux-kernel@vger.kernel.org, robh+dt@kernel.org, lgirdwood@gmail.com, broonie@kernel.org, linux-imx@nxp.com, kernel@pengutronix.de, michael@amarulasolutions.com, festevam@gmail.com, linux-arm-kernel@lists.infradead.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, Feb 10, 2022 at 10:40:49AM -0300, Ariel D'Alessandro wrote: > BSH SystemMaster (SMM) S2 PRO board comes with an audio card based on > tlv320aic31xx family codec. > > The audio card exposes two playback devices, one of them using the EASRC > (Enhanced Asynchronous Sample Rate Converter) module. Note that this > would require SDMA and EASRC firmware in order to work. > > Signed-off-by: Ariel D'Alessandro > Signed-off-by: Michael Trimarchi > --- > .../dts/freescale/imx8mn-bsh-smm-s2pro.dts | 94 +++++++++++++++++++ > 1 file changed, 94 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2pro.dts b/arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2pro.dts > index c6a8ed6745c1..3621354b4a92 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2pro.dts > +++ b/arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2pro.dts > @@ -7,6 +7,7 @@ > /dts-v1/; > > #include "imx8mn-bsh-smm-s2-common.dtsi" > +#include > > / { > model = "BSH SMM S2 PRO"; > @@ -16,6 +17,69 @@ memory@40000000 { > device_type = "memory"; > reg = <0x0 0x40000000 0x0 0x20000000>; > }; > + > + sound-tlv320aic31xx { > + compatible = "fsl,imx-audio-tlv320aic31xx"; > + model = "tlv320aic31xx-hifi"; > + audio-cpu = <&sai3>; > + audio-codec = <&codec>; > + audio-asrc = <&easrc>; > + audio-routing = > + "Ext Spk", "SPL", > + "Ext Spk", "SPR"; > + mclk-id = ; > + }; > + > + vdd_input: vdd_input { > + compatible = "regulator-fixed"; > + regulator-name = "vdd_input"; > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>; > + }; > +}; > + > +&easrc { > + fsl,asrc-rate = <48000>; Double spaces before '='. > + fsl,asrc-format = <10>; > + status = "okay"; > +}; > + > +&i2c2 { > + clock-frequency = <400000>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_i2c2>; > + status = "okay"; > + > + codec: tlv320dac3101@18 { tlv320dac3101: audio-codec@18 > + #sound-dai-cells = <0>; > + compatible = "ti,tlv320dac3101"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_dac_rst>; > + reg = <0x18>; > + > + ai31xx-micbias-vg = ; > + > + HPVDD-supply = <&buck4_reg>; > + SPRVDD-supply = <&vdd_input>; > + SPLVDD-supply = <&vdd_input>; > + AVDD-supply = <&buck4_reg>; > + IOVDD-supply = <&buck4_reg>; > + DVDD-supply = <&buck5_reg>; > + reset-gpios = <&gpio1 6 GPIO_ACTIVE_LOW>; > + > + clocks = <&clk IMX8MN_CLK_SAI3_ROOT>; > + clock-names = "mclk"; > + }; > +}; > + > +&sai3 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_sai3>; > + assigned-clocks = <&clk IMX8MN_CLK_SAI3>; > + assigned-clock-parents = <&clk IMX8MN_AUDIO_PLL1_OUT>; > + assigned-clock-rates = <24576000>; > + fsl,sai-mclk-direction-output; > + status = "okay"; > }; > > /* eMMC */ > @@ -30,6 +94,36 @@ &usdhc1 { > }; > > &iomuxc { > + pinctrl_dac_rst: dac_rst { Name the node more in the same style as other pinctrl nodes. Shawn > + fsl,pins = < > + MX8MN_IOMUXC_GPIO1_IO06_GPIO1_IO6 0x19 /* DAC_RST */ > + >; > + }; > + > + pinctrl_espi2: espi2grp { > + fsl,pins = < > + MX8MN_IOMUXC_ECSPI2_SCLK_ECSPI2_SCLK 0x082 > + MX8MN_IOMUXC_ECSPI2_MOSI_ECSPI2_MOSI 0x082 > + MX8MN_IOMUXC_ECSPI2_MISO_ECSPI2_MISO 0x082 > + MX8MN_IOMUXC_ECSPI2_SS0_ECSPI2_SS0 0x040 > + >; > + }; > + > + pinctrl_i2c2: i2c2grp { > + fsl,pins = < > + MX8MN_IOMUXC_I2C2_SCL_I2C2_SCL 0x400000c3 > + MX8MN_IOMUXC_I2C2_SDA_I2C2_SDA 0x400000c3 > + >; > + }; > + > + pinctrl_sai3: sai3grp { > + fsl,pins = < > + MX8MN_IOMUXC_SAI3_TXFS_SAI3_TX_SYNC 0xd6 > + MX8MN_IOMUXC_SAI3_TXC_SAI3_TX_BCLK 0xd6 > + MX8MN_IOMUXC_SAI3_TXD_SAI3_TX_DATA0 0xd6 > + >; > + }; > + > pinctrl_usdhc1: usdhc1grp { > fsl,pins = < > MX8MN_IOMUXC_SD1_CLK_USDHC1_CLK 0x40000090 > -- > 2.34.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 31B44C433EF for ; Sun, 13 Feb 2022 04:20:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2+ep1qoAfIg0Sk2+UqnaxWRV7Y6efaWxD+EqKL5RODU=; b=MUYo9K0PTOCZ20 j9Ugh/iyhqlMwmDamfxn3NCbbK6opiZE9Zvx22GQTKW1Wax4A/blomAb1L0bsge8ADGsMAnKTMjmm tdgPSVZ9OHeBDykkIulaCL+YojzEPPGKGbX8VwjWsAiPe3rgg8XkK9pszaFZZr3+OmXJ0wW+TlAj3 WgN5FLXidOO2Qlek8Au3BGq7Zy+sSqlNcLPwTqm6dx7kkFouI8/S7CQxXRuJ/0TceUUCWzm9EY0ga td3Aw+lJOwRY0NWiHekR5lTytxsDA6FveZWB8K5xjRyexmkwb1Fk1DGeW21hYw9JgYP2BLnJ5o5DG JspdV2IswZV+16/NJ1UQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nJ6Ln-00AvVw-6B; Sun, 13 Feb 2022 04:19:03 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nJ6Li-00AvV3-PG for linux-arm-kernel@lists.infradead.org; Sun, 13 Feb 2022 04:19:01 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B1C2BB80A09; Sun, 13 Feb 2022 04:18:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AF1CAC004E1; Sun, 13 Feb 2022 04:18:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1644725935; bh=p/ufFHAr6UeinZdHwhtVze3Hpr+rcfIupxTX/GoBTEs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=M7IiHT69weTTTjTQzLEW1+5HoFuEUmrLZr7MB3NMNKdWc/0ZUBwFpBQQn/eHyNkx7 nb44W6j+MgrZ42DxkbrYQI1114YnkLzGYU7zJMghexGRFhvvA6zM0ozFDoU9oXNk84 z7aMKZuTfkQFPQvJILH1LNlOc6MkVXh5M2chlsCTHV018TH6Wzsn5/G0zBJA4JgtLp JPYFDDHIX7v0dQYEjVQR50TO62/0Dx2Ciflfmjsn0APUL0iGEVBKYV4y/HeaUP4bD0 9r9Gzrr9D2ACEEuJiw6yDqXlfiJUArLmeymwt/PP5k+Uq9+qlqeB/uxLj/J+XV9g0m YPCsQyv/ZSsMg== Date: Sun, 13 Feb 2022 12:18:49 +0800 From: Shawn Guo To: Ariel D'Alessandro Cc: alsa-devel@alsa-project.org, devicetree@vger.kernel.org, kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, broonie@kernel.org, festevam@gmail.com, krzysztof.kozlowski@canonical.com, lgirdwood@gmail.com, michael@amarulasolutions.com, robh+dt@kernel.org, s.hauer@pengutronix.de Subject: Re: [PATCH v2 2/2] arm64: dts: imx8mn-bsh-smm-s2pro: Add tlv320aic31xx audio card node Message-ID: <20220213041823.GL4909@dragon> References: <20220210134049.32576-1-ariel.dalessandro@collabora.com> <20220210134049.32576-2-ariel.dalessandro@collabora.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220210134049.32576-2-ariel.dalessandro@collabora.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220212_201859_199931_924BB58F X-CRM114-Status: GOOD ( 17.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Feb 10, 2022 at 10:40:49AM -0300, Ariel D'Alessandro wrote: > BSH SystemMaster (SMM) S2 PRO board comes with an audio card based on > tlv320aic31xx family codec. > > The audio card exposes two playback devices, one of them using the EASRC > (Enhanced Asynchronous Sample Rate Converter) module. Note that this > would require SDMA and EASRC firmware in order to work. > > Signed-off-by: Ariel D'Alessandro > Signed-off-by: Michael Trimarchi > --- > .../dts/freescale/imx8mn-bsh-smm-s2pro.dts | 94 +++++++++++++++++++ > 1 file changed, 94 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2pro.dts b/arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2pro.dts > index c6a8ed6745c1..3621354b4a92 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2pro.dts > +++ b/arch/arm64/boot/dts/freescale/imx8mn-bsh-smm-s2pro.dts > @@ -7,6 +7,7 @@ > /dts-v1/; > > #include "imx8mn-bsh-smm-s2-common.dtsi" > +#include > > / { > model = "BSH SMM S2 PRO"; > @@ -16,6 +17,69 @@ memory@40000000 { > device_type = "memory"; > reg = <0x0 0x40000000 0x0 0x20000000>; > }; > + > + sound-tlv320aic31xx { > + compatible = "fsl,imx-audio-tlv320aic31xx"; > + model = "tlv320aic31xx-hifi"; > + audio-cpu = <&sai3>; > + audio-codec = <&codec>; > + audio-asrc = <&easrc>; > + audio-routing = > + "Ext Spk", "SPL", > + "Ext Spk", "SPR"; > + mclk-id = ; > + }; > + > + vdd_input: vdd_input { > + compatible = "regulator-fixed"; > + regulator-name = "vdd_input"; > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>; > + }; > +}; > + > +&easrc { > + fsl,asrc-rate = <48000>; Double spaces before '='. > + fsl,asrc-format = <10>; > + status = "okay"; > +}; > + > +&i2c2 { > + clock-frequency = <400000>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_i2c2>; > + status = "okay"; > + > + codec: tlv320dac3101@18 { tlv320dac3101: audio-codec@18 > + #sound-dai-cells = <0>; > + compatible = "ti,tlv320dac3101"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_dac_rst>; > + reg = <0x18>; > + > + ai31xx-micbias-vg = ; > + > + HPVDD-supply = <&buck4_reg>; > + SPRVDD-supply = <&vdd_input>; > + SPLVDD-supply = <&vdd_input>; > + AVDD-supply = <&buck4_reg>; > + IOVDD-supply = <&buck4_reg>; > + DVDD-supply = <&buck5_reg>; > + reset-gpios = <&gpio1 6 GPIO_ACTIVE_LOW>; > + > + clocks = <&clk IMX8MN_CLK_SAI3_ROOT>; > + clock-names = "mclk"; > + }; > +}; > + > +&sai3 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_sai3>; > + assigned-clocks = <&clk IMX8MN_CLK_SAI3>; > + assigned-clock-parents = <&clk IMX8MN_AUDIO_PLL1_OUT>; > + assigned-clock-rates = <24576000>; > + fsl,sai-mclk-direction-output; > + status = "okay"; > }; > > /* eMMC */ > @@ -30,6 +94,36 @@ &usdhc1 { > }; > > &iomuxc { > + pinctrl_dac_rst: dac_rst { Name the node more in the same style as other pinctrl nodes. Shawn > + fsl,pins = < > + MX8MN_IOMUXC_GPIO1_IO06_GPIO1_IO6 0x19 /* DAC_RST */ > + >; > + }; > + > + pinctrl_espi2: espi2grp { > + fsl,pins = < > + MX8MN_IOMUXC_ECSPI2_SCLK_ECSPI2_SCLK 0x082 > + MX8MN_IOMUXC_ECSPI2_MOSI_ECSPI2_MOSI 0x082 > + MX8MN_IOMUXC_ECSPI2_MISO_ECSPI2_MISO 0x082 > + MX8MN_IOMUXC_ECSPI2_SS0_ECSPI2_SS0 0x040 > + >; > + }; > + > + pinctrl_i2c2: i2c2grp { > + fsl,pins = < > + MX8MN_IOMUXC_I2C2_SCL_I2C2_SCL 0x400000c3 > + MX8MN_IOMUXC_I2C2_SDA_I2C2_SDA 0x400000c3 > + >; > + }; > + > + pinctrl_sai3: sai3grp { > + fsl,pins = < > + MX8MN_IOMUXC_SAI3_TXFS_SAI3_TX_SYNC 0xd6 > + MX8MN_IOMUXC_SAI3_TXC_SAI3_TX_BCLK 0xd6 > + MX8MN_IOMUXC_SAI3_TXD_SAI3_TX_DATA0 0xd6 > + >; > + }; > + > pinctrl_usdhc1: usdhc1grp { > fsl,pins = < > MX8MN_IOMUXC_SD1_CLK_USDHC1_CLK 0x40000090 > -- > 2.34.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel