Re: [PATCH v4 0/5] btrfs: defrag: don't waste CPU time on non-target extent

[David Sterba <dsterba@suse.cz>]

On Fri, Feb 11, 2022 at 02:41:38PM +0800, Qu Wenruo wrote:
> Changelog:
> v2:
> - Rebased to lastest misc-next
>   Just one small conflict with static_assert() update.
>   And this time only those patches are rebased to misc-next, thus it may
>   cause conflicts with fixes for defrag_check_next_extent() in the
>   future.
> 
> - Several grammar fixes
> 
> - Report accurate btrfs_defrag_ctrl::sectors_defragged
>   This is inspired by a comment from Filipe that the skip check
>   should be done in the defrag_collect_targets() call inside
>   defrag_one_range().
> 
>   This results a new patch in v2.
> 
> - Change the timing of btrfs_defrag_ctrl::last_scanned update
>   Now it's updated inside defrag_one_range(), which will give
>   us an accurate view, unlike the previous call site in
>   defrag_one_cluster().
> 
> - Don't change the timing of extent threshold.
> 
> - Rename @last_target to @last_is_target in defrag_collect_targets()
> 
> v3:
> - Add Reviewed-by tags
> 
> - Fix a wrong value in commit message of the 1st patch
> 
> - Make @orig_start const for the 3rd patch
> 
> - Fix a missing word "skip" in the 5th patch
> 
> - Remove one unnecessary assignment in the 5th patch
>   As we don't return the defragged sectors to user space.
> 
> v4:
> - Move the skip behavior before the btrfs_defrag_ctrl refactor
>   So it can be backported to v5.16

Thanks, I've picked the patch to misc-next. I'm not sure about the rest
because of the ctrl structure cleanup and there are still some pending
defrag fixes. So I'll add the remainig patches as topic branch for
testing.