From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C34B2C433EF for ; Tue, 15 Feb 2022 11:00:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236831AbiBOLAx (ORCPT ); Tue, 15 Feb 2022 06:00:53 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:37526 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236851AbiBOLAq (ORCPT ); Tue, 15 Feb 2022 06:00:46 -0500 Received: from relay10.mail.gandi.net (relay10.mail.gandi.net [217.70.178.230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6145DF9562 for ; Tue, 15 Feb 2022 03:00:36 -0800 (PST) Received: (Authenticated sender: jacopo@jmondi.org) by mail.gandi.net (Postfix) with ESMTPSA id C8F71240011; Tue, 15 Feb 2022 11:00:32 +0000 (UTC) Date: Tue, 15 Feb 2022 12:01:41 +0100 From: Jacopo Mondi To: Laurent Pinchart Cc: linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Sakari Ailus , Hans Verkuil , Kieran Bingham , Niklas =?utf-8?Q?S=C3=B6derlund?= , Tomi Valkeinen , Janusz Krzysztofik , Lars-Peter Clausen Subject: Re: [RFC PATCH 7/8] media: v4l2-mediabus: Drop legacy V4L2_MBUS_CSI2_CHANNEL_* flags Message-ID: <20220215110141.se2gyvfb2xvez2vn@uno.localdomain> References: <20220103162414.27723-1-laurent.pinchart+renesas@ideasonboard.com> <20220103162414.27723-8-laurent.pinchart+renesas@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220103162414.27723-8-laurent.pinchart+renesas@ideasonboard.com> Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Laurent On Mon, Jan 03, 2022 at 06:24:13PM +0200, Laurent Pinchart wrote: > The V4L2_MBUS_CSI2_CHANNEL_* flags are a legacy API. Only > V4L2_MBUS_CSI2_CHANNEL_0 is used, set in a single driver, and never > read. Drop those flags. Virtual channel information should be conveyed > through frame descriptors instead. I see one more user in the latest media master drivers/media/platform/atmel/microchip-csi2dc.c: if (mbus_config.flags & V4L2_MBUS_CSI2_CHANNEL_0) With that fixed Reviewed-by: Jacopo Mondi Thanks j > > Signed-off-by: Laurent Pinchart > --- > drivers/media/i2c/adv7180.c | 1 - > include/media/v4l2-mediabus.h | 10 ---------- > 2 files changed, 11 deletions(-) > > diff --git a/drivers/media/i2c/adv7180.c b/drivers/media/i2c/adv7180.c > index 286f5017d9c3..3ff37a550810 100644 > --- a/drivers/media/i2c/adv7180.c > +++ b/drivers/media/i2c/adv7180.c > @@ -786,7 +786,6 @@ static int adv7180_get_mbus_config(struct v4l2_subdev *sd, > cfg->type = V4L2_MBUS_CSI2_DPHY; > cfg->bus.mipi_csi2.num_data_lanes = 1; > cfg->bus.mipi_csi2.flags = > - V4L2_MBUS_CSI2_CHANNEL_0 | > V4L2_MBUS_CSI2_CONTINUOUS_CLOCK; > } else { > /* > diff --git a/include/media/v4l2-mediabus.h b/include/media/v4l2-mediabus.h > index 44195ceeccca..c6626a22b394 100644 > --- a/include/media/v4l2-mediabus.h > +++ b/include/media/v4l2-mediabus.h > @@ -67,20 +67,10 @@ > #define V4L2_MBUS_DATA_ENABLE_LOW BIT(15) > > /* Serial flags */ > -/* CSI-2 Virtual Channel identifiers. */ > -#define V4L2_MBUS_CSI2_CHANNEL_0 BIT(4) > -#define V4L2_MBUS_CSI2_CHANNEL_1 BIT(5) > -#define V4L2_MBUS_CSI2_CHANNEL_2 BIT(6) > -#define V4L2_MBUS_CSI2_CHANNEL_3 BIT(7) > /* Clock non-continuous mode support. */ > #define V4L2_MBUS_CSI2_CONTINUOUS_CLOCK BIT(8) > #define V4L2_MBUS_CSI2_NONCONTINUOUS_CLOCK BIT(9) > > -#define V4L2_MBUS_CSI2_CHANNELS (V4L2_MBUS_CSI2_CHANNEL_0 | \ > - V4L2_MBUS_CSI2_CHANNEL_1 | \ > - V4L2_MBUS_CSI2_CHANNEL_2 | \ > - V4L2_MBUS_CSI2_CHANNEL_3) > - > #define V4L2_MBUS_CSI2_MAX_DATA_LANES 8 > > /** > -- > Regards, > > Laurent Pinchart >