From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E431F1561; Tue, 15 Feb 2022 13:01:26 +0000 (UTC) Received: from localhost (unknown [IPv6:2a02:3030:c:4872:44aa:f680:5c21:4d9e]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: sebastianfricke) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id B8E621F4478F; Tue, 15 Feb 2022 13:01:24 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1644930085; bh=oP5LmZQ2v+ynwHP2YgQ3HzLx8VbZLLfieXayaQwh2AY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Y5MoHVAz6qUMJA0Axj1VeVkWWxHnce4wEZF13y6m1OMe0Gu/zvbtcbO+ElYkP88S0 /+inE+Oza/Uq7aOpRyuMaYaIkAJGh2MA245Cpx3I46/BzzzlD6Y9tOO+pQtkZRXHiQ soWQ9A3CYUTDUHHWi61eRhbL990SjcdDZEjuQuzoN/2ShXmqXkRVHtjS7f8N92qzFH Nv07t2WrKMjjtIfe4+61ra4DAgj40VMU/ufS/Nv+Z9dWRrsluR6o959YKyDI0/lUYo vLt8aB65utTeu/ZF2iyiIl4eXO5CHXeuq0tA1MXF7PcGrUHf0RD7l35c0C6Dec1X3/ 6A5ThyXzJq33g== Date: Tue, 15 Feb 2022 14:01:21 +0100 From: Sebastian Fricke To: Benjamin Gaignard Cc: mchehab@kernel.org, ezequiel@vanguardiasur.com.ar, p.zabel@pengutronix.de, gregkh@linuxfoundation.org, mripard@kernel.org, paul.kocialkowski@bootlin.com, wens@csie.org, jernej.skrabec@gmail.com, hverkuil-cisco@xs4all.nl, jonas@kwiboo.se, nicolas@ndufresne.ca, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, kernel@collabora.com, knaerzche@gmail.com, jc@kynesim.co.uk Subject: Re: [RFC v2 0/8] Move HEVC stateless controls out of staging Message-ID: <20220215130121.4ekixb457ot6zaqi@basti-XPS-13-9310> References: <20220215110103.241297-1-benjamin.gaignard@collabora.com> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline In-Reply-To: <20220215110103.241297-1-benjamin.gaignard@collabora.com> Hey Benjamin, On 15.02.2022 12:00, Benjamin Gaignard wrote: >This series aims to make HEVC uapi stable and usable for hardware >decoder. HEVC uapi is used by 2 mainlined drivers (Cedrus and Hantro) >and 2 out of the tree drivers (rkvdec and RPI). Why is rkvdec out-of-tree? It is in the staging directory just like hantro and cedrus? Am I missing something here? Greetings, Sebastian > >The 3 first patches are from Hans to implement v4l2 dynamic control >feature which is need by patch 7 for V4L2_CID_STATELESS_HEVC_ENTRY_POINT_OFFSET >definition. > >Patch 4 move the existing uapi to stable, including definitions renaming >and CID number change to fit with v4l2 naming. > >Patches 5 and 7 add fields needed for rkvdec and RPI decoders. > >Patches 6 is cleaning up the uapi of useless field. >Patches 8 change one field description and name to define offset by >bytes rather than by bits > >Benjamin > >Benjamin Gaignard (5): > media: uapi: Move HEVC stateless controls out of staging > media: uapi: Add fields needed for RKVDEC driver > media: uapi: Remove bit_size field from v4l2_ctrl_hevc_slice_params > media: uapi: Add V4L2_CID_STATELESS_HEVC_ENTRY_POINT_OFFSET control > media: uapi: Change data_bit_offset definition > >Hans Verkuil (3): > videodev2.h: add V4L2_CTRL_FLAG_DYNAMIC_ARRAY > v4l2-ctrls: add support for dynamically allocated arrays. > vivid: add dynamic array test control > > .../userspace-api/media/drivers/hantro.rst | 5 - > .../media/v4l/ext-ctrls-codec.rst | 58 ++-- > .../media/v4l/vidioc-queryctrl.rst | 8 + > .../media/test-drivers/vivid/vivid-ctrls.c | 15 ++ > drivers/media/v4l2-core/v4l2-ctrls-api.c | 103 ++++++-- > drivers/media/v4l2-core/v4l2-ctrls-core.c | 182 ++++++++++--- > drivers/media/v4l2-core/v4l2-ctrls-defs.c | 32 +-- > drivers/media/v4l2-core/v4l2-ctrls-priv.h | 3 +- > drivers/media/v4l2-core/v4l2-ctrls-request.c | 13 +- > drivers/staging/media/hantro/hantro_drv.c | 27 +- > drivers/staging/media/hantro/hantro_hevc.c | 8 +- > drivers/staging/media/sunxi/cedrus/cedrus.c | 24 +- > .../staging/media/sunxi/cedrus/cedrus_dec.c | 10 +- > .../staging/media/sunxi/cedrus/cedrus_h265.c | 13 +- > include/linux/hantro-media.h | 17 ++ > include/media/hevc-ctrls.h | 250 ------------------ > include/media/v4l2-ctrls.h | 48 +++- > include/uapi/linux/v4l2-controls.h | 224 ++++++++++++++++ > include/uapi/linux/videodev2.h | 8 + > 19 files changed, 640 insertions(+), 408 deletions(-) > create mode 100644 include/linux/hantro-media.h > delete mode 100644 include/media/hevc-ctrls.h > >-- >2.32.0 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6769DC433F5 for ; Tue, 15 Feb 2022 13:02:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MaQ3aGVUzavfHhhHcdXOc15gzSxhDrh+mIuHI3bV/9c=; b=IBFiobAotfa5rvsQGjxK7fMzHn W//yS9QdYyqzc5kvuPJnFVP4Hm2kDeChYG83/7O1AfsEttxCNa/qrG3w+Q0Kqnfhdc5yRedVe+A+a y+/HdC5S/9FYpuGRoeoGmpyrI/SLQTdJ+E6Phn1ntFbhc8feusGy8I+RU/bTDVeoqrT/qBy6wdcSL aqbJ3QYuh8T9eONT34jLe4tgXxGbxxrCDg38Pe49autImZn4m1p4B1j79nUFQWiw2dVHJnEOyACEV vqu707AStbpNzbJCCQ9UWuPdjT2i6D0oojeJUVBmD3ZvVkQfHO4XnFPOnQqEMhRJeLrxCtsc0/rw/ Z6stzAiA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nJxSY-002kWs-1e; Tue, 15 Feb 2022 13:01:34 +0000 Received: from bhuna.collabora.co.uk ([46.235.227.227]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nJxST-002kUo-DS for linux-arm-kernel@lists.infradead.org; Tue, 15 Feb 2022 13:01:31 +0000 Received: from localhost (unknown [IPv6:2a02:3030:c:4872:44aa:f680:5c21:4d9e]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: sebastianfricke) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id B8E621F4478F; Tue, 15 Feb 2022 13:01:24 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1644930085; bh=oP5LmZQ2v+ynwHP2YgQ3HzLx8VbZLLfieXayaQwh2AY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Y5MoHVAz6qUMJA0Axj1VeVkWWxHnce4wEZF13y6m1OMe0Gu/zvbtcbO+ElYkP88S0 /+inE+Oza/Uq7aOpRyuMaYaIkAJGh2MA245Cpx3I46/BzzzlD6Y9tOO+pQtkZRXHiQ soWQ9A3CYUTDUHHWi61eRhbL990SjcdDZEjuQuzoN/2ShXmqXkRVHtjS7f8N92qzFH Nv07t2WrKMjjtIfe4+61ra4DAgj40VMU/ufS/Nv+Z9dWRrsluR6o959YKyDI0/lUYo vLt8aB65utTeu/ZF2iyiIl4eXO5CHXeuq0tA1MXF7PcGrUHf0RD7l35c0C6Dec1X3/ 6A5ThyXzJq33g== Date: Tue, 15 Feb 2022 14:01:21 +0100 From: Sebastian Fricke To: Benjamin Gaignard Cc: mchehab@kernel.org, ezequiel@vanguardiasur.com.ar, p.zabel@pengutronix.de, gregkh@linuxfoundation.org, mripard@kernel.org, paul.kocialkowski@bootlin.com, wens@csie.org, jernej.skrabec@gmail.com, hverkuil-cisco@xs4all.nl, jonas@kwiboo.se, nicolas@ndufresne.ca, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, kernel@collabora.com, knaerzche@gmail.com, jc@kynesim.co.uk Subject: Re: [RFC v2 0/8] Move HEVC stateless controls out of staging Message-ID: <20220215130121.4ekixb457ot6zaqi@basti-XPS-13-9310> References: <20220215110103.241297-1-benjamin.gaignard@collabora.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220215110103.241297-1-benjamin.gaignard@collabora.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220215_050129_686716_DE761103 X-CRM114-Status: GOOD ( 15.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hey Benjamin, On 15.02.2022 12:00, Benjamin Gaignard wrote: >This series aims to make HEVC uapi stable and usable for hardware >decoder. HEVC uapi is used by 2 mainlined drivers (Cedrus and Hantro) >and 2 out of the tree drivers (rkvdec and RPI). Why is rkvdec out-of-tree? It is in the staging directory just like hantro and cedrus? Am I missing something here? Greetings, Sebastian > >The 3 first patches are from Hans to implement v4l2 dynamic control >feature which is need by patch 7 for V4L2_CID_STATELESS_HEVC_ENTRY_POINT_OFFSET >definition. > >Patch 4 move the existing uapi to stable, including definitions renaming >and CID number change to fit with v4l2 naming. > >Patches 5 and 7 add fields needed for rkvdec and RPI decoders. > >Patches 6 is cleaning up the uapi of useless field. >Patches 8 change one field description and name to define offset by >bytes rather than by bits > >Benjamin > >Benjamin Gaignard (5): > media: uapi: Move HEVC stateless controls out of staging > media: uapi: Add fields needed for RKVDEC driver > media: uapi: Remove bit_size field from v4l2_ctrl_hevc_slice_params > media: uapi: Add V4L2_CID_STATELESS_HEVC_ENTRY_POINT_OFFSET control > media: uapi: Change data_bit_offset definition > >Hans Verkuil (3): > videodev2.h: add V4L2_CTRL_FLAG_DYNAMIC_ARRAY > v4l2-ctrls: add support for dynamically allocated arrays. > vivid: add dynamic array test control > > .../userspace-api/media/drivers/hantro.rst | 5 - > .../media/v4l/ext-ctrls-codec.rst | 58 ++-- > .../media/v4l/vidioc-queryctrl.rst | 8 + > .../media/test-drivers/vivid/vivid-ctrls.c | 15 ++ > drivers/media/v4l2-core/v4l2-ctrls-api.c | 103 ++++++-- > drivers/media/v4l2-core/v4l2-ctrls-core.c | 182 ++++++++++--- > drivers/media/v4l2-core/v4l2-ctrls-defs.c | 32 +-- > drivers/media/v4l2-core/v4l2-ctrls-priv.h | 3 +- > drivers/media/v4l2-core/v4l2-ctrls-request.c | 13 +- > drivers/staging/media/hantro/hantro_drv.c | 27 +- > drivers/staging/media/hantro/hantro_hevc.c | 8 +- > drivers/staging/media/sunxi/cedrus/cedrus.c | 24 +- > .../staging/media/sunxi/cedrus/cedrus_dec.c | 10 +- > .../staging/media/sunxi/cedrus/cedrus_h265.c | 13 +- > include/linux/hantro-media.h | 17 ++ > include/media/hevc-ctrls.h | 250 ------------------ > include/media/v4l2-ctrls.h | 48 +++- > include/uapi/linux/v4l2-controls.h | 224 ++++++++++++++++ > include/uapi/linux/videodev2.h | 8 + > 19 files changed, 640 insertions(+), 408 deletions(-) > create mode 100644 include/linux/hantro-media.h > delete mode 100644 include/media/hevc-ctrls.h > >-- >2.32.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel