All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eli Cohen <elic@nvidia.com>
To: Si-Wei Liu <si-wei.liu@oracle.com>
Cc: <stephen@networkplumber.org>, <netdev@vger.kernel.org>,
	<jasowang@redhat.com>, <lulu@redhat.com>,
	Jianbo Liu <jianbol@mellanox.com>
Subject: Re: [PATCH v1 1/4] vdpa: Remove unsupported command line option
Date: Tue, 15 Feb 2022 16:49:36 +0200	[thread overview]
Message-ID: <20220215144936.GE229469@mtl-vdi-166.wap.labs.mlnx> (raw)
In-Reply-To: <ca2775b1-f755-d50a-7a23-0db8c4e220d9@oracle.com>

On Fri, Feb 11, 2022 at 04:44:14PM -0800, Si-Wei Liu wrote:
> 
> 
> On 2/10/2022 5:31 AM, Eli Cohen wrote:
> > "-v[erbose]" option is not supported.
> > Remove it.
> > 
> > Acked-by: Jason Wang <jasowang@redhat.com>
> > Reviewed-by: Jianbo Liu <jianbol@mellanox.com>
> > Signed-off-by: Eli Cohen <elic@nvidia.com>
> > ---
> >   vdpa/vdpa.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/vdpa/vdpa.c b/vdpa/vdpa.c
> > index f048e470c929..4ccb564872a0 100644
> > --- a/vdpa/vdpa.c
> > +++ b/vdpa/vdpa.c
> > @@ -711,7 +711,7 @@ static void help(void)
> >   	fprintf(stderr,
> >   		"Usage: vdpa [ OPTIONS ] OBJECT { COMMAND | help }\n"
> >   		"where  OBJECT := { mgmtdev | dev }\n"
> > -		"       OPTIONS := { -V[ersion] | -n[o-nice-names] | -j[son] | -p[retty] | -v[erbose] }\n");
> > +		"       OPTIONS := { -V[ersion] | -n[o-nice-names] | -j[son] | -p[retty] }\n");
> Maybe remove -n option that is also unsupported yet?

I didn't notice this. Will review all help messages and fix in a follow
up patch.

> 
> Reviewed-by: Si-Wei Liu <si-wei.liu@oracle.com>
> >   }
> >   static int vdpa_cmd(struct vdpa *vdpa, int argc, char **argv)
> 

  reply	other threads:[~2022-02-15 14:51 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-10 13:31 [PATCH v1 0/4] vdpa tool enhancements Eli Cohen
2022-02-10 13:31 ` [PATCH v1 1/4] vdpa: Remove unsupported command line option Eli Cohen
2022-02-12  0:44   ` Si-Wei Liu
2022-02-15 14:49     ` Eli Cohen [this message]
2022-02-10 13:31 ` [PATCH v1 2/4] vdpa: Allow for printing negotiated features of a device Eli Cohen
2022-02-12  1:15   ` Si-Wei Liu
2022-02-15 15:16     ` Eli Cohen
2022-02-16 21:42       ` Si-Wei Liu
2022-02-10 13:31 ` [PATCH v1 3/4] vdpa: Support for configuring max VQ pairs for " Eli Cohen
2022-02-12  0:37   ` Si-Wei Liu
2022-02-15 14:45     ` Eli Cohen
2022-02-10 13:31 ` [PATCH v1 4/4] vdpa: Support reading device features Eli Cohen
2022-02-12  0:43   ` Si-Wei Liu
2022-02-15 14:46     ` Eli Cohen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220215144936.GE229469@mtl-vdi-166.wap.labs.mlnx \
    --to=elic@nvidia.com \
    --cc=jasowang@redhat.com \
    --cc=jianbol@mellanox.com \
    --cc=lulu@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=si-wei.liu@oracle.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.