From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27729C433FE for ; Tue, 15 Feb 2022 15:06:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239585AbiBOPGL (ORCPT ); Tue, 15 Feb 2022 10:06:11 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:36626 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239558AbiBOPGK (ORCPT ); Tue, 15 Feb 2022 10:06:10 -0500 Received: from p3plsmtpa09-10.prod.phx3.secureserver.net (p3plsmtpa09-10.prod.phx3.secureserver.net [173.201.193.239]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B1008108560 for ; Tue, 15 Feb 2022 07:06:00 -0800 (PST) Received: from localhost ([82.17.115.212]) by :SMTPAUTH: with ESMTPA id JzOvneUB7ApSlJzOxnv8kp; Tue, 15 Feb 2022 08:05:59 -0700 X-CMAE-Analysis: v=2.4 cv=G8PZr/o5 c=1 sm=1 tr=0 ts=620bc157 a=9gipVNR6X1CoIeAWHwLoWw==:117 a=9gipVNR6X1CoIeAWHwLoWw==:17 a=IkcTkHD0fZMA:10 a=eRuHl9Be23FFiiB-UZwA:9 a=QEXdDO2ut3YA:10 X-SECURESERVER-ACCT: atomlin@atomlin.com Date: Tue, 15 Feb 2022 15:05:57 +0000 From: Aaron Tomlin To: Christophe Leroy Cc: Aaron Tomlin , "mcgrof@kernel.org" , "cl@linux.com" , "pmladek@suse.com" , "mbenes@suse.cz" , "akpm@linux-foundation.org" , "jeyu@kernel.org" , "linux-kernel@vger.kernel.org" , "linux-modules@vger.kernel.org" , "live-patching@vger.kernel.org" , "ghalat@redhat.com" , "allen.lkml@gmail.com" , "void@manifault.com" , "joe@perches.com" , "msuchanek@suse.de" , "oleksandr@natalenko.name" Subject: Re: [PATCH v5 13/13] module: Move version support into a separate file Message-ID: <20220215150557.g7mvx47ibhjgweyo@ava.usersys.com> References: <20220209171118.3269581-1-atomlin@redhat.com> <20220209171118.3269581-3-atomlin@redhat.com> <14a1678f-0c56-1237-c5c7-4ca1bac4b42a@csgroup.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-CMAE-Envelope: MS4xfE6u2n9DvFiGsYMeR3knNtd1Uva+OFrVy9oEyo66zu27ZGI/MXq9RjqzQsM7JLBsAGQrHziUfDdZ7PdUHEDucW7KYBpPGXdMA/s8RfiJnGF60yp5OQYQ 34/DADYiivZZnSXdDmDZacjYodnY31fPUWCaK3qKjfCC/vsG0fCkkBDofkzoDMhdkqppdsgwwMPmR/Bdtyad0GIOiI/dFI/FiLsnQqQmirhgLcu931KyiKwj SlvzCVK19hmmJJQpNKfjg5Yr1yN70RRQZlxrhJp4L8kCi981iCR4BD8dPGNMonpNkobC83Ao7/y9NrV23L/CfXW7lAlCvrM3CfFmBy03x8hxADWskgR4dmje XQMt+oVaFTySOqjuoLn1TEJRvtiUiD9wKcknPxlG1e8SRkMLOfcY/Iv31YpgV0RF6tR/bZYv3/WnRDs+Mp+3atcCwI+LrTQQahfVPVTXmWiB1ctlrMUi0M9r /k9O/7j3TceeRL9hUZkWQiPtXognSDh4GSoqPybHOm3CLj/HtrnRsKG7HoR4xpx6mEknNrOTsvJECi1pWr2/Oeznfld1mJLvjR+r7KMrNtBFKzWpwZGpr+9Z a8LD96SgYe1oEx0N3cWMiQiZgdp5vvnLrdhbDs6uKS/qKsN5jytzrRXnWi/Da74X2T/yKdrhm8GJ1GR4wejhOSAKOpTIFaVDVYO1UZ49HJcbyg== Precedence: bulk List-ID: On Sun 2022-02-13 18:29 +0000, Christophe Leroy wrote: > I'm not sure you can do that. > > From commit 8c8ef42aee8f ("module: include other structures in module > version check") I understand that module_layout is there for some signature. Hi Christophe, I see. In which case, if I understand correctly, we'd have to ignore the report from Sparse. I will add a comment to hopefully suggest against removal. Kind regards, -- Aaron Tomlin