From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 590E1C433F5 for ; Tue, 15 Feb 2022 19:30:02 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B890E81F9A; Tue, 15 Feb 2022 20:29:59 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="GE1GIMTT"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id BD0F781F9A; Tue, 15 Feb 2022 20:29:57 +0100 (CET) Received: from mail-qt1-x82d.google.com (mail-qt1-x82d.google.com [IPv6:2607:f8b0:4864:20::82d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B09D081DB4 for ; Tue, 15 Feb 2022 20:29:53 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x82d.google.com with SMTP id bt3so1737585qtb.0 for ; Tue, 15 Feb 2022 11:29:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:subject:message-id:mime-version:content-disposition; bh=C5e7NPk2T4p6M8Qh0rHF+mHOBMYGE6d6Cwex0NpsPjA=; b=GE1GIMTTcPusLM05CJaJ3dTfgfEkVLN0vkBMM+X1a8mSEszC7PgpkZpsVTYPqMHITq 1GcZpSZ2QLsCYRRUqndWuKZtJtUAIo6edRQ1aZ2kR2PWemxtw6/453g1I1q8GqlVA+60 h2uw6yKpVxiY4oLrczBtLwHG9UImI6JXzvFMg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:subject:message-id:mime-version :content-disposition; bh=C5e7NPk2T4p6M8Qh0rHF+mHOBMYGE6d6Cwex0NpsPjA=; b=EaP6cj3qjWoLOux3Hg4m+WzB4vnbg8jL92r95CKXZ5FVW5O929AxYlcceMvCnPYqy3 qu9waJYjy7LI7TkEuUtXmmxaYRCxXSLjbx/xvqvmECFrj+r4Ad6tCd4ZU+sAACSf7jm7 qW531D444ZQOOn4mERIUPkE2XEPEfG2nFHXDqOC0mlP5+IEOe85BETUlmQHgmK5mJe/Q Gz3NvUBbAvTu5CcmVLl4EHwfwtrzFJsVDPAwgEUEBg9oQ5p8zFn9y/kXVr2qYgMTMkh7 g/G182Am0ALxejtAQJf/Ji8G7RFvOFB6TSmH8kIOEV6n7cHvTG7hM8uCcvZZ2n5A8Je9 Y8sQ== X-Gm-Message-State: AOAM530Mj5vBRYwXRFUnH+0tzuxYwIoZXheHvdM168saKfSq7baYUyhG XccYsTX3dT9pff97j+LQDn6tHaIUTiRzWagr X-Google-Smtp-Source: ABdhPJwJyJii5FesH6jdF3WU+7cAdNo7/8AzW7N3LUg9WuMuK5wHySGSif/ice5JBFBJ3urVElLcjA== X-Received: by 2002:ac8:7e89:: with SMTP id w9mr499119qtj.574.1644953392199; Tue, 15 Feb 2022 11:29:52 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-2ef0-5dff-fedb-a8ba.res6.spectrum.com. [2603:6081:7b01:cbda:2ef0:5dff:fedb:a8ba]) by smtp.gmail.com with ESMTPSA id u16sm20196061qtx.46.2022.02.15.11.29.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Feb 2022 11:29:51 -0800 (PST) Date: Tue, 15 Feb 2022 14:29:49 -0500 From: Tom Rini To: u-boot@lists.denx.de, Zhang Ning , AKASHI Takahiro Subject: [scan-admin@coverity.com: New Defects reported by Coverity Scan for Das U-Boot] Message-ID: <20220215192949.GA1557591@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="LQksG6bCIzRHxTLp" Content-Disposition: inline X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean --LQksG6bCIzRHxTLp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hey all, Here's the latest report. ----- Forwarded message from scan-admin@coverity.com ----- Date: Mon, 14 Feb 2022 22:13:51 +0000 (UTC) =46rom: scan-admin@coverity.com To: tom.rini@gmail.com Subject: New Defects reported by Coverity Scan for Das U-Boot Hi, Please find the latest report on new defect(s) introduced to Das U-Boot fou= nd with Coverity Scan. 2 new defect(s) introduced to Das U-Boot found with Coverity Scan. 2 defect(s), reported by Coverity Scan earlier, were marked fixed in the re= cent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 348361: Code maintainability issues (SIZEOF_MISMATCH) /boot/pxe_utils.c: 369 in label_boot_kaslrseed() ___________________________________________________________________________= _____________________________ *** CID 348361: Code maintainability issues (SIZEOF_MISMATCH) /boot/pxe_utils.c: 369 in label_boot_kaslrseed() 363 =20 364 if (dm_rng_read(dev, buf, n)) { 365 printf("Reading RNG failed\n"); 366 goto err; 367 } 368 =20 >>> CID 348361: Code maintainability issues (SIZEOF_MISMATCH) >>> Passing argument "buf" of type "u64 *" and argument "8 /* sizeof (b= uf) */" to function "fdt_setprop" is suspicious. In this case, "sizeof (u64= *)" is equal to "sizeof (u64)", but this is not a portable assumption. 369 err =3D fdt_setprop(working_fdt, nodeoffset, "kaslr-seed", buf, si= zeof(buf)); 370 if (err < 0) { 371 printf("Unable to set kaslr-seed on chosen node: %s\n", fdt_strer= ror(err)); 372 goto err; 373 } 374 err: ** CID 348360: Control flow issues (DEADCODE) /tools/mkeficapsule.c: 216 in create_auth_data() ___________________________________________________________________________= _____________________________ *** CID 348360: Control flow issues (DEADCODE) /tools/mkeficapsule.c: 216 in create_auth_data() 210 cert.size =3D file_size; 211 =20 212 ret =3D read_bin_file(ctx->key_file, &key.data, &file_size); 213 if (ret < 0) 214 return -1; 215 if (ret < 0) >>> CID 348360: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "return -1;". 216 return -1; 217 if (file_size > UINT_MAX) 218 return -1; 219 key.size =3D file_size; 220 =20 221 /* ___________________________________________________________________________= _____________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.n= et/ls/click?upn=3DHRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yoA22WlOQ-2By3= ieUvdbKmOyw68TMVT4Kip-2BBzfOGWXJ5yIiYplmPF9KAnKIja4Zd7tU-3DzatU_EEm8SbLgSDs= aDZif-2Bv7ch8WqhKpLoKErHi4nXpwDNTtBG6gUqymbLeHiLUZdYE-2BnFbf8zeujozu1RicmnC= lG68TkQz5O-2BGjs-2FiSUi9SbNlD0ZKYuwGCOtzzhPrzmz3aE-2FGoy8IfPEIkNIW63Gi9NpdM= US9Ikumb8oIFeDys4nJ5vGaorBAY9O9ON-2BXS4h6-2FgOrRT3qYLv0G399O590I1aQ-3D-3D To manage Coverity Scan email notifications for "tom.rini@gmail.com", cli= ck https://u15810271.ct.sendgrid.net/ls/click?upn=3DHRESupC-2F2Czv4BOaCWWCy= 7my0P0qcxCbhZ31OYv50yped04pjJnmXOsUBtKYNIXxWeIHzDeopm-2BEWQ6S6K-2FtUHv9ZTk8= qZbuzkkz9sa-2BJFw4elYDyedRVZOC-2ButxjBZdouVmTGuWB6Aj6G7lm7t25-2Biv1B-2B9082= pHzCCex2kqMs-3D4FDW_EEm8SbLgSDsaDZif-2Bv7ch8WqhKpLoKErHi4nXpwDNTtBG6gUqymbL= eHiLUZdYE-2BnFhYoNq9mQGL-2FVdQFZIqeIZwliLES0HECBswlH590ugIExPr3PyN1Y4w0WO5K= tHGXAw8STt9dOWWhzHpyUYpWpEhXNMVJaJpaycREp8UUQddEItpr1JHWiHxEXRzVxzJv5pVvnvW= o1MNlxWMr7wY67Q-3D-3D ----- End forwarded message ----- --=20 Tom --LQksG6bCIzRHxTLp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmIL/yoACgkQFHw5/5Y0 tyyj3Qv/VLeTDlJU/7kCiBseODJl9/7tU//2N6ZVpavVzBZUq6Hu/Vc5dSGEUWlU 9thO8iCJIdu4w74RoqucqSm62fzVQp6zJfuLHaXem1goGs8BO0R/HPirStk8qK3g CxTnpo/o2UfbO2m1pZFdRU4SqDCbEuwdaReDYefCZXZDuvV8aYQvgDxJBCN0IkIS 2YA81twhwO8gYKGSktmmSAkv36JLUUuoZ8ArLU1wchg1zQ9q2CaxAKbT8h0FTL3q JYjSDQ3rpj5edLMpECC4iyEwgSPMyHW7yX02xkGPPQjRxleSo8YKXdybVotnY8re LWGnXwha+tjq0qqHKw2zbOPWWQH5hRdHkKgXCgzI+y1VefsSPUrRnj9wahwJz/oW j5A4kWsXk6y3/wEQaEEOvOkgKipKrd4ZksXS6rEgNWvFAR4uOWC56mK1O2JDPUfq s9P8KOaOVU2kIeVKVfPi6ehaw5NhdFkvkN36UTAY/IHRBVMxwLV8Xa80crzZQoHd xSm0XT+K =G40t -----END PGP SIGNATURE----- --LQksG6bCIzRHxTLp--