[PATCH net-next] net: dsa: tag_8021q: only call skb_push/skb_pull around __skb_vlan_pop

[PATCH net-next] net: dsa: tag_8021q: only call skb_push/skb_pull around __skb_vlan_pop

[Vladimir Oltean]

__skb_vlan_pop() needs skb->data to point at the mac_header, while
skb_vlan_tag_present() and skb_vlan_tag_get() don't, because they don't
look at skb->data at all.

So we can avoid uselessly moving around skb->data for the case where the
VLAN tag was offloaded by the DSA master.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
 net/dsa/tag_8021q.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/dsa/tag_8021q.c b/net/dsa/tag_8021q.c
index 27712a81c967..114f663332d0 100644
--- a/net/dsa/tag_8021q.c
+++ b/net/dsa/tag_8021q.c
@@ -577,14 +577,14 @@ void dsa_8021q_rcv(struct sk_buff *skb, int *source_port, int *switch_id)
 {
 	u16 vid, tci;
 
-	skb_push_rcsum(skb, ETH_HLEN);
 	if (skb_vlan_tag_present(skb)) {
 		tci = skb_vlan_tag_get(skb);
 		__vlan_hwaccel_clear_tag(skb);
 	} else {
+		skb_push_rcsum(skb, ETH_HLEN);
 		__skb_vlan_pop(skb, &tci);
+		skb_pull_rcsum(skb, ETH_HLEN);
 	}
-	skb_pull_rcsum(skb, ETH_HLEN);
 
 	vid = tci & VLAN_VID_MASK;
 
-- 
2.25.1

Re: [PATCH net-next] net: dsa: tag_8021q: only call skb_push/skb_pull around __skb_vlan_pop

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Tue, 15 Feb 2022 22:47:22 +0200 you wrote:
> __skb_vlan_pop() needs skb->data to point at the mac_header, while
> skb_vlan_tag_present() and skb_vlan_tag_get() don't, because they don't
> look at skb->data at all.
> 
> So we can avoid uselessly moving around skb->data for the case where the
> VLAN tag was offloaded by the DSA master.
> 
> [...]

Here is the summary with links:
  - [net-next] net: dsa: tag_8021q: only call skb_push/skb_pull around __skb_vlan_pop
    https://git.kernel.org/netdev/net-next/c/c8620335951d

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html