All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v5 0/8] document dt-schema and fix node names for some USB Ethernet controllers
@ 2022-02-16  7:49 ` Oleksij Rempel
  0 siblings, 0 replies; 46+ messages in thread
From: Oleksij Rempel @ 2022-02-16  7:49 UTC (permalink / raw)
  To: Benoît Cousson, David S. Miller, Florian Fainelli,
	Jakub Kicinski, Krzysztof Kozlowski, Nicolas Saenz Julienne,
	Ray Jui, Rob Herring, Sascha Hauer, Scott Branden, Shawn Guo,
	Tony Lindgren
  Cc: Oleksij Rempel, kernel, bcm-kernel-feedback-list, netdev,
	devicetree, linux-kernel, linux-usb, linux-rpi-kernel,
	linux-arm-kernel, linux-samsung-soc, linux-omap, linux-tegra

changes v5:
- move compatible string changes to a separate patch
- add note about possible regressions

changes v4:
- reword commit logs.
- add note about compatible fix

Oleksij Rempel (9):
  dt-bindings: net: add schema for ASIX USB Ethernet controllers
  dt-bindings: net: add schema for Microchip/SMSC LAN95xx USB Ethernet
    controllers
  dt-bindings: usb: ci-hdrc-usb2: fix node node for ethernet controller
  ARM: dts: bcm283x: fix ethernet node name
  ARM: dts: exynos: fix ethernet node name for different odroid boards
  ARM: dts: exynos: fix compatible strings for Ethernet USB devices
  ARM: dts: omap3/4/5: fix ethernet node name for different OMAP boards
  ARM: dts: tegra20/30: fix ethernet node name for different tegra
    boards
  arm64: dts: imx8mm-kontron: fix ethernet node name

 .../devicetree/bindings/net/asix,ax88178.yaml | 68 ++++++++++++++++
 .../bindings/net/microchip,lan95xx.yaml       | 80 +++++++++++++++++++
 .../devicetree/bindings/usb/ci-hdrc-usb2.txt  |  2 +-
 arch/arm/boot/dts/bcm283x-rpi-smsc9512.dtsi   |  2 +-
 arch/arm/boot/dts/bcm283x-rpi-smsc9514.dtsi   |  2 +-
 arch/arm/boot/dts/exynos4412-odroidu3.dts     |  4 +-
 arch/arm/boot/dts/exynos4412-odroidx.dts      |  8 +-
 arch/arm/boot/dts/exynos5410-odroidxu.dts     |  4 +-
 .../boot/dts/exynos5422-odroidxu3-lite.dts    |  6 +-
 arch/arm/boot/dts/exynos5422-odroidxu3.dts    |  6 +-
 arch/arm/boot/dts/omap3-beagle-xm.dts         |  2 +-
 arch/arm/boot/dts/omap4-panda-common.dtsi     |  2 +-
 arch/arm/boot/dts/omap5-igep0050.dts          |  2 +-
 arch/arm/boot/dts/omap5-uevm.dts              |  2 +-
 arch/arm/boot/dts/tegra20-colibri.dtsi        |  2 +-
 arch/arm/boot/dts/tegra30-colibri.dtsi        |  2 +-
 arch/arm/boot/dts/tegra30-ouya.dts            |  2 +-
 .../dts/freescale/imx8mm-kontron-n801x-s.dts  |  2 +-
 18 files changed, 173 insertions(+), 25 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/net/asix,ax88178.yaml
 create mode 100644 Documentation/devicetree/bindings/net/microchip,lan95xx.yaml

-- 
2.30.2


^ permalink raw reply	[flat|nested] 46+ messages in thread

* [PATCH v5 0/8] document dt-schema and fix node names for some USB Ethernet controllers
@ 2022-02-16  7:49 ` Oleksij Rempel
  0 siblings, 0 replies; 46+ messages in thread
From: Oleksij Rempel @ 2022-02-16  7:49 UTC (permalink / raw)
  To: Benoît Cousson, David S. Miller, Florian Fainelli,
	Jakub Kicinski, Krzysztof Kozlowski, Nicolas Saenz Julienne,
	Ray Jui, Rob Herring, Sascha Hauer, Scott Branden, Shawn Guo,
	Tony Lindgren
  Cc: Oleksij Rempel, kernel, bcm-kernel-feedback-list, netdev,
	devicetree, linux-kernel, linux-usb, linux-rpi-kernel,
	linux-arm-kernel, linux-samsung-soc, linux-omap, linux-tegra

changes v5:
- move compatible string changes to a separate patch
- add note about possible regressions

changes v4:
- reword commit logs.
- add note about compatible fix

Oleksij Rempel (9):
  dt-bindings: net: add schema for ASIX USB Ethernet controllers
  dt-bindings: net: add schema for Microchip/SMSC LAN95xx USB Ethernet
    controllers
  dt-bindings: usb: ci-hdrc-usb2: fix node node for ethernet controller
  ARM: dts: bcm283x: fix ethernet node name
  ARM: dts: exynos: fix ethernet node name for different odroid boards
  ARM: dts: exynos: fix compatible strings for Ethernet USB devices
  ARM: dts: omap3/4/5: fix ethernet node name for different OMAP boards
  ARM: dts: tegra20/30: fix ethernet node name for different tegra
    boards
  arm64: dts: imx8mm-kontron: fix ethernet node name

 .../devicetree/bindings/net/asix,ax88178.yaml | 68 ++++++++++++++++
 .../bindings/net/microchip,lan95xx.yaml       | 80 +++++++++++++++++++
 .../devicetree/bindings/usb/ci-hdrc-usb2.txt  |  2 +-
 arch/arm/boot/dts/bcm283x-rpi-smsc9512.dtsi   |  2 +-
 arch/arm/boot/dts/bcm283x-rpi-smsc9514.dtsi   |  2 +-
 arch/arm/boot/dts/exynos4412-odroidu3.dts     |  4 +-
 arch/arm/boot/dts/exynos4412-odroidx.dts      |  8 +-
 arch/arm/boot/dts/exynos5410-odroidxu.dts     |  4 +-
 .../boot/dts/exynos5422-odroidxu3-lite.dts    |  6 +-
 arch/arm/boot/dts/exynos5422-odroidxu3.dts    |  6 +-
 arch/arm/boot/dts/omap3-beagle-xm.dts         |  2 +-
 arch/arm/boot/dts/omap4-panda-common.dtsi     |  2 +-
 arch/arm/boot/dts/omap5-igep0050.dts          |  2 +-
 arch/arm/boot/dts/omap5-uevm.dts              |  2 +-
 arch/arm/boot/dts/tegra20-colibri.dtsi        |  2 +-
 arch/arm/boot/dts/tegra30-colibri.dtsi        |  2 +-
 arch/arm/boot/dts/tegra30-ouya.dts            |  2 +-
 .../dts/freescale/imx8mm-kontron-n801x-s.dts  |  2 +-
 18 files changed, 173 insertions(+), 25 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/net/asix,ax88178.yaml
 create mode 100644 Documentation/devicetree/bindings/net/microchip,lan95xx.yaml

-- 
2.30.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 46+ messages in thread

* [PATCH v5 1/9] dt-bindings: net: add schema for ASIX USB Ethernet controllers
  2022-02-16  7:49 ` Oleksij Rempel
@ 2022-02-16  7:49   ` Oleksij Rempel
  -1 siblings, 0 replies; 46+ messages in thread
From: Oleksij Rempel @ 2022-02-16  7:49 UTC (permalink / raw)
  To: Benoît Cousson, David S. Miller, Florian Fainelli,
	Jakub Kicinski, Krzysztof Kozlowski, Nicolas Saenz Julienne,
	Ray Jui, Rob Herring, Sascha Hauer, Scott Branden, Shawn Guo,
	Tony Lindgren
  Cc: Oleksij Rempel, kernel, bcm-kernel-feedback-list, netdev,
	devicetree, linux-kernel, linux-usb, linux-rpi-kernel,
	linux-arm-kernel, linux-samsung-soc, linux-omap, linux-tegra

Create schema for ASIX USB Ethernet controllers and import some of
currently supported USB IDs form drivers/net/usb/asix_devices.c

These devices are already used in some of DTs. So, this schema makes it official.
NOTE: there was no previously documented txt based DT binding for this
controllers.

Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
 .../devicetree/bindings/net/asix,ax88178.yaml | 68 +++++++++++++++++++
 1 file changed, 68 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/net/asix,ax88178.yaml

diff --git a/Documentation/devicetree/bindings/net/asix,ax88178.yaml b/Documentation/devicetree/bindings/net/asix,ax88178.yaml
new file mode 100644
index 000000000000..1af52358de4c
--- /dev/null
+++ b/Documentation/devicetree/bindings/net/asix,ax88178.yaml
@@ -0,0 +1,68 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/net/asix,ax88178.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: The device tree bindings for the USB Ethernet controllers
+
+maintainers:
+  - Oleksij Rempel <o.rempel@pengutronix.de>
+
+description: |
+  Device tree properties for hard wired USB Ethernet devices.
+
+allOf:
+  - $ref: ethernet-controller.yaml#
+
+properties:
+  compatible:
+    items:
+      - enum:
+          - usbb95,1720   # ASIX AX88172
+          - usbb95,172a   # ASIX AX88172A
+          - usbb95,1780   # ASIX AX88178
+          - usbb95,7720   # ASIX AX88772
+          - usbb95,772a   # ASIX AX88772A
+          - usbb95,772b   # ASIX AX88772B
+          - usbb95,7e2b   # ASIX AX88772B
+
+  reg: true
+  local-mac-address: true
+  mac-address: true
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    usb {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        ethernet@1 {
+            compatible = "usbb95,7e2b";
+            reg = <1>;
+            local-mac-address = [00 00 00 00 00 00];
+        };
+    };
+  - |
+    usb {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        usb1@1 {
+            compatible = "usb1234,5678";
+            reg = <1>;
+            #address-cells = <1>;
+            #size-cells = <0>;
+
+            ethernet@1 {
+               compatible = "usbb95,772b";
+               reg = <1>;
+            };
+        };
+    };
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 46+ messages in thread

* [PATCH v5 1/9] dt-bindings: net: add schema for ASIX USB Ethernet controllers
@ 2022-02-16  7:49   ` Oleksij Rempel
  0 siblings, 0 replies; 46+ messages in thread
From: Oleksij Rempel @ 2022-02-16  7:49 UTC (permalink / raw)
  To: Benoît Cousson, David S. Miller, Florian Fainelli,
	Jakub Kicinski, Krzysztof Kozlowski, Nicolas Saenz Julienne,
	Ray Jui, Rob Herring, Sascha Hauer, Scott Branden, Shawn Guo,
	Tony Lindgren
  Cc: Oleksij Rempel, kernel, bcm-kernel-feedback-list, netdev,
	devicetree, linux-kernel, linux-usb, linux-rpi-kernel,
	linux-arm-kernel, linux-samsung-soc, linux-omap, linux-tegra

Create schema for ASIX USB Ethernet controllers and import some of
currently supported USB IDs form drivers/net/usb/asix_devices.c

These devices are already used in some of DTs. So, this schema makes it official.
NOTE: there was no previously documented txt based DT binding for this
controllers.

Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
 .../devicetree/bindings/net/asix,ax88178.yaml | 68 +++++++++++++++++++
 1 file changed, 68 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/net/asix,ax88178.yaml

diff --git a/Documentation/devicetree/bindings/net/asix,ax88178.yaml b/Documentation/devicetree/bindings/net/asix,ax88178.yaml
new file mode 100644
index 000000000000..1af52358de4c
--- /dev/null
+++ b/Documentation/devicetree/bindings/net/asix,ax88178.yaml
@@ -0,0 +1,68 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/net/asix,ax88178.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: The device tree bindings for the USB Ethernet controllers
+
+maintainers:
+  - Oleksij Rempel <o.rempel@pengutronix.de>
+
+description: |
+  Device tree properties for hard wired USB Ethernet devices.
+
+allOf:
+  - $ref: ethernet-controller.yaml#
+
+properties:
+  compatible:
+    items:
+      - enum:
+          - usbb95,1720   # ASIX AX88172
+          - usbb95,172a   # ASIX AX88172A
+          - usbb95,1780   # ASIX AX88178
+          - usbb95,7720   # ASIX AX88772
+          - usbb95,772a   # ASIX AX88772A
+          - usbb95,772b   # ASIX AX88772B
+          - usbb95,7e2b   # ASIX AX88772B
+
+  reg: true
+  local-mac-address: true
+  mac-address: true
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    usb {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        ethernet@1 {
+            compatible = "usbb95,7e2b";
+            reg = <1>;
+            local-mac-address = [00 00 00 00 00 00];
+        };
+    };
+  - |
+    usb {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        usb1@1 {
+            compatible = "usb1234,5678";
+            reg = <1>;
+            #address-cells = <1>;
+            #size-cells = <0>;
+
+            ethernet@1 {
+               compatible = "usbb95,772b";
+               reg = <1>;
+            };
+        };
+    };
-- 
2.30.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 46+ messages in thread

* [PATCH v5 2/9] dt-bindings: net: add schema for Microchip/SMSC LAN95xx USB Ethernet controllers
  2022-02-16  7:49 ` Oleksij Rempel
@ 2022-02-16  7:49   ` Oleksij Rempel
  -1 siblings, 0 replies; 46+ messages in thread
From: Oleksij Rempel @ 2022-02-16  7:49 UTC (permalink / raw)
  To: Benoît Cousson, David S. Miller, Florian Fainelli,
	Jakub Kicinski, Krzysztof Kozlowski, Nicolas Saenz Julienne,
	Ray Jui, Rob Herring, Sascha Hauer, Scott Branden, Shawn Guo,
	Tony Lindgren
  Cc: Oleksij Rempel, kernel, bcm-kernel-feedback-list, netdev,
	devicetree, linux-kernel, linux-usb, linux-rpi-kernel,
	linux-arm-kernel, linux-samsung-soc, linux-omap, linux-tegra

Create initial schema for Microchip/SMSC LAN95xx USB Ethernet controllers and
import some of currently supported USB IDs form drivers/net/usb/smsc95xx.c

These devices are already used in some of DTs. So, this schema makes it official.
NOTE: there was no previously documented txt based DT binding for this
controllers.

Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
 .../bindings/net/microchip,lan95xx.yaml       | 80 +++++++++++++++++++
 1 file changed, 80 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/net/microchip,lan95xx.yaml

diff --git a/Documentation/devicetree/bindings/net/microchip,lan95xx.yaml b/Documentation/devicetree/bindings/net/microchip,lan95xx.yaml
new file mode 100644
index 000000000000..8521c65366b4
--- /dev/null
+++ b/Documentation/devicetree/bindings/net/microchip,lan95xx.yaml
@@ -0,0 +1,80 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/net/microchip,lan95xx.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: The device tree bindings for the USB Ethernet controllers
+
+maintainers:
+  - Oleksij Rempel <o.rempel@pengutronix.de>
+
+description: |
+  Device tree properties for hard wired SMSC95xx compatible USB Ethernet
+  controller.
+
+allOf:
+  - $ref: ethernet-controller.yaml#
+
+properties:
+  compatible:
+    items:
+      - enum:
+          - usb424,9500   # SMSC9500 USB Ethernet Device
+          - usb424,9505   # SMSC9505 USB Ethernet Device
+          - usb424,9530   # SMSC LAN9530 USB Ethernet Device
+          - usb424,9730   # SMSC LAN9730 USB Ethernet Device
+          - usb424,9900   # SMSC9500 USB Ethernet Device (SAL10)
+          - usb424,9901   # SMSC9505 USB Ethernet Device (SAL10)
+          - usb424,9902   # SMSC9500A USB Ethernet Device (SAL10)
+          - usb424,9903   # SMSC9505A USB Ethernet Device (SAL10)
+          - usb424,9904   # SMSC9512/9514 USB Hub & Ethernet Device (SAL10)
+          - usb424,9905   # SMSC9500A USB Ethernet Device (HAL)
+          - usb424,9906   # SMSC9505A USB Ethernet Device (HAL)
+          - usb424,9907   # SMSC9500 USB Ethernet Device (Alternate ID)
+          - usb424,9908   # SMSC9500A USB Ethernet Device (Alternate ID)
+          - usb424,9909   # SMSC9512/9514 USB Hub & Ethernet Devic.  ID)
+          - usb424,9e00   # SMSC9500A USB Ethernet Device
+          - usb424,9e01   # SMSC9505A USB Ethernet Device
+          - usb424,9e08   # SMSC LAN89530 USB Ethernet Device
+          - usb424,ec00   # SMSC9512/9514 USB Hub & Ethernet Device
+
+  reg: true
+  local-mac-address: true
+  mac-address: true
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    usb {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        ethernet@1 {
+            compatible = "usb424,ec00";
+            reg = <1>;
+            local-mac-address = [00 00 00 00 00 00];
+        };
+    };
+  - |
+    usb {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        usb1@1 {
+            compatible = "usb424,9514";
+            reg = <1>;
+            #address-cells = <1>;
+            #size-cells = <0>;
+
+            ethernet@1 {
+               compatible = "usb424,ec00";
+               reg = <1>;
+            };
+        };
+    };
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 46+ messages in thread

* [PATCH v5 2/9] dt-bindings: net: add schema for Microchip/SMSC LAN95xx USB Ethernet controllers
@ 2022-02-16  7:49   ` Oleksij Rempel
  0 siblings, 0 replies; 46+ messages in thread
From: Oleksij Rempel @ 2022-02-16  7:49 UTC (permalink / raw)
  To: Benoît Cousson, David S. Miller, Florian Fainelli,
	Jakub Kicinski, Krzysztof Kozlowski, Nicolas Saenz Julienne,
	Ray Jui, Rob Herring, Sascha Hauer, Scott Branden, Shawn Guo,
	Tony Lindgren
  Cc: Oleksij Rempel, kernel, bcm-kernel-feedback-list, netdev,
	devicetree, linux-kernel, linux-usb, linux-rpi-kernel,
	linux-arm-kernel, linux-samsung-soc, linux-omap, linux-tegra

Create initial schema for Microchip/SMSC LAN95xx USB Ethernet controllers and
import some of currently supported USB IDs form drivers/net/usb/smsc95xx.c

These devices are already used in some of DTs. So, this schema makes it official.
NOTE: there was no previously documented txt based DT binding for this
controllers.

Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
 .../bindings/net/microchip,lan95xx.yaml       | 80 +++++++++++++++++++
 1 file changed, 80 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/net/microchip,lan95xx.yaml

diff --git a/Documentation/devicetree/bindings/net/microchip,lan95xx.yaml b/Documentation/devicetree/bindings/net/microchip,lan95xx.yaml
new file mode 100644
index 000000000000..8521c65366b4
--- /dev/null
+++ b/Documentation/devicetree/bindings/net/microchip,lan95xx.yaml
@@ -0,0 +1,80 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/net/microchip,lan95xx.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: The device tree bindings for the USB Ethernet controllers
+
+maintainers:
+  - Oleksij Rempel <o.rempel@pengutronix.de>
+
+description: |
+  Device tree properties for hard wired SMSC95xx compatible USB Ethernet
+  controller.
+
+allOf:
+  - $ref: ethernet-controller.yaml#
+
+properties:
+  compatible:
+    items:
+      - enum:
+          - usb424,9500   # SMSC9500 USB Ethernet Device
+          - usb424,9505   # SMSC9505 USB Ethernet Device
+          - usb424,9530   # SMSC LAN9530 USB Ethernet Device
+          - usb424,9730   # SMSC LAN9730 USB Ethernet Device
+          - usb424,9900   # SMSC9500 USB Ethernet Device (SAL10)
+          - usb424,9901   # SMSC9505 USB Ethernet Device (SAL10)
+          - usb424,9902   # SMSC9500A USB Ethernet Device (SAL10)
+          - usb424,9903   # SMSC9505A USB Ethernet Device (SAL10)
+          - usb424,9904   # SMSC9512/9514 USB Hub & Ethernet Device (SAL10)
+          - usb424,9905   # SMSC9500A USB Ethernet Device (HAL)
+          - usb424,9906   # SMSC9505A USB Ethernet Device (HAL)
+          - usb424,9907   # SMSC9500 USB Ethernet Device (Alternate ID)
+          - usb424,9908   # SMSC9500A USB Ethernet Device (Alternate ID)
+          - usb424,9909   # SMSC9512/9514 USB Hub & Ethernet Devic.  ID)
+          - usb424,9e00   # SMSC9500A USB Ethernet Device
+          - usb424,9e01   # SMSC9505A USB Ethernet Device
+          - usb424,9e08   # SMSC LAN89530 USB Ethernet Device
+          - usb424,ec00   # SMSC9512/9514 USB Hub & Ethernet Device
+
+  reg: true
+  local-mac-address: true
+  mac-address: true
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    usb {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        ethernet@1 {
+            compatible = "usb424,ec00";
+            reg = <1>;
+            local-mac-address = [00 00 00 00 00 00];
+        };
+    };
+  - |
+    usb {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        usb1@1 {
+            compatible = "usb424,9514";
+            reg = <1>;
+            #address-cells = <1>;
+            #size-cells = <0>;
+
+            ethernet@1 {
+               compatible = "usb424,ec00";
+               reg = <1>;
+            };
+        };
+    };
-- 
2.30.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 46+ messages in thread

* [PATCH v5 3/9] dt-bindings: usb: ci-hdrc-usb2: fix node node for ethernet controller
  2022-02-16  7:49 ` Oleksij Rempel
@ 2022-02-16  7:49   ` Oleksij Rempel
  -1 siblings, 0 replies; 46+ messages in thread
From: Oleksij Rempel @ 2022-02-16  7:49 UTC (permalink / raw)
  To: Benoît Cousson, David S. Miller, Florian Fainelli,
	Jakub Kicinski, Krzysztof Kozlowski, Nicolas Saenz Julienne,
	Ray Jui, Rob Herring, Sascha Hauer, Scott Branden, Shawn Guo,
	Tony Lindgren
  Cc: Oleksij Rempel, kernel, bcm-kernel-feedback-list, netdev,
	devicetree, linux-kernel, linux-usb, linux-rpi-kernel,
	linux-arm-kernel, linux-samsung-soc, linux-omap, linux-tegra

This documentation provides wrong node name for the Ethernet controller.
It should be "ethernet" instead of "smsc" as required by Ethernet
controller devicetree schema:
 Documentation/devicetree/bindings/net/ethernet-controller.yaml

Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
 Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
index a5c5db6a0b2d..ba51fb1252b9 100644
--- a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
+++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
@@ -151,7 +151,7 @@ Example for HSIC:
 		#address-cells = <1>;
 		#size-cells = <0>;
 
-		usbnet: smsc@1 {
+		usbnet: ethernet@1 {
 			compatible = "usb424,9730";
 			reg = <1>;
 		};
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 46+ messages in thread

* [PATCH v5 3/9] dt-bindings: usb: ci-hdrc-usb2: fix node node for ethernet controller
@ 2022-02-16  7:49   ` Oleksij Rempel
  0 siblings, 0 replies; 46+ messages in thread
From: Oleksij Rempel @ 2022-02-16  7:49 UTC (permalink / raw)
  To: Benoît Cousson, David S. Miller, Florian Fainelli,
	Jakub Kicinski, Krzysztof Kozlowski, Nicolas Saenz Julienne,
	Ray Jui, Rob Herring, Sascha Hauer, Scott Branden, Shawn Guo,
	Tony Lindgren
  Cc: Oleksij Rempel, kernel, bcm-kernel-feedback-list, netdev,
	devicetree, linux-kernel, linux-usb, linux-rpi-kernel,
	linux-arm-kernel, linux-samsung-soc, linux-omap, linux-tegra

This documentation provides wrong node name for the Ethernet controller.
It should be "ethernet" instead of "smsc" as required by Ethernet
controller devicetree schema:
 Documentation/devicetree/bindings/net/ethernet-controller.yaml

Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
 Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
index a5c5db6a0b2d..ba51fb1252b9 100644
--- a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
+++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt
@@ -151,7 +151,7 @@ Example for HSIC:
 		#address-cells = <1>;
 		#size-cells = <0>;
 
-		usbnet: smsc@1 {
+		usbnet: ethernet@1 {
 			compatible = "usb424,9730";
 			reg = <1>;
 		};
-- 
2.30.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 46+ messages in thread

* [PATCH v5 4/9] ARM: dts: bcm283x: fix ethernet node name
  2022-02-16  7:49 ` Oleksij Rempel
@ 2022-02-16  7:49   ` Oleksij Rempel
  -1 siblings, 0 replies; 46+ messages in thread
From: Oleksij Rempel @ 2022-02-16  7:49 UTC (permalink / raw)
  To: Benoît Cousson, David S. Miller, Florian Fainelli,
	Jakub Kicinski, Krzysztof Kozlowski, Nicolas Saenz Julienne,
	Ray Jui, Rob Herring, Sascha Hauer, Scott Branden, Shawn Guo,
	Tony Lindgren
  Cc: Oleksij Rempel, kernel, bcm-kernel-feedback-list, netdev,
	devicetree, linux-kernel, linux-usb, linux-rpi-kernel,
	linux-arm-kernel, linux-samsung-soc, linux-omap, linux-tegra

It should be "ethernet@x" instead of "usbether@x" as required by Ethernet
controller devicetree schema:
 Documentation/devicetree/bindings/net/ethernet-controller.yaml

This patch can potentially affect boot loaders patching against full
node path instead of using device aliases.

Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
 arch/arm/boot/dts/bcm283x-rpi-smsc9512.dtsi | 2 +-
 arch/arm/boot/dts/bcm283x-rpi-smsc9514.dtsi | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/bcm283x-rpi-smsc9512.dtsi b/arch/arm/boot/dts/bcm283x-rpi-smsc9512.dtsi
index 967e081cb9c2..882b13807075 100644
--- a/arch/arm/boot/dts/bcm283x-rpi-smsc9512.dtsi
+++ b/arch/arm/boot/dts/bcm283x-rpi-smsc9512.dtsi
@@ -12,7 +12,7 @@ usb1@1 {
 		#address-cells = <1>;
 		#size-cells = <0>;
 
-		ethernet: usbether@1 {
+		ethernet: ethernet@1 {
 			compatible = "usb424,ec00";
 			reg = <1>;
 		};
diff --git a/arch/arm/boot/dts/bcm283x-rpi-smsc9514.dtsi b/arch/arm/boot/dts/bcm283x-rpi-smsc9514.dtsi
index dc7ae776db5f..4273b90b53cc 100644
--- a/arch/arm/boot/dts/bcm283x-rpi-smsc9514.dtsi
+++ b/arch/arm/boot/dts/bcm283x-rpi-smsc9514.dtsi
@@ -11,7 +11,7 @@ usb1@1 {
 		#address-cells = <1>;
 		#size-cells = <0>;
 
-		ethernet: usbether@1 {
+		ethernet: ethernet@1 {
 			compatible = "usb424,ec00";
 			reg = <1>;
 		};
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 46+ messages in thread

* [PATCH v5 4/9] ARM: dts: bcm283x: fix ethernet node name
@ 2022-02-16  7:49   ` Oleksij Rempel
  0 siblings, 0 replies; 46+ messages in thread
From: Oleksij Rempel @ 2022-02-16  7:49 UTC (permalink / raw)
  To: Benoît Cousson, David S. Miller, Florian Fainelli,
	Jakub Kicinski, Krzysztof Kozlowski, Nicolas Saenz Julienne,
	Ray Jui, Rob Herring, Sascha Hauer, Scott Branden, Shawn Guo,
	Tony Lindgren
  Cc: Oleksij Rempel, kernel, bcm-kernel-feedback-list, netdev,
	devicetree, linux-kernel, linux-usb, linux-rpi-kernel,
	linux-arm-kernel, linux-samsung-soc, linux-omap, linux-tegra

It should be "ethernet@x" instead of "usbether@x" as required by Ethernet
controller devicetree schema:
 Documentation/devicetree/bindings/net/ethernet-controller.yaml

This patch can potentially affect boot loaders patching against full
node path instead of using device aliases.

Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
 arch/arm/boot/dts/bcm283x-rpi-smsc9512.dtsi | 2 +-
 arch/arm/boot/dts/bcm283x-rpi-smsc9514.dtsi | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/bcm283x-rpi-smsc9512.dtsi b/arch/arm/boot/dts/bcm283x-rpi-smsc9512.dtsi
index 967e081cb9c2..882b13807075 100644
--- a/arch/arm/boot/dts/bcm283x-rpi-smsc9512.dtsi
+++ b/arch/arm/boot/dts/bcm283x-rpi-smsc9512.dtsi
@@ -12,7 +12,7 @@ usb1@1 {
 		#address-cells = <1>;
 		#size-cells = <0>;
 
-		ethernet: usbether@1 {
+		ethernet: ethernet@1 {
 			compatible = "usb424,ec00";
 			reg = <1>;
 		};
diff --git a/arch/arm/boot/dts/bcm283x-rpi-smsc9514.dtsi b/arch/arm/boot/dts/bcm283x-rpi-smsc9514.dtsi
index dc7ae776db5f..4273b90b53cc 100644
--- a/arch/arm/boot/dts/bcm283x-rpi-smsc9514.dtsi
+++ b/arch/arm/boot/dts/bcm283x-rpi-smsc9514.dtsi
@@ -11,7 +11,7 @@ usb1@1 {
 		#address-cells = <1>;
 		#size-cells = <0>;
 
-		ethernet: usbether@1 {
+		ethernet: ethernet@1 {
 			compatible = "usb424,ec00";
 			reg = <1>;
 		};
-- 
2.30.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 46+ messages in thread

* [PATCH v5 5/9] ARM: dts: exynos: fix ethernet node name for different odroid boards
  2022-02-16  7:49 ` Oleksij Rempel
@ 2022-02-16  7:49   ` Oleksij Rempel
  -1 siblings, 0 replies; 46+ messages in thread
From: Oleksij Rempel @ 2022-02-16  7:49 UTC (permalink / raw)
  To: Benoît Cousson, David S. Miller, Florian Fainelli,
	Jakub Kicinski, Krzysztof Kozlowski, Nicolas Saenz Julienne,
	Ray Jui, Rob Herring, Sascha Hauer, Scott Branden, Shawn Guo,
	Tony Lindgren
  Cc: Oleksij Rempel, kernel, bcm-kernel-feedback-list, netdev,
	devicetree, linux-kernel, linux-usb, linux-rpi-kernel,
	linux-arm-kernel, linux-samsung-soc, linux-omap, linux-tegra

The node name of Ethernet controller should be "ethernet" instead of
"usbether" as required by Ethernet controller devicetree schema:
 Documentation/devicetree/bindings/net/ethernet-controller.yaml

This patch can potentially affect boot loaders patching against full
node path instead of using device aliases.

Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
 arch/arm/boot/dts/exynos4412-odroidu3.dts       | 2 +-
 arch/arm/boot/dts/exynos4412-odroidx.dts        | 2 +-
 arch/arm/boot/dts/exynos5410-odroidxu.dts       | 2 +-
 arch/arm/boot/dts/exynos5422-odroidxu3-lite.dts | 2 +-
 arch/arm/boot/dts/exynos5422-odroidxu3.dts      | 2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/arch/arm/boot/dts/exynos4412-odroidu3.dts b/arch/arm/boot/dts/exynos4412-odroidu3.dts
index efaf7533e84f..5ddbb6cbe1bf 100644
--- a/arch/arm/boot/dts/exynos4412-odroidu3.dts
+++ b/arch/arm/boot/dts/exynos4412-odroidu3.dts
@@ -119,7 +119,7 @@ &ehci {
 	phys = <&exynos_usbphy 2>, <&exynos_usbphy 3>;
 	phy-names = "hsic0", "hsic1";
 
-	ethernet: usbether@2 {
+	ethernet: ethernet@2 {
 		compatible = "usb0424,9730";
 		reg = <2>;
 		local-mac-address = [00 00 00 00 00 00]; /* Filled in by a bootloader */
diff --git a/arch/arm/boot/dts/exynos4412-odroidx.dts b/arch/arm/boot/dts/exynos4412-odroidx.dts
index 440135d0ff2a..ea7bccec518d 100644
--- a/arch/arm/boot/dts/exynos4412-odroidx.dts
+++ b/arch/arm/boot/dts/exynos4412-odroidx.dts
@@ -81,7 +81,7 @@ hub@1 {
 			#address-cells = <1>;
 			#size-cells = <0>;
 
-			ethernet: usbether@1 {
+			ethernet: ethernet@1 {
 				compatible = "usb0424,ec00";
 				reg = <1>;
 				/* Filled in by a bootloader */
diff --git a/arch/arm/boot/dts/exynos5410-odroidxu.dts b/arch/arm/boot/dts/exynos5410-odroidxu.dts
index 884fef55836c..38e23b4ae730 100644
--- a/arch/arm/boot/dts/exynos5410-odroidxu.dts
+++ b/arch/arm/boot/dts/exynos5410-odroidxu.dts
@@ -675,7 +675,7 @@ &usbhost2 {
 	#address-cells = <1>;
 	#size-cells = <0>;
 
-	ethernet: usbether@2 {
+	ethernet: ethernet@2 {
 		compatible = "usb0424,9730";
 		reg = <2>;
 		local-mac-address = [00 00 00 00 00 00]; /* Filled in by a bootloader */
diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-lite.dts b/arch/arm/boot/dts/exynos5422-odroidxu3-lite.dts
index 62c5928aa994..749f051ffe70 100644
--- a/arch/arm/boot/dts/exynos5422-odroidxu3-lite.dts
+++ b/arch/arm/boot/dts/exynos5422-odroidxu3-lite.dts
@@ -118,7 +118,7 @@ hub@1 {
 		#address-cells = <1>;
 		#size-cells = <0>;
 
-		ethernet: usbether@1 {
+		ethernet: ethernet@1 {
 			compatible = "usb0424,ec00";
 			reg = <1>;
 			local-mac-address = [00 00 00 00 00 00]; /* Filled in by a bootloader */
diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
index cecaeb69e623..8cf3d644a4c1 100644
--- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
+++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
@@ -85,7 +85,7 @@ hub@1 {
 		#address-cells = <1>;
 		#size-cells = <0>;
 
-		ethernet: usbether@1 {
+		ethernet: ethernet@1 {
 			compatible = "usb0424,ec00";
 			reg = <1>;
 			local-mac-address = [00 00 00 00 00 00]; /* Filled in by a bootloader */
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 46+ messages in thread

* [PATCH v5 5/9] ARM: dts: exynos: fix ethernet node name for different odroid boards
@ 2022-02-16  7:49   ` Oleksij Rempel
  0 siblings, 0 replies; 46+ messages in thread
From: Oleksij Rempel @ 2022-02-16  7:49 UTC (permalink / raw)
  To: Benoît Cousson, David S. Miller, Florian Fainelli,
	Jakub Kicinski, Krzysztof Kozlowski, Nicolas Saenz Julienne,
	Ray Jui, Rob Herring, Sascha Hauer, Scott Branden, Shawn Guo,
	Tony Lindgren
  Cc: Oleksij Rempel, kernel, bcm-kernel-feedback-list, netdev,
	devicetree, linux-kernel, linux-usb, linux-rpi-kernel,
	linux-arm-kernel, linux-samsung-soc, linux-omap, linux-tegra

The node name of Ethernet controller should be "ethernet" instead of
"usbether" as required by Ethernet controller devicetree schema:
 Documentation/devicetree/bindings/net/ethernet-controller.yaml

This patch can potentially affect boot loaders patching against full
node path instead of using device aliases.

Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
 arch/arm/boot/dts/exynos4412-odroidu3.dts       | 2 +-
 arch/arm/boot/dts/exynos4412-odroidx.dts        | 2 +-
 arch/arm/boot/dts/exynos5410-odroidxu.dts       | 2 +-
 arch/arm/boot/dts/exynos5422-odroidxu3-lite.dts | 2 +-
 arch/arm/boot/dts/exynos5422-odroidxu3.dts      | 2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/arch/arm/boot/dts/exynos4412-odroidu3.dts b/arch/arm/boot/dts/exynos4412-odroidu3.dts
index efaf7533e84f..5ddbb6cbe1bf 100644
--- a/arch/arm/boot/dts/exynos4412-odroidu3.dts
+++ b/arch/arm/boot/dts/exynos4412-odroidu3.dts
@@ -119,7 +119,7 @@ &ehci {
 	phys = <&exynos_usbphy 2>, <&exynos_usbphy 3>;
 	phy-names = "hsic0", "hsic1";
 
-	ethernet: usbether@2 {
+	ethernet: ethernet@2 {
 		compatible = "usb0424,9730";
 		reg = <2>;
 		local-mac-address = [00 00 00 00 00 00]; /* Filled in by a bootloader */
diff --git a/arch/arm/boot/dts/exynos4412-odroidx.dts b/arch/arm/boot/dts/exynos4412-odroidx.dts
index 440135d0ff2a..ea7bccec518d 100644
--- a/arch/arm/boot/dts/exynos4412-odroidx.dts
+++ b/arch/arm/boot/dts/exynos4412-odroidx.dts
@@ -81,7 +81,7 @@ hub@1 {
 			#address-cells = <1>;
 			#size-cells = <0>;
 
-			ethernet: usbether@1 {
+			ethernet: ethernet@1 {
 				compatible = "usb0424,ec00";
 				reg = <1>;
 				/* Filled in by a bootloader */
diff --git a/arch/arm/boot/dts/exynos5410-odroidxu.dts b/arch/arm/boot/dts/exynos5410-odroidxu.dts
index 884fef55836c..38e23b4ae730 100644
--- a/arch/arm/boot/dts/exynos5410-odroidxu.dts
+++ b/arch/arm/boot/dts/exynos5410-odroidxu.dts
@@ -675,7 +675,7 @@ &usbhost2 {
 	#address-cells = <1>;
 	#size-cells = <0>;
 
-	ethernet: usbether@2 {
+	ethernet: ethernet@2 {
 		compatible = "usb0424,9730";
 		reg = <2>;
 		local-mac-address = [00 00 00 00 00 00]; /* Filled in by a bootloader */
diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-lite.dts b/arch/arm/boot/dts/exynos5422-odroidxu3-lite.dts
index 62c5928aa994..749f051ffe70 100644
--- a/arch/arm/boot/dts/exynos5422-odroidxu3-lite.dts
+++ b/arch/arm/boot/dts/exynos5422-odroidxu3-lite.dts
@@ -118,7 +118,7 @@ hub@1 {
 		#address-cells = <1>;
 		#size-cells = <0>;
 
-		ethernet: usbether@1 {
+		ethernet: ethernet@1 {
 			compatible = "usb0424,ec00";
 			reg = <1>;
 			local-mac-address = [00 00 00 00 00 00]; /* Filled in by a bootloader */
diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
index cecaeb69e623..8cf3d644a4c1 100644
--- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
+++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
@@ -85,7 +85,7 @@ hub@1 {
 		#address-cells = <1>;
 		#size-cells = <0>;
 
-		ethernet: usbether@1 {
+		ethernet: ethernet@1 {
 			compatible = "usb0424,ec00";
 			reg = <1>;
 			local-mac-address = [00 00 00 00 00 00]; /* Filled in by a bootloader */
-- 
2.30.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 46+ messages in thread

* [PATCH v5 6/9] ARM: dts: exynos: fix compatible strings for Ethernet USB devices
  2022-02-16  7:49 ` Oleksij Rempel
@ 2022-02-16  7:49   ` Oleksij Rempel
  -1 siblings, 0 replies; 46+ messages in thread
From: Oleksij Rempel @ 2022-02-16  7:49 UTC (permalink / raw)
  To: Benoît Cousson, David S. Miller, Florian Fainelli,
	Jakub Kicinski, Krzysztof Kozlowski, Nicolas Saenz Julienne,
	Ray Jui, Rob Herring, Sascha Hauer, Scott Branden, Shawn Guo,
	Tony Lindgren
  Cc: Oleksij Rempel, kernel, bcm-kernel-feedback-list, netdev,
	devicetree, linux-kernel, linux-usb, linux-rpi-kernel,
	linux-arm-kernel, linux-samsung-soc, linux-omap, linux-tegra

Fix compatible string for Ethernet USB device as required by USB device schema:
 Documentation/devicetree/bindings/usb/usb-device.yaml
  The textual representation of VID and PID shall be in lower case hexadecimal
  with leading zeroes suppressed.

Since there are no kernel driver matching against this compatibles, I
expect no regressions with this patch. At the same time, without this fix, we
are not be able to validate this device nodes with newly provided DT
schema.

Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
 arch/arm/boot/dts/exynos4412-odroidu3.dts       | 2 +-
 arch/arm/boot/dts/exynos4412-odroidx.dts        | 6 +++---
 arch/arm/boot/dts/exynos5410-odroidxu.dts       | 2 +-
 arch/arm/boot/dts/exynos5422-odroidxu3-lite.dts | 4 ++--
 arch/arm/boot/dts/exynos5422-odroidxu3.dts      | 4 ++--
 5 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/arch/arm/boot/dts/exynos4412-odroidu3.dts b/arch/arm/boot/dts/exynos4412-odroidu3.dts
index 5ddbb6cbe1bf..36c369c42b77 100644
--- a/arch/arm/boot/dts/exynos4412-odroidu3.dts
+++ b/arch/arm/boot/dts/exynos4412-odroidu3.dts
@@ -120,7 +120,7 @@ &ehci {
 	phy-names = "hsic0", "hsic1";
 
 	ethernet: ethernet@2 {
-		compatible = "usb0424,9730";
+		compatible = "usb424,9730";
 		reg = <2>;
 		local-mac-address = [00 00 00 00 00 00]; /* Filled in by a bootloader */
 	};
diff --git a/arch/arm/boot/dts/exynos4412-odroidx.dts b/arch/arm/boot/dts/exynos4412-odroidx.dts
index ea7bccec518d..ba46baf9117f 100644
--- a/arch/arm/boot/dts/exynos4412-odroidx.dts
+++ b/arch/arm/boot/dts/exynos4412-odroidx.dts
@@ -70,19 +70,19 @@ &ehci {
 	phy-names = "hsic0";
 
 	hub@2 {
-		compatible = "usb0424,3503";
+		compatible = "usb424,3503";
 		reg = <2>;
 		#address-cells = <1>;
 		#size-cells = <0>;
 
 		hub@1 {
-			compatible = "usb0424,9514";
+			compatible = "usb424,9514";
 			reg = <1>;
 			#address-cells = <1>;
 			#size-cells = <0>;
 
 			ethernet: ethernet@1 {
-				compatible = "usb0424,ec00";
+				compatible = "usb424,ec00";
 				reg = <1>;
 				/* Filled in by a bootloader */
 				local-mac-address = [00 00 00 00 00 00];
diff --git a/arch/arm/boot/dts/exynos5410-odroidxu.dts b/arch/arm/boot/dts/exynos5410-odroidxu.dts
index 38e23b4ae730..4c7039e771db 100644
--- a/arch/arm/boot/dts/exynos5410-odroidxu.dts
+++ b/arch/arm/boot/dts/exynos5410-odroidxu.dts
@@ -676,7 +676,7 @@ &usbhost2 {
 	#size-cells = <0>;
 
 	ethernet: ethernet@2 {
-		compatible = "usb0424,9730";
+		compatible = "usb424,9730";
 		reg = <2>;
 		local-mac-address = [00 00 00 00 00 00]; /* Filled in by a bootloader */
 	};
diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-lite.dts b/arch/arm/boot/dts/exynos5422-odroidxu3-lite.dts
index 749f051ffe70..e3154a1cae23 100644
--- a/arch/arm/boot/dts/exynos5422-odroidxu3-lite.dts
+++ b/arch/arm/boot/dts/exynos5422-odroidxu3-lite.dts
@@ -113,13 +113,13 @@ &usbhost2 {
 	#size-cells = <0>;
 
 	hub@1 {
-		compatible = "usb0424,9514";
+		compatible = "usb424,9514";
 		reg = <1>;
 		#address-cells = <1>;
 		#size-cells = <0>;
 
 		ethernet: ethernet@1 {
-			compatible = "usb0424,ec00";
+			compatible = "usb424,ec00";
 			reg = <1>;
 			local-mac-address = [00 00 00 00 00 00]; /* Filled in by a bootloader */
 		};
diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
index 8cf3d644a4c1..a378d4937ff7 100644
--- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
+++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
@@ -80,13 +80,13 @@ &usbhost2 {
 	#size-cells = <0>;
 
 	hub@1 {
-		compatible = "usb0424,9514";
+		compatible = "usb424,9514";
 		reg = <1>;
 		#address-cells = <1>;
 		#size-cells = <0>;
 
 		ethernet: ethernet@1 {
-			compatible = "usb0424,ec00";
+			compatible = "usb424,ec00";
 			reg = <1>;
 			local-mac-address = [00 00 00 00 00 00]; /* Filled in by a bootloader */
 		};
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 46+ messages in thread

* [PATCH v5 6/9] ARM: dts: exynos: fix compatible strings for Ethernet USB devices
@ 2022-02-16  7:49   ` Oleksij Rempel
  0 siblings, 0 replies; 46+ messages in thread
From: Oleksij Rempel @ 2022-02-16  7:49 UTC (permalink / raw)
  To: Benoît Cousson, David S. Miller, Florian Fainelli,
	Jakub Kicinski, Krzysztof Kozlowski, Nicolas Saenz Julienne,
	Ray Jui, Rob Herring, Sascha Hauer, Scott Branden, Shawn Guo,
	Tony Lindgren
  Cc: Oleksij Rempel, kernel, bcm-kernel-feedback-list, netdev,
	devicetree, linux-kernel, linux-usb, linux-rpi-kernel,
	linux-arm-kernel, linux-samsung-soc, linux-omap, linux-tegra

Fix compatible string for Ethernet USB device as required by USB device schema:
 Documentation/devicetree/bindings/usb/usb-device.yaml
  The textual representation of VID and PID shall be in lower case hexadecimal
  with leading zeroes suppressed.

Since there are no kernel driver matching against this compatibles, I
expect no regressions with this patch. At the same time, without this fix, we
are not be able to validate this device nodes with newly provided DT
schema.

Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
 arch/arm/boot/dts/exynos4412-odroidu3.dts       | 2 +-
 arch/arm/boot/dts/exynos4412-odroidx.dts        | 6 +++---
 arch/arm/boot/dts/exynos5410-odroidxu.dts       | 2 +-
 arch/arm/boot/dts/exynos5422-odroidxu3-lite.dts | 4 ++--
 arch/arm/boot/dts/exynos5422-odroidxu3.dts      | 4 ++--
 5 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/arch/arm/boot/dts/exynos4412-odroidu3.dts b/arch/arm/boot/dts/exynos4412-odroidu3.dts
index 5ddbb6cbe1bf..36c369c42b77 100644
--- a/arch/arm/boot/dts/exynos4412-odroidu3.dts
+++ b/arch/arm/boot/dts/exynos4412-odroidu3.dts
@@ -120,7 +120,7 @@ &ehci {
 	phy-names = "hsic0", "hsic1";
 
 	ethernet: ethernet@2 {
-		compatible = "usb0424,9730";
+		compatible = "usb424,9730";
 		reg = <2>;
 		local-mac-address = [00 00 00 00 00 00]; /* Filled in by a bootloader */
 	};
diff --git a/arch/arm/boot/dts/exynos4412-odroidx.dts b/arch/arm/boot/dts/exynos4412-odroidx.dts
index ea7bccec518d..ba46baf9117f 100644
--- a/arch/arm/boot/dts/exynos4412-odroidx.dts
+++ b/arch/arm/boot/dts/exynos4412-odroidx.dts
@@ -70,19 +70,19 @@ &ehci {
 	phy-names = "hsic0";
 
 	hub@2 {
-		compatible = "usb0424,3503";
+		compatible = "usb424,3503";
 		reg = <2>;
 		#address-cells = <1>;
 		#size-cells = <0>;
 
 		hub@1 {
-			compatible = "usb0424,9514";
+			compatible = "usb424,9514";
 			reg = <1>;
 			#address-cells = <1>;
 			#size-cells = <0>;
 
 			ethernet: ethernet@1 {
-				compatible = "usb0424,ec00";
+				compatible = "usb424,ec00";
 				reg = <1>;
 				/* Filled in by a bootloader */
 				local-mac-address = [00 00 00 00 00 00];
diff --git a/arch/arm/boot/dts/exynos5410-odroidxu.dts b/arch/arm/boot/dts/exynos5410-odroidxu.dts
index 38e23b4ae730..4c7039e771db 100644
--- a/arch/arm/boot/dts/exynos5410-odroidxu.dts
+++ b/arch/arm/boot/dts/exynos5410-odroidxu.dts
@@ -676,7 +676,7 @@ &usbhost2 {
 	#size-cells = <0>;
 
 	ethernet: ethernet@2 {
-		compatible = "usb0424,9730";
+		compatible = "usb424,9730";
 		reg = <2>;
 		local-mac-address = [00 00 00 00 00 00]; /* Filled in by a bootloader */
 	};
diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-lite.dts b/arch/arm/boot/dts/exynos5422-odroidxu3-lite.dts
index 749f051ffe70..e3154a1cae23 100644
--- a/arch/arm/boot/dts/exynos5422-odroidxu3-lite.dts
+++ b/arch/arm/boot/dts/exynos5422-odroidxu3-lite.dts
@@ -113,13 +113,13 @@ &usbhost2 {
 	#size-cells = <0>;
 
 	hub@1 {
-		compatible = "usb0424,9514";
+		compatible = "usb424,9514";
 		reg = <1>;
 		#address-cells = <1>;
 		#size-cells = <0>;
 
 		ethernet: ethernet@1 {
-			compatible = "usb0424,ec00";
+			compatible = "usb424,ec00";
 			reg = <1>;
 			local-mac-address = [00 00 00 00 00 00]; /* Filled in by a bootloader */
 		};
diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
index 8cf3d644a4c1..a378d4937ff7 100644
--- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
+++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
@@ -80,13 +80,13 @@ &usbhost2 {
 	#size-cells = <0>;
 
 	hub@1 {
-		compatible = "usb0424,9514";
+		compatible = "usb424,9514";
 		reg = <1>;
 		#address-cells = <1>;
 		#size-cells = <0>;
 
 		ethernet: ethernet@1 {
-			compatible = "usb0424,ec00";
+			compatible = "usb424,ec00";
 			reg = <1>;
 			local-mac-address = [00 00 00 00 00 00]; /* Filled in by a bootloader */
 		};
-- 
2.30.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 46+ messages in thread

* [PATCH v5 7/9] ARM: dts: omap3/4/5: fix ethernet node name for different OMAP boards
  2022-02-16  7:49 ` Oleksij Rempel
@ 2022-02-16  7:49   ` Oleksij Rempel
  -1 siblings, 0 replies; 46+ messages in thread
From: Oleksij Rempel @ 2022-02-16  7:49 UTC (permalink / raw)
  To: Benoît Cousson, David S. Miller, Florian Fainelli,
	Jakub Kicinski, Krzysztof Kozlowski, Nicolas Saenz Julienne,
	Ray Jui, Rob Herring, Sascha Hauer, Scott Branden, Shawn Guo,
	Tony Lindgren
  Cc: Oleksij Rempel, kernel, bcm-kernel-feedback-list, netdev,
	devicetree, linux-kernel, linux-usb, linux-rpi-kernel,
	linux-arm-kernel, linux-samsung-soc, linux-omap, linux-tegra

The node name of Ethernet controller should be "ethernet" instead of
"usbether" as required by Ethernet controller devicetree schema:
 Documentation/devicetree/bindings/net/ethernet-controller.yaml

This patch can potentially affect boot loaders patching against full
node path instead of using device aliases.

Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
 arch/arm/boot/dts/omap3-beagle-xm.dts     | 2 +-
 arch/arm/boot/dts/omap4-panda-common.dtsi | 2 +-
 arch/arm/boot/dts/omap5-igep0050.dts      | 2 +-
 arch/arm/boot/dts/omap5-uevm.dts          | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm/boot/dts/omap3-beagle-xm.dts b/arch/arm/boot/dts/omap3-beagle-xm.dts
index a858ebfa1500..35eced6521ef 100644
--- a/arch/arm/boot/dts/omap3-beagle-xm.dts
+++ b/arch/arm/boot/dts/omap3-beagle-xm.dts
@@ -370,7 +370,7 @@ hub@2 {
 		#address-cells = <1>;
 		#size-cells = <0>;
 
-		ethernet: usbether@1 {
+		ethernet: ethernet@1 {
 			compatible = "usb424,ec00";
 			reg = <1>;
 		};
diff --git a/arch/arm/boot/dts/omap4-panda-common.dtsi b/arch/arm/boot/dts/omap4-panda-common.dtsi
index 609a8dea946b..518652a599bd 100644
--- a/arch/arm/boot/dts/omap4-panda-common.dtsi
+++ b/arch/arm/boot/dts/omap4-panda-common.dtsi
@@ -558,7 +558,7 @@ hub@1 {
 		#address-cells = <1>;
 		#size-cells = <0>;
 
-		ethernet: usbether@1 {
+		ethernet: ethernet@1 {
 			compatible = "usb424,ec00";
 			reg = <1>;
 		};
diff --git a/arch/arm/boot/dts/omap5-igep0050.dts b/arch/arm/boot/dts/omap5-igep0050.dts
index 76e499d89d24..3851120857d7 100644
--- a/arch/arm/boot/dts/omap5-igep0050.dts
+++ b/arch/arm/boot/dts/omap5-igep0050.dts
@@ -128,7 +128,7 @@ hub@2 {
 		#address-cells = <1>;
 		#size-cells = <0>;
 
-		ethernet: usbether@3 {
+		ethernet: ethernet@3 {
 			compatible = "usb424,7500";
 			reg = <3>;
 		};
diff --git a/arch/arm/boot/dts/omap5-uevm.dts b/arch/arm/boot/dts/omap5-uevm.dts
index 51d5fcae5081..453da9f18a99 100644
--- a/arch/arm/boot/dts/omap5-uevm.dts
+++ b/arch/arm/boot/dts/omap5-uevm.dts
@@ -209,7 +209,7 @@ hub@2 {
 		#size-cells = <0>;
 	};
 
-	ethernet: usbether@3 {
+	ethernet: ethernet@3 {
 		compatible = "usb424,9730";
 		reg = <3>;
 	};
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 46+ messages in thread

* [PATCH v5 7/9] ARM: dts: omap3/4/5: fix ethernet node name for different OMAP boards
@ 2022-02-16  7:49   ` Oleksij Rempel
  0 siblings, 0 replies; 46+ messages in thread
From: Oleksij Rempel @ 2022-02-16  7:49 UTC (permalink / raw)
  To: Benoît Cousson, David S. Miller, Florian Fainelli,
	Jakub Kicinski, Krzysztof Kozlowski, Nicolas Saenz Julienne,
	Ray Jui, Rob Herring, Sascha Hauer, Scott Branden, Shawn Guo,
	Tony Lindgren
  Cc: Oleksij Rempel, kernel, bcm-kernel-feedback-list, netdev,
	devicetree, linux-kernel, linux-usb, linux-rpi-kernel,
	linux-arm-kernel, linux-samsung-soc, linux-omap, linux-tegra

The node name of Ethernet controller should be "ethernet" instead of
"usbether" as required by Ethernet controller devicetree schema:
 Documentation/devicetree/bindings/net/ethernet-controller.yaml

This patch can potentially affect boot loaders patching against full
node path instead of using device aliases.

Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
 arch/arm/boot/dts/omap3-beagle-xm.dts     | 2 +-
 arch/arm/boot/dts/omap4-panda-common.dtsi | 2 +-
 arch/arm/boot/dts/omap5-igep0050.dts      | 2 +-
 arch/arm/boot/dts/omap5-uevm.dts          | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm/boot/dts/omap3-beagle-xm.dts b/arch/arm/boot/dts/omap3-beagle-xm.dts
index a858ebfa1500..35eced6521ef 100644
--- a/arch/arm/boot/dts/omap3-beagle-xm.dts
+++ b/arch/arm/boot/dts/omap3-beagle-xm.dts
@@ -370,7 +370,7 @@ hub@2 {
 		#address-cells = <1>;
 		#size-cells = <0>;
 
-		ethernet: usbether@1 {
+		ethernet: ethernet@1 {
 			compatible = "usb424,ec00";
 			reg = <1>;
 		};
diff --git a/arch/arm/boot/dts/omap4-panda-common.dtsi b/arch/arm/boot/dts/omap4-panda-common.dtsi
index 609a8dea946b..518652a599bd 100644
--- a/arch/arm/boot/dts/omap4-panda-common.dtsi
+++ b/arch/arm/boot/dts/omap4-panda-common.dtsi
@@ -558,7 +558,7 @@ hub@1 {
 		#address-cells = <1>;
 		#size-cells = <0>;
 
-		ethernet: usbether@1 {
+		ethernet: ethernet@1 {
 			compatible = "usb424,ec00";
 			reg = <1>;
 		};
diff --git a/arch/arm/boot/dts/omap5-igep0050.dts b/arch/arm/boot/dts/omap5-igep0050.dts
index 76e499d89d24..3851120857d7 100644
--- a/arch/arm/boot/dts/omap5-igep0050.dts
+++ b/arch/arm/boot/dts/omap5-igep0050.dts
@@ -128,7 +128,7 @@ hub@2 {
 		#address-cells = <1>;
 		#size-cells = <0>;
 
-		ethernet: usbether@3 {
+		ethernet: ethernet@3 {
 			compatible = "usb424,7500";
 			reg = <3>;
 		};
diff --git a/arch/arm/boot/dts/omap5-uevm.dts b/arch/arm/boot/dts/omap5-uevm.dts
index 51d5fcae5081..453da9f18a99 100644
--- a/arch/arm/boot/dts/omap5-uevm.dts
+++ b/arch/arm/boot/dts/omap5-uevm.dts
@@ -209,7 +209,7 @@ hub@2 {
 		#size-cells = <0>;
 	};
 
-	ethernet: usbether@3 {
+	ethernet: ethernet@3 {
 		compatible = "usb424,9730";
 		reg = <3>;
 	};
-- 
2.30.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 46+ messages in thread

* [PATCH v5 8/9] ARM: dts: tegra20/30: fix ethernet node name for different tegra boards
  2022-02-16  7:49 ` Oleksij Rempel
@ 2022-02-16  7:49   ` Oleksij Rempel
  -1 siblings, 0 replies; 46+ messages in thread
From: Oleksij Rempel @ 2022-02-16  7:49 UTC (permalink / raw)
  To: Benoît Cousson, David S. Miller, Florian Fainelli,
	Jakub Kicinski, Krzysztof Kozlowski, Nicolas Saenz Julienne,
	Ray Jui, Rob Herring, Sascha Hauer, Scott Branden, Shawn Guo,
	Tony Lindgren
  Cc: Oleksij Rempel, kernel, bcm-kernel-feedback-list, netdev,
	devicetree, linux-kernel, linux-usb, linux-rpi-kernel,
	linux-arm-kernel, linux-samsung-soc, linux-omap, linux-tegra

The node name of Ethernet controller should be "ethernet" instead of
"asix" or "smsc" as required by Ethernet controller devicetree schema:
 Documentation/devicetree/bindings/net/ethernet-controller.yaml

This patch can potentially affect boot loaders patching against full
node path instead of using device aliases.

Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
 arch/arm/boot/dts/tegra20-colibri.dtsi | 2 +-
 arch/arm/boot/dts/tegra30-colibri.dtsi | 2 +-
 arch/arm/boot/dts/tegra30-ouya.dts     | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/boot/dts/tegra20-colibri.dtsi b/arch/arm/boot/dts/tegra20-colibri.dtsi
index 1eefb9ee4ac8..8ebd8afc857d 100644
--- a/arch/arm/boot/dts/tegra20-colibri.dtsi
+++ b/arch/arm/boot/dts/tegra20-colibri.dtsi
@@ -691,7 +691,7 @@ usb@c5004000 {
 		#address-cells = <1>;
 		#size-cells = <0>;
 
-		asix@1 {
+		ethernet@1 {
 			compatible = "usbb95,772b";
 			reg = <1>;
 			local-mac-address = [00 00 00 00 00 00];
diff --git a/arch/arm/boot/dts/tegra30-colibri.dtsi b/arch/arm/boot/dts/tegra30-colibri.dtsi
index be691a1c33a1..22231d450b1b 100644
--- a/arch/arm/boot/dts/tegra30-colibri.dtsi
+++ b/arch/arm/boot/dts/tegra30-colibri.dtsi
@@ -960,7 +960,7 @@ usb@7d004000 {
 		#address-cells = <1>;
 		#size-cells = <0>;
 
-		asix@1 {
+		ethernet@1 {
 			compatible = "usbb95,772b";
 			reg = <1>;
 			local-mac-address = [00 00 00 00 00 00];
diff --git a/arch/arm/boot/dts/tegra30-ouya.dts b/arch/arm/boot/dts/tegra30-ouya.dts
index a5cfbab5f565..e58dda4f9d2c 100644
--- a/arch/arm/boot/dts/tegra30-ouya.dts
+++ b/arch/arm/boot/dts/tegra30-ouya.dts
@@ -4553,7 +4553,7 @@ usb@7d004000 {
 		#address-cells = <1>;
 		#size-cells = <0>;
 
-		smsc@2 { /* SMSC 10/100T Ethernet Controller */
+		ethernet@2 { /* SMSC 10/100T Ethernet Controller */
 			compatible = "usb424,9e00";
 			reg = <2>;
 			local-mac-address = [00 11 22 33 44 55];
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 46+ messages in thread

* [PATCH v5 8/9] ARM: dts: tegra20/30: fix ethernet node name for different tegra boards
@ 2022-02-16  7:49   ` Oleksij Rempel
  0 siblings, 0 replies; 46+ messages in thread
From: Oleksij Rempel @ 2022-02-16  7:49 UTC (permalink / raw)
  To: Benoît Cousson, David S. Miller, Florian Fainelli,
	Jakub Kicinski, Krzysztof Kozlowski, Nicolas Saenz Julienne,
	Ray Jui, Rob Herring, Sascha Hauer, Scott Branden, Shawn Guo,
	Tony Lindgren
  Cc: Oleksij Rempel, kernel, bcm-kernel-feedback-list, netdev,
	devicetree, linux-kernel, linux-usb, linux-rpi-kernel,
	linux-arm-kernel, linux-samsung-soc, linux-omap, linux-tegra

The node name of Ethernet controller should be "ethernet" instead of
"asix" or "smsc" as required by Ethernet controller devicetree schema:
 Documentation/devicetree/bindings/net/ethernet-controller.yaml

This patch can potentially affect boot loaders patching against full
node path instead of using device aliases.

Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
 arch/arm/boot/dts/tegra20-colibri.dtsi | 2 +-
 arch/arm/boot/dts/tegra30-colibri.dtsi | 2 +-
 arch/arm/boot/dts/tegra30-ouya.dts     | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/boot/dts/tegra20-colibri.dtsi b/arch/arm/boot/dts/tegra20-colibri.dtsi
index 1eefb9ee4ac8..8ebd8afc857d 100644
--- a/arch/arm/boot/dts/tegra20-colibri.dtsi
+++ b/arch/arm/boot/dts/tegra20-colibri.dtsi
@@ -691,7 +691,7 @@ usb@c5004000 {
 		#address-cells = <1>;
 		#size-cells = <0>;
 
-		asix@1 {
+		ethernet@1 {
 			compatible = "usbb95,772b";
 			reg = <1>;
 			local-mac-address = [00 00 00 00 00 00];
diff --git a/arch/arm/boot/dts/tegra30-colibri.dtsi b/arch/arm/boot/dts/tegra30-colibri.dtsi
index be691a1c33a1..22231d450b1b 100644
--- a/arch/arm/boot/dts/tegra30-colibri.dtsi
+++ b/arch/arm/boot/dts/tegra30-colibri.dtsi
@@ -960,7 +960,7 @@ usb@7d004000 {
 		#address-cells = <1>;
 		#size-cells = <0>;
 
-		asix@1 {
+		ethernet@1 {
 			compatible = "usbb95,772b";
 			reg = <1>;
 			local-mac-address = [00 00 00 00 00 00];
diff --git a/arch/arm/boot/dts/tegra30-ouya.dts b/arch/arm/boot/dts/tegra30-ouya.dts
index a5cfbab5f565..e58dda4f9d2c 100644
--- a/arch/arm/boot/dts/tegra30-ouya.dts
+++ b/arch/arm/boot/dts/tegra30-ouya.dts
@@ -4553,7 +4553,7 @@ usb@7d004000 {
 		#address-cells = <1>;
 		#size-cells = <0>;
 
-		smsc@2 { /* SMSC 10/100T Ethernet Controller */
+		ethernet@2 { /* SMSC 10/100T Ethernet Controller */
 			compatible = "usb424,9e00";
 			reg = <2>;
 			local-mac-address = [00 11 22 33 44 55];
-- 
2.30.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 46+ messages in thread

* [PATCH v5 9/9] arm64: dts: imx8mm-kontron: fix ethernet node name
  2022-02-16  7:49 ` Oleksij Rempel
@ 2022-02-16  7:49   ` Oleksij Rempel
  -1 siblings, 0 replies; 46+ messages in thread
From: Oleksij Rempel @ 2022-02-16  7:49 UTC (permalink / raw)
  To: Benoît Cousson, David S. Miller, Florian Fainelli,
	Jakub Kicinski, Krzysztof Kozlowski, Nicolas Saenz Julienne,
	Ray Jui, Rob Herring, Sascha Hauer, Scott Branden, Shawn Guo,
	Tony Lindgren
  Cc: Oleksij Rempel, kernel, bcm-kernel-feedback-list, netdev,
	devicetree, linux-kernel, linux-usb, linux-rpi-kernel,
	linux-arm-kernel, linux-samsung-soc, linux-omap, linux-tegra

The node name of Ethernet controller should be "ethernet" instead of
"usbether" as required by Ethernet controller devicetree schema:
 Documentation/devicetree/bindings/net/ethernet-controller.yaml

This patch can potentially affect boot loaders patching against full
node path instead of using device aliases.

Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
 arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts
index d40caf14ac4a..23be1ec538ba 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts
@@ -182,7 +182,7 @@ usb1@1 {
 		#address-cells = <1>;
 		#size-cells = <0>;
 
-		usbnet: usbether@1 {
+		usbnet: ethernet@1 {
 			compatible = "usb424,ec00";
 			reg = <1>;
 			local-mac-address = [ 00 00 00 00 00 00 ];
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 46+ messages in thread

* [PATCH v5 9/9] arm64: dts: imx8mm-kontron: fix ethernet node name
@ 2022-02-16  7:49   ` Oleksij Rempel
  0 siblings, 0 replies; 46+ messages in thread
From: Oleksij Rempel @ 2022-02-16  7:49 UTC (permalink / raw)
  To: Benoît Cousson, David S. Miller, Florian Fainelli,
	Jakub Kicinski, Krzysztof Kozlowski, Nicolas Saenz Julienne,
	Ray Jui, Rob Herring, Sascha Hauer, Scott Branden, Shawn Guo,
	Tony Lindgren
  Cc: Oleksij Rempel, kernel, bcm-kernel-feedback-list, netdev,
	devicetree, linux-kernel, linux-usb, linux-rpi-kernel,
	linux-arm-kernel, linux-samsung-soc, linux-omap, linux-tegra

The node name of Ethernet controller should be "ethernet" instead of
"usbether" as required by Ethernet controller devicetree schema:
 Documentation/devicetree/bindings/net/ethernet-controller.yaml

This patch can potentially affect boot loaders patching against full
node path instead of using device aliases.

Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
 arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts
index d40caf14ac4a..23be1ec538ba 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts
@@ -182,7 +182,7 @@ usb1@1 {
 		#address-cells = <1>;
 		#size-cells = <0>;
 
-		usbnet: usbether@1 {
+		usbnet: ethernet@1 {
 			compatible = "usb424,ec00";
 			reg = <1>;
 			local-mac-address = [ 00 00 00 00 00 00 ];
-- 
2.30.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 46+ messages in thread

* Re: [PATCH v5 1/9] dt-bindings: net: add schema for ASIX USB Ethernet controllers
  2022-02-16  7:49   ` Oleksij Rempel
@ 2022-02-24 17:13     ` Rob Herring
  -1 siblings, 0 replies; 46+ messages in thread
From: Rob Herring @ 2022-02-24 17:13 UTC (permalink / raw)
  To: Oleksij Rempel
  Cc: Rob Herring, linux-arm-kernel, linux-omap, Ray Jui,
	linux-rpi-kernel, Scott Branden, Shawn Guo,
	Nicolas Saenz Julienne, David S. Miller, kernel, linux-tegra,
	Tony Lindgren, Jakub Kicinski, devicetree,
	bcm-kernel-feedback-list, linux-usb, linux-kernel,
	Benoît Cousson, linux-samsung-soc, Sascha Hauer,
	Florian Fainelli, Krzysztof Kozlowski, netdev

On Wed, 16 Feb 2022 08:49:19 +0100, Oleksij Rempel wrote:
> Create schema for ASIX USB Ethernet controllers and import some of
> currently supported USB IDs form drivers/net/usb/asix_devices.c
> 
> These devices are already used in some of DTs. So, this schema makes it official.
> NOTE: there was no previously documented txt based DT binding for this
> controllers.
> 
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
>  .../devicetree/bindings/net/asix,ax88178.yaml | 68 +++++++++++++++++++
>  1 file changed, 68 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/net/asix,ax88178.yaml
> 

Reviewed-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: [PATCH v5 1/9] dt-bindings: net: add schema for ASIX USB Ethernet controllers
@ 2022-02-24 17:13     ` Rob Herring
  0 siblings, 0 replies; 46+ messages in thread
From: Rob Herring @ 2022-02-24 17:13 UTC (permalink / raw)
  To: Oleksij Rempel
  Cc: Rob Herring, linux-arm-kernel, linux-omap, Ray Jui,
	linux-rpi-kernel, Scott Branden, Shawn Guo,
	Nicolas Saenz Julienne, David S. Miller, kernel, linux-tegra,
	Tony Lindgren, Jakub Kicinski, devicetree,
	bcm-kernel-feedback-list, linux-usb, linux-kernel,
	Benoît Cousson, linux-samsung-soc, Sascha Hauer,
	Florian Fainelli, Krzysztof Kozlowski, netdev

On Wed, 16 Feb 2022 08:49:19 +0100, Oleksij Rempel wrote:
> Create schema for ASIX USB Ethernet controllers and import some of
> currently supported USB IDs form drivers/net/usb/asix_devices.c
> 
> These devices are already used in some of DTs. So, this schema makes it official.
> NOTE: there was no previously documented txt based DT binding for this
> controllers.
> 
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
>  .../devicetree/bindings/net/asix,ax88178.yaml | 68 +++++++++++++++++++
>  1 file changed, 68 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/net/asix,ax88178.yaml
> 

Reviewed-by: Rob Herring <robh@kernel.org>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: [PATCH v5 2/9] dt-bindings: net: add schema for Microchip/SMSC LAN95xx USB Ethernet controllers
  2022-02-16  7:49   ` Oleksij Rempel
@ 2022-02-24 17:18     ` Rob Herring
  -1 siblings, 0 replies; 46+ messages in thread
From: Rob Herring @ 2022-02-24 17:18 UTC (permalink / raw)
  To: Oleksij Rempel
  Cc: Benoît Cousson, David S. Miller, Florian Fainelli,
	Jakub Kicinski, Krzysztof Kozlowski, Nicolas Saenz Julienne,
	Ray Jui, Sascha Hauer, Scott Branden, Shawn Guo, Tony Lindgren,
	kernel, bcm-kernel-feedback-list, netdev, devicetree,
	linux-kernel, linux-usb, linux-rpi-kernel, linux-arm-kernel,
	linux-samsung-soc, linux-omap, linux-tegra

On Wed, Feb 16, 2022 at 08:49:20AM +0100, Oleksij Rempel wrote:
> Create initial schema for Microchip/SMSC LAN95xx USB Ethernet controllers and
> import some of currently supported USB IDs form drivers/net/usb/smsc95xx.c
> 
> These devices are already used in some of DTs. So, this schema makes it official.
> NOTE: there was no previously documented txt based DT binding for this
> controllers.
> 
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
>  .../bindings/net/microchip,lan95xx.yaml       | 80 +++++++++++++++++++
>  1 file changed, 80 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/net/microchip,lan95xx.yaml
> 
> diff --git a/Documentation/devicetree/bindings/net/microchip,lan95xx.yaml b/Documentation/devicetree/bindings/net/microchip,lan95xx.yaml
> new file mode 100644
> index 000000000000..8521c65366b4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/microchip,lan95xx.yaml
> @@ -0,0 +1,80 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/microchip,lan95xx.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: The device tree bindings for the USB Ethernet controllers
> +
> +maintainers:
> +  - Oleksij Rempel <o.rempel@pengutronix.de>
> +
> +description: |
> +  Device tree properties for hard wired SMSC95xx compatible USB Ethernet
> +  controller.
> +
> +allOf:
> +  - $ref: ethernet-controller.yaml#
> +
> +properties:
> +  compatible:
> +    items:
> +      - enum:
> +          - usb424,9500   # SMSC9500 USB Ethernet Device
> +          - usb424,9505   # SMSC9505 USB Ethernet Device
> +          - usb424,9530   # SMSC LAN9530 USB Ethernet Device
> +          - usb424,9730   # SMSC LAN9730 USB Ethernet Device
> +          - usb424,9900   # SMSC9500 USB Ethernet Device (SAL10)
> +          - usb424,9901   # SMSC9505 USB Ethernet Device (SAL10)
> +          - usb424,9902   # SMSC9500A USB Ethernet Device (SAL10)
> +          - usb424,9903   # SMSC9505A USB Ethernet Device (SAL10)
> +          - usb424,9904   # SMSC9512/9514 USB Hub & Ethernet Device (SAL10)
> +          - usb424,9905   # SMSC9500A USB Ethernet Device (HAL)
> +          - usb424,9906   # SMSC9505A USB Ethernet Device (HAL)
> +          - usb424,9907   # SMSC9500 USB Ethernet Device (Alternate ID)
> +          - usb424,9908   # SMSC9500A USB Ethernet Device (Alternate ID)
> +          - usb424,9909   # SMSC9512/9514 USB Hub & Ethernet Devic.  ID)
> +          - usb424,9e00   # SMSC9500A USB Ethernet Device
> +          - usb424,9e01   # SMSC9505A USB Ethernet Device
> +          - usb424,9e08   # SMSC LAN89530 USB Ethernet Device
> +          - usb424,ec00   # SMSC9512/9514 USB Hub & Ethernet Device
> +
> +  reg: true
> +  local-mac-address: true
> +  mac-address: true
> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    usb {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        ethernet@1 {
> +            compatible = "usb424,ec00";

If this is a hub/ethernet combo device, how is it valid to be standalone 
without the hub?

> +            reg = <1>;
> +            local-mac-address = [00 00 00 00 00 00];
> +        };
> +    };
> +  - |
> +    usb {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        usb1@1 {
> +            compatible = "usb424,9514";

Not documented.

> +            reg = <1>;
> +            #address-cells = <1>;
> +            #size-cells = <0>;
> +
> +            ethernet@1 {
> +               compatible = "usb424,ec00";
> +               reg = <1>;
> +            };
> +        };
> +    };
> -- 
> 2.30.2
> 
> 

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: [PATCH v5 2/9] dt-bindings: net: add schema for Microchip/SMSC LAN95xx USB Ethernet controllers
@ 2022-02-24 17:18     ` Rob Herring
  0 siblings, 0 replies; 46+ messages in thread
From: Rob Herring @ 2022-02-24 17:18 UTC (permalink / raw)
  To: Oleksij Rempel
  Cc: Benoît Cousson, David S. Miller, Florian Fainelli,
	Jakub Kicinski, Krzysztof Kozlowski, Nicolas Saenz Julienne,
	Ray Jui, Sascha Hauer, Scott Branden, Shawn Guo, Tony Lindgren,
	kernel, bcm-kernel-feedback-list, netdev, devicetree,
	linux-kernel, linux-usb, linux-rpi-kernel, linux-arm-kernel,
	linux-samsung-soc, linux-omap, linux-tegra

On Wed, Feb 16, 2022 at 08:49:20AM +0100, Oleksij Rempel wrote:
> Create initial schema for Microchip/SMSC LAN95xx USB Ethernet controllers and
> import some of currently supported USB IDs form drivers/net/usb/smsc95xx.c
> 
> These devices are already used in some of DTs. So, this schema makes it official.
> NOTE: there was no previously documented txt based DT binding for this
> controllers.
> 
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
>  .../bindings/net/microchip,lan95xx.yaml       | 80 +++++++++++++++++++
>  1 file changed, 80 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/net/microchip,lan95xx.yaml
> 
> diff --git a/Documentation/devicetree/bindings/net/microchip,lan95xx.yaml b/Documentation/devicetree/bindings/net/microchip,lan95xx.yaml
> new file mode 100644
> index 000000000000..8521c65366b4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/microchip,lan95xx.yaml
> @@ -0,0 +1,80 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/microchip,lan95xx.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: The device tree bindings for the USB Ethernet controllers
> +
> +maintainers:
> +  - Oleksij Rempel <o.rempel@pengutronix.de>
> +
> +description: |
> +  Device tree properties for hard wired SMSC95xx compatible USB Ethernet
> +  controller.
> +
> +allOf:
> +  - $ref: ethernet-controller.yaml#
> +
> +properties:
> +  compatible:
> +    items:
> +      - enum:
> +          - usb424,9500   # SMSC9500 USB Ethernet Device
> +          - usb424,9505   # SMSC9505 USB Ethernet Device
> +          - usb424,9530   # SMSC LAN9530 USB Ethernet Device
> +          - usb424,9730   # SMSC LAN9730 USB Ethernet Device
> +          - usb424,9900   # SMSC9500 USB Ethernet Device (SAL10)
> +          - usb424,9901   # SMSC9505 USB Ethernet Device (SAL10)
> +          - usb424,9902   # SMSC9500A USB Ethernet Device (SAL10)
> +          - usb424,9903   # SMSC9505A USB Ethernet Device (SAL10)
> +          - usb424,9904   # SMSC9512/9514 USB Hub & Ethernet Device (SAL10)
> +          - usb424,9905   # SMSC9500A USB Ethernet Device (HAL)
> +          - usb424,9906   # SMSC9505A USB Ethernet Device (HAL)
> +          - usb424,9907   # SMSC9500 USB Ethernet Device (Alternate ID)
> +          - usb424,9908   # SMSC9500A USB Ethernet Device (Alternate ID)
> +          - usb424,9909   # SMSC9512/9514 USB Hub & Ethernet Devic.  ID)
> +          - usb424,9e00   # SMSC9500A USB Ethernet Device
> +          - usb424,9e01   # SMSC9505A USB Ethernet Device
> +          - usb424,9e08   # SMSC LAN89530 USB Ethernet Device
> +          - usb424,ec00   # SMSC9512/9514 USB Hub & Ethernet Device
> +
> +  reg: true
> +  local-mac-address: true
> +  mac-address: true
> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    usb {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        ethernet@1 {
> +            compatible = "usb424,ec00";

If this is a hub/ethernet combo device, how is it valid to be standalone 
without the hub?

> +            reg = <1>;
> +            local-mac-address = [00 00 00 00 00 00];
> +        };
> +    };
> +  - |
> +    usb {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        usb1@1 {
> +            compatible = "usb424,9514";

Not documented.

> +            reg = <1>;
> +            #address-cells = <1>;
> +            #size-cells = <0>;
> +
> +            ethernet@1 {
> +               compatible = "usb424,ec00";
> +               reg = <1>;
> +            };
> +        };
> +    };
> -- 
> 2.30.2
> 
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: [PATCH v5 3/9] dt-bindings: usb: ci-hdrc-usb2: fix node node for ethernet controller
  2022-02-16  7:49   ` Oleksij Rempel
@ 2022-02-24 17:19     ` Rob Herring
  -1 siblings, 0 replies; 46+ messages in thread
From: Rob Herring @ 2022-02-24 17:19 UTC (permalink / raw)
  To: Oleksij Rempel
  Cc: Ray Jui, linux-kernel, Nicolas Saenz Julienne, Florian Fainelli,
	Sascha Hauer, Jakub Kicinski, linux-arm-kernel, kernel,
	David S. Miller, linux-rpi-kernel, netdev, Scott Branden,
	Rob Herring, Benoît Cousson, linux-tegra, devicetree,
	Tony Lindgren, linux-omap, linux-samsung-soc, Shawn Guo,
	Krzysztof Kozlowski, bcm-kernel-feedback-list, linux-usb

On Wed, 16 Feb 2022 08:49:21 +0100, Oleksij Rempel wrote:
> This documentation provides wrong node name for the Ethernet controller.
> It should be "ethernet" instead of "smsc" as required by Ethernet
> controller devicetree schema:
>  Documentation/devicetree/bindings/net/ethernet-controller.yaml
> 
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
>  Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Acked-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: [PATCH v5 3/9] dt-bindings: usb: ci-hdrc-usb2: fix node node for ethernet controller
@ 2022-02-24 17:19     ` Rob Herring
  0 siblings, 0 replies; 46+ messages in thread
From: Rob Herring @ 2022-02-24 17:19 UTC (permalink / raw)
  To: Oleksij Rempel
  Cc: Ray Jui, linux-kernel, Nicolas Saenz Julienne, Florian Fainelli,
	Sascha Hauer, Jakub Kicinski, linux-arm-kernel, kernel,
	David S. Miller, linux-rpi-kernel, netdev, Scott Branden,
	Rob Herring, Benoît Cousson, linux-tegra, devicetree,
	Tony Lindgren, linux-omap, linux-samsung-soc, Shawn Guo,
	Krzysztof Kozlowski, bcm-kernel-feedback-list, linux-usb

On Wed, 16 Feb 2022 08:49:21 +0100, Oleksij Rempel wrote:
> This documentation provides wrong node name for the Ethernet controller.
> It should be "ethernet" instead of "smsc" as required by Ethernet
> controller devicetree schema:
>  Documentation/devicetree/bindings/net/ethernet-controller.yaml
> 
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
>  Documentation/devicetree/bindings/usb/ci-hdrc-usb2.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Acked-by: Rob Herring <robh@kernel.org>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: [PATCH v5 2/9] dt-bindings: net: add schema for Microchip/SMSC LAN95xx USB Ethernet controllers
  2022-02-24 17:18     ` Rob Herring
@ 2022-02-25  8:40       ` Oleksij Rempel
  -1 siblings, 0 replies; 46+ messages in thread
From: Oleksij Rempel @ 2022-02-25  8:40 UTC (permalink / raw)
  To: Rob Herring
  Cc: Benoît Cousson, David S. Miller, Florian Fainelli,
	Jakub Kicinski, Krzysztof Kozlowski, Nicolas Saenz Julienne,
	Ray Jui, Sascha Hauer, Scott Branden, Shawn Guo, Tony Lindgren,
	kernel, bcm-kernel-feedback-list, netdev, devicetree,
	linux-kernel, linux-usb, linux-rpi-kernel, linux-arm-kernel,
	linux-samsung-soc, linux-omap, linux-tegra

On Thu, Feb 24, 2022 at 11:18:30AM -0600, Rob Herring wrote:
> On Wed, Feb 16, 2022 at 08:49:20AM +0100, Oleksij Rempel wrote:
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    usb {
> > +        #address-cells = <1>;
> > +        #size-cells = <0>;
> > +
> > +        ethernet@1 {
> > +            compatible = "usb424,ec00";
> 
> If this is a hub/ethernet combo device, how is it valid to be standalone 
> without the hub?

What is the best way to describe two type of devices: with and without
hub in package? Have two different schema to keep things simple?

Regards,
Oleksij
-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: [PATCH v5 2/9] dt-bindings: net: add schema for Microchip/SMSC LAN95xx USB Ethernet controllers
@ 2022-02-25  8:40       ` Oleksij Rempel
  0 siblings, 0 replies; 46+ messages in thread
From: Oleksij Rempel @ 2022-02-25  8:40 UTC (permalink / raw)
  To: Rob Herring
  Cc: Benoît Cousson, David S. Miller, Florian Fainelli,
	Jakub Kicinski, Krzysztof Kozlowski, Nicolas Saenz Julienne,
	Ray Jui, Sascha Hauer, Scott Branden, Shawn Guo, Tony Lindgren,
	kernel, bcm-kernel-feedback-list, netdev, devicetree,
	linux-kernel, linux-usb, linux-rpi-kernel, linux-arm-kernel,
	linux-samsung-soc, linux-omap, linux-tegra

On Thu, Feb 24, 2022 at 11:18:30AM -0600, Rob Herring wrote:
> On Wed, Feb 16, 2022 at 08:49:20AM +0100, Oleksij Rempel wrote:
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    usb {
> > +        #address-cells = <1>;
> > +        #size-cells = <0>;
> > +
> > +        ethernet@1 {
> > +            compatible = "usb424,ec00";
> 
> If this is a hub/ethernet combo device, how is it valid to be standalone 
> without the hub?

What is the best way to describe two type of devices: with and without
hub in package? Have two different schema to keep things simple?

Regards,
Oleksij
-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: [PATCH v5 5/9] ARM: dts: exynos: fix ethernet node name for different odroid boards
  2022-02-16  7:49   ` Oleksij Rempel
@ 2022-03-08 11:02     ` Krzysztof Kozlowski
  -1 siblings, 0 replies; 46+ messages in thread
From: Krzysztof Kozlowski @ 2022-03-08 11:02 UTC (permalink / raw)
  To: Oleksij Rempel, Benoît Cousson, David S. Miller,
	Florian Fainelli, Jakub Kicinski, Nicolas Saenz Julienne,
	Ray Jui, Rob Herring, Sascha Hauer, Scott Branden, Shawn Guo,
	Tony Lindgren
  Cc: kernel, bcm-kernel-feedback-list, netdev, devicetree,
	linux-kernel, linux-usb, linux-rpi-kernel, linux-arm-kernel,
	linux-samsung-soc, linux-omap, linux-tegra

On 16/02/2022 08:49, Oleksij Rempel wrote:
> The node name of Ethernet controller should be "ethernet" instead of
> "usbether" as required by Ethernet controller devicetree schema:
>  Documentation/devicetree/bindings/net/ethernet-controller.yaml
> 
> This patch can potentially affect boot loaders patching against full
> node path instead of using device aliases.
> 
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
>  arch/arm/boot/dts/exynos4412-odroidu3.dts       | 2 +-
>  arch/arm/boot/dts/exynos4412-odroidx.dts        | 2 +-
>  arch/arm/boot/dts/exynos5410-odroidxu.dts       | 2 +-
>  arch/arm/boot/dts/exynos5422-odroidxu3-lite.dts | 2 +-
>  arch/arm/boot/dts/exynos5422-odroidxu3.dts      | 2 +-
>  5 files changed, 5 insertions(+), 5 deletions(-)
> 

Hi Oleksij,

Both Exynos patches look good, unfortunately I forgot about them a week
ago when I was preparing late pull request and now it is too late for
this cycle. I will pick them up after the merge window. Sorry, for this.

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: [PATCH v5 5/9] ARM: dts: exynos: fix ethernet node name for different odroid boards
@ 2022-03-08 11:02     ` Krzysztof Kozlowski
  0 siblings, 0 replies; 46+ messages in thread
From: Krzysztof Kozlowski @ 2022-03-08 11:02 UTC (permalink / raw)
  To: Oleksij Rempel, Benoît Cousson, David S. Miller,
	Florian Fainelli, Jakub Kicinski, Nicolas Saenz Julienne,
	Ray Jui, Rob Herring, Sascha Hauer, Scott Branden, Shawn Guo,
	Tony Lindgren
  Cc: kernel, bcm-kernel-feedback-list, netdev, devicetree,
	linux-kernel, linux-usb, linux-rpi-kernel, linux-arm-kernel,
	linux-samsung-soc, linux-omap, linux-tegra

On 16/02/2022 08:49, Oleksij Rempel wrote:
> The node name of Ethernet controller should be "ethernet" instead of
> "usbether" as required by Ethernet controller devicetree schema:
>  Documentation/devicetree/bindings/net/ethernet-controller.yaml
> 
> This patch can potentially affect boot loaders patching against full
> node path instead of using device aliases.
> 
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
>  arch/arm/boot/dts/exynos4412-odroidu3.dts       | 2 +-
>  arch/arm/boot/dts/exynos4412-odroidx.dts        | 2 +-
>  arch/arm/boot/dts/exynos5410-odroidxu.dts       | 2 +-
>  arch/arm/boot/dts/exynos5422-odroidxu3-lite.dts | 2 +-
>  arch/arm/boot/dts/exynos5422-odroidxu3.dts      | 2 +-
>  5 files changed, 5 insertions(+), 5 deletions(-)
> 

Hi Oleksij,

Both Exynos patches look good, unfortunately I forgot about them a week
ago when I was preparing late pull request and now it is too late for
this cycle. I will pick them up after the merge window. Sorry, for this.

Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: [PATCH v5 5/9] ARM: dts: exynos: fix ethernet node name for different odroid boards
  2022-03-08 11:02     ` Krzysztof Kozlowski
@ 2022-03-08 11:15       ` Oleksij Rempel
  -1 siblings, 0 replies; 46+ messages in thread
From: Oleksij Rempel @ 2022-03-08 11:15 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Benoît Cousson, David S. Miller, Florian Fainelli,
	Jakub Kicinski, Nicolas Saenz Julienne, Ray Jui, Rob Herring,
	Sascha Hauer, Scott Branden, Shawn Guo, Tony Lindgren, kernel,
	bcm-kernel-feedback-list, netdev, devicetree, linux-kernel,
	linux-usb, linux-rpi-kernel, linux-arm-kernel, linux-samsung-soc,
	linux-omap, linux-tegra

On Tue, Mar 08, 2022 at 12:02:29PM +0100, Krzysztof Kozlowski wrote:
> On 16/02/2022 08:49, Oleksij Rempel wrote:
> > The node name of Ethernet controller should be "ethernet" instead of
> > "usbether" as required by Ethernet controller devicetree schema:
> >  Documentation/devicetree/bindings/net/ethernet-controller.yaml
> > 
> > This patch can potentially affect boot loaders patching against full
> > node path instead of using device aliases.
> > 
> > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> > ---
> >  arch/arm/boot/dts/exynos4412-odroidu3.dts       | 2 +-
> >  arch/arm/boot/dts/exynos4412-odroidx.dts        | 2 +-
> >  arch/arm/boot/dts/exynos5410-odroidxu.dts       | 2 +-
> >  arch/arm/boot/dts/exynos5422-odroidxu3-lite.dts | 2 +-
> >  arch/arm/boot/dts/exynos5422-odroidxu3.dts      | 2 +-
> >  5 files changed, 5 insertions(+), 5 deletions(-)
> > 
> 
> Hi Oleksij,
> 
> Both Exynos patches look good, unfortunately I forgot about them a week
> ago when I was preparing late pull request and now it is too late for
> this cycle. I will pick them up after the merge window. Sorry, for this.

No problem. Thank you for the feedback :)

Regards,
Oleksij
-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: [PATCH v5 5/9] ARM: dts: exynos: fix ethernet node name for different odroid boards
@ 2022-03-08 11:15       ` Oleksij Rempel
  0 siblings, 0 replies; 46+ messages in thread
From: Oleksij Rempel @ 2022-03-08 11:15 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Benoît Cousson, David S. Miller, Florian Fainelli,
	Jakub Kicinski, Nicolas Saenz Julienne, Ray Jui, Rob Herring,
	Sascha Hauer, Scott Branden, Shawn Guo, Tony Lindgren, kernel,
	bcm-kernel-feedback-list, netdev, devicetree, linux-kernel,
	linux-usb, linux-rpi-kernel, linux-arm-kernel, linux-samsung-soc,
	linux-omap, linux-tegra

On Tue, Mar 08, 2022 at 12:02:29PM +0100, Krzysztof Kozlowski wrote:
> On 16/02/2022 08:49, Oleksij Rempel wrote:
> > The node name of Ethernet controller should be "ethernet" instead of
> > "usbether" as required by Ethernet controller devicetree schema:
> >  Documentation/devicetree/bindings/net/ethernet-controller.yaml
> > 
> > This patch can potentially affect boot loaders patching against full
> > node path instead of using device aliases.
> > 
> > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> > ---
> >  arch/arm/boot/dts/exynos4412-odroidu3.dts       | 2 +-
> >  arch/arm/boot/dts/exynos4412-odroidx.dts        | 2 +-
> >  arch/arm/boot/dts/exynos5410-odroidxu.dts       | 2 +-
> >  arch/arm/boot/dts/exynos5422-odroidxu3-lite.dts | 2 +-
> >  arch/arm/boot/dts/exynos5422-odroidxu3.dts      | 2 +-
> >  5 files changed, 5 insertions(+), 5 deletions(-)
> > 
> 
> Hi Oleksij,
> 
> Both Exynos patches look good, unfortunately I forgot about them a week
> ago when I was preparing late pull request and now it is too late for
> this cycle. I will pick them up after the merge window. Sorry, for this.

No problem. Thank you for the feedback :)

Regards,
Oleksij
-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: (subset) [PATCH v5 5/9] ARM: dts: exynos: fix ethernet node name for different odroid boards
  2022-02-16  7:49   ` Oleksij Rempel
@ 2022-04-04 16:40     ` Krzysztof Kozlowski
  -1 siblings, 0 replies; 46+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-04 16:40 UTC (permalink / raw)
  To: Sascha Hauer, Rob Herring, Ray Jui, Krzysztof Kozlowski,
	Oleksij Rempel, Nicolas Saenz Julienne, David S. Miller,
	Jakub Kicinski, Shawn Guo, Benoît Cousson, Florian Fainelli,
	Tony Lindgren, Scott Branden
  Cc: Krzysztof Kozlowski, linux-samsung-soc, linux-tegra,
	bcm-kernel-feedback-list, devicetree, kernel, linux-omap,
	linux-arm-kernel, netdev, linux-kernel, linux-usb,
	linux-rpi-kernel

On Wed, 16 Feb 2022 08:49:23 +0100, Oleksij Rempel wrote:
> The node name of Ethernet controller should be "ethernet" instead of
> "usbether" as required by Ethernet controller devicetree schema:
>  Documentation/devicetree/bindings/net/ethernet-controller.yaml
> 
> This patch can potentially affect boot loaders patching against full
> node path instead of using device aliases.
> 
> [...]

Applied, thanks!

[5/9] ARM: dts: exynos: fix ethernet node name for different odroid boards
      commit: c1ed0f41032f54e47c03088f096f8b37cae40d8e

Best regards,
-- 
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: (subset) [PATCH v5 5/9] ARM: dts: exynos: fix ethernet node name for different odroid boards
@ 2022-04-04 16:40     ` Krzysztof Kozlowski
  0 siblings, 0 replies; 46+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-04 16:40 UTC (permalink / raw)
  To: Sascha Hauer, Rob Herring, Ray Jui, Krzysztof Kozlowski,
	Oleksij Rempel, Nicolas Saenz Julienne, David S. Miller,
	Jakub Kicinski, Shawn Guo, Benoît Cousson, Florian Fainelli,
	Tony Lindgren, Scott Branden
  Cc: Krzysztof Kozlowski, linux-samsung-soc, linux-tegra,
	bcm-kernel-feedback-list, devicetree, kernel, linux-omap,
	linux-arm-kernel, netdev, linux-kernel, linux-usb,
	linux-rpi-kernel

On Wed, 16 Feb 2022 08:49:23 +0100, Oleksij Rempel wrote:
> The node name of Ethernet controller should be "ethernet" instead of
> "usbether" as required by Ethernet controller devicetree schema:
>  Documentation/devicetree/bindings/net/ethernet-controller.yaml
> 
> This patch can potentially affect boot loaders patching against full
> node path instead of using device aliases.
> 
> [...]

Applied, thanks!

[5/9] ARM: dts: exynos: fix ethernet node name for different odroid boards
      commit: c1ed0f41032f54e47c03088f096f8b37cae40d8e

Best regards,
-- 
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: (subset) [PATCH v5 6/9] ARM: dts: exynos: fix compatible strings for Ethernet USB devices
  2022-02-16  7:49   ` Oleksij Rempel
@ 2022-04-04 16:40     ` Krzysztof Kozlowski
  -1 siblings, 0 replies; 46+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-04 16:40 UTC (permalink / raw)
  To: Sascha Hauer, Rob Herring, Ray Jui, Krzysztof Kozlowski,
	Oleksij Rempel, Nicolas Saenz Julienne, David S. Miller,
	Jakub Kicinski, Shawn Guo, Benoît Cousson, Florian Fainelli,
	Tony Lindgren, Scott Branden
  Cc: Krzysztof Kozlowski, linux-samsung-soc, linux-tegra,
	bcm-kernel-feedback-list, devicetree, kernel, linux-omap,
	linux-arm-kernel, netdev, linux-kernel, linux-usb,
	linux-rpi-kernel

On Wed, 16 Feb 2022 08:49:24 +0100, Oleksij Rempel wrote:
> Fix compatible string for Ethernet USB device as required by USB device schema:
>  Documentation/devicetree/bindings/usb/usb-device.yaml
>   The textual representation of VID and PID shall be in lower case hexadecimal
>   with leading zeroes suppressed.
> 
> Since there are no kernel driver matching against this compatibles, I
> expect no regressions with this patch. At the same time, without this fix, we
> are not be able to validate this device nodes with newly provided DT
> schema.
> 
> [...]

Applied, thanks!

[6/9] ARM: dts: exynos: fix compatible strings for Ethernet USB devices
      commit: 2e33a7b5fdb3930a9b1051bc792dbdc6a7490aae

Best regards,
-- 
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: (subset) [PATCH v5 6/9] ARM: dts: exynos: fix compatible strings for Ethernet USB devices
@ 2022-04-04 16:40     ` Krzysztof Kozlowski
  0 siblings, 0 replies; 46+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-04 16:40 UTC (permalink / raw)
  To: Sascha Hauer, Rob Herring, Ray Jui, Krzysztof Kozlowski,
	Oleksij Rempel, Nicolas Saenz Julienne, David S. Miller,
	Jakub Kicinski, Shawn Guo, Benoît Cousson, Florian Fainelli,
	Tony Lindgren, Scott Branden
  Cc: Krzysztof Kozlowski, linux-samsung-soc, linux-tegra,
	bcm-kernel-feedback-list, devicetree, kernel, linux-omap,
	linux-arm-kernel, netdev, linux-kernel, linux-usb,
	linux-rpi-kernel

On Wed, 16 Feb 2022 08:49:24 +0100, Oleksij Rempel wrote:
> Fix compatible string for Ethernet USB device as required by USB device schema:
>  Documentation/devicetree/bindings/usb/usb-device.yaml
>   The textual representation of VID and PID shall be in lower case hexadecimal
>   with leading zeroes suppressed.
> 
> Since there are no kernel driver matching against this compatibles, I
> expect no regressions with this patch. At the same time, without this fix, we
> are not be able to validate this device nodes with newly provided DT
> schema.
> 
> [...]

Applied, thanks!

[6/9] ARM: dts: exynos: fix compatible strings for Ethernet USB devices
      commit: 2e33a7b5fdb3930a9b1051bc792dbdc6a7490aae

Best regards,
-- 
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: [PATCH v5 4/9] ARM: dts: bcm283x: fix ethernet node name
  2022-02-16  7:49   ` Oleksij Rempel
@ 2022-04-04 16:44     ` Florian Fainelli
  -1 siblings, 0 replies; 46+ messages in thread
From: Florian Fainelli @ 2022-04-04 16:44 UTC (permalink / raw)
  To: bcm-kernel-feedback-list, Oleksij Rempel, Benoît Cousson,
	David S. Miller, Jakub Kicinski, Krzysztof Kozlowski,
	Nicolas Saenz Julienne, Ray Jui, Rob Herring, Sascha Hauer,
	Scott Branden, Shawn Guo, Tony Lindgren
  Cc: kernel, netdev, devicetree, linux-kernel, linux-usb,
	linux-rpi-kernel, linux-arm-kernel, linux-samsung-soc,
	linux-omap, linux-tegra

On Wed, 16 Feb 2022 08:49:22 +0100, Oleksij Rempel <o.rempel@pengutronix.de> wrote:
> It should be "ethernet@x" instead of "usbether@x" as required by Ethernet
> controller devicetree schema:
>  Documentation/devicetree/bindings/net/ethernet-controller.yaml
> 
> This patch can potentially affect boot loaders patching against full
> node path instead of using device aliases.
> 
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---

Applied to https://github.com/Broadcom/stblinux/commits/devicetree/next, thanks!
--
Florian

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: [PATCH v5 4/9] ARM: dts: bcm283x: fix ethernet node name
@ 2022-04-04 16:44     ` Florian Fainelli
  0 siblings, 0 replies; 46+ messages in thread
From: Florian Fainelli @ 2022-04-04 16:44 UTC (permalink / raw)
  To: bcm-kernel-feedback-list, Oleksij Rempel, Benoît Cousson,
	David S. Miller, Jakub Kicinski, Krzysztof Kozlowski,
	Nicolas Saenz Julienne, Ray Jui, Rob Herring, Sascha Hauer,
	Scott Branden, Shawn Guo, Tony Lindgren
  Cc: kernel, netdev, devicetree, linux-kernel, linux-usb,
	linux-rpi-kernel, linux-arm-kernel, linux-samsung-soc,
	linux-omap, linux-tegra

On Wed, 16 Feb 2022 08:49:22 +0100, Oleksij Rempel <o.rempel@pengutronix.de> wrote:
> It should be "ethernet@x" instead of "usbether@x" as required by Ethernet
> controller devicetree schema:
>  Documentation/devicetree/bindings/net/ethernet-controller.yaml
> 
> This patch can potentially affect boot loaders patching against full
> node path instead of using device aliases.
> 
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---

Applied to https://github.com/Broadcom/stblinux/commits/devicetree/next, thanks!
--
Florian

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: [PATCH v5 9/9] arm64: dts: imx8mm-kontron: fix ethernet node name
  2022-02-16  7:49   ` Oleksij Rempel
@ 2022-04-06  1:13     ` Shawn Guo
  -1 siblings, 0 replies; 46+ messages in thread
From: Shawn Guo @ 2022-04-06  1:13 UTC (permalink / raw)
  To: Oleksij Rempel, Frieder Schrempf
  Cc: Benoît Cousson, David S. Miller, Florian Fainelli,
	Jakub Kicinski, Krzysztof Kozlowski, Nicolas Saenz Julienne,
	Ray Jui, Rob Herring, Sascha Hauer, Scott Branden, Tony Lindgren,
	kernel, bcm-kernel-feedback-list, netdev, devicetree,
	linux-kernel, linux-usb, linux-rpi-kernel, linux-arm-kernel,
	linux-samsung-soc, linux-omap, linux-tegra

+ Frieder Schrempf who is the board owner.

On Wed, Feb 16, 2022 at 08:49:27AM +0100, Oleksij Rempel wrote:
> The node name of Ethernet controller should be "ethernet" instead of
> "usbether" as required by Ethernet controller devicetree schema:
>  Documentation/devicetree/bindings/net/ethernet-controller.yaml
> 
> This patch can potentially affect boot loaders patching against full
> node path instead of using device aliases.

Frieder,

Are you okay with that?

Shawn

> 
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
>  arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts
> index d40caf14ac4a..23be1ec538ba 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts
> @@ -182,7 +182,7 @@ usb1@1 {
>  		#address-cells = <1>;
>  		#size-cells = <0>;
>  
> -		usbnet: usbether@1 {
> +		usbnet: ethernet@1 {
>  			compatible = "usb424,ec00";
>  			reg = <1>;
>  			local-mac-address = [ 00 00 00 00 00 00 ];
> -- 
> 2.30.2
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: [PATCH v5 9/9] arm64: dts: imx8mm-kontron: fix ethernet node name
@ 2022-04-06  1:13     ` Shawn Guo
  0 siblings, 0 replies; 46+ messages in thread
From: Shawn Guo @ 2022-04-06  1:13 UTC (permalink / raw)
  To: Oleksij Rempel, Frieder Schrempf
  Cc: Benoît Cousson, David S. Miller, Florian Fainelli,
	Jakub Kicinski, Krzysztof Kozlowski, Nicolas Saenz Julienne,
	Ray Jui, Rob Herring, Sascha Hauer, Scott Branden, Tony Lindgren,
	kernel, bcm-kernel-feedback-list, netdev, devicetree,
	linux-kernel, linux-usb, linux-rpi-kernel, linux-arm-kernel,
	linux-samsung-soc, linux-omap, linux-tegra

+ Frieder Schrempf who is the board owner.

On Wed, Feb 16, 2022 at 08:49:27AM +0100, Oleksij Rempel wrote:
> The node name of Ethernet controller should be "ethernet" instead of
> "usbether" as required by Ethernet controller devicetree schema:
>  Documentation/devicetree/bindings/net/ethernet-controller.yaml
> 
> This patch can potentially affect boot loaders patching against full
> node path instead of using device aliases.

Frieder,

Are you okay with that?

Shawn

> 
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
>  arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts
> index d40caf14ac4a..23be1ec538ba 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts
> @@ -182,7 +182,7 @@ usb1@1 {
>  		#address-cells = <1>;
>  		#size-cells = <0>;
>  
> -		usbnet: usbether@1 {
> +		usbnet: ethernet@1 {
>  			compatible = "usb424,ec00";
>  			reg = <1>;
>  			local-mac-address = [ 00 00 00 00 00 00 ];
> -- 
> 2.30.2
> 

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: [PATCH v5 9/9] arm64: dts: imx8mm-kontron: fix ethernet node name
  2022-04-06  1:13     ` Shawn Guo
@ 2022-04-06  7:11       ` Frieder Schrempf
  -1 siblings, 0 replies; 46+ messages in thread
From: Frieder Schrempf @ 2022-04-06  7:11 UTC (permalink / raw)
  To: Shawn Guo, Oleksij Rempel
  Cc: Benoît Cousson, David S. Miller, Florian Fainelli,
	Jakub Kicinski, Krzysztof Kozlowski, Nicolas Saenz Julienne,
	Ray Jui, Rob Herring, Sascha Hauer, Scott Branden, Tony Lindgren,
	kernel, bcm-kernel-feedback-list, netdev, devicetree,
	linux-kernel, linux-usb, linux-rpi-kernel, linux-arm-kernel,
	linux-samsung-soc, linux-omap, linux-tegra

Am 06.04.22 um 03:13 schrieb Shawn Guo:
> + Frieder Schrempf who is the board owner.
> 
> On Wed, Feb 16, 2022 at 08:49:27AM +0100, Oleksij Rempel wrote:
>> The node name of Ethernet controller should be "ethernet" instead of
>> "usbether" as required by Ethernet controller devicetree schema:
>>  Documentation/devicetree/bindings/net/ethernet-controller.yaml
>>
>> This patch can potentially affect boot loaders patching against full
>> node path instead of using device aliases.
> 
> Frieder,
> 
> Are you okay with that?

Yes!

> 
> Shawn
> 
>>
>> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>

Acked-by: Frieder Schrempf <frieder.schrempf@kontron.de>

>> ---
>>  arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts
>> index d40caf14ac4a..23be1ec538ba 100644
>> --- a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts
>> +++ b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts
>> @@ -182,7 +182,7 @@ usb1@1 {
>>  		#address-cells = <1>;
>>  		#size-cells = <0>;
>>  
>> -		usbnet: usbether@1 {
>> +		usbnet: ethernet@1 {
>>  			compatible = "usb424,ec00";
>>  			reg = <1>;
>>  			local-mac-address = [ 00 00 00 00 00 00 ];
>> -- 
>> 2.30.2
>>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: [PATCH v5 9/9] arm64: dts: imx8mm-kontron: fix ethernet node name
@ 2022-04-06  7:11       ` Frieder Schrempf
  0 siblings, 0 replies; 46+ messages in thread
From: Frieder Schrempf @ 2022-04-06  7:11 UTC (permalink / raw)
  To: Shawn Guo, Oleksij Rempel
  Cc: Benoît Cousson, David S. Miller, Florian Fainelli,
	Jakub Kicinski, Krzysztof Kozlowski, Nicolas Saenz Julienne,
	Ray Jui, Rob Herring, Sascha Hauer, Scott Branden, Tony Lindgren,
	kernel, bcm-kernel-feedback-list, netdev, devicetree,
	linux-kernel, linux-usb, linux-rpi-kernel, linux-arm-kernel,
	linux-samsung-soc, linux-omap, linux-tegra

Am 06.04.22 um 03:13 schrieb Shawn Guo:
> + Frieder Schrempf who is the board owner.
> 
> On Wed, Feb 16, 2022 at 08:49:27AM +0100, Oleksij Rempel wrote:
>> The node name of Ethernet controller should be "ethernet" instead of
>> "usbether" as required by Ethernet controller devicetree schema:
>>  Documentation/devicetree/bindings/net/ethernet-controller.yaml
>>
>> This patch can potentially affect boot loaders patching against full
>> node path instead of using device aliases.
> 
> Frieder,
> 
> Are you okay with that?

Yes!

> 
> Shawn
> 
>>
>> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>

Acked-by: Frieder Schrempf <frieder.schrempf@kontron.de>

>> ---
>>  arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts
>> index d40caf14ac4a..23be1ec538ba 100644
>> --- a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts
>> +++ b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-s.dts
>> @@ -182,7 +182,7 @@ usb1@1 {
>>  		#address-cells = <1>;
>>  		#size-cells = <0>;
>>  
>> -		usbnet: usbether@1 {
>> +		usbnet: ethernet@1 {
>>  			compatible = "usb424,ec00";
>>  			reg = <1>;
>>  			local-mac-address = [ 00 00 00 00 00 00 ];
>> -- 
>> 2.30.2
>>

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: [PATCH v5 9/9] arm64: dts: imx8mm-kontron: fix ethernet node name
  2022-02-16  7:49   ` Oleksij Rempel
@ 2022-04-06 12:51     ` Shawn Guo
  -1 siblings, 0 replies; 46+ messages in thread
From: Shawn Guo @ 2022-04-06 12:51 UTC (permalink / raw)
  To: Oleksij Rempel
  Cc: Benoît Cousson, David S. Miller, Florian Fainelli,
	Jakub Kicinski, Krzysztof Kozlowski, Nicolas Saenz Julienne,
	Ray Jui, Rob Herring, Sascha Hauer, Scott Branden, Tony Lindgren,
	kernel, bcm-kernel-feedback-list, netdev, devicetree,
	linux-kernel, linux-usb, linux-rpi-kernel, linux-arm-kernel,
	linux-samsung-soc, linux-omap, linux-tegra

On Wed, Feb 16, 2022 at 08:49:27AM +0100, Oleksij Rempel wrote:
> The node name of Ethernet controller should be "ethernet" instead of
> "usbether" as required by Ethernet controller devicetree schema:
>  Documentation/devicetree/bindings/net/ethernet-controller.yaml
> 
> This patch can potentially affect boot loaders patching against full
> node path instead of using device aliases.
> 
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>

Applied, thanks!

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: [PATCH v5 9/9] arm64: dts: imx8mm-kontron: fix ethernet node name
@ 2022-04-06 12:51     ` Shawn Guo
  0 siblings, 0 replies; 46+ messages in thread
From: Shawn Guo @ 2022-04-06 12:51 UTC (permalink / raw)
  To: Oleksij Rempel
  Cc: Benoît Cousson, David S. Miller, Florian Fainelli,
	Jakub Kicinski, Krzysztof Kozlowski, Nicolas Saenz Julienne,
	Ray Jui, Rob Herring, Sascha Hauer, Scott Branden, Tony Lindgren,
	kernel, bcm-kernel-feedback-list, netdev, devicetree,
	linux-kernel, linux-usb, linux-rpi-kernel, linux-arm-kernel,
	linux-samsung-soc, linux-omap, linux-tegra

On Wed, Feb 16, 2022 at 08:49:27AM +0100, Oleksij Rempel wrote:
> The node name of Ethernet controller should be "ethernet" instead of
> "usbether" as required by Ethernet controller devicetree schema:
>  Documentation/devicetree/bindings/net/ethernet-controller.yaml
> 
> This patch can potentially affect boot loaders patching against full
> node path instead of using device aliases.
> 
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>

Applied, thanks!

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: [PATCH v5 7/9] ARM: dts: omap3/4/5: fix ethernet node name for different OMAP boards
  2022-02-16  7:49   ` Oleksij Rempel
@ 2022-04-21 10:47     ` Tony Lindgren
  -1 siblings, 0 replies; 46+ messages in thread
From: Tony Lindgren @ 2022-04-21 10:47 UTC (permalink / raw)
  To: Oleksij Rempel
  Cc: Benoît Cousson, David S. Miller, Florian Fainelli,
	Jakub Kicinski, Krzysztof Kozlowski, Nicolas Saenz Julienne,
	Ray Jui, Rob Herring, Sascha Hauer, Scott Branden, Shawn Guo,
	kernel, bcm-kernel-feedback-list, netdev, devicetree,
	linux-kernel, linux-usb, linux-rpi-kernel, linux-arm-kernel,
	linux-samsung-soc, linux-omap, linux-tegra

* Oleksij Rempel <o.rempel@pengutronix.de> [220216 09:49]:
> The node name of Ethernet controller should be "ethernet" instead of
> "usbether" as required by Ethernet controller devicetree schema:
>  Documentation/devicetree/bindings/net/ethernet-controller.yaml
> 
> This patch can potentially affect boot loaders patching against full
> node path instead of using device aliases.

Picking up this patch into omap-for-v5.19/dt branch.

Thanks,

Tony

^ permalink raw reply	[flat|nested] 46+ messages in thread

* Re: [PATCH v5 7/9] ARM: dts: omap3/4/5: fix ethernet node name for different OMAP boards
@ 2022-04-21 10:47     ` Tony Lindgren
  0 siblings, 0 replies; 46+ messages in thread
From: Tony Lindgren @ 2022-04-21 10:47 UTC (permalink / raw)
  To: Oleksij Rempel
  Cc: Benoît Cousson, David S. Miller, Florian Fainelli,
	Jakub Kicinski, Krzysztof Kozlowski, Nicolas Saenz Julienne,
	Ray Jui, Rob Herring, Sascha Hauer, Scott Branden, Shawn Guo,
	kernel, bcm-kernel-feedback-list, netdev, devicetree,
	linux-kernel, linux-usb, linux-rpi-kernel, linux-arm-kernel,
	linux-samsung-soc, linux-omap, linux-tegra

* Oleksij Rempel <o.rempel@pengutronix.de> [220216 09:49]:
> The node name of Ethernet controller should be "ethernet" instead of
> "usbether" as required by Ethernet controller devicetree schema:
>  Documentation/devicetree/bindings/net/ethernet-controller.yaml
> 
> This patch can potentially affect boot loaders patching against full
> node path instead of using device aliases.

Picking up this patch into omap-for-v5.19/dt branch.

Thanks,

Tony

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 46+ messages in thread

end of thread, other threads:[~2022-04-21 10:48 UTC | newest]

Thread overview: 46+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-16  7:49 [PATCH v5 0/8] document dt-schema and fix node names for some USB Ethernet controllers Oleksij Rempel
2022-02-16  7:49 ` Oleksij Rempel
2022-02-16  7:49 ` [PATCH v5 1/9] dt-bindings: net: add schema for ASIX " Oleksij Rempel
2022-02-16  7:49   ` Oleksij Rempel
2022-02-24 17:13   ` Rob Herring
2022-02-24 17:13     ` Rob Herring
2022-02-16  7:49 ` [PATCH v5 2/9] dt-bindings: net: add schema for Microchip/SMSC LAN95xx " Oleksij Rempel
2022-02-16  7:49   ` Oleksij Rempel
2022-02-24 17:18   ` Rob Herring
2022-02-24 17:18     ` Rob Herring
2022-02-25  8:40     ` Oleksij Rempel
2022-02-25  8:40       ` Oleksij Rempel
2022-02-16  7:49 ` [PATCH v5 3/9] dt-bindings: usb: ci-hdrc-usb2: fix node node for ethernet controller Oleksij Rempel
2022-02-16  7:49   ` Oleksij Rempel
2022-02-24 17:19   ` Rob Herring
2022-02-24 17:19     ` Rob Herring
2022-02-16  7:49 ` [PATCH v5 4/9] ARM: dts: bcm283x: fix ethernet node name Oleksij Rempel
2022-02-16  7:49   ` Oleksij Rempel
2022-04-04 16:44   ` Florian Fainelli
2022-04-04 16:44     ` Florian Fainelli
2022-02-16  7:49 ` [PATCH v5 5/9] ARM: dts: exynos: fix ethernet node name for different odroid boards Oleksij Rempel
2022-02-16  7:49   ` Oleksij Rempel
2022-03-08 11:02   ` Krzysztof Kozlowski
2022-03-08 11:02     ` Krzysztof Kozlowski
2022-03-08 11:15     ` Oleksij Rempel
2022-03-08 11:15       ` Oleksij Rempel
2022-04-04 16:40   ` (subset) " Krzysztof Kozlowski
2022-04-04 16:40     ` Krzysztof Kozlowski
2022-02-16  7:49 ` [PATCH v5 6/9] ARM: dts: exynos: fix compatible strings for Ethernet USB devices Oleksij Rempel
2022-02-16  7:49   ` Oleksij Rempel
2022-04-04 16:40   ` (subset) " Krzysztof Kozlowski
2022-04-04 16:40     ` Krzysztof Kozlowski
2022-02-16  7:49 ` [PATCH v5 7/9] ARM: dts: omap3/4/5: fix ethernet node name for different OMAP boards Oleksij Rempel
2022-02-16  7:49   ` Oleksij Rempel
2022-04-21 10:47   ` Tony Lindgren
2022-04-21 10:47     ` Tony Lindgren
2022-02-16  7:49 ` [PATCH v5 8/9] ARM: dts: tegra20/30: fix ethernet node name for different tegra boards Oleksij Rempel
2022-02-16  7:49   ` Oleksij Rempel
2022-02-16  7:49 ` [PATCH v5 9/9] arm64: dts: imx8mm-kontron: fix ethernet node name Oleksij Rempel
2022-02-16  7:49   ` Oleksij Rempel
2022-04-06  1:13   ` Shawn Guo
2022-04-06  1:13     ` Shawn Guo
2022-04-06  7:11     ` Frieder Schrempf
2022-04-06  7:11       ` Frieder Schrempf
2022-04-06 12:51   ` Shawn Guo
2022-04-06 12:51     ` Shawn Guo

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.