From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2102EC433F5 for ; Thu, 17 Feb 2022 08:53:44 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 670B983A6A; Thu, 17 Feb 2022 09:53:42 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1645088022; bh=vu6qXJmYZz2hGyX8zZdS2DCR2Ip/Ry/wmc1DcZBs3v4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=NugYsp1v/mLQYEvu9Vzza0tGUYfXCyJIVf83tITBGaGWMpRSbWW89xrGmxra/ZZXy biKvKk8mkdCAfBIwu9IPWfb3exQtUWiipEqVDoxK0K5bU1M0IWY1KdbgH665Q4Gwdy OSuvogiLtjrY5FX+NkwgrbTRbaZeZ0a3FeA7ZjC9eSXRWOJsWlA8ta0uqP48mghPKm 2juM+Ql0aUFtZ3XuYpTuijrCs5GTVMtZeoqwMyqn4OfNEjZ5N5+k49gthd6yM1M20o ZQXnySrL+OD8S31fZ8Du9CawJTXK03egQisgY9MsCdJ/p4Ypt+EoTEMAQgKg8CQZuZ XrF8cQ7hLgIng== Received: from crub (p508b6e90.dip0.t-ipconnect.de [80.139.110.144]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: agust@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id B374683881; Thu, 17 Feb 2022 09:53:39 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1645088019; bh=vu6qXJmYZz2hGyX8zZdS2DCR2Ip/Ry/wmc1DcZBs3v4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=WqD9OHiK91QqocP74apjXNY8oS4qcEphEgVzo9d+iIk7HLj5wwIf3gmPpkbTlgUFX HYA8oz+c/0mi7LKSUV4ts/Kwj9gCzmPTKcHXB5QPImibubvWkbX8Aa08DkWdX94ZnB KdUrUNrqzMRSTQXYV5tLcNAvTsG3gkaGol/xfrSF99fU3qAO8pvUdkYp/t1Y1xF4et 9gWYTgQXl1h7BSD54pEcai2tMxjR6CS1wZRQoHrG1jPfcXA+XMOfDnNaFnzUbj+0bX hi0FU78L0NstrpeqGBo7NSPLHIcVz2O31uXzhoBmiGfIMu8CHK+TFtNElRnGgfpjME p8BLg/HLzmkQg== Date: Thu, 17 Feb 2022 09:53:39 +0100 From: Anatolij Gustschin To: Pali =?UTF-8?B?Um9ow6Fy?= Cc: Simon Glass , Tom Rini , u-boot@lists.denx.de Subject: Re: [PATCH] WIP: Nokia RX-51: Convert to CONFIG_DM_VIDEO Message-ID: <20220217095339.7d950fe3@crub> In-Reply-To: <20220216204219.18539-1-pali@kernel.org> References: <20220216204219.18539-1-pali@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Hi Pali, On Wed, 16 Feb 2022 21:42:19 +0100 Pali Roh=C3=A1r pali@kernel.org wrote: > --- > I had to comment "return -ENOSPC;" in video-uclass.c because without it > DM_VIDEO does not work and I do not know why. This looks like either > false-positive test or a bug in DM_VIDEO code. I have already set > PRE_RELOC flag but it has no effect on that code. Probably the frame buffer memory allocation did not work.=20 Could you please try with a bind callback, i.e.: static int rx51_video_bind(struct udevice *dev) { struct video_uc_plat *plat =3D dev_get_uclass_plat(dev); plat->size =3D 800 * 480 * 2; return 0; } ... U_BOOT_DRIVER(rx51_video) =3D { .name =3D "rx51_video", .id =3D UCLASS_VIDEO, .bind =3D rx51_video_bind, .probe =3D rx51_video_probe, .flags =3D DM_FLAG_PRE_RELOC, }; >=20 > Second thing is that CONFIG_VIDEO_LOGO is broken and does not work even it > is enabled in config file. I do not know why too. >=20 > Any idea? Not yet. There were some logo related changes recently, but if I remember correctly, I tested them on wandboard and nitrogen6q targets and with sandbox, and logo drawing worked there. -- Anatolij