From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 65CA2C433EF for ; Thu, 17 Feb 2022 12:20:56 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 87E898339D; Thu, 17 Feb 2022 13:20:53 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="tg82SUnZ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id DCE2B837B6; Thu, 17 Feb 2022 13:20:51 +0100 (CET) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C2C1483097 for ; Thu, 17 Feb 2022 13:20:47 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 476C061841; Thu, 17 Feb 2022 12:20:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8A2CEC340E8; Thu, 17 Feb 2022 12:20:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1645100445; bh=cQ38LZo+gK0YEtJlD6PAlWXeN4WITFkFvX9irq50B64=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tg82SUnZUOk3JjBJ0W8iSC4ghLqzhYu3tw88UUmbUGafsMw5ajY358Sf7BGr4PXb5 itL2NtIrJK7b75JXNrb31FsYsPiX9c4K1q6DDq5FDoAlzwjsVvmrZUiWUVsTstJ4s2 8vivWHH2Q+tAwAVIx1KndRQtJXCBr/PfGARqln1zOijQXz2A05Rsuw6D/c3lv7/i9L E/iALr8bTNRHB1z4LcoU3aEqJwrb8V8LpEzxF7UoBqXOeaEO/EeTeP/nTnTgBRRray pyPJwLnaD7x3XJdZVvAR8ROGfd7bT5Whe+mkZIJfdCz2ySx66HZBteNMNX2ge+OXmS BZM0+jZ1IH1Sg== Received: by pali.im (Postfix) id 277611187; Thu, 17 Feb 2022 13:20:43 +0100 (CET) Date: Thu, 17 Feb 2022 13:20:43 +0100 From: Pali =?utf-8?B?Um9ow6Fy?= To: Anatolij Gustschin Cc: Simon Glass , Tom Rini , u-boot@lists.denx.de Subject: Re: [PATCH] WIP: Nokia RX-51: Convert to CONFIG_DM_VIDEO Message-ID: <20220217122043.nhjd7o467pkcrnas@pali> References: <20220216204219.18539-1-pali@kernel.org> <20220217095339.7d950fe3@crub> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220217095339.7d950fe3@crub> User-Agent: NeoMutt/20180716 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On Thursday 17 February 2022 09:53:39 Anatolij Gustschin wrote: > Hi Pali, > > On Wed, 16 Feb 2022 21:42:19 +0100 > Pali Rohár pali@kernel.org wrote: > > > --- > > I had to comment "return -ENOSPC;" in video-uclass.c because without it > > DM_VIDEO does not work and I do not know why. This looks like either > > false-positive test or a bug in DM_VIDEO code. I have already set > > PRE_RELOC flag but it has no effect on that code. > > Probably the frame buffer memory allocation did not work. > Could you please try with a bind callback, i.e.: > > static int rx51_video_bind(struct udevice *dev) > { > struct video_uc_plat *plat = dev_get_uclass_plat(dev); > > plat->size = 800 * 480 * 2; > return 0; > } > ... > U_BOOT_DRIVER(rx51_video) = { > .name = "rx51_video", > .id = UCLASS_VIDEO, > .bind = rx51_video_bind, > .probe = rx51_video_probe, > .flags = DM_FLAG_PRE_RELOC, > }; Hello! It does not work too. Here is the output: U-Boot 2022.04-rc2-00002-ga2c1a9878375-dirty (Jan 01 1970 - 00:00:00 +0000) OMAP35XX-GP ES3.1, CPU-OPP2, L3-165MHz, Max CPU Clock 600 MHz DRAM: Video frame buffers from 8fe30000 to 8fe30000 256 MiB Video device 'rx51_video' cannot allocate frame buffer memory -ensure the device is set up before relocation If "return -ENOSPC;" is not commented then this is the last printed line. If it is commented then output continues with: video_post_bind: Claiming 130000 bytes at 8fd00000 for video device 'rx51_video' And framebuffer is working fine like without above rx51_video_bind() change. > > > > Second thing is that CONFIG_VIDEO_LOGO is broken and does not work even it > > is enabled in config file. I do not know why too. > > > > Any idea? > > Not yet. There were some logo related changes recently, but if I > remember correctly, I tested them on wandboard and nitrogen6q > targets and with sandbox, and logo drawing worked there. > > -- > Anatolij