From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1nL5jZ-0004ya-9W for mharc-grub-devel@gnu.org; Fri, 18 Feb 2022 11:03:49 -0500 Received: from eggs.gnu.org ([209.51.188.92]:33726) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nL5jW-0004v8-So for grub-devel@gnu.org; Fri, 18 Feb 2022 11:03:46 -0500 Received: from [2607:f8b0:4864:20::f2a] (port=47102 helo=mail-qv1-xf2a.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nL5jR-0001AF-KN for grub-devel@gnu.org; Fri, 18 Feb 2022 11:03:46 -0500 Received: by mail-qv1-xf2a.google.com with SMTP id n6so15544835qvk.13 for ; Fri, 18 Feb 2022 08:03:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficientek-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references:reply-to :mime-version:content-transfer-encoding; bh=Jz8bHMyvALPuoixMuT1WRmvXGnBOHWy5QIAQ6zRsBek=; b=v7K1lZXrFqnju0xRuQ00IDr0V8OikTR7y1YOCj/gOHpjnCfcTBmGBPGX3kkuIPaoYy LH33DpyMexZftBnUd70Rs1BIT/uizBsle7qmq3qKTHptkv9d8JAwtFYNdNu8g/y11OwT 5GWiumfFS3Yu3ymqDhWyplzKi2tNlOsHEQZCqGYjnW+nZBBvGi/QpR7ydCc9N4GNJwio gLw2mkUyyYTYqY2qIjvtGwF2uV4ZJGem3MdrPpPyDrW8gThs/bDBSI/JdfPEbJRcKs/q z7DnOleaxKw5sHLL0tMoelC1V8kQ4h2PFXRfh9bW1H20eyd8PXa0N77QI/YHmQ5e+EwR MmXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:reply-to:mime-version:content-transfer-encoding; bh=Jz8bHMyvALPuoixMuT1WRmvXGnBOHWy5QIAQ6zRsBek=; b=0iKcaFihcZrFvKn2jALcF3uivnDAnJrOrCVfRCV65PLFGhpXnt7mmGBMQAUzDb70KD BfL7oXzqVw+oTO8qxwyXt9ZyDumJUjdk7VrwbHOpk+rjlq24a1vaWZ2SGYlXeNTCdmJm jcTJXNOZ+3P3fLUfELznE/Mu3Mih5u/D/uWgRnJZ/l/UYtZ8Np6VV2kJeyJ9vv4AijQg /4p4JUIJIlZE0sP6NDt3b5sQmX4Q0XTmjazKYBbsBml3eYdUYBtCffjTLFNBWYnkohFW JqJX+tmk1fjlXLjw4Xj7BfuEADaco9pjE1dUgtbL1vso/L+d8EV9NWitn+lEMhBNo2ct GLBg== X-Gm-Message-State: AOAM530VqMwMsRDfe+aqJOpwkVGLXUYTLMDbvFVP8lXUZNyKfplEk/A+ u+V0kskkZZzWjEgrzZbbmxQHQ9zOw58+qQ== X-Google-Smtp-Source: ABdhPJy1fzv4CyY6OM48BiKY/8DnyqwbhxkQoIMdy0GqNtlqYnb0k/ZBfJ+f3nzNJ44rMSk24vapKw== X-Received: by 2002:ad4:5fce:0:b0:42d:fa10:6451 with SMTP id jq14-20020ad45fce000000b0042dfa106451mr6356209qvb.1.1645200220326; Fri, 18 Feb 2022 08:03:40 -0800 (PST) Received: from crass-HP-ZBook-15-G2 (garza.riseup.net. [198.252.153.109]) by smtp.gmail.com with ESMTPSA id t23sm4564128qtp.67.2022.02.18.08.03.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Feb 2022 08:03:40 -0800 (PST) Date: Fri, 18 Feb 2022 10:03:23 -0600 From: Glenn Washburn To: Robbie Harwood Cc: grub-devel@gnu.org, dkiper@net-space.pl Subject: Re: [PATCH v5 0/4] Update gnulib and drop some patches Message-ID: <20220218100323.66a3adf7@crass-HP-ZBook-15-G2> In-Reply-To: <20220216214142.555294-1-rharwood@redhat.com> References: <20220216214142.555294-1-rharwood@redhat.com> Reply-To: development@efficientek.com X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::f2a (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::f2a; envelope-from=development@efficientek.com; helo=mail-qv1-xf2a.google.com X-Spam_score_int: -4 X-Spam_score: -0.5 X-Spam_bar: / X-Spam_report: (-0.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Feb 2022 16:03:47 -0000 On Wed, 16 Feb 2022 16:41:38 -0500 Robbie Harwood wrote: > Changes in this version: > > - Include most _GL_* defines from gnulib. Hopefully we do not need all their > prereq logic as well, but I don't know what the compilers we support are, so > please correct that if needed. > > - Avoid creating empty #defines. > > - Fix issues with building gnulib's allocation modules observed by Glenn. The > tree now builds warning-free with default cflags for me. Minor nit, in the future it would be nice to have the info from --interdiff or --range-diff on follow-up patch series. This make its easier to see what changed from the previous series. I can confirm that this now successfully builds for me and is not causing new test failures. Tested-by: Glenn Washburn Glenn > > Be well, > --Robbie > > Robbie Harwood (4): > Use visual indentation in config.h.in > Drop gnulib fix-base64.patch > Drop gnulib no-abort.patch > Update gnulib version and drop most gnulib patches > > bootstrap | 319 ++++++++++-------- > bootstrap.conf | 21 +- > conf/Makefile.extra-dist | 8 - > config.h.in | 112 ++++-- > configure.ac | 2 +- > grub-core/Makefile.core.def | 1 + > grub-core/disk/luks2.c | 4 +- > grub-core/lib/gnulib-patches/fix-base64.patch | 21 -- > .../lib/gnulib-patches/fix-null-deref.patch | 13 - > .../gnulib-patches/fix-null-state-deref.patch | 12 - > .../fix-regcomp-uninit-token.patch | 15 - > .../fix-regexec-null-deref.patch | 12 - > .../gnulib-patches/fix-uninit-structure.patch | 11 - > .../lib/gnulib-patches/fix-unused-value.patch | 14 - > grub-core/lib/gnulib-patches/no-abort.patch | 26 -- > grub-core/lib/posix_wrap/limits.h | 6 +- > grub-core/lib/posix_wrap/sys/types.h | 7 +- > grub-core/lib/xzembed/xz.h | 5 +- > include/grub/compiler.h | 4 +- > include/grub/list.h | 2 +- > 20 files changed, 293 insertions(+), 322 deletions(-) > delete mode 100644 grub-core/lib/gnulib-patches/fix-base64.patch > delete mode 100644 grub-core/lib/gnulib-patches/fix-null-deref.patch > delete mode 100644 grub-core/lib/gnulib-patches/fix-null-state-deref.patch > delete mode 100644 grub-core/lib/gnulib-patches/fix-regcomp-uninit-token.patch > delete mode 100644 grub-core/lib/gnulib-patches/fix-regexec-null-deref.patch > delete mode 100644 grub-core/lib/gnulib-patches/fix-uninit-structure.patch > delete mode 100644 grub-core/lib/gnulib-patches/fix-unused-value.patch > delete mode 100644 grub-core/lib/gnulib-patches/no-abort.patch >