All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] mtd: rawnand: omap2: Actually prevent invalid configuration and build error
@ 2022-02-19 19:36 ` Roger Quadros
  0 siblings, 0 replies; 25+ messages in thread
From: Roger Quadros @ 2022-02-19 19:36 UTC (permalink / raw)
  To: miquel.raynal, krzysztof.kozlowski
  Cc: vigneshr, nm, linux, linux-mtd, linux-kernel, Roger Quadros

The root of the problem is that we are selecting symbols that have
dependencies. This can cause random configurations that can fail.
The cleanest solution is to avoid using select.

This driver uses interfaces from the OMAP_GPMC driver so we have to
depend on it instead.

Fixes: 4cd335dae3cf ("mtd: rawnand: omap2: Prevent invalid configuration and build error")
Signed-off-by: Roger Quadros <rogerq@kernel.org>
---
 drivers/mtd/nand/raw/Kconfig | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/mtd/nand/raw/Kconfig b/drivers/mtd/nand/raw/Kconfig
index 36e697456ec4..9b078e78f3fa 100644
--- a/drivers/mtd/nand/raw/Kconfig
+++ b/drivers/mtd/nand/raw/Kconfig
@@ -42,8 +42,7 @@ config MTD_NAND_OMAP2
 	tristate "OMAP2, OMAP3, OMAP4 and Keystone NAND controller"
 	depends on ARCH_OMAP2PLUS || ARCH_KEYSTONE || ARCH_K3 || COMPILE_TEST
 	depends on HAS_IOMEM
-	select MEMORY
-	select OMAP_GPMC
+	depends on OMAP_GPMC
 	help
 	  Support for NAND flash on Texas Instruments OMAP2, OMAP3, OMAP4
 	  and Keystone platforms.
-- 
2.17.1


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply related	[flat|nested] 25+ messages in thread
* Re: [PATCH] mtd: rawnand: omap2: Actually prevent invalid configuration and build error
@ 2022-02-20  0:44 Guenter Roeck
  2022-02-27  6:55   ` Randy Dunlap
  0 siblings, 1 reply; 25+ messages in thread
From: Guenter Roeck @ 2022-02-20  0:44 UTC (permalink / raw)
  To: Roger Quadros
  Cc: miquel.raynal, krzysztof.kozlowski, vigneshr, nm, linux-mtd,
	linux-kernel

On Sat, Feb 19, 2022 at 09:36:00PM +0200, Roger Quadros wrote:
> The root of the problem is that we are selecting symbols that have
> dependencies. This can cause random configurations that can fail.
> The cleanest solution is to avoid using select.
> 
> This driver uses interfaces from the OMAP_GPMC driver so we have to
> depend on it instead.
> 
> Fixes: 4cd335dae3cf ("mtd: rawnand: omap2: Prevent invalid configuration and build error")
> Signed-off-by: Roger Quadros <rogerq@kernel.org>

Tested-by: Guenter Roeck <linux@roeck-us.net>

> ---
>  drivers/mtd/nand/raw/Kconfig | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/mtd/nand/raw/Kconfig b/drivers/mtd/nand/raw/Kconfig
> index 36e697456ec4..9b078e78f3fa 100644
> --- a/drivers/mtd/nand/raw/Kconfig
> +++ b/drivers/mtd/nand/raw/Kconfig
> @@ -42,8 +42,7 @@ config MTD_NAND_OMAP2
>  	tristate "OMAP2, OMAP3, OMAP4 and Keystone NAND controller"
>  	depends on ARCH_OMAP2PLUS || ARCH_KEYSTONE || ARCH_K3 || COMPILE_TEST
>  	depends on HAS_IOMEM
> -	select MEMORY
> -	select OMAP_GPMC
> +	depends on OMAP_GPMC
>  	help
>  	  Support for NAND flash on Texas Instruments OMAP2, OMAP3, OMAP4
>  	  and Keystone platforms.
> -- 
> 2.17.1
> 

^ permalink raw reply	[flat|nested] 25+ messages in thread

end of thread, other threads:[~2022-03-08  9:27 UTC | newest]

Thread overview: 25+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-19 19:36 [PATCH] mtd: rawnand: omap2: Actually prevent invalid configuration and build error Roger Quadros
2022-02-19 19:36 ` Roger Quadros
2022-02-25 11:15 ` Miquel Raynal
2022-02-25 11:15   ` Miquel Raynal
2022-02-20  0:44 Guenter Roeck
2022-02-27  6:55 ` Randy Dunlap
2022-02-27  6:55   ` Randy Dunlap
2022-03-04 15:54   ` Miquel Raynal
2022-03-04 15:54     ` Miquel Raynal
2022-03-04 20:04     ` Guenter Roeck
2022-03-04 20:04       ` Guenter Roeck
2022-03-04 22:50     ` Roger Quadros
2022-03-04 22:50       ` Roger Quadros
2022-03-07 10:03       ` Miquel Raynal
2022-03-07 10:03         ` Miquel Raynal
2022-03-07 12:25         ` Roger Quadros
2022-03-07 12:25           ` Roger Quadros
2022-03-07 14:12           ` Miquel Raynal
2022-03-07 14:12             ` Miquel Raynal
2022-03-07 21:05             ` Roger Quadros
2022-03-07 21:05               ` Roger Quadros
2022-03-08  9:26               ` Miquel Raynal
2022-03-08  9:26                 ` Miquel Raynal
2022-03-07 14:21           ` Miquel Raynal
2022-03-07 14:21             ` Miquel Raynal

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.