From: Dongli Zhang <dongli.zhang@oracle.com>
To: netdev@vger.kernel.org, bpf@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, davem@davemloft.net,
kuba@kernel.org, rostedt@goodmis.org, mingo@redhat.com,
ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
imagedong@tencent.com, joao.m.martins@oracle.com,
joe.jin@oracle.com, dsahern@gmail.com, edumazet@google.com
Subject: [PATCH net-next v3 0/3] tun/tap: use kfree_skb_reason() to trace dropped skb
Date: Sun, 20 Feb 2022 21:34:36 -0800 [thread overview]
Message-ID: <20220221053440.7320-1-dongli.zhang@oracle.com> (raw)
The commit c504e5c2f964 ("net: skb: introduce kfree_skb_reason()") has
introduced the kfree_skb_reason() to help track the reason.
The tun and tap are commonly used as virtio-net/vhost-net backend. This is to
use kfree_skb_reason() to trace the dropped skb for those two drivers.
Changed since v1:
- I have renamed many of the reasons since v1. I make them as generic as
possible so that they can be re-used by core networking and drivers.
Changed since v2:
- declare drop_reason as type "enum skb_drop_reason"
- handle the drop in skb_list_walk_safe() case for tap driver, and
kfree_skb_list_reason() is introduced
The following reasons are introduced.
- SKB_DROP_REASON_SKB_CSUM
This is used whenever there is checksum error with sk_buff.
- SKB_DROP_REASON_SKB_COPY_DATA
The kernel may (zero) copy the data to or from sk_buff, e.g.,
zerocopy_sg_from_iter(), skb_copy_datagram_from_iter() and
skb_orphan_frags_rx(). This reason is for the copy related error.
- SKB_DROP_REASON_SKB_GSO_SEG
Any error reported when GSO processing the sk_buff. It is frequent to process
sk_buff gso data and we introduce a new reason to handle that.
- SKB_DROP_REASON_SKB_PULL
- SKB_DROP_REASON_SKB_TRIM
It is frequent to pull to sk_buff data or trim the sk_buff data.
- SKB_DROP_REASON_DEV_HDR
Any driver may report error if there is any error in the metadata on the DMA
ring buffer.
- SKB_DROP_REASON_DEV_READY
The device is not ready/online or initialized to receive data.
- SKB_DROP_REASON_DEV_FILTER
David Ahern suggested SKB_DROP_REASON_TAP_FILTER. I changed from 'TAP' to 'DEV'
to make it more generic.
- SKB_DROP_REASON_FULL_RING
Suggested by Eric Dumazet.
- SKB_DROP_REASON_BPF_FILTER
Dropped by ebpf filter
This is the output for TUN device.
# cat /sys/kernel/debug/tracing/trace_pipe
<idle>-0 [018] ..s1. 1478.130490: kfree_skb: skbaddr=00000000c4f21b8d protocol=0 location=00000000aff342c7 reason: NOT_SPECIFIED
vhost-9003-9020 [012] b..1. 1478.196264: kfree_skb: skbaddr=00000000b174fb9b protocol=2054 location=000000001cf38db0 reason: FULL_RING
arping-9639 [018] b..1. 1479.082993: kfree_skb: skbaddr=00000000c4f21b8d protocol=2054 location=000000001cf38db0 reason: FULL_RING
<idle>-0 [012] b.s3. 1479.110472: kfree_skb: skbaddr=00000000e0c3681f protocol=4 location=000000001cf38db0 reason: FULL_RING
arping-9639 [018] b..1. 1480.083086: kfree_skb: skbaddr=00000000c4f21b8d protocol=2054 location=000000001cf38db0 reason: FULL_RING
This is the output for TAP device.
# cat /sys/kernel/debug/tracing/trace_pipe
<idle>-0 [014] ..s1. 1096.418621: kfree_skb: skbaddr=00000000f8f41946 protocol=0 location=00000000aff342c7 reason: NOT_SPECIFIED
arping-7006 [001] ..s1. 1096.843961: kfree_skb: skbaddr=000000002ec803a8 protocol=2054 location=000000009a57b32f reason: FULL_RING
arping-7006 [001] ..s1. 1097.844035: kfree_skb: skbaddr=000000002ec803a8 protocol=2054 location=000000009a57b32f reason: FULL_RING
arping-7006 [001] ..s1. 1098.844102: kfree_skb: skbaddr=00000000295eb0da protocol=2054 location=000000009a57b32f reason: FULL_RING
arping-7006 [001] ..s1. 1099.844160: kfree_skb: skbaddr=00000000295eb0da protocol=2054 location=000000009a57b32f reason: FULL_RING
arping-7006 [001] ..s1. 1100.844214: kfree_skb: skbaddr=00000000295eb0da protocol=2054 location=000000009a57b32f reason: FULL_RING
arping-7006 [001] ..s1. 1101.844230: kfree_skb: skbaddr=00000000295eb0da protocol=2054 location=000000009a57b32f reason: FULL_RING
drivers/net/tap.c | 35 +++++++++++++++++++++++++----------
drivers/net/tun.c | 38 ++++++++++++++++++++++++++++++--------
include/linux/skbuff.h | 18 ++++++++++++++++++
include/trace/events/skb.h | 10 ++++++++++
net/core/skbuff.c | 11 +++++++++--
5 files changed, 92 insertions(+), 20 deletions(-)
Please let me know if there is any suggestion on the definition of reasons.
Thank you very much!
Dongli Zhang
next reply other threads:[~2022-02-21 5:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-21 5:34 Dongli Zhang [this message]
2022-02-21 5:34 ` [PATCH net-next v3 1/4] skbuff: introduce kfree_skb_list_reason() Dongli Zhang
2022-02-22 3:20 ` David Ahern
2022-02-21 5:34 ` [PATCH net-next v3 2/4] net: tap: track dropped skb via kfree_skb_reason() Dongli Zhang
2022-02-22 3:24 ` David Ahern
2022-02-22 4:31 ` Dongli Zhang
2022-02-26 8:52 ` Dongli Zhang
2022-02-21 5:34 ` [PATCH net-next v3 3/4] net: tun: split run_ebpf_filter() and pskb_trim() into different "if statement" Dongli Zhang
2022-02-22 3:28 ` David Ahern
2022-02-21 5:34 ` [PATCH net-next v3 4/4] net: tun: track dropped skb via kfree_skb_reason() Dongli Zhang
2022-02-22 3:28 ` David Ahern
2022-02-22 4:45 ` Dongli Zhang
2022-02-22 14:39 ` David Ahern
2022-02-22 18:20 ` Dongli Zhang
2022-02-25 5:57 ` Menglong Dong
2022-02-25 15:48 ` David Ahern
2022-02-25 16:49 ` Dongli Zhang
2022-02-21 22:53 ` [PATCH net-next v3 0/3] tun/tap: use kfree_skb_reason() to trace dropped skb Dongli Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220221053440.7320-1-dongli.zhang@oracle.com \
--to=dongli.zhang@oracle.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=edumazet@google.com \
--cc=imagedong@tencent.com \
--cc=joao.m.martins@oracle.com \
--cc=joe.jin@oracle.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.