All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ritesh Harjani <riteshh@linux.ibm.com>
To: Harshad Shirwadkar <harshadshirwadkar@gmail.com>,
	"Theodore Ts'o" <tytso@mit.edu>
Cc: linux-ext4 <linux-ext4@vger.kernel.org>, Jan Kara <jack@suse.cz>
Subject: Query regarding fast_commit replay of inode
Date: Mon, 21 Feb 2022 13:29:38 +0530	[thread overview]
Message-ID: <20220221075938.g2lncbi7sxnnbrhr@riteshh-domain> (raw)

Hello Ted/Harshad,

I think we did discuss this once before, but I am unable to recollect the exact
reasoning for this. So question is - why do we have to call ext4_ext_clear_bb()
from ext4_fc_replay_inode()?

I was just thinking if this is suboptimal and if it can be optimized. But before
working on that problem, I wanted to again understand the right reasoning behind
choosing this approach in the first place.

Could you please help with this again?

ext4_fc_replay_inode()
<..>
	inode = ext4_iget(sb, ino, EXT4_IGET_NORMAL);
	if (!IS_ERR(inode)) {
		ext4_ext_clear_bb(inode);
		iput(inode);
	}
<..>

I will document it this time, so that I don't have to keep coming to this
everytime I look into fc replay code.

Thanks again for your help!!
-ritesh

             reply	other threads:[~2022-02-21  7:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-21  7:59 Ritesh Harjani [this message]
2022-02-21 18:54 ` Query regarding fast_commit replay of inode harshad shirwadkar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220221075938.g2lncbi7sxnnbrhr@riteshh-domain \
    --to=riteshh@linux.ibm.com \
    --cc=harshadshirwadkar@gmail.com \
    --cc=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.