From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDF6DC433FE for ; Mon, 21 Feb 2022 22:48:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235783AbiBUWtR (ORCPT ); Mon, 21 Feb 2022 17:49:17 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:51550 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232926AbiBUWtP (ORCPT ); Mon, 21 Feb 2022 17:49:15 -0500 Received: from smtp-fw-6002.amazon.com (smtp-fw-6002.amazon.com [52.95.49.90]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6526B22B32; Mon, 21 Feb 2022 14:48:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1645483732; x=1677019732; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=UNqAMTAVydknhHstqyu4WYIg/j3vKUO81xt/oxFzZ8c=; b=QQWh32Z4n875LIE8R4NmB6FJVuOJN6JrNhv1CZytkhjrNRIXbbL30QOR 9ujhcNWH2D+G6NmRHT/bFpTIeICffxTlu8CVl53SozCcF7eOLvGaqIWT6 GKwLRQ11z3RzKJako48Ae6dMsu2ONBqKbUX7/O9ib9owhwkpystxEbshl g=; X-IronPort-AV: E=Sophos;i="5.88,386,1635206400"; d="scan'208";a="178631464" Received: from iad12-co-svc-p1-lb1-vlan2.amazon.com (HELO email-inbound-relay-iad-1e-98691110.us-east-1.amazon.com) ([10.43.8.2]) by smtp-border-fw-6002.iad6.amazon.com with ESMTP; 21 Feb 2022 22:48:51 +0000 Received: from EX13MTAUWB001.ant.amazon.com (iad12-ws-svc-p26-lb9-vlan3.iad.amazon.com [10.40.163.38]) by email-inbound-relay-iad-1e-98691110.us-east-1.amazon.com (Postfix) with ESMTPS id 3F4FD85227; Mon, 21 Feb 2022 22:48:44 +0000 (UTC) Received: from EX13D02UWC002.ant.amazon.com (10.43.162.6) by EX13MTAUWB001.ant.amazon.com (10.43.161.249) with Microsoft SMTP Server (TLS) id 15.0.1497.28; Mon, 21 Feb 2022 22:48:20 +0000 Received: from EX13MTAUEA001.ant.amazon.com (10.43.61.82) by EX13D02UWC002.ant.amazon.com (10.43.162.6) with Microsoft SMTP Server (TLS) id 15.0.1497.28; Mon, 21 Feb 2022 22:48:20 +0000 Received: from dev-dsk-alisaidi-1d-b9a0e636.us-east-1.amazon.com (172.19.181.128) by mail-relay.amazon.com (10.43.61.243) with Microsoft SMTP Server id 15.0.1497.28 via Frontend Transport; Mon, 21 Feb 2022 22:48:19 +0000 Received: by dev-dsk-alisaidi-1d-b9a0e636.us-east-1.amazon.com (Postfix, from userid 5131138) id 6A34417C4; Mon, 21 Feb 2022 22:48:19 +0000 (UTC) From: Ali Saidi To: , , , , CC: , , Peter Zijlstra , Ingo Molnar , "Arnaldo Carvalho de Melo" , Mark Rutland , "Alexander Shishkin" , Jiri Olsa , Namhyung Kim , John Garry , "Will Deacon" , Mathieu Poirier , "James Clark" , Andrew Kilroy , Jin Yao , Kajol Jain , Li Huafei Subject: [PATCH v2 2/2] perf mem: Support HITM for when mem_lvl_num is used Date: Mon, 21 Feb 2022 22:48:00 +0000 Message-ID: <20220221224807.18172-2-alisaidi@amazon.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220221224807.18172-1-alisaidi@amazon.com> References: <20220221224807.18172-1-alisaidi@amazon.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Current code only support HITM statistics for last level cache (LLC) when mem_lvl encodes the level. On existing Arm64 machines there are as many as four levels cache and this change supports decoding l1, l2, and llc hits from the mem_lvl_num data. Given that the mem_lvl namespace is being deprecated take this opportunity to encode the neoverse data into mem_lvl_num. For loads that hit in a the LLC snoop filter and are fullfilled from a higher level cache, it's not usually clear what the true level of the cache the data came from (i.e. a transfer from a core could come from it's L1 or L2). Instead of making an assumption of where the line came from, add support for incrementing HITM if the source is CACHE_ANY. Since other architectures don't seem to populate the mem_lvl_num field here there shouldn't be a change in functionality. Signed-off-by: Ali Saidi --- tools/perf/util/mem-events.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/tools/perf/util/mem-events.c b/tools/perf/util/mem-events.c index ed0ab838bcc5..6c3fd4aac7ae 100644 --- a/tools/perf/util/mem-events.c +++ b/tools/perf/util/mem-events.c @@ -485,6 +485,7 @@ int c2c_decode_stats(struct c2c_stats *stats, struct mem_info *mi) u64 daddr = mi->daddr.addr; u64 op = data_src->mem_op; u64 lvl = data_src->mem_lvl; + u64 lnum = data_src->mem_lvl_num; u64 snoop = data_src->mem_snoop; u64 lock = data_src->mem_lock; u64 blk = data_src->mem_blk; @@ -527,16 +528,18 @@ do { \ if (lvl & P(LVL, UNC)) stats->ld_uncache++; if (lvl & P(LVL, IO)) stats->ld_io++; if (lvl & P(LVL, LFB)) stats->ld_fbhit++; - if (lvl & P(LVL, L1 )) stats->ld_l1hit++; - if (lvl & P(LVL, L2 )) stats->ld_l2hit++; - if (lvl & P(LVL, L3 )) { + if (lvl & P(LVL, L1) || lnum == P(LVLNUM, L1)) + stats->ld_l1hit++; + if (lvl & P(LVL, L2) || lnum == P(LVLNUM, L2)) + stats->ld_l2hit++; + if (lvl & P(LVL, L3) || lnum == P(LVLNUM, L4)) { if (snoop & P(SNOOP, HITM)) HITM_INC(lcl_hitm); else stats->ld_llchit++; } - if (lvl & P(LVL, LOC_RAM)) { + if (lvl & P(LVL, LOC_RAM) || lnum == P(LVLNUM, RAM)) { stats->lcl_dram++; if (snoop & P(SNOOP, HIT)) stats->ld_shared++; @@ -564,6 +567,9 @@ do { \ HITM_INC(rmt_hitm); } + if (lnum == P(LVLNUM, ANY_CACHE) && snoop & P(SNOOP, HITM)) + HITM_INC(lcl_hitm); + if ((lvl & P(LVL, MISS))) stats->ld_miss++; -- 2.32.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3949EC433EF for ; Mon, 21 Feb 2022 22:50:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sPhLzxOvEGxb7bs5f+iZnte/N93NnKc+D17R7Wxosbg=; b=f9GE3pW0YYdnki Gxiymqg/ArojvMlKwN2RdbLHgLWMhCpEUcdMivwFILXCAW9//PsQMUfTCHaRnVsKsZ6fsLXedd5Qa XlMkPfRoCprMWTH2VIXyEz1h28KkJgTyxJKJBUJd/mCx5M6LrbQwZ+N6m0oBHiuQpAXx6Ar28qYq+ NHDx+RxIkS+l+AGjVl9jS79Gqavz0qvEwbmd+kLadfsrxZ2M0RbHzciuNqafwtyVhz1+Vlk+azU2O kn9GZ18LB0GiH8A9JaJsmZ5PJRHRqjO7gGexPN29tV+ndipzfWPAO4xC2gWsYGtfiJYgbNBTOFP7b MZ5/weP5QHMiuALYE0lw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nMHUI-007Oj7-A5; Mon, 21 Feb 2022 22:48:58 +0000 Received: from smtp-fw-6002.amazon.com ([52.95.49.90]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nMHUD-007Ohk-Fd for linux-arm-kernel@lists.infradead.org; Mon, 21 Feb 2022 22:48:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1645483734; x=1677019734; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=UNqAMTAVydknhHstqyu4WYIg/j3vKUO81xt/oxFzZ8c=; b=i69Zp0enG1K6xlpb8ntuYjiGiwtV6fY+amYuwt1jEFLmwIeCW3jq46cd cWH7qtuuy8mZ/olLfQkg5HSdoP2Qo3RLuAdZespq8cnTGEMkYtSJQL8oz i09WiwHViLvHug45X/ByLVYf3ysgdsEf+HwLxvCysPmCglDn9cBlp73SF c=; X-IronPort-AV: E=Sophos;i="5.88,386,1635206400"; d="scan'208";a="178631464" Received: from iad12-co-svc-p1-lb1-vlan2.amazon.com (HELO email-inbound-relay-iad-1e-98691110.us-east-1.amazon.com) ([10.43.8.2]) by smtp-border-fw-6002.iad6.amazon.com with ESMTP; 21 Feb 2022 22:48:51 +0000 Received: from EX13MTAUWB001.ant.amazon.com (iad12-ws-svc-p26-lb9-vlan3.iad.amazon.com [10.40.163.38]) by email-inbound-relay-iad-1e-98691110.us-east-1.amazon.com (Postfix) with ESMTPS id 3F4FD85227; Mon, 21 Feb 2022 22:48:44 +0000 (UTC) Received: from EX13D02UWC002.ant.amazon.com (10.43.162.6) by EX13MTAUWB001.ant.amazon.com (10.43.161.249) with Microsoft SMTP Server (TLS) id 15.0.1497.28; Mon, 21 Feb 2022 22:48:20 +0000 Received: from EX13MTAUEA001.ant.amazon.com (10.43.61.82) by EX13D02UWC002.ant.amazon.com (10.43.162.6) with Microsoft SMTP Server (TLS) id 15.0.1497.28; Mon, 21 Feb 2022 22:48:20 +0000 Received: from dev-dsk-alisaidi-1d-b9a0e636.us-east-1.amazon.com (172.19.181.128) by mail-relay.amazon.com (10.43.61.243) with Microsoft SMTP Server id 15.0.1497.28 via Frontend Transport; Mon, 21 Feb 2022 22:48:19 +0000 Received: by dev-dsk-alisaidi-1d-b9a0e636.us-east-1.amazon.com (Postfix, from userid 5131138) id 6A34417C4; Mon, 21 Feb 2022 22:48:19 +0000 (UTC) From: Ali Saidi To: , , , , CC: , , Peter Zijlstra , Ingo Molnar , "Arnaldo Carvalho de Melo" , Mark Rutland , "Alexander Shishkin" , Jiri Olsa , Namhyung Kim , John Garry , "Will Deacon" , Mathieu Poirier , "James Clark" , Andrew Kilroy , Jin Yao , Kajol Jain , Li Huafei Subject: [PATCH v2 2/2] perf mem: Support HITM for when mem_lvl_num is used Date: Mon, 21 Feb 2022 22:48:00 +0000 Message-ID: <20220221224807.18172-2-alisaidi@amazon.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220221224807.18172-1-alisaidi@amazon.com> References: <20220221224807.18172-1-alisaidi@amazon.com> MIME-Version: 1.0 Precedence: Bulk X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220221_144853_681591_998D0150 X-CRM114-Status: GOOD ( 14.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Current code only support HITM statistics for last level cache (LLC) when mem_lvl encodes the level. On existing Arm64 machines there are as many as four levels cache and this change supports decoding l1, l2, and llc hits from the mem_lvl_num data. Given that the mem_lvl namespace is being deprecated take this opportunity to encode the neoverse data into mem_lvl_num. For loads that hit in a the LLC snoop filter and are fullfilled from a higher level cache, it's not usually clear what the true level of the cache the data came from (i.e. a transfer from a core could come from it's L1 or L2). Instead of making an assumption of where the line came from, add support for incrementing HITM if the source is CACHE_ANY. Since other architectures don't seem to populate the mem_lvl_num field here there shouldn't be a change in functionality. Signed-off-by: Ali Saidi --- tools/perf/util/mem-events.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/tools/perf/util/mem-events.c b/tools/perf/util/mem-events.c index ed0ab838bcc5..6c3fd4aac7ae 100644 --- a/tools/perf/util/mem-events.c +++ b/tools/perf/util/mem-events.c @@ -485,6 +485,7 @@ int c2c_decode_stats(struct c2c_stats *stats, struct mem_info *mi) u64 daddr = mi->daddr.addr; u64 op = data_src->mem_op; u64 lvl = data_src->mem_lvl; + u64 lnum = data_src->mem_lvl_num; u64 snoop = data_src->mem_snoop; u64 lock = data_src->mem_lock; u64 blk = data_src->mem_blk; @@ -527,16 +528,18 @@ do { \ if (lvl & P(LVL, UNC)) stats->ld_uncache++; if (lvl & P(LVL, IO)) stats->ld_io++; if (lvl & P(LVL, LFB)) stats->ld_fbhit++; - if (lvl & P(LVL, L1 )) stats->ld_l1hit++; - if (lvl & P(LVL, L2 )) stats->ld_l2hit++; - if (lvl & P(LVL, L3 )) { + if (lvl & P(LVL, L1) || lnum == P(LVLNUM, L1)) + stats->ld_l1hit++; + if (lvl & P(LVL, L2) || lnum == P(LVLNUM, L2)) + stats->ld_l2hit++; + if (lvl & P(LVL, L3) || lnum == P(LVLNUM, L4)) { if (snoop & P(SNOOP, HITM)) HITM_INC(lcl_hitm); else stats->ld_llchit++; } - if (lvl & P(LVL, LOC_RAM)) { + if (lvl & P(LVL, LOC_RAM) || lnum == P(LVLNUM, RAM)) { stats->lcl_dram++; if (snoop & P(SNOOP, HIT)) stats->ld_shared++; @@ -564,6 +567,9 @@ do { \ HITM_INC(rmt_hitm); } + if (lnum == P(LVLNUM, ANY_CACHE) && snoop & P(SNOOP, HITM)) + HITM_INC(lcl_hitm); + if ((lvl & P(LVL, MISS))) stats->ld_miss++; -- 2.32.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel