From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B7C4C433FE for ; Tue, 22 Feb 2022 02:13:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238935AbiBVCNw (ORCPT ); Mon, 21 Feb 2022 21:13:52 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:59498 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238911AbiBVCNu (ORCPT ); Mon, 21 Feb 2022 21:13:50 -0500 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9318C12AD8 for ; Mon, 21 Feb 2022 18:13:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645496006; x=1677032006; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=BDTLsUAWuprzHLATa1TYRxv6ZIA0bJgq5t/PRPMCMYw=; b=oJ6aNRSNZfYqp9Vxer1NLThhgXmV8SbTC0pJSuOTP57JOeAg8/0nZV2I iBxTC+T3ZmfniVKy/Ep2u9OXYXugW8StXsssgjuLnztdOXCf7utI0ZDGG COZO6hKRnl9DXq2ZyUowdtQhkA4OpnpiSZGhtoLf7pKj9pcq58eqZOtZv 4fhze6C5pFu6Y1EFOJmHBNy24ADbCw0cXlYPigJ2IvkRcgGoGz8bwjmrT O5Qr/MH1AwYiyx52ZnIbbRCAluaX6/gV7QKUWVrEmSQff47ikPNWnXoxI vUnjTre+J45dG1KHcgGXxFalJeVvSvAPOxYQPzgbGlScGDKKB735WI/Mb w==; X-IronPort-AV: E=McAfee;i="6200,9189,10265"; a="314857655" X-IronPort-AV: E=Sophos;i="5.88,387,1635231600"; d="scan'208";a="314857655" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Feb 2022 18:13:26 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,387,1635231600"; d="scan'208";a="627528941" Received: from cliu38-mobl3.sh.intel.com ([10.239.147.47]) by FMSMGA003.fm.intel.com with ESMTP; 21 Feb 2022 18:13:24 -0800 From: Chuansheng Liu To: linux-kernel@vger.kernel.org Cc: rafael@kernel.org, srinivas.pandruvada@linux.intel.com, rui.zhang@intel.com Subject: [PATCH] thermal: int340x: fix memory leak in int3400_notify() Date: Tue, 22 Feb 2022 10:00:21 +0800 Message-Id: <20220222020021.19640-1-chuansheng.liu@intel.com> X-Mailer: git-send-email 2.25.0.rc2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It is easy to hit the below memory leaks in my TigerLake platform: -- unreferenced object 0xffff927c8b91dbc0 (size 32): comm "kworker/0:2", pid 112, jiffies 4294893323 (age 83.604s) hex dump (first 32 bytes): 4e 41 4d 45 3d 49 4e 54 33 34 30 30 20 54 68 65 NAME=INT3400 The 72 6d 61 6c 00 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b a5 rmal.kkkkkkkkkk. backtrace: [] __kmalloc_track_caller+0x2fe/0x4a0 [] kvasprintf+0x65/0xd0 [] kasprintf+0x4e/0x70 [] int3400_notify+0x82/0x120 [int3400_thermal] [] acpi_ev_notify_dispatch+0x54/0x71 [] acpi_os_execute_deferred+0x17/0x30 [] process_one_work+0x21a/0x3f0 [] worker_thread+0x4a/0x3b0 [] kthread+0xfd/0x130 [] ret_from_fork+0x1f/0x30 --- Fix it by calling kfree() accordingly. Signed-off-by: Chuansheng Liu --- drivers/thermal/intel/int340x_thermal/int3400_thermal.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/thermal/intel/int340x_thermal/int3400_thermal.c b/drivers/thermal/intel/int340x_thermal/int3400_thermal.c index 72acb1f61849..4f478812cb51 100644 --- a/drivers/thermal/intel/int340x_thermal/int3400_thermal.c +++ b/drivers/thermal/intel/int340x_thermal/int3400_thermal.c @@ -404,6 +404,10 @@ static void int3400_notify(acpi_handle handle, thermal_prop[3] = kasprintf(GFP_KERNEL, "EVENT=%d", therm_event); thermal_prop[4] = NULL; kobject_uevent_env(&priv->thermal->device.kobj, KOBJ_CHANGE, thermal_prop); + kfree(thermal_prop[0]); + kfree(thermal_prop[1]); + kfree(thermal_prop[2]); + kfree(thermal_prop[3]); } static int int3400_thermal_get_temp(struct thermal_zone_device *thermal, -- 2.25.0.rc2