All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Miao Li <miao.li@intel.com>
Cc: dev@dpdk.org, david.hunt@intel.com, yinan.wang@intel.com
Subject: Re: [PATCH v1] power: add wakeup log
Date: Tue, 22 Feb 2022 08:07:13 -0800	[thread overview]
Message-ID: <20220222080713.5ea7a07d@hermes.local> (raw)
In-Reply-To: <20220222135227.631275-1-miao.li@intel.com>

On Tue, 22 Feb 2022 13:52:27 +0000
Miao Li <miao.li@intel.com> wrote:

> +			"lcore %u is waked up from value change\n",

That is awkward phrasing in English and should be DEBUG not INFO level
because it may happen often.

Maybe:
		"lcore %u awoke because value changed\n"
or something better.

PS: sometimes it is good idea to using grammar tools when wording commit
or messages.

  reply	other threads:[~2022-02-22 16:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-22 13:52 [PATCH v1] power: add wakeup log Miao Li
2022-02-22 16:07 ` Stephen Hemminger [this message]
2022-02-24  2:45   ` Li, Miao
2022-02-22 16:32 ` David Hunt
2022-02-24  2:38   ` Li, Miao
2022-02-25 11:19     ` Burakov, Anatoly

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220222080713.5ea7a07d@hermes.local \
    --to=stephen@networkplumber.org \
    --cc=david.hunt@intel.com \
    --cc=dev@dpdk.org \
    --cc=miao.li@intel.com \
    --cc=yinan.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.