All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vikash Chandola <vikash.chandola@linux.intel.com>
To: linux@roeck-us.net, jdelvare@suse.com,
	linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
	iwona.winiarska@intel.com
Cc: Vikash Chandola <vikash.chandola@linux.intel.com>
Subject: [PATCH v2] hwmon: (pmbus) Clear pmbus fault/warning bits after read
Date: Tue, 22 Feb 2022 13:12:53 +0000	[thread overview]
Message-ID: <20220222131253.2426834-1-vikash.chandola@linux.intel.com> (raw)

Almost all fault/warning bits in pmbus status registers remain set even
after fault/warning condition are removed. As per pmbus specification
these faults must be cleared by user.
Modify hwmon behavior to clear fault/warning bit after fetching data if
fault/warning bit was set. This allows to get fresh data in next read.

Signed-off-by: Vikash Chandola <vikash.chandola@linux.intel.com>
---
changes since v1:
v1 patch was clearing all the faults. That would have lead faults not
getting reported to user at all. This change clears only current fault
and that too after reporting it at least once. This way all the faults
will be reported to user space at least once.

Behaviour has been verified with following PSU
FRU Device Description : IS162F22 (ID 84)
Product Manufacturer   : SOLUM CO., LTD.
Product Name           : IS162F22
Product Part Number    : G36234-015
Product Version        : 10A

 drivers/hwmon/pmbus/pmbus_core.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/hwmon/pmbus/pmbus_core.c b/drivers/hwmon/pmbus/pmbus_core.c
index 776ee2237be2..ac2fbee1ba9c 100644
--- a/drivers/hwmon/pmbus/pmbus_core.c
+++ b/drivers/hwmon/pmbus/pmbus_core.c
@@ -911,6 +911,11 @@ static int pmbus_get_boolean(struct i2c_client *client, struct pmbus_boolean *b,
 		pmbus_update_sensor_data(client, s2);
 
 	regval = status & mask;
+	if (regval) {
+		ret = pmbus_write_byte_data(client, page, reg, regval);
+		if (ret)
+			goto unlock;
+	}
 	if (s1 && s2) {
 		s64 v1, v2;
 
-- 
2.25.1


             reply	other threads:[~2022-02-22 13:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-22 13:12 Vikash Chandola [this message]
2022-02-22 16:15 ` [PATCH v2] hwmon: (pmbus) Clear pmbus fault/warning bits after read Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220222131253.2426834-1-vikash.chandola@linux.intel.com \
    --to=vikash.chandola@linux.intel.com \
    --cc=iwona.winiarska@intel.com \
    --cc=jdelvare@suse.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.