From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1nMYnr-0007q9-ND for mharc-grub-devel@gnu.org; Tue, 22 Feb 2022 12:18:20 -0500 Received: from eggs.gnu.org ([209.51.188.92]:55982) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nMYni-0007nb-2t for grub-devel@gnu.org; Tue, 22 Feb 2022 12:18:11 -0500 Received: from dibed.net-space.pl ([84.10.22.86]:34922) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_3DES_EDE_CBC_SHA1:192) (Exim 4.90_1) (envelope-from ) id 1nMYng-0007BJ-ER for grub-devel@gnu.org; Tue, 22 Feb 2022 12:18:09 -0500 Received: from router-fw.i.net-space.pl ([192.168.52.1]:58500 "EHLO tomti.i.net-space.pl") by router-fw-old.i.net-space.pl with ESMTP id S1902113AbiBVRRx (ORCPT ); Tue, 22 Feb 2022 18:17:53 +0100 X-Comment: RFC 2476 MSA function at dibed.net-space.pl logged sender identity as: dkiper Date: Tue, 22 Feb 2022 18:17:51 +0100 From: Daniel Kiper To: Robbie Harwood Cc: grub-devel@gnu.org, development@efficientek.com Subject: Re: [PATCH v5 0/4] Update gnulib and drop some patches Message-ID: <20220222171751.e6lwotgsi3mvct4t@tomti.i.net-space.pl> References: <20220216214142.555294-1-rharwood@redhat.com> <20220222152122.enimol3yrdiufsl4@tomti.i.net-space.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Received-SPF: pass client-ip=84.10.22.86; envelope-from=dkiper@net-space.pl; helo=dibed.net-space.pl X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Feb 2022 17:18:13 -0000 On Tue, Feb 22, 2022 at 11:44:37AM -0500, Robbie Harwood wrote: > Daniel Kiper writes: > > > On Wed, Feb 16, 2022 at 04:41:38PM -0500, Robbie Harwood wrote: > >> Changes in this version: > >> > >> - Include most _GL_* defines from gnulib. Hopefully we do not need all their > >> prereq logic as well, but I don't know what the compilers we support are, so > >> please correct that if needed. > >> > >> - Avoid creating empty #defines. > >> > >> - Fix issues with building gnulib's allocation modules observed by Glenn. The > >> tree now builds warning-free with default cflags for me. > > > > ./configure --target=arm-linux-gnueabihf --with-platform=coreboot --enable-grub-mkfont ... > > > > make ... > > > > ... and you will get this... :-( > > > > In file included from lib/gnulib/malloc/dynarray_resize.c:25:0: > > lib/gnulib/malloc/dynarray_resize.c: In function ‘gl_dynarray_resize’: > > ../grub-core/lib/gnulib/intprops.h:592:8: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits] > > ((b) < 0 \ > > ^ > > ../grub-core/lib/gnulib/intprops.h:536:4: note: in expansion of macro ‘_GL_INT_MULTIPLY_RANGE_OVERFLOW’ > > (overflow (a, b, tmin, tmax) \ > > ^~~~~~~~ > > ../grub-core/lib/gnulib/intprops.h:479:8: note: in expansion of macro ‘_GL_INT_OP_CALC’ > > ? _GL_INT_OP_CALC (a, b, r, op, overflow, unsigned int, st, smin, smax) \ > > ^~~~~~~~~~~~~~~ > > ../grub-core/lib/gnulib/intprops.h:494:7: note: in expansion of macro ‘_GL_INT_OP_WRAPV_SMALLISH’ > > ? _GL_INT_OP_WRAPV_SMALLISH (a, b, r, op, overflow, \ > > ^~~~~~~~~~~~~~~~~~~~~~~~~ > > ../grub-core/lib/gnulib/intprops.h:418:4: note: in expansion of macro ‘_GL_INT_OP_WRAPV’ > > _GL_INT_OP_WRAPV (a, b, r, *, _GL_INT_MULTIPLY_RANGE_OVERFLOW) > > ^~~~~~~~~~~~~~~~ > > lib/gnulib/malloc/dynarray_resize.c:45:7: note: in expansion of macro ‘INT_MULTIPLY_WRAPV’ > > if (INT_MULTIPLY_WRAPV (size, element_size, &new_size_bytes)) > > ^~~~~~~~~~~~~~~~~~ > > ... > > I don't get that, actually. What OS/gcc? It's fine with the gcc-11 I'm > using here. Does gcc-11 work with the configure mentioned above? Anyway, Debian 9, arm-linux-gnueabihf-gcc (Debian 6.3.0-18) 6.3.0 20170516. The GRUB INSTALL file says: The Requirements ================ GRUB depends on some software packages installed into your system. If you don't have any of them, please obtain and install them before configuring the GRUB. * GCC 5.1.0 or later So, even if it is old it is perfectly valid compiler according to the GRUB docs. Hmmm... What are the latest gnulib minimal compiler, linker, etc. requirements? Daniel