[PATCH v3] ARM: imx: imx8mn-*-evk: use DM settings for PHY configuration

[PATCH v3] ARM: imx: imx8mn-*-evk: use DM settings for PHY configuration

[Heiko Thiery]

With the correct settings described in the device-tree the PHY settings
in the board init are no longer required. The values are taken from the
linux device tree.

The PHY latency settings are derived from the phy-mode property and the
voltage seetings are done via the regulator.

Suggested-by: Michael Walle <michael@walle.cc>
Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
---
v2:
 - remove phy-reset-gpios node (thanks to Michael)
    When using DM_ETH_PHY the reset-gpios from the phy is used

v3:
 - Only change remove/replace the voltage settings and the delay settings.
   The pyh-reset-gpios vs. reset-gpios settings has to be discussed

 arch/arm/dts/imx8mn-evk.dtsi            |  6 ++++++
 board/freescale/imx8mn_evk/imx8mn_evk.c | 16 ----------------
 2 files changed, 6 insertions(+), 16 deletions(-)

diff --git a/arch/arm/dts/imx8mn-evk.dtsi b/arch/arm/dts/imx8mn-evk.dtsi
index 416fadb22b..fc2c7f1d44 100644
--- a/arch/arm/dts/imx8mn-evk.dtsi
+++ b/arch/arm/dts/imx8mn-evk.dtsi
@@ -64,6 +64,12 @@
 		ethphy0: ethernet-phy@0 {
 			compatible = "ethernet-phy-ieee802.3-c22";
 			reg = <0>;
+			vddio-supply = <&vddio>;
+
+			vddio: vddio-regulator {
+				regulator-min-microvolt = <1800000>;
+				regulator-max-microvolt = <1800000>;
+			};
 		};
 	};
 };
diff --git a/board/freescale/imx8mn_evk/imx8mn_evk.c b/board/freescale/imx8mn_evk/imx8mn_evk.c
index b24342fd5c..e35d505aea 100644
--- a/board/freescale/imx8mn_evk/imx8mn_evk.c
+++ b/board/freescale/imx8mn_evk/imx8mn_evk.c
@@ -27,22 +27,6 @@ static void setup_fec(void)
 	clrsetbits_le32(&gpr->gpr[1], 0x2000, 0);
 }
 
-int board_phy_config(struct phy_device *phydev)
-{
-	/* enable rgmii rxc skew and phy mode select to RGMII copper */
-	phy_write(phydev, MDIO_DEVAD_NONE, 0x1d, 0x1f);
-	phy_write(phydev, MDIO_DEVAD_NONE, 0x1e, 0x8);
-
-	phy_write(phydev, MDIO_DEVAD_NONE, 0x1d, 0x00);
-	phy_write(phydev, MDIO_DEVAD_NONE, 0x1e, 0x82ee);
-	phy_write(phydev, MDIO_DEVAD_NONE, 0x1d, 0x05);
-	phy_write(phydev, MDIO_DEVAD_NONE, 0x1e, 0x100);
-
-	if (phydev->drv->config)
-		phydev->drv->config(phydev);
-	return 0;
-}
-
 int board_init(void)
 {
 	setup_fec();
-- 
2.30.2

Re: [PATCH v3] ARM: imx: imx8mn-*-evk: use DM settings for PHY configuration

[Marek Vasut]

On 2/23/22 09:10, Heiko Thiery wrote:
> With the correct settings described in the device-tree the PHY settings
> in the board init are no longer required. The values are taken from the
> linux device tree.
> 
> The PHY latency settings are derived from the phy-mode property and the
> voltage seetings are done via the regulator.
> 
> Suggested-by: Michael Walle <michael@walle.cc>
> Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>

Tested-by: Marek Vasut <marex@denx.de> # 8MNANOD4-EVK

Re: [PATCH v3] ARM: imx: imx8mn-*-evk: use DM settings for PHY configuration

[Fabio Estevam]

On Wed, Feb 23, 2022 at 5:10 AM Heiko Thiery <heiko.thiery@gmail.com> wrote:
>
> With the correct settings described in the device-tree the PHY settings
> in the board init are no longer required. The values are taken from the
> linux device tree.
>
> The PHY latency settings are derived from the phy-mode property and the
> voltage seetings are done via the regulator.
>
> Suggested-by: Michael Walle <michael@walle.cc>
> Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>

Reviewed-by: Fabio Estevam <festevam@gmail.com>