From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEF09C433F5 for ; Wed, 23 Feb 2022 10:56:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239568AbiBWK4l (ORCPT ); Wed, 23 Feb 2022 05:56:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33300 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239285AbiBWK4k (ORCPT ); Wed, 23 Feb 2022 05:56:40 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D84487DE04 for ; Wed, 23 Feb 2022 02:56:12 -0800 (PST) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nMpJb-0004Mc-6v; Wed, 23 Feb 2022 11:56:11 +0100 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1nMpJa-0005an-0j; Wed, 23 Feb 2022 11:56:10 +0100 Date: Wed, 23 Feb 2022 11:56:09 +0100 From: Sascha Hauer To: Joakim Zhang Cc: "netdev@vger.kernel.org" , "David S . Miller" , "kernel@pengutronix.de" , Ahmad Fatoum Subject: Re: [PATCH] net: fec: ethtool: fix unbalanced IRQ wake disable Message-ID: <20220223105609.GL9136@pengutronix.de> References: <20220223080918.3751233-1-s.hauer@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 11:44:45 up 74 days, 19:30, 91 users, load average: 0.17, 0.19, 0.22 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: netdev@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Feb 23, 2022 at 10:28:34AM +0000, Joakim Zhang wrote: > > Hi Sascha, > > > -----Original Message----- > > From: Sascha Hauer > > Sent: 2022年2月23日 16:09 > > To: netdev@vger.kernel.org > > Cc: Joakim Zhang ; David S . Miller > > ; kernel@pengutronix.de; Ahmad Fatoum > > ; Sascha Hauer > > Subject: [PATCH] net: fec: ethtool: fix unbalanced IRQ wake disable > > > > From: Ahmad Fatoum > > > > Userspace can trigger a kernel warning by using the ethtool ioctls to disable > > WoL, when it was not enabled before: > > > > $ ethtool -s eth0 wol d ; ethtool -s eth0 wol d > > Unbalanced IRQ 54 wake disable > > WARNING: CPU: 2 PID: 17532 at kernel/irq/manage.c:900 > > irq_set_irq_wake+0x108/0x148 > > > > This is because fec_enet_set_wol happily calls disable_irq_wake, even if the > > wake IRQ is already disabled. > > I have not found disable_irq_wake in fec_enet_set_wol. > https://elixir.bootlin.com/linux/v5.17-rc5/source/drivers/net/ethernet/freescale/fec_main.c#L2882 > > > Looking at other drivers, like lpc_eth, suggests the way to go is to do wake > > IRQ enabling/disabling in the suspend/resume callbacks. > > Doing so avoids the warning at no loss of functionality. > > FEC done as this way: > https://elixir.bootlin.com/linux/v5.17-rc5/source/drivers/net/ethernet/freescale/fec_main.c#L4075 > https://elixir.bootlin.com/linux/v5.17-rc5/source/drivers/net/ethernet/freescale/fec_main.c#L4119 > > > This only affects userspace with older ethtool versions. Newer ones use > > netlink and disabling before enabling will be refused before reaching the > > driver. > > Ahh, what I misunderstand? All the description makes me confusion. Please use the latest kernel. This patch was forward ported from v5.16. I should have had a closer look before posting, then I maybe would have realized that 0b6f65c707e5 ("net: fec: fix system hang during suspend/resume") already fixes the issue. Sorry for the noise. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |