From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E36AC800 for ; Wed, 23 Feb 2022 05:00:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645592419; x=1677128419; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=6FLKm6fp0tyd6+4vW4Mst9f8YW1kXerksPWJZQnchhs=; b=bemAQRmfBd4QjWuSoHkTYeRi9b2xigHFI9GkEPVoj4tCEYDEPty5FglH AFGTXfjRwd4U33H3DXoRfLPJ9/mqmyn2noFz8WHWIDD3TkTw1XtEwchRF +jlgocSyd/2dO/lrhlCZrCU5BJlgkp08ifDStJ24IbtVpoV56tdrlgT08 YXOC2KEfshhcJST8rbQOQKPzz6qntqtxJ0SF3YTqa+P4h+GgaiLswzkax Fij2duv2TcoQ3jAEqzWbKEyD9iAYwaKLzlVS6sDu9thxCfGIDFueG5SuM YIchs+t7NbsGO7hVTHRbkjMrYL6BNUt2zAWXaz3whfscZ66isGk4sVVXD A==; X-IronPort-AV: E=McAfee;i="6200,9189,10266"; a="250710792" X-IronPort-AV: E=Sophos;i="5.88,390,1635231600"; d="scan'208";a="250710792" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Feb 2022 21:00:19 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,390,1635231600"; d="scan'208";a="639175040" Received: from lkp-server01.sh.intel.com (HELO 788b1cd46f0d) ([10.239.97.150]) by orsmga004.jf.intel.com with ESMTP; 22 Feb 2022 21:00:16 -0800 Received: from kbuild by 788b1cd46f0d with local (Exim 4.92) (envelope-from ) id 1nMjl9-0000zj-DA; Wed, 23 Feb 2022 05:00:15 +0000 Date: Wed, 23 Feb 2022 12:59:48 +0800 From: kernel test robot To: Markuss Broks , linux-kernel@vger.kernel.org Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org, phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, Markuss Broks , Dmitry Torokhov , Rob Herring , Krzysztof Kozlowski , Henrik Rydberg , linux-input@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v6 2/2] Input: add Imagis touchscreen driver Message-ID: <202202231213.Vj9yo4tW-lkp@intel.com> References: <20220222203414.8656-3-markuss.broks@gmail.com> Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220222203414.8656-3-markuss.broks@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Hi Markuss, I love your patch! Perhaps something to improve: [auto build test WARNING on dtor-input/next] [also build test WARNING on linux/master robh/for-next linus/master v5.17-rc5 next-20220222] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Markuss-Broks/Add-support-for-Imagis-touchscreens/20220223-043645 base: https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next config: hexagon-allyesconfig (https://download.01.org/0day-ci/archive/20220223/202202231213.Vj9yo4tW-lkp@intel.com/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project d271fc04d5b97b12e6b797c6067d3c96a8d7470e) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/bc77ee5e0d7309edca7d65925c6afa05334b0b01 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Markuss-Broks/Add-support-for-Imagis-touchscreens/20220223-043645 git checkout bc77ee5e0d7309edca7d65925c6afa05334b0b01 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/input/touchscreen/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> drivers/input/touchscreen/imagis.c:300:6: warning: variable 'ret' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] if (input_device_enabled(ts->input_dev)) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/input/touchscreen/imagis.c:305:9: note: uninitialized use occurs here return ret; ^~~ drivers/input/touchscreen/imagis.c:300:2: note: remove the 'if' if its condition is always true if (input_device_enabled(ts->input_dev)) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/input/touchscreen/imagis.c:296:9: note: initialize the variable 'ret' to silence this warning int ret; ^ = 0 drivers/input/touchscreen/imagis.c:316:6: warning: variable 'ret' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] if (input_device_enabled(ts->input_dev)) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/input/touchscreen/imagis.c:321:9: note: uninitialized use occurs here return ret; ^~~ drivers/input/touchscreen/imagis.c:316:2: note: remove the 'if' if its condition is always true if (input_device_enabled(ts->input_dev)) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/input/touchscreen/imagis.c:312:9: note: initialize the variable 'ret' to silence this warning int ret; ^ = 0 2 warnings generated. vim +300 drivers/input/touchscreen/imagis.c 291 292 static int __maybe_unused imagis_suspend(struct device *dev) 293 { 294 struct i2c_client *client = to_i2c_client(dev); 295 struct imagis_ts *ts = i2c_get_clientdata(client); 296 int ret; 297 298 mutex_lock(&ts->input_dev->mutex); 299 > 300 if (input_device_enabled(ts->input_dev)) 301 ret = imagis_stop(ts); 302 303 mutex_unlock(&ts->input_dev->mutex); 304 305 return ret; 306 } 307 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org