From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0B28DC433EF for ; Wed, 23 Feb 2022 13:42:01 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3B4C410F614; Wed, 23 Feb 2022 13:42:00 +0000 (UTC) Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) by gabe.freedesktop.org (Postfix) with ESMTPS id 391EF10F612 for ; Wed, 23 Feb 2022 13:41:59 +0000 (UTC) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailnew.nyi.internal (Postfix) with ESMTP id 73B8858044C; Wed, 23 Feb 2022 08:41:58 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Wed, 23 Feb 2022 08:41:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; bh=e8NmwAG6UivGYRFtg0hHFrdMBYky5dWC8kuRA0 WJsso=; b=YD5dlt/SFvey4BAp1hBhNpY3fvtEX3m0grKMgKW/RhaFQnJMh44bwP t2xGuZCv5i14Ky1KI42iQZWgi+UszmcpVEc5Wlq2xoK5ILLQvlTVVvBb6BU+pMqA zJonCMXkdoO+mUithp8hB3rNA0/z9qnfGyYA2tznUI4RxFJrdf/FFsrGJXgTa7Wm si3o+UfNDS/HLrwy6jyyrXC3Rjj/vTUb8BxdVq8RpY//25wsAlDaxXtK1R+LHHia eny4vs12GFziZhIHrDheuMif6VelPvG168OxUdu6rCwZoMKCUErA75zpnVptC1bc q6BfvV3OTl/x9mLrPpAUibNX7KE8Md2Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=e8NmwAG6UivGYRFtg 0hHFrdMBYky5dWC8kuRA0WJsso=; b=mP6DEOcf4VeV4R1583lgOIcoH0juQyiAg rGnrgzQCAVIPCqSnyc6Q6OfRgSNqffzr9+42SY4F+C1VgvKxUkam+E/cF77OMvO6 +Y6reTrQts2mL2PBS11SwlRv5MXmMMAZYZaaNtCR3ydIGUrACV07QEt86c3P+6xy +tCxYr9I3mfCDmpXjGuq+R8lD9QSNFhLfUMBMHuXOI0Po3kl2rGlzuJ/dckPZHfR 7+AWAjDWghDL9oi3OOee6xn0ve4wC4whHX05CTOiCrkoAagSazCgkqryDUtPv4CQ wirQkfXsD6M7glylx4T2XVHkBKaHF8vjNNP0las4H5tgK0naxqTbg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrledtgdehgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofgrgihimhgv ucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrghtth gvrhhnpeevveefffduveeitdegtefhhfetueffteefffdvheevvdehteethedvleffgfej vdenucffohhmrghinhepkhgvrhhnvghlrdhorhhgnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 23 Feb 2022 08:41:56 -0500 (EST) Date: Wed, 23 Feb 2022 14:41:54 +0100 From: Maxime Ripard To: Max Krummenacher Subject: Re: [RFC PATCH] drm/panel: simple: panel-dpi: use bus-format to set bpc and bus_format Message-ID: <20220223134154.oo7xhf37bgtvm3ai@houat> References: <20220222084723.14310-1-max.krummenacher@toradex.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="p5r42g3rwoleu74b" Content-Disposition: inline In-Reply-To: <20220222084723.14310-1-max.krummenacher@toradex.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Christoph Niedermaier , Max Krummenacher , Marek Vasut , Pengutronix Kernel Team , David Airlie , Sam Ravnborg , Sascha Hauer , dri-devel@lists.freedesktop.org, DenysDrozdov , Laurent Pinchart , Shawn Guo , linux-arm-kernel@lists.infradead.org, NXP Linux Team Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" --p5r42g3rwoleu74b Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Tue, Feb 22, 2022 at 09:47:23AM +0100, Max Krummenacher wrote: > Use the new property bus-format to set the enum bus_format and bpc. > Completes: commit 4a1d0dbc8332 ("drm/panel: simple: add panel-dpi support= ") >=20 > Signed-off-by: Max Krummenacher >=20 > --- >=20 > drivers/gpu/drm/panel/panel-simple.c | 32 ++++++++++++++++++++++++++++ > 1 file changed, 32 insertions(+) >=20 > Relates to the discussion: https://lore.kernel.org/all/20220201110717.358= 5-1-cniedermaier@dh-electronics.com/ >=20 > Max >=20 > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel= /panel-simple.c > index c5f133667a2d..5c07260de71c 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -453,6 +453,7 @@ static int panel_dpi_probe(struct device *dev, > struct panel_desc *desc; > unsigned int bus_flags; > struct videomode vm; > + const char *format =3D ""; > int ret; > =20 > np =3D dev->of_node; > @@ -477,6 +478,37 @@ static int panel_dpi_probe(struct device *dev, > of_property_read_u32(np, "width-mm", &desc->size.width); > of_property_read_u32(np, "height-mm", &desc->size.height); > =20 > + of_property_read_string(np, "bus-format", &format); > + if (!strcmp(format, "BGR888_1X24")) { > + desc->bpc =3D 8; > + desc->bus_format =3D MEDIA_BUS_FMT_BGR888_1X24; > + } else if (!strcmp(format, "GBR888_1X24")) { > + desc->bpc =3D 8; > + desc->bus_format =3D MEDIA_BUS_FMT_GBR888_1X24; > + } else if (!strcmp(format, "RBG888_1X24")) { > + desc->bpc =3D 8; > + desc->bus_format =3D MEDIA_BUS_FMT_RBG888_1X24; > + } else if (!strcmp(format, "RGB444_1X12")) { > + desc->bpc =3D 6; > + desc->bus_format =3D MEDIA_BUS_FMT_RGB444_1X12; > + } else if (!strcmp(format, "RGB565_1X16")) { > + desc->bpc =3D 6; > + desc->bus_format =3D MEDIA_BUS_FMT_RGB565_1X16; > + } else if (!strcmp(format, "RGB666_1X18")) { > + desc->bpc =3D 6; > + desc->bus_format =3D MEDIA_BUS_FMT_RGB666_1X18; > + } else if (!strcmp(format, "RGB666_1X24_CPADHI")) { > + desc->bpc =3D 6; > + desc->bus_format =3D MEDIA_BUS_FMT_RGB666_1X24_CPADHI; > + } else if (!strcmp(format, "RGB888_1X24")) { > + desc->bpc =3D 8; > + desc->bus_format =3D MEDIA_BUS_FMT_RGB888_1X24; > + } else { > + dev_err(dev, "%pOF: missing or unknown bus-format property\n", > + np); > + return -EINVAL; > + } > + It doesn't seem right, really. We can't the bus format / bpc be inferred =66rom the compatible? I'd expect two panels that don't have the same bus format to not be claimed as compatible. Maxime --p5r42g3rwoleu74b Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYhY5ogAKCRDj7w1vZxhR xaKjAP9r35RESlRiF7rfKqiTJVl3wTvAIk9qVnbgg8tFEdcmBwD/ek7HxWjxgyUq ZOCPlrE47eND/Q51wIiHmf6Ce07QlQM= =wsWm -----END PGP SIGNATURE----- --p5r42g3rwoleu74b-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5F0E3C433F5 for ; Wed, 23 Feb 2022 13:43:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=uzqwIVPmt/DJwywQWq4mqy4Dqe+5fOzYh4jx4JR+j5U=; b=V9nR7EFhLzqSP+OXvyKIhfWcsI 9i53joi7HfU4zELwaKTPW/dkar5zlWBQ+1lclYfec1/Wqwv/dTEiSwtfKnfyQDnt2fWMMk1a57CMs MdVmN26BBbNGh3+BQ3gmbu6KtXGgFzJEJ6OE8hqu7gKMnuqs4uZWKX7Vys/fwCfXm4xVpxA47OM8w /3f5AjUrdJs2wHbrh5/0NpDAJdZlNMP3jx/IEILwvglIBFKA6KEFeEmbq7j2dc3iKpz3JIbuMQ8G7 +An0dzyxSSmbxTstC8/2fJ5nnT3lPOF2NIaD29i4zpjsWnFdQCO1YfOP87W+COTJIRVhAXTtjR5Rk zEvM9C0Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nMruE-00EYyX-3T; Wed, 23 Feb 2022 13:42:10 +0000 Received: from new3-smtp.messagingengine.com ([66.111.4.229]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nMru8-00EYtt-Ia for linux-arm-kernel@lists.infradead.org; Wed, 23 Feb 2022 13:42:07 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailnew.nyi.internal (Postfix) with ESMTP id 73B8858044C; Wed, 23 Feb 2022 08:41:58 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Wed, 23 Feb 2022 08:41:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; bh=e8NmwAG6UivGYRFtg0hHFrdMBYky5dWC8kuRA0 WJsso=; b=YD5dlt/SFvey4BAp1hBhNpY3fvtEX3m0grKMgKW/RhaFQnJMh44bwP t2xGuZCv5i14Ky1KI42iQZWgi+UszmcpVEc5Wlq2xoK5ILLQvlTVVvBb6BU+pMqA zJonCMXkdoO+mUithp8hB3rNA0/z9qnfGyYA2tznUI4RxFJrdf/FFsrGJXgTa7Wm si3o+UfNDS/HLrwy6jyyrXC3Rjj/vTUb8BxdVq8RpY//25wsAlDaxXtK1R+LHHia eny4vs12GFziZhIHrDheuMif6VelPvG168OxUdu6rCwZoMKCUErA75zpnVptC1bc q6BfvV3OTl/x9mLrPpAUibNX7KE8Md2Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=e8NmwAG6UivGYRFtg 0hHFrdMBYky5dWC8kuRA0WJsso=; b=mP6DEOcf4VeV4R1583lgOIcoH0juQyiAg rGnrgzQCAVIPCqSnyc6Q6OfRgSNqffzr9+42SY4F+C1VgvKxUkam+E/cF77OMvO6 +Y6reTrQts2mL2PBS11SwlRv5MXmMMAZYZaaNtCR3ydIGUrACV07QEt86c3P+6xy +tCxYr9I3mfCDmpXjGuq+R8lD9QSNFhLfUMBMHuXOI0Po3kl2rGlzuJ/dckPZHfR 7+AWAjDWghDL9oi3OOee6xn0ve4wC4whHX05CTOiCrkoAagSazCgkqryDUtPv4CQ wirQkfXsD6M7glylx4T2XVHkBKaHF8vjNNP0las4H5tgK0naxqTbg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrledtgdehgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofgrgihimhgv ucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrghtth gvrhhnpeevveefffduveeitdegtefhhfetueffteefffdvheevvdehteethedvleffgfej vdenucffohhmrghinhepkhgvrhhnvghlrdhorhhgnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 23 Feb 2022 08:41:56 -0500 (EST) Date: Wed, 23 Feb 2022 14:41:54 +0100 From: Maxime Ripard To: Max Krummenacher Cc: dri-devel@lists.freedesktop.org, Sascha Hauer , Philipp Zabel , Laurent Pinchart , Fabio Estevam , linux-arm-kernel@lists.infradead.org, DenysDrozdov , David Airlie , Christoph Niedermaier , Pengutronix Kernel Team , Sam Ravnborg , Shawn Guo , Daniel Vetter , Marek Vasut , NXP Linux Team , Max Krummenacher Subject: Re: [RFC PATCH] drm/panel: simple: panel-dpi: use bus-format to set bpc and bus_format Message-ID: <20220223134154.oo7xhf37bgtvm3ai@houat> References: <20220222084723.14310-1-max.krummenacher@toradex.com> MIME-Version: 1.0 In-Reply-To: <20220222084723.14310-1-max.krummenacher@toradex.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220223_054204_698062_83903132 X-CRM114-Status: GOOD ( 17.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============3579437183819465113==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============3579437183819465113== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="p5r42g3rwoleu74b" Content-Disposition: inline --p5r42g3rwoleu74b Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Tue, Feb 22, 2022 at 09:47:23AM +0100, Max Krummenacher wrote: > Use the new property bus-format to set the enum bus_format and bpc. > Completes: commit 4a1d0dbc8332 ("drm/panel: simple: add panel-dpi support= ") >=20 > Signed-off-by: Max Krummenacher >=20 > --- >=20 > drivers/gpu/drm/panel/panel-simple.c | 32 ++++++++++++++++++++++++++++ > 1 file changed, 32 insertions(+) >=20 > Relates to the discussion: https://lore.kernel.org/all/20220201110717.358= 5-1-cniedermaier@dh-electronics.com/ >=20 > Max >=20 > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel= /panel-simple.c > index c5f133667a2d..5c07260de71c 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -453,6 +453,7 @@ static int panel_dpi_probe(struct device *dev, > struct panel_desc *desc; > unsigned int bus_flags; > struct videomode vm; > + const char *format =3D ""; > int ret; > =20 > np =3D dev->of_node; > @@ -477,6 +478,37 @@ static int panel_dpi_probe(struct device *dev, > of_property_read_u32(np, "width-mm", &desc->size.width); > of_property_read_u32(np, "height-mm", &desc->size.height); > =20 > + of_property_read_string(np, "bus-format", &format); > + if (!strcmp(format, "BGR888_1X24")) { > + desc->bpc =3D 8; > + desc->bus_format =3D MEDIA_BUS_FMT_BGR888_1X24; > + } else if (!strcmp(format, "GBR888_1X24")) { > + desc->bpc =3D 8; > + desc->bus_format =3D MEDIA_BUS_FMT_GBR888_1X24; > + } else if (!strcmp(format, "RBG888_1X24")) { > + desc->bpc =3D 8; > + desc->bus_format =3D MEDIA_BUS_FMT_RBG888_1X24; > + } else if (!strcmp(format, "RGB444_1X12")) { > + desc->bpc =3D 6; > + desc->bus_format =3D MEDIA_BUS_FMT_RGB444_1X12; > + } else if (!strcmp(format, "RGB565_1X16")) { > + desc->bpc =3D 6; > + desc->bus_format =3D MEDIA_BUS_FMT_RGB565_1X16; > + } else if (!strcmp(format, "RGB666_1X18")) { > + desc->bpc =3D 6; > + desc->bus_format =3D MEDIA_BUS_FMT_RGB666_1X18; > + } else if (!strcmp(format, "RGB666_1X24_CPADHI")) { > + desc->bpc =3D 6; > + desc->bus_format =3D MEDIA_BUS_FMT_RGB666_1X24_CPADHI; > + } else if (!strcmp(format, "RGB888_1X24")) { > + desc->bpc =3D 8; > + desc->bus_format =3D MEDIA_BUS_FMT_RGB888_1X24; > + } else { > + dev_err(dev, "%pOF: missing or unknown bus-format property\n", > + np); > + return -EINVAL; > + } > + It doesn't seem right, really. We can't the bus format / bpc be inferred =66rom the compatible? I'd expect two panels that don't have the same bus format to not be claimed as compatible. Maxime --p5r42g3rwoleu74b Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYhY5ogAKCRDj7w1vZxhR xaKjAP9r35RESlRiF7rfKqiTJVl3wTvAIk9qVnbgg8tFEdcmBwD/ek7HxWjxgyUq ZOCPlrE47eND/Q51wIiHmf6Ce07QlQM= =wsWm -----END PGP SIGNATURE----- --p5r42g3rwoleu74b-- --===============3579437183819465113== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============3579437183819465113==--