From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E7CFFC433F5 for ; Wed, 23 Feb 2022 14:37:09 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3823B10E9AF; Wed, 23 Feb 2022 14:37:09 +0000 (UTC) Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) by gabe.freedesktop.org (Postfix) with ESMTPS id 747CB10E9AF for ; Wed, 23 Feb 2022 14:37:08 +0000 (UTC) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailnew.nyi.internal (Postfix) with ESMTP id 45D9A58019B; Wed, 23 Feb 2022 09:37:07 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 23 Feb 2022 09:37:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; bh=U1ztKaGkOzZJFAZ8G4o9Wx8yE8iWLSUjP9RjAb wql68=; b=sjFTMA9zm3lHctp0NjjQmmQB9RkDqqFIPIkZK3ZN9+Tt822gVCDVEq Avd/9ZObUfkyYeFjMTfugiGfiwuqC20CER7y54zzLLu4U4UxqM+TmRbWgx4rCjh5 CMzR7oOj+GBD4DPXovkAmya+GAU3CzDvWmDK5jwG7rlFNKn6r97tFGMIkrJHNRFI ehnyuoTOIpklwuGAQqOsPlqiXTjnpbScPOjtrx4q0VLRdkbnghHjynqBMHbLG6cw eBq5bdpXSbyY1dFi5NfenPMCOF6lip+Kzow6jm0BQuT1QsyWqh8xmZOlc/N1T8ZR uf6qL7DvhiykzwBr1/GjuZdIRburDJ1g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=U1ztKaGkOzZJFAZ8G 4o9Wx8yE8iWLSUjP9RjAbwql68=; b=FREHTqGOFi/nJplcCGWuhl4burgmXu1+T y7gdr1L4Yacgd/QCTVo/Wr5kXTaKO0CMM0QLhOrTWDhMwFJlZYu2++29EzC9NGjT fFJeO8zOGM7ohBUCP4/IFK6pNvYRnT8SWKS2T9q8llwlskaiR7NmDgEAImfPmN3o f7ZhNHAWp/ybZbILFTYbHgJYSLUSxYdz0hBbuWHyc4vFLnMWTepjT/jyxXgp05lU xIsUj0qCT51/QT28s/LP8KhcrOC6z5VLzHLinF+YTCYn22VAizeOVHxdWuNXCjgq aCwDGoMd0oOSgDN1/A82Mv2YdetcJr4wKvNHM6YBj2A7WGVB1heag== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrledtgdeihecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofgrgihimhgv ucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrghtth gvrhhnpeevveefffduveeitdegtefhhfetueffteefffdvheevvdehteethedvleffgfej vdenucffohhmrghinhepkhgvrhhnvghlrdhorhhgnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 23 Feb 2022 09:37:05 -0500 (EST) Date: Wed, 23 Feb 2022 15:37:03 +0100 From: Maxime Ripard To: Marek Vasut Subject: Re: [RFC PATCH] drm/panel: simple: panel-dpi: use bus-format to set bpc and bus_format Message-ID: <20220223143703.xi7vpamjg4ytmvqs@houat> References: <20220222084723.14310-1-max.krummenacher@toradex.com> <20220223134154.oo7xhf37bgtvm3ai@houat> <20220223134757.f5upi2iun27op5w5@houat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="6wpya4l5ynxm4fnp" Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Christoph Niedermaier , Max Krummenacher , Pengutronix Kernel Team , Max Krummenacher , David Airlie , Sam Ravnborg , Sascha Hauer , dri-devel@lists.freedesktop.org, DenysDrozdov , Laurent Pinchart , Shawn Guo , linux-arm-kernel@lists.infradead.org, NXP Linux Team Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" --6wpya4l5ynxm4fnp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 23, 2022 at 03:09:08PM +0100, Marek Vasut wrote: > On 2/23/22 14:47, Maxime Ripard wrote: > > On Wed, Feb 23, 2022 at 02:45:30PM +0100, Marek Vasut wrote: > > > On 2/23/22 14:41, Maxime Ripard wrote: > > > > Hi, > > > >=20 > > > > On Tue, Feb 22, 2022 at 09:47:23AM +0100, Max Krummenacher wrote: > > > > > Use the new property bus-format to set the enum bus_format and bp= c. > > > > > Completes: commit 4a1d0dbc8332 ("drm/panel: simple: add panel-dpi= support") > > > > >=20 > > > > > Signed-off-by: Max Krummenacher > > > > >=20 > > > > > --- > > > > >=20 > > > > > drivers/gpu/drm/panel/panel-simple.c | 32 ++++++++++++++++++++= ++++++++ > > > > > 1 file changed, 32 insertions(+) > > > > >=20 > > > > > Relates to the discussion: https://lore.kernel.org/all/2022020111= 0717.3585-1-cniedermaier@dh-electronics.com/ > > > > >=20 > > > > > Max > > > > >=20 > > > > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/d= rm/panel/panel-simple.c > > > > > index c5f133667a2d..5c07260de71c 100644 > > > > > --- a/drivers/gpu/drm/panel/panel-simple.c > > > > > +++ b/drivers/gpu/drm/panel/panel-simple.c > > > > > @@ -453,6 +453,7 @@ static int panel_dpi_probe(struct device *dev, > > > > > struct panel_desc *desc; > > > > > unsigned int bus_flags; > > > > > struct videomode vm; > > > > > + const char *format =3D ""; > > > > > int ret; > > > > > np =3D dev->of_node; > > > > > @@ -477,6 +478,37 @@ static int panel_dpi_probe(struct device *de= v, > > > > > of_property_read_u32(np, "width-mm", &desc->size.width); > > > > > of_property_read_u32(np, "height-mm", &desc->size.height); > > > > > + of_property_read_string(np, "bus-format", &format); > > > > > + if (!strcmp(format, "BGR888_1X24")) { > > > > > + desc->bpc =3D 8; > > > > > + desc->bus_format =3D MEDIA_BUS_FMT_BGR888_1X24; > > > > > + } else if (!strcmp(format, "GBR888_1X24")) { > > > > > + desc->bpc =3D 8; > > > > > + desc->bus_format =3D MEDIA_BUS_FMT_GBR888_1X24; > > > > > + } else if (!strcmp(format, "RBG888_1X24")) { > > > > > + desc->bpc =3D 8; > > > > > + desc->bus_format =3D MEDIA_BUS_FMT_RBG888_1X24; > > > > > + } else if (!strcmp(format, "RGB444_1X12")) { > > > > > + desc->bpc =3D 6; > > > > > + desc->bus_format =3D MEDIA_BUS_FMT_RGB444_1X12; > > > > > + } else if (!strcmp(format, "RGB565_1X16")) { > > > > > + desc->bpc =3D 6; > > > > > + desc->bus_format =3D MEDIA_BUS_FMT_RGB565_1X16; > > > > > + } else if (!strcmp(format, "RGB666_1X18")) { > > > > > + desc->bpc =3D 6; > > > > > + desc->bus_format =3D MEDIA_BUS_FMT_RGB666_1X18; > > > > > + } else if (!strcmp(format, "RGB666_1X24_CPADHI")) { > > > > > + desc->bpc =3D 6; > > > > > + desc->bus_format =3D MEDIA_BUS_FMT_RGB666_1X24_CPADHI; > > > > > + } else if (!strcmp(format, "RGB888_1X24")) { > > > > > + desc->bpc =3D 8; > > > > > + desc->bus_format =3D MEDIA_BUS_FMT_RGB888_1X24; > > > > > + } else { > > > > > + dev_err(dev, "%pOF: missing or unknown bus-format property\n", > > > > > + np); > > > > > + return -EINVAL; > > > > > + } > > > > > + > > > >=20 > > > > It doesn't seem right, really. We can't the bus format / bpc be inf= erred > > > > from the compatible? I'd expect two panels that don't have the same= bus > > > > format to not be claimed as compatible. > > >=20 > > > Which compatible ? > > >=20 > > > Note that this is for panel-dpi compatible, i.e. the panel which has = timings > > > specified in DT (and needs bus format specified there too). > >=20 > > panel-dpi is supposed to have two compatibles, the panel-specific one > > and panel-dpi. This would obviously be tied to the panel-specific one. >=20 > This whole discussion is about the one which only has 'panel-dpi' compati= ble > and describes the panel in DT completely. The specific compatible is not > present in DT when this patch is needed. =46rom the panel-dpi DT binding: properties: compatible: description: Shall contain a panel specific compatible and "panel-dpi" in that order. items: - {} - const: panel-dpi The panel-specific compatible is mandatory, whether you like it or not. Maxime --6wpya4l5ynxm4fnp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYhZGjwAKCRDj7w1vZxhR xdHLAQDQssPhht+kae52yacGtxmpSWshiwtBIdGc1/noGZc+SQD/eWWwRTC5dz7V KyMzwoV7YYbuLhqyeqUP8muHgP0cVAQ= =78y1 -----END PGP SIGNATURE----- --6wpya4l5ynxm4fnp-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A91E8C433EF for ; Wed, 23 Feb 2022 15:00:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zgL7DUjfiMn84yiNSQiz5roC0JLROSYd661H0gkY+w4=; b=yFkm1w7+qaaxroIAtzNkAew5ei oRV2AtoJPw7tnuNYD24+qnhHdV/qNPr2AMuWwTDq1JLY2h7vkp5hjPQ1jLAK6VCY4hVCQr5POTefE ypWwrJBlLTuaHtE7f6+eZRHH7cNHxEljw5udm8EGYLaHgQZixBZPeFIKJhHyRKD5DuBHmDJMrjdT6 rcRd6zVmO9Wy0MdWkHl0F6PeUhLXM+F90zkBGduLjwsvmGTwFjeNEuDChAKg+gxOOchBxKQZlPFqp 2xEq0O1bF7CD8F5T71GFlvKbDU7bKYbU/C+ocziwgiZcQPOPyG78RMi2YJQUnmI459fO0S5ToYfRe mTqk+J3Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nMt6Y-00Esbv-8A; Wed, 23 Feb 2022 14:58:59 +0000 Received: from new3-smtp.messagingengine.com ([66.111.4.229]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nMslS-00ElwX-H9 for linux-arm-kernel@lists.infradead.org; Wed, 23 Feb 2022 14:37:12 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailnew.nyi.internal (Postfix) with ESMTP id 45D9A58019B; Wed, 23 Feb 2022 09:37:07 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 23 Feb 2022 09:37:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; bh=U1ztKaGkOzZJFAZ8G4o9Wx8yE8iWLSUjP9RjAb wql68=; b=sjFTMA9zm3lHctp0NjjQmmQB9RkDqqFIPIkZK3ZN9+Tt822gVCDVEq Avd/9ZObUfkyYeFjMTfugiGfiwuqC20CER7y54zzLLu4U4UxqM+TmRbWgx4rCjh5 CMzR7oOj+GBD4DPXovkAmya+GAU3CzDvWmDK5jwG7rlFNKn6r97tFGMIkrJHNRFI ehnyuoTOIpklwuGAQqOsPlqiXTjnpbScPOjtrx4q0VLRdkbnghHjynqBMHbLG6cw eBq5bdpXSbyY1dFi5NfenPMCOF6lip+Kzow6jm0BQuT1QsyWqh8xmZOlc/N1T8ZR uf6qL7DvhiykzwBr1/GjuZdIRburDJ1g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=U1ztKaGkOzZJFAZ8G 4o9Wx8yE8iWLSUjP9RjAbwql68=; b=FREHTqGOFi/nJplcCGWuhl4burgmXu1+T y7gdr1L4Yacgd/QCTVo/Wr5kXTaKO0CMM0QLhOrTWDhMwFJlZYu2++29EzC9NGjT fFJeO8zOGM7ohBUCP4/IFK6pNvYRnT8SWKS2T9q8llwlskaiR7NmDgEAImfPmN3o f7ZhNHAWp/ybZbILFTYbHgJYSLUSxYdz0hBbuWHyc4vFLnMWTepjT/jyxXgp05lU xIsUj0qCT51/QT28s/LP8KhcrOC6z5VLzHLinF+YTCYn22VAizeOVHxdWuNXCjgq aCwDGoMd0oOSgDN1/A82Mv2YdetcJr4wKvNHM6YBj2A7WGVB1heag== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrledtgdeihecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofgrgihimhgv ucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrghtth gvrhhnpeevveefffduveeitdegtefhhfetueffteefffdvheevvdehteethedvleffgfej vdenucffohhmrghinhepkhgvrhhnvghlrdhorhhgnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 23 Feb 2022 09:37:05 -0500 (EST) Date: Wed, 23 Feb 2022 15:37:03 +0100 From: Maxime Ripard To: Marek Vasut Cc: Max Krummenacher , dri-devel@lists.freedesktop.org, Sascha Hauer , Philipp Zabel , Laurent Pinchart , Fabio Estevam , linux-arm-kernel@lists.infradead.org, DenysDrozdov , David Airlie , Christoph Niedermaier , Pengutronix Kernel Team , Sam Ravnborg , Shawn Guo , Daniel Vetter , NXP Linux Team , Max Krummenacher Subject: Re: [RFC PATCH] drm/panel: simple: panel-dpi: use bus-format to set bpc and bus_format Message-ID: <20220223143703.xi7vpamjg4ytmvqs@houat> References: <20220222084723.14310-1-max.krummenacher@toradex.com> <20220223134154.oo7xhf37bgtvm3ai@houat> <20220223134757.f5upi2iun27op5w5@houat> MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220223_063710_755562_F02D61C4 X-CRM114-Status: GOOD ( 28.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============7147154973540347434==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============7147154973540347434== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="6wpya4l5ynxm4fnp" Content-Disposition: inline --6wpya4l5ynxm4fnp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 23, 2022 at 03:09:08PM +0100, Marek Vasut wrote: > On 2/23/22 14:47, Maxime Ripard wrote: > > On Wed, Feb 23, 2022 at 02:45:30PM +0100, Marek Vasut wrote: > > > On 2/23/22 14:41, Maxime Ripard wrote: > > > > Hi, > > > >=20 > > > > On Tue, Feb 22, 2022 at 09:47:23AM +0100, Max Krummenacher wrote: > > > > > Use the new property bus-format to set the enum bus_format and bp= c. > > > > > Completes: commit 4a1d0dbc8332 ("drm/panel: simple: add panel-dpi= support") > > > > >=20 > > > > > Signed-off-by: Max Krummenacher > > > > >=20 > > > > > --- > > > > >=20 > > > > > drivers/gpu/drm/panel/panel-simple.c | 32 ++++++++++++++++++++= ++++++++ > > > > > 1 file changed, 32 insertions(+) > > > > >=20 > > > > > Relates to the discussion: https://lore.kernel.org/all/2022020111= 0717.3585-1-cniedermaier@dh-electronics.com/ > > > > >=20 > > > > > Max > > > > >=20 > > > > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/d= rm/panel/panel-simple.c > > > > > index c5f133667a2d..5c07260de71c 100644 > > > > > --- a/drivers/gpu/drm/panel/panel-simple.c > > > > > +++ b/drivers/gpu/drm/panel/panel-simple.c > > > > > @@ -453,6 +453,7 @@ static int panel_dpi_probe(struct device *dev, > > > > > struct panel_desc *desc; > > > > > unsigned int bus_flags; > > > > > struct videomode vm; > > > > > + const char *format =3D ""; > > > > > int ret; > > > > > np =3D dev->of_node; > > > > > @@ -477,6 +478,37 @@ static int panel_dpi_probe(struct device *de= v, > > > > > of_property_read_u32(np, "width-mm", &desc->size.width); > > > > > of_property_read_u32(np, "height-mm", &desc->size.height); > > > > > + of_property_read_string(np, "bus-format", &format); > > > > > + if (!strcmp(format, "BGR888_1X24")) { > > > > > + desc->bpc =3D 8; > > > > > + desc->bus_format =3D MEDIA_BUS_FMT_BGR888_1X24; > > > > > + } else if (!strcmp(format, "GBR888_1X24")) { > > > > > + desc->bpc =3D 8; > > > > > + desc->bus_format =3D MEDIA_BUS_FMT_GBR888_1X24; > > > > > + } else if (!strcmp(format, "RBG888_1X24")) { > > > > > + desc->bpc =3D 8; > > > > > + desc->bus_format =3D MEDIA_BUS_FMT_RBG888_1X24; > > > > > + } else if (!strcmp(format, "RGB444_1X12")) { > > > > > + desc->bpc =3D 6; > > > > > + desc->bus_format =3D MEDIA_BUS_FMT_RGB444_1X12; > > > > > + } else if (!strcmp(format, "RGB565_1X16")) { > > > > > + desc->bpc =3D 6; > > > > > + desc->bus_format =3D MEDIA_BUS_FMT_RGB565_1X16; > > > > > + } else if (!strcmp(format, "RGB666_1X18")) { > > > > > + desc->bpc =3D 6; > > > > > + desc->bus_format =3D MEDIA_BUS_FMT_RGB666_1X18; > > > > > + } else if (!strcmp(format, "RGB666_1X24_CPADHI")) { > > > > > + desc->bpc =3D 6; > > > > > + desc->bus_format =3D MEDIA_BUS_FMT_RGB666_1X24_CPADHI; > > > > > + } else if (!strcmp(format, "RGB888_1X24")) { > > > > > + desc->bpc =3D 8; > > > > > + desc->bus_format =3D MEDIA_BUS_FMT_RGB888_1X24; > > > > > + } else { > > > > > + dev_err(dev, "%pOF: missing or unknown bus-format property\n", > > > > > + np); > > > > > + return -EINVAL; > > > > > + } > > > > > + > > > >=20 > > > > It doesn't seem right, really. We can't the bus format / bpc be inf= erred > > > > from the compatible? I'd expect two panels that don't have the same= bus > > > > format to not be claimed as compatible. > > >=20 > > > Which compatible ? > > >=20 > > > Note that this is for panel-dpi compatible, i.e. the panel which has = timings > > > specified in DT (and needs bus format specified there too). > >=20 > > panel-dpi is supposed to have two compatibles, the panel-specific one > > and panel-dpi. This would obviously be tied to the panel-specific one. >=20 > This whole discussion is about the one which only has 'panel-dpi' compati= ble > and describes the panel in DT completely. The specific compatible is not > present in DT when this patch is needed. =46rom the panel-dpi DT binding: properties: compatible: description: Shall contain a panel specific compatible and "panel-dpi" in that order. items: - {} - const: panel-dpi The panel-specific compatible is mandatory, whether you like it or not. Maxime --6wpya4l5ynxm4fnp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYhZGjwAKCRDj7w1vZxhR xdHLAQDQssPhht+kae52yacGtxmpSWshiwtBIdGc1/noGZc+SQD/eWWwRTC5dz7V KyMzwoV7YYbuLhqyeqUP8muHgP0cVAQ= =78y1 -----END PGP SIGNATURE----- --6wpya4l5ynxm4fnp-- --===============7147154973540347434== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============7147154973540347434==--