All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Roopa Prabhu <roopa@nvidia.com>
Cc: <davem@davemloft.net>, <netdev@vger.kernel.org>,
	<stephen@networkplumber.org>, <nikolay@cumulusnetworks.com>,
	<idosch@nvidia.com>, <dsahern@gmail.com>, <bpoirier@nvidia.com>
Subject: Re: [PATCH net-next v2 11/12] drivers: vxlan: vnifilter: per vni stats
Date: Wed, 23 Feb 2022 20:02:06 -0800	[thread overview]
Message-ID: <20220223200206.20169386@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20220222025230.2119189-12-roopa@nvidia.com>

On Tue, 22 Feb 2022 02:52:29 +0000 Roopa Prabhu wrote:
> @@ -164,7 +166,6 @@ int vxlan_vnilist_update_group(struct vxlan_dev *vxlan,
>  			       union vxlan_addr *new_remote_ip,
>  			       struct netlink_ext_ack *extack);
>  
> -

spurious

>  /* vxlan_multicast.c */
>  int vxlan_multicast_join(struct vxlan_dev *vxlan);
>  int vxlan_multicast_leave(struct vxlan_dev *vxlan);

> +void vxlan_vnifilter_count(struct vxlan_dev *vxlan, __be32 vni,
> +			   int type, unsigned int len)
> +{
> +	struct vxlan_vni_node *vninode;
> +
> +	if (!(vxlan->cfg.flags & VXLAN_F_VNIFILTER))
> +		return;
> +
> +	vninode = vxlan_vnifilter_lookup(vxlan, vni);
> +	if (!vninode)
> +		return;

Don't we end up calling vxlan_vnifilter_lookup() multiple times for
every packet? Can't we remember the vninode from vxlan_vs_find_vni()?

> +	vxlan_vnifilter_stats_add(vninode, type, len);
> +}

  reply	other threads:[~2022-02-24  4:02 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-22  2:52 [PATCH net-next v2 00/12] vxlan metadata device vnifiltering support Roopa Prabhu
2022-02-22  2:52 ` [PATCH net-next v2 01/12] vxlan: move to its own directory Roopa Prabhu
2022-02-22  2:52 ` [PATCH net-next v2 02/12] vxlan_core: fix build warnings in vxlan_xmit_one Roopa Prabhu
2022-02-22  2:52 ` [PATCH net-next v2 03/12] vxlan_core: move common declarations to private header file Roopa Prabhu
2022-02-22  2:52 ` [PATCH net-next v2 04/12] vxlan_core: move some fdb helpers to non-static Roopa Prabhu
2022-02-22  2:52 ` [PATCH net-next v2 05/12] vxlan_core: make multicast helper take rip and ifindex explicitly Roopa Prabhu
2022-02-22  2:52 ` [PATCH net-next v2 06/12] vxlan_core: add helper vxlan_vni_in_use Roopa Prabhu
2022-02-22  2:52 ` [PATCH net-next v2 07/12] rtnetlink: add new rtm tunnel api for tunnel id filtering Roopa Prabhu
2022-02-23  1:26   ` Jakub Kicinski
2022-02-23  2:49     ` Roopa Prabhu
2022-02-23  3:50       ` Jakub Kicinski
2022-02-23  6:31         ` Roopa Prabhu
2022-02-23 16:22           ` Jakub Kicinski
2022-02-22  2:52 ` [PATCH net-next v2 08/12] vxlan_multicast: Move multicast helpers to a separate file Roopa Prabhu
2022-02-22  2:52 ` [PATCH net-next v2 09/12] vxlan: vni filtering support on collect metadata device Roopa Prabhu
2022-02-24  4:04   ` Jakub Kicinski
2022-02-25 17:50     ` Roopa Prabhu
2022-02-24  4:25   ` Jakub Kicinski
2022-02-25 18:00     ` Roopa Prabhu
2022-02-22  2:52 ` [PATCH net-next v2 10/12] selftests: add new tests for vxlan vnifiltering Roopa Prabhu
2022-02-22  2:52 ` [PATCH net-next v2 11/12] drivers: vxlan: vnifilter: per vni stats Roopa Prabhu
2022-02-24  4:02   ` Jakub Kicinski [this message]
2022-02-25 17:49     ` Roopa Prabhu
2022-02-25 22:34       ` Jakub Kicinski
2022-02-26  2:15         ` Roopa Prabhu
2022-02-22  2:52 ` [PATCH net-next v2 12/12] drivers: vxlan: vnifilter: add support for stats dumping Roopa Prabhu
2022-02-24  3:56   ` Jakub Kicinski
2022-02-24 17:19     ` Roopa Prabhu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220223200206.20169386@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
    --to=kuba@kernel.org \
    --cc=bpoirier@nvidia.com \
    --cc=davem@davemloft.net \
    --cc=dsahern@gmail.com \
    --cc=idosch@nvidia.com \
    --cc=netdev@vger.kernel.org \
    --cc=nikolay@cumulusnetworks.com \
    --cc=roopa@nvidia.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.