From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D503EC433EF for ; Wed, 23 Feb 2022 23:06:18 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 59DC183D44; Thu, 24 Feb 2022 00:04:56 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="e7TZos/v"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 26E4283D44; Thu, 24 Feb 2022 00:04:46 +0100 (CET) Received: from mail-oo1-xc2c.google.com (mail-oo1-xc2c.google.com [IPv6:2607:f8b0:4864:20::c2c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B2CF283CE4 for ; Thu, 24 Feb 2022 00:01:08 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-oo1-xc2c.google.com with SMTP id 189-20020a4a03c6000000b003179d7b30d8so850901ooi.2 for ; Wed, 23 Feb 2022 15:01:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=21kjcaMDSuXgkhu4cMApSwbLCHYHupKkosHyqgsVIrY=; b=e7TZos/vGhOu3sKgQDwrtVHLkbamHVeGbKQLxmW5AzVYew2RUj+ad0RHS8Y7uoh7Fv vPemYoUPMwmKe3bfHCo8k2ebOnUKdpKXU6RReeCu9s/tjBvnLhi2GrI/bt5laHPd1XNG edmqd7qu2uygrKGSzPiYR0Bz2IZY/g/sQ8t8k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=21kjcaMDSuXgkhu4cMApSwbLCHYHupKkosHyqgsVIrY=; b=YxuDoiXE7V7QRLrIrQEC0N3XxkQOeXtjBYAD5FGlVar+L3zECxRKJFmvOKCBt806r3 kzkyfdiAxPI8JsQgXZgjj2E137TeWmYPpQiZJUvnVLOv6YJVVHBeleS1v/i8ExdRNEDk KiXFuzrBIVLJl6RbzCoggI40obejNLWE7yTj/fugX9v1lO6O3+mkfN3Sm42IPIY34Rln 6wKZh2FYJ8DRw7lbB2JJtYcytY/iAZGvFgJbS3ozb9+leoM45ju3ogNo5SQPtLCQukiY Ejxnl+nnrEamoaGlujbIzZ0R9wBjUT5/kHuQSjOtltNDQcfFF+iW96zOZCkEjUk0oK8w T+Vw== X-Gm-Message-State: AOAM530T4s4E0cAkSBQCzpaYWU/k1LyM1Py6auXp8wNr62dRatn11gZ9 MKxifgSX60SmoTU3HMSIHYz0YmKmcjYy2g== X-Google-Smtp-Source: ABdhPJzPWRxGOt6AUecuBDtYhUhx93DcuX6/zidHmFh4BGQdTaoVjn0WJiyazEuYMSQz8jVALJ79cA== X-Received: by 2002:a05:6870:41cf:b0:d6:b8e4:868c with SMTP id z15-20020a05687041cf00b000d6b8e4868cmr1823151oac.282.1645657267295; Wed, 23 Feb 2022 15:01:07 -0800 (PST) Received: from kiwi.bld.corp.google.com (c-67-190-101-114.hsd1.co.comcast.net. [67.190.101.114]) by smtp.gmail.com with ESMTPSA id o2sm427507otl.9.2022.02.23.15.01.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Feb 2022 15:01:07 -0800 (PST) From: Simon Glass To: U-Boot Mailing List Cc: Ivan Mikhaylov , Tom Rini , Philippe Reynes , Roger Quadros , Alper Nebi Yasak , huang lin , Jeffy Chen , Simon Glass , Kever Yang , Philipp Tomsich Subject: [PATCH v2 15/25] binman: Read the fit entries only once Date: Wed, 23 Feb 2022 16:00:30 -0700 Message-Id: <20220223230040.159317-16-sjg@chromium.org> X-Mailer: git-send-email 2.35.1.574.g5d30c73bfb-goog In-Reply-To: <20220223230040.159317-1-sjg@chromium.org> References: <20220223230040.159317-1-sjg@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean At present the entries are read twice, once by the entry_Section class and once by the FIT implementation. This is harmless but can be confusing when debugging. Fix it. Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/etype/fit.py | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/binman/etype/fit.py b/tools/binman/etype/fit.py index 2b82955226..7b0c94dfee 100644 --- a/tools/binman/etype/fit.py +++ b/tools/binman/etype/fit.py @@ -185,7 +185,6 @@ class Entry_fit(Entry_section): self.mkimage = None def ReadNode(self): - self.ReadEntries() super().ReadNode() def _get_operation(self, subnode): -- 2.35.1.574.g5d30c73bfb-goog