From: Jacopo Mondi <jacopo@jmondi.org>
To: Steve Longerbeam <slongerbeam@gmail.com>
Cc: Jacopo Mondi <jacopo@jmondi.org>,
laurent.pinchart@ideasonboard.com, sakari.ailus@iki.fi,
hverkuil-cisco@xs4all.nl, mirela.rabulea@nxp.com,
xavier.roumegue@oss.nxp.com, tomi.valkeinen@ideasonboard.com,
hugues.fruchet@st.com, prabhakar.mahadev-lad.rj@bp.renesas.com,
aford173@gmail.com, festevam@gmail.com,
Eugen.Hristev@microchip.com, jbrunet@baylibre.com,
paul.elder@ideasonboard.com,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org
Subject: [PATCH v5 17/27] media: ov5640: Change CSI-2 timings to comply with FPS
Date: Thu, 24 Feb 2022 10:43:03 +0100 [thread overview]
Message-ID: <20220224094313.233347-18-jacopo@jmondi.org> (raw)
In-Reply-To: <20220224094313.233347-1-jacopo@jmondi.org>
Now that the frame duration can be controlled by tuning the VBLANK
duration in CSI-2 mode, fix all modes definitions to comply with the
reported FPS.
All modes run at 30 FPS except for full-resolution mode 2592x1944
which runs at 15FPS.
Tested on a 2 data lanes setup in UYVY and RGB565 modes in CSI-2 mode.
Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
drivers/media/i2c/ov5640.c | 30 +++++++++++++++---------------
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c
index 665a8bcebf09..6f10514e3c11 100644
--- a/drivers/media/i2c/ov5640.c
+++ b/drivers/media/i2c/ov5640.c
@@ -596,8 +596,8 @@ static const struct ov5640_mode_info ov5640_mode_data[OV5640_NUM_MODES] = {
.width = 160,
.height = 120,
},
- .htot = 1896,
- .vblank_def = 864,
+ .htot = 1600,
+ .vblank_def = 878,
},
.reg_data = ov5640_setting_low_res,
.reg_data_size = ARRAY_SIZE(ov5640_setting_low_res),
@@ -640,8 +640,8 @@ static const struct ov5640_mode_info ov5640_mode_data[OV5640_NUM_MODES] = {
.width = 176,
.height = 144,
},
- .htot = 1896,
- .vblank_def = 840,
+ .htot = 1600,
+ .vblank_def = 854,
},
.reg_data = ov5640_setting_low_res,
.reg_data_size = ARRAY_SIZE(ov5640_setting_low_res),
@@ -684,8 +684,8 @@ static const struct ov5640_mode_info ov5640_mode_data[OV5640_NUM_MODES] = {
.width = 320,
.height = 240,
},
- .htot = 1896,
- .vblank_def = 744,
+ .htot = 1600,
+ .vblank_def = 760,
},
.reg_data = ov5640_setting_low_res,
.reg_data_size = ARRAY_SIZE(ov5640_setting_low_res),
@@ -728,8 +728,8 @@ static const struct ov5640_mode_info ov5640_mode_data[OV5640_NUM_MODES] = {
.width = 640,
.height = 480,
},
- .htot = 1896,
- .vblank_def = 600,
+ .htot = 1600,
+ .vblank_def = 520,
},
.reg_data = ov5640_setting_low_res,
.reg_data_size = ARRAY_SIZE(ov5640_setting_low_res),
@@ -772,7 +772,7 @@ static const struct ov5640_mode_info ov5640_mode_data[OV5640_NUM_MODES] = {
.height = 480,
},
.htot = 1896,
- .vblank_def = 504,
+ .vblank_def = 1206,
},
.reg_data = ov5640_setting_low_res,
.reg_data_size = ARRAY_SIZE(ov5640_setting_low_res),
@@ -815,7 +815,7 @@ static const struct ov5640_mode_info ov5640_mode_data[OV5640_NUM_MODES] = {
.height = 576,
},
.htot = 1896,
- .vblank_def = 408,
+ .vblank_def = 1110,
},
.reg_data = ov5640_setting_low_res,
.reg_data_size = ARRAY_SIZE(ov5640_setting_low_res),
@@ -857,7 +857,7 @@ static const struct ov5640_mode_info ov5640_mode_data[OV5640_NUM_MODES] = {
.height = 768,
},
.htot = 1896,
- .vblank_def = 312,
+ .vblank_def = 918,
},
.reg_data = ov5640_setting_low_res,
.reg_data_size = ARRAY_SIZE(ov5640_setting_low_res),
@@ -898,8 +898,8 @@ static const struct ov5640_mode_info ov5640_mode_data[OV5640_NUM_MODES] = {
.width = 1280,
.height = 720,
},
- .htot = 1892,
- .vblank_def = 20,
+ .htot = 1600,
+ .vblank_def = 560,
},
.reg_data = ov5640_setting_720P_1280_720,
.reg_data_size = ARRAY_SIZE(ov5640_setting_720P_1280_720),
@@ -942,8 +942,8 @@ static const struct ov5640_mode_info ov5640_mode_data[OV5640_NUM_MODES] = {
.width = 1920,
.height = 1080,
},
- .htot = 2500,
- .vblank_def = 40,
+ .htot = 2234,
+ .vblank_def = 24,
},
.reg_data = ov5640_setting_1080P_1920_1080,
.reg_data_size = ARRAY_SIZE(ov5640_setting_1080P_1920_1080),
--
2.35.0
next prev parent reply other threads:[~2022-02-24 9:47 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-24 9:42 [PATCH v5 00/27] media: ov5640: Rework the clock tree programming for MIPI Jacopo Mondi
2022-02-24 9:42 ` [PATCH v5 01/27] media: ov5640: Add pixel rate to modes Jacopo Mondi
2022-02-24 9:42 ` [PATCH v5 02/27] media: ov5604: Re-arrange modes definition Jacopo Mondi
2022-02-24 9:42 ` [PATCH v5 03/27] media: ov5640: Add ov5640_is_csi2() function Jacopo Mondi
2022-02-24 9:42 ` [PATCH v5 04/27] media: ov5640: Associate bpp with formats Jacopo Mondi
2022-02-24 9:42 ` [PATCH v5 05/27] media: ov5640: Add LINK_FREQ control Jacopo Mondi
2022-02-24 9:42 ` [PATCH v5 06/27] media: ov5640: Update pixel_rate and link_freq Jacopo Mondi
2022-04-07 16:25 ` Hugues FRUCHET - FOSS
2022-04-11 16:46 ` Jacopo Mondi
2022-04-26 13:34 ` Hugues FRUCHET - FOSS
2022-02-24 9:42 ` [PATCH v5 07/27] media: ov5640: Rework CSI-2 clock tree Jacopo Mondi
2022-02-24 9:42 ` [PATCH v5 08/27] media: ov5640: Rework timings programming Jacopo Mondi
2022-02-24 9:42 ` [PATCH v5 09/27] media: ov5640: Fix 720x480 in RGB888 mode Jacopo Mondi
2022-02-24 9:42 ` [PATCH v5 10/27] media: ov5640: Split DVP and CSI-2 timings Jacopo Mondi
2022-02-24 9:42 ` [PATCH v5 11/27] media: ov5640: Provide timings accessor Jacopo Mondi
2022-02-24 9:42 ` [PATCH v5 12/27] media: ov5640: Re-sort per-mode register tables Jacopo Mondi
2022-02-24 9:42 ` [PATCH v5 13/27] media: ov5640: Remove duplicated mode settings Jacopo Mondi
2022-02-24 9:43 ` [PATCH v5 14/27] media: ov5640: Remove ov5640_mode_init_data Jacopo Mondi
2022-02-24 9:43 ` [PATCH v5 15/27] media: ov5640: Add HBLANK control Jacopo Mondi
2022-02-24 9:43 ` [PATCH v5 16/27] media: ov5640: Add VBLANK control Jacopo Mondi
2022-04-07 16:25 ` Hugues FRUCHET - FOSS
2022-04-11 15:42 ` Jacopo Mondi
2022-04-26 12:53 ` Hugues FRUCHET - FOSS
2022-04-26 13:58 ` Jacopo Mondi
2022-04-26 14:32 ` Hugues FRUCHET - FOSS
2022-02-24 9:43 ` Jacopo Mondi [this message]
2022-02-24 9:43 ` [PATCH v5 18/27] media: ov5640: Implement init_cfg Jacopo Mondi
2022-02-24 9:43 ` [PATCH v5 19/27] media: ov5640: Implement get_selection Jacopo Mondi
2022-02-24 9:43 ` [PATCH v5 20/27] media: ov5640: Limit frame_interval to DVP mode only Jacopo Mondi
2022-04-07 16:25 ` Hugues FRUCHET - FOSS
2022-04-08 16:08 ` Jacopo Mondi
2022-02-24 9:43 ` [PATCH v5 21/27] media: ov5640: Register device properties Jacopo Mondi
2022-02-24 9:43 ` [PATCH v5 22/27] media: ov5640: Add RGB565_1X16 format Jacopo Mondi
2022-02-24 9:43 ` [PATCH v5 23/27] media: ov5640: Add BGR888 format Jacopo Mondi
2022-02-24 9:43 ` [PATCH v5 24/27] media: ov5640: Restrict sizes to mbus code Jacopo Mondi
2022-02-24 9:43 ` [PATCH v5 25/27] media: ov5640: Adjust format to bpp in s_fmt Jacopo Mondi
2022-02-24 9:43 ` [PATCH v5 26/27] media: ov5640: Split DVP and CSI-2 formats Jacopo Mondi
2022-02-24 9:43 ` [PATCH v5 27/27] media: ov5640: Move format mux config in format Jacopo Mondi
2022-03-04 0:09 ` [PATCH v5 00/27] media: ov5640: Rework the clock tree programming for MIPI Sakari Ailus
2022-03-04 8:41 ` Eugen.Hristev
2022-03-04 8:45 ` Jacopo Mondi
2022-03-04 8:52 ` Sakari Ailus
2022-03-23 8:51 ` Tomi Valkeinen
2022-03-23 8:54 ` Sakari Ailus
2022-03-23 8:59 ` Laurent Pinchart
2022-03-23 9:50 ` Jacopo Mondi
2022-03-23 10:41 ` Laurent Pinchart
2022-03-28 14:57 ` Jacopo Mondi
2022-03-28 20:50 ` Sakari Ailus
2022-04-07 16:25 ` Hugues FRUCHET - FOSS
2022-04-08 11:05 ` Sakari Ailus
2022-04-26 12:32 ` Hugues FRUCHET - FOSS
2022-04-07 16:24 ` Hugues FRUCHET - FOSS
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220224094313.233347-18-jacopo@jmondi.org \
--to=jacopo@jmondi.org \
--cc=Eugen.Hristev@microchip.com \
--cc=aford173@gmail.com \
--cc=festevam@gmail.com \
--cc=hugues.fruchet@st.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jbrunet@baylibre.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mirela.rabulea@nxp.com \
--cc=paul.elder@ideasonboard.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=sakari.ailus@iki.fi \
--cc=slongerbeam@gmail.com \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=xavier.roumegue@oss.nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.