All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
To: laurent@vivier.eu, qemu-devel@nongnu.org
Subject: [PATCH v2 09/12] mos6522: record last_irq_levels in mos6522_set_irq()
Date: Thu, 24 Feb 2022 11:59:53 +0000	[thread overview]
Message-ID: <20220224115956.29997-10-mark.cave-ayland@ilande.co.uk> (raw)
In-Reply-To: <20220224115956.29997-1-mark.cave-ayland@ilande.co.uk>

To detect edge-triggered IRQs it is necessary to store the last state of each
IRQ in a last_irq_levels bitmap.

Note: this is a migration break for machines which use mos6522 instances which
are g3beige/mac99 (PPC) and q800 (m68k).

Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
---
 hw/misc/mos6522.c         | 11 +++++++++--
 include/hw/misc/mos6522.h |  1 +
 2 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/hw/misc/mos6522.c b/hw/misc/mos6522.c
index 38b5877ffa..60b3b693d0 100644
--- a/hw/misc/mos6522.c
+++ b/hw/misc/mos6522.c
@@ -72,6 +72,12 @@ static void mos6522_set_irq(void *opaque, int n, int level)
     }
 
     mos6522_update_irq(s);
+
+    if (level) {
+        s->last_irq_levels |= 1 << n;
+    } else {
+        s->last_irq_levels &= ~(1 << n);
+    }
 }
 
 static uint64_t get_counter_value(MOS6522State *s, MOS6522Timer *ti)
@@ -544,8 +550,8 @@ static const VMStateDescription vmstate_mos6522_timer = {
 
 const VMStateDescription vmstate_mos6522 = {
     .name = "mos6522",
-    .version_id = 0,
-    .minimum_version_id = 0,
+    .version_id = 1,
+    .minimum_version_id = 1,
     .fields = (VMStateField[]) {
         VMSTATE_UINT8(a, MOS6522State),
         VMSTATE_UINT8(b, MOS6522State),
@@ -556,6 +562,7 @@ const VMStateDescription vmstate_mos6522 = {
         VMSTATE_UINT8(pcr, MOS6522State),
         VMSTATE_UINT8(ifr, MOS6522State),
         VMSTATE_UINT8(ier, MOS6522State),
+        VMSTATE_UINT8(last_irq_levels, MOS6522State),
         VMSTATE_STRUCT_ARRAY(timers, MOS6522State, 2, 0,
                              vmstate_mos6522_timer, MOS6522Timer),
         VMSTATE_END_OF_LIST()
diff --git a/include/hw/misc/mos6522.h b/include/hw/misc/mos6522.h
index 846ded64b7..9ec9b57239 100644
--- a/include/hw/misc/mos6522.h
+++ b/include/hw/misc/mos6522.h
@@ -131,6 +131,7 @@ struct MOS6522State {
     uint64_t frequency;
 
     qemu_irq irq;
+    uint8_t last_irq_levels;
 };
 
 #define TYPE_MOS6522 "mos6522"
-- 
2.20.1



  parent reply	other threads:[~2022-02-24 12:17 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-24 11:59 [PATCH v2 00/12] mos6522: switch to gpios, add control line edge-triggering and extra debugging Mark Cave-Ayland
2022-02-24 11:59 ` [PATCH v2 01/12] mos6522: add defines for IFR bit flags Mark Cave-Ayland
2022-02-24 13:57   ` Philippe Mathieu-Daudé
2022-03-03 17:38   ` Laurent Vivier
2022-02-24 11:59 ` [PATCH v2 02/12] mac_via: use IFR bit flag constants for VIA1 IRQs Mark Cave-Ayland
2022-03-03 17:39   ` Laurent Vivier
2022-02-24 11:59 ` [PATCH v2 03/12] mac_via: use IFR bit flag constants for VIA2 IRQs Mark Cave-Ayland
2022-02-24 13:57   ` Philippe Mathieu-Daudé
2022-03-03 17:40   ` Laurent Vivier
2022-02-24 11:59 ` [PATCH v2 04/12] mos6522: switch over to use qdev gpios for IRQs Mark Cave-Ayland
2022-03-03 17:47   ` Laurent Vivier
2022-02-24 11:59 ` [PATCH v2 05/12] mos6522: remove update_irq() and set_sr_int() methods from MOS6522DeviceClass Mark Cave-Ayland
2022-03-03 17:47   ` Laurent Vivier
2022-02-24 11:59 ` [PATCH v2 06/12] mos6522: use device_class_set_parent_reset() to propagate reset to parent Mark Cave-Ayland
2022-03-03 19:52   ` Laurent Vivier
2022-02-24 11:59 ` [PATCH v2 07/12] mos6522: add register names to register read/write trace events Mark Cave-Ayland
2022-02-24 14:04   ` Philippe Mathieu-Daudé
2022-03-05 14:17     ` Mark Cave-Ayland
2022-03-05 14:32       ` Philippe Mathieu-Daudé
2022-03-03 19:54   ` Laurent Vivier
2022-02-24 11:59 ` [PATCH v2 08/12] mos6522: add "info via" HMP command for debugging Mark Cave-Ayland
2022-03-03 19:55   ` Laurent Vivier
2022-02-24 11:59 ` Mark Cave-Ayland [this message]
2022-03-03 19:56   ` [PATCH v2 09/12] mos6522: record last_irq_levels in mos6522_set_irq() Laurent Vivier
2022-02-24 11:59 ` [PATCH v2 10/12] mac_via: make SCSI_DATA (DRQ) bit live rather than latched Mark Cave-Ayland
2022-02-24 14:00   ` Philippe Mathieu-Daudé
2022-03-03 19:57   ` Laurent Vivier
2022-02-24 11:59 ` [PATCH v2 11/12] mos6522: implement edge-triggering for CA1/2 and CB1/2 control line IRQs Mark Cave-Ayland
2022-03-03 20:01   ` Laurent Vivier
2022-02-24 11:59 ` [PATCH v2 12/12] macio/pmu.c: remove redundant code Mark Cave-Ayland
2022-03-03 20:02   ` Laurent Vivier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220224115956.29997-10-mark.cave-ayland@ilande.co.uk \
    --to=mark.cave-ayland@ilande.co.uk \
    --cc=laurent@vivier.eu \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.