All of lore.kernel.org
 help / color / mirror / Atom feed
From: Henry Lin <henryl@nvidia.com>
To: <gregkh@linuxfoundation.org>
Cc: Henry Lin <henryl@nvidia.com>,
	Mathias Nyman <mathias.nyman@intel.com>,
	<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: [PATCH v2] xhci: fix runtime PM imbalance in USB2 resume
Date: Fri, 25 Feb 2022 15:15:06 +0800	[thread overview]
Message-ID: <20220225071506.22012-1-henryl@nvidia.com> (raw)
In-Reply-To: <20220225055311.92447-1-henryl@nvidia.com>

USB2 resume starts with usb_hcd_start_port_resume() in port status
change handling for RESUME link state. usb_hcd_end_port_resume() call is
needed to keep runtime PM balance.

Fixes: a231ec41e6f6 ("xhci: refactor U0 link state handling in get_port_status")
Signed-off-by: Henry Lin <henryl@nvidia.com>
---
 drivers/usb/host/xhci-hub.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/usb/host/xhci-hub.c b/drivers/usb/host/xhci-hub.c
index df3522dab31b..4a8b07b8ee01 100644
--- a/drivers/usb/host/xhci-hub.c
+++ b/drivers/usb/host/xhci-hub.c
@@ -1090,6 +1090,8 @@ static void xhci_get_usb2_port_status(struct xhci_port *port, u32 *status,
 		if (link_state == XDEV_U0) {
 			bus_state->resume_done[portnum] = 0;
 			clear_bit(portnum, &bus_state->resuming_ports);
+			usb_hcd_end_port_resume(&port->rhub->hcd->self,
+						portnum);
 			if (bus_state->suspended_ports & (1 << portnum)) {
 				bus_state->suspended_ports &= ~(1 << portnum);
 				bus_state->port_c_suspend |= 1 << portnum;
-- 
2.17.1


  parent reply	other threads:[~2022-02-25  7:15 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-25  5:53 [PATCH] xhci: fix runtime PM imbalance in USB2 resume Henry Lin
2022-02-25  6:23 ` Greg Kroah-Hartman
2022-02-25  6:40   ` Henry Lin
2022-02-25  6:49     ` Greg Kroah-Hartman
2022-02-25  7:02       ` Henry Lin
2022-02-25  7:15 ` Henry Lin [this message]
2022-02-25  9:16   ` [PATCH v2] " Greg KH
2022-02-26 16:06     ` Henry Lin
2022-02-26 16:20       ` Henry Lin
2022-02-28 10:56   ` Mathias Nyman
2022-03-01 10:28     ` Henry Lin
2022-03-01 15:49       ` Mathias Nyman
2022-03-01 19:18         ` Henry Lin
2022-03-02  6:51         ` [PATCH v3] " Henry Lin
2022-03-02  9:16           ` Mathias Nyman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220225071506.22012-1-henryl@nvidia.com \
    --to=henryl@nvidia.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.