From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9495C433FE for ; Fri, 25 Feb 2022 12:58:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240838AbiBYM6t (ORCPT ); Fri, 25 Feb 2022 07:58:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43366 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232670AbiBYM6r (ORCPT ); Fri, 25 Feb 2022 07:58:47 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 85DE714FFFE; Fri, 25 Feb 2022 04:58:15 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 3D4CAB82F79; Fri, 25 Feb 2022 12:58:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C68B6C340E7; Fri, 25 Feb 2022 12:58:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1645793893; bh=yXNshXV8iIu7D0QVOExyxryhfq/he3SIhXZTLLv/Cos=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uLwe9KLo89Nib7HAZFqLVK/37FznuJAkVKorOG+qTB9XTpwuqAFkoQC6K79+86FoE 2HUAiZcBSIzsMXwfwFf5oye8uSVbL7kMYmpwS9fRuWEnwt0zKPOROcTXO+cBzkuRsO IgOkGY0XeJaI8x6fy5tXh7jt5AiMNVJIpm/O8+/itqfk/emur0v7ExOIwBA+zFASst VliY0+I2ReoymJUGSaxBS+SCvQuhBQ0XKRKUhCdSWnItMhqrPxIAFhRyzv7fQOW2B1 nOzdp0l4BNtNMxNx5T7veOmCAihQbiunDw8zJfqZIVkc24wTrEy4UY45QmwMTSx/YO IfyqeaWdYlLcA== Received: by pali.im (Postfix) id 62D427EF; Fri, 25 Feb 2022 13:58:10 +0100 (CET) Date: Fri, 25 Feb 2022 13:58:10 +0100 From: Pali =?utf-8?B?Um9ow6Fy?= To: Bjorn Helgaas Cc: Lorenzo Pieralisi , Bjorn Helgaas , Rob Herring , Thomas Petazzoni , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Marek =?utf-8?B?QmVow7pu?= , Russell King , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 04/12] dt-bindings: PCI: mvebu: Add num-lanes property Message-ID: <20220225125810.7mbo7firer5yodls@pali> References: <20220222155030.988-5-pali@kernel.org> <20220225000226.GA304258@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220225000226.GA304258@bhelgaas> User-Agent: NeoMutt/20180716 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 24 February 2022 18:02:26 Bjorn Helgaas wrote: > On Tue, Feb 22, 2022 at 04:50:22PM +0100, Pali Rohár wrote: > > Controller driver needs to correctly configure PCIe link if it contains 1 > > or 4 SerDes PCIe lanes. Therefore add a new 'num-lanes' DT property for > > mvebu PCIe controller. Property 'num-lanes' seems to be de-facto standard > > way how number of lanes is specified in other PCIe controllers. > > > > Signed-off-by: Pali Rohár > > Acked-by: Rob Herring > > --- > > Documentation/devicetree/bindings/pci/mvebu-pci.txt | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/pci/mvebu-pci.txt b/Documentation/devicetree/bindings/pci/mvebu-pci.txt > > index 6173af6885f8..24225852bce0 100644 > > --- a/Documentation/devicetree/bindings/pci/mvebu-pci.txt > > +++ b/Documentation/devicetree/bindings/pci/mvebu-pci.txt > > @@ -77,6 +77,7 @@ and the following optional properties: > > - marvell,pcie-lane: the physical PCIe lane number, for ports having > > multiple lanes. If this property is not found, we assume that the > > value is 0. > > +- num-lanes: number of SerDes PCIe lanes for this link (1 or 4) > > - reset-gpios: optional GPIO to PERST# > > - reset-delay-us: delay in us to wait after reset de-assertion, if not > > specified will default to 100ms, as required by the PCIe specification. > > @@ -141,6 +142,7 @@ pcie-controller { > > interrupt-map = <0 0 0 0 &mpic 58>; > > marvell,pcie-port = <0>; > > marvell,pcie-lane = <0>; > > + num-lanes = <1>; > > Is this patch really necessary? This is just documentation patch. And I think that documentation is always important. > AFAICS, the related driver change > only sets "port->is_x4 = true" when "num-lanes = <4>", and in all > other cases it defaults to a Max Link Width of 1: > > lnkcap |= (port->is_x4 ? 4 : 1) << 4; Yes! And this registers configures number of lanes in HW. > I don't see the point of adding a value that we don't validate or do > anything with. E.g., I don't see an error message that would catch > "num-lanes = <3>". > > Bjorn In past I was told that kernel should not do validation of DT properties and it is job of some DT schema validation. That is why I did not added code into kernel which show error message when value different than 1 and 4 is specified in DT. But issue here is that there is no DT schema for pci-mvebu as above .txt file was not converted to YAML schema yet. This is something which should be improved... From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F3270C433EF for ; Fri, 25 Feb 2022 12:59:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PyDeu4v9RqU/yMaJ0vDqSk0KQqZ9OYKnZjZaLrFaUQ4=; b=Za1kiJr+SSgWdq 8KVAIKK10km2Haoo2rrwV51dnabs2+Y3QBWBc25cTiIXS6uh3UbadNloZQe2fD3eJBFCFYKOaTIO4 i3kLf8/ngbbhpMV6xX69Z6xb5VIaiRFZoP0VWQsy5NkgBk9jWp/Aw8M83rIg1KdnlhtBTnaLj7KAA LZOOi1kX5WNtmlR2Pzf7E4cERmJ5wA/VsI3lWTnFmpzyLWjiKvsCK3KJUxYgNBu3CWKAkw1G1FIqe rwQ/IzLGIH++zn8K1HqZnUoqY7PoiKiMzAv58a1VLkd4rAz73Gf7Euo8iGP/5H8eD6W7Ga1MWlVqf IxYbQiVxAB5rQrTlcZdA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nNaAr-004xXZ-7N; Fri, 25 Feb 2022 12:58:17 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nNaAn-004xWk-Pk for linux-arm-kernel@lists.infradead.org; Fri, 25 Feb 2022 12:58:15 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 26C7261C27; Fri, 25 Feb 2022 12:58:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C68B6C340E7; Fri, 25 Feb 2022 12:58:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1645793893; bh=yXNshXV8iIu7D0QVOExyxryhfq/he3SIhXZTLLv/Cos=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uLwe9KLo89Nib7HAZFqLVK/37FznuJAkVKorOG+qTB9XTpwuqAFkoQC6K79+86FoE 2HUAiZcBSIzsMXwfwFf5oye8uSVbL7kMYmpwS9fRuWEnwt0zKPOROcTXO+cBzkuRsO IgOkGY0XeJaI8x6fy5tXh7jt5AiMNVJIpm/O8+/itqfk/emur0v7ExOIwBA+zFASst VliY0+I2ReoymJUGSaxBS+SCvQuhBQ0XKRKUhCdSWnItMhqrPxIAFhRyzv7fQOW2B1 nOzdp0l4BNtNMxNx5T7veOmCAihQbiunDw8zJfqZIVkc24wTrEy4UY45QmwMTSx/YO IfyqeaWdYlLcA== Received: by pali.im (Postfix) id 62D427EF; Fri, 25 Feb 2022 13:58:10 +0100 (CET) Date: Fri, 25 Feb 2022 13:58:10 +0100 From: Pali =?utf-8?B?Um9ow6Fy?= To: Bjorn Helgaas Cc: Lorenzo Pieralisi , Bjorn Helgaas , Rob Herring , Thomas Petazzoni , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Marek =?utf-8?B?QmVow7pu?= , Russell King , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 04/12] dt-bindings: PCI: mvebu: Add num-lanes property Message-ID: <20220225125810.7mbo7firer5yodls@pali> References: <20220222155030.988-5-pali@kernel.org> <20220225000226.GA304258@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220225000226.GA304258@bhelgaas> User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220225_045813_940075_EFCA1CB4 X-CRM114-Status: GOOD ( 29.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1cnNkYXkgMjQgRmVicnVhcnkgMjAyMiAxODowMjoyNiBCam9ybiBIZWxnYWFzIHdyb3Rl Ogo+IE9uIFR1ZSwgRmViIDIyLCAyMDIyIGF0IDA0OjUwOjIyUE0gKzAxMDAsIFBhbGkgUm9ow6Fy IHdyb3RlOgo+ID4gQ29udHJvbGxlciBkcml2ZXIgbmVlZHMgdG8gY29ycmVjdGx5IGNvbmZpZ3Vy ZSBQQ0llIGxpbmsgaWYgaXQgY29udGFpbnMgMQo+ID4gb3IgNCBTZXJEZXMgUENJZSBsYW5lcy4g VGhlcmVmb3JlIGFkZCBhIG5ldyAnbnVtLWxhbmVzJyBEVCBwcm9wZXJ0eSBmb3IKPiA+IG12ZWJ1 IFBDSWUgY29udHJvbGxlci4gUHJvcGVydHkgJ251bS1sYW5lcycgc2VlbXMgdG8gYmUgZGUtZmFj dG8gc3RhbmRhcmQKPiA+IHdheSBob3cgbnVtYmVyIG9mIGxhbmVzIGlzIHNwZWNpZmllZCBpbiBv dGhlciBQQ0llIGNvbnRyb2xsZXJzLgo+ID4gCj4gPiBTaWduZWQtb2ZmLWJ5OiBQYWxpIFJvaMOh ciA8cGFsaUBrZXJuZWwub3JnPgo+ID4gQWNrZWQtYnk6IFJvYiBIZXJyaW5nIDxyb2JoQGtlcm5l bC5vcmc+Cj4gPiAtLS0KPiA+ICBEb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvcGNp L212ZWJ1LXBjaS50eHQgfCAxMSArKysrKysrKysrKwo+ID4gIDEgZmlsZSBjaGFuZ2VkLCAxMSBp bnNlcnRpb25zKCspCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9Eb2N1bWVudGF0aW9uL2RldmljZXRy ZWUvYmluZGluZ3MvcGNpL212ZWJ1LXBjaS50eHQgYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUv YmluZGluZ3MvcGNpL212ZWJ1LXBjaS50eHQKPiA+IGluZGV4IDYxNzNhZjY4ODVmOC4uMjQyMjU4 NTJiY2UwIDEwMDY0NAo+ID4gLS0tIGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdz L3BjaS9tdmVidS1wY2kudHh0Cj4gPiArKysgYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmlu ZGluZ3MvcGNpL212ZWJ1LXBjaS50eHQKPiA+IEBAIC03Nyw2ICs3Nyw3IEBAIGFuZCB0aGUgZm9s bG93aW5nIG9wdGlvbmFsIHByb3BlcnRpZXM6Cj4gPiAgLSBtYXJ2ZWxsLHBjaWUtbGFuZTogdGhl IHBoeXNpY2FsIFBDSWUgbGFuZSBudW1iZXIsIGZvciBwb3J0cyBoYXZpbmcKPiA+ICAgIG11bHRp cGxlIGxhbmVzLiBJZiB0aGlzIHByb3BlcnR5IGlzIG5vdCBmb3VuZCwgd2UgYXNzdW1lIHRoYXQg dGhlCj4gPiAgICB2YWx1ZSBpcyAwLgo+ID4gKy0gbnVtLWxhbmVzOiBudW1iZXIgb2YgU2VyRGVz IFBDSWUgbGFuZXMgZm9yIHRoaXMgbGluayAoMSBvciA0KQo+ID4gIC0gcmVzZXQtZ3Bpb3M6IG9w dGlvbmFsIEdQSU8gdG8gUEVSU1QjCj4gPiAgLSByZXNldC1kZWxheS11czogZGVsYXkgaW4gdXMg dG8gd2FpdCBhZnRlciByZXNldCBkZS1hc3NlcnRpb24sIGlmIG5vdAo+ID4gICAgc3BlY2lmaWVk IHdpbGwgZGVmYXVsdCB0byAxMDBtcywgYXMgcmVxdWlyZWQgYnkgdGhlIFBDSWUgc3BlY2lmaWNh dGlvbi4KPiA+IEBAIC0xNDEsNiArMTQyLDcgQEAgcGNpZS1jb250cm9sbGVyIHsKPiA+ICAJCWlu dGVycnVwdC1tYXAgPSA8MCAwIDAgMCAmbXBpYyA1OD47Cj4gPiAgCQltYXJ2ZWxsLHBjaWUtcG9y dCA9IDwwPjsKPiA+ICAJCW1hcnZlbGwscGNpZS1sYW5lID0gPDA+Owo+ID4gKwkJbnVtLWxhbmVz ID0gPDE+Owo+IAo+IElzIHRoaXMgcGF0Y2ggcmVhbGx5IG5lY2Vzc2FyeT8KClRoaXMgaXMganVz dCBkb2N1bWVudGF0aW9uIHBhdGNoLiBBbmQgSSB0aGluayB0aGF0IGRvY3VtZW50YXRpb24gaXMK YWx3YXlzIGltcG9ydGFudC4KCj4gQUZBSUNTLCB0aGUgcmVsYXRlZCBkcml2ZXIgY2hhbmdlCj4g b25seSBzZXRzICJwb3J0LT5pc194NCA9IHRydWUiIHdoZW4gIm51bS1sYW5lcyA9IDw0PiIsIGFu ZCBpbiBhbGwKPiBvdGhlciBjYXNlcyBpdCBkZWZhdWx0cyB0byBhIE1heCBMaW5rIFdpZHRoIG9m IDE6Cj4gCj4gICBsbmtjYXAgfD0gKHBvcnQtPmlzX3g0ID8gNCA6IDEpIDw8IDQ7CgpZZXMhCgpB bmQgdGhpcyByZWdpc3RlcnMgY29uZmlndXJlcyBudW1iZXIgb2YgbGFuZXMgaW4gSFcuCgo+IEkg ZG9uJ3Qgc2VlIHRoZSBwb2ludCBvZiBhZGRpbmcgYSB2YWx1ZSB0aGF0IHdlIGRvbid0IHZhbGlk YXRlIG9yIGRvCj4gYW55dGhpbmcgd2l0aC4gIEUuZy4sIEkgZG9uJ3Qgc2VlIGFuIGVycm9yIG1l c3NhZ2UgdGhhdCB3b3VsZCBjYXRjaAo+ICJudW0tbGFuZXMgPSA8Mz4iLgo+IAo+IEJqb3JuCgpJ biBwYXN0IEkgd2FzIHRvbGQgdGhhdCBrZXJuZWwgc2hvdWxkIG5vdCBkbyB2YWxpZGF0aW9uIG9m IERUIHByb3BlcnRpZXMKYW5kIGl0IGlzIGpvYiBvZiBzb21lIERUIHNjaGVtYSB2YWxpZGF0aW9u LiBUaGF0IGlzIHdoeSBJIGRpZCBub3QgYWRkZWQKY29kZSBpbnRvIGtlcm5lbCB3aGljaCBzaG93 IGVycm9yIG1lc3NhZ2Ugd2hlbiB2YWx1ZSBkaWZmZXJlbnQgdGhhbiAxCmFuZCA0IGlzIHNwZWNp ZmllZCBpbiBEVC4KCkJ1dCBpc3N1ZSBoZXJlIGlzIHRoYXQgdGhlcmUgaXMgbm8gRFQgc2NoZW1h IGZvciBwY2ktbXZlYnUgYXMgYWJvdmUKLnR4dCBmaWxlIHdhcyBub3QgY29udmVydGVkIHRvIFlB TUwgc2NoZW1hIHlldC4gVGhpcyBpcyBzb21ldGhpbmcgd2hpY2gKc2hvdWxkIGJlIGltcHJvdmVk Li4uCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51 eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVh ZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1h cm0ta2VybmVsCg==