From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32BC5C433FE for ; Fri, 25 Feb 2022 16:02:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242556AbiBYQDN (ORCPT ); Fri, 25 Feb 2022 11:03:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54688 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242554AbiBYQDK (ORCPT ); Fri, 25 Feb 2022 11:03:10 -0500 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F36264BEC; Fri, 25 Feb 2022 08:02:34 -0800 (PST) Received: by verein.lst.de (Postfix, from userid 2407) id AD37B68AA6; Fri, 25 Feb 2022 17:02:31 +0100 (CET) Date: Fri, 25 Feb 2022 17:02:31 +0100 From: Christoph Hellwig To: Keith Busch Cc: linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, linux-crypto@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, axboe@kernel.dk, hch@lst.de, martin.petersen@oracle.com, colyli@suse.de, Hannes Reinecke Subject: Re: [PATCHv3 02/10] nvme: allow integrity on extended metadata formats Message-ID: <20220225160231.GB13610@lst.de> References: <20220222163144.1782447-1-kbusch@kernel.org> <20220222163144.1782447-3-kbusch@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220222163144.1782447-3-kbusch@kernel.org> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Tue, Feb 22, 2022 at 08:31:36AM -0800, Keith Busch wrote: > The block integrity subsystem knows how to construct protection > information buffers with metadata beyond the protection information > fields. Remove the driver restriction. > > Note, this can only work if the PI field appears first in the metadata, > as the integrity subsystem doesn't calculate guard tags on preceding > metadata. > > Reviewed-by: Hannes Reinecke > Reviewed-by: Martin K. Petersen > Signed-off-by: Keith Busch Looks good, Reviewed-by: Christoph Hellwig