From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C998C433F5 for ; Mon, 28 Feb 2022 09:22:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234259AbiB1JXD (ORCPT ); Mon, 28 Feb 2022 04:23:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43288 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232390AbiB1JW7 (ORCPT ); Mon, 28 Feb 2022 04:22:59 -0500 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E54CF57B2E for ; Mon, 28 Feb 2022 01:22:20 -0800 (PST) Received: by verein.lst.de (Postfix, from userid 2407) id 3971168AA6; Mon, 28 Feb 2022 10:22:16 +0100 (CET) Date: Mon, 28 Feb 2022 10:22:15 +0100 From: Christoph Hellwig To: Enzo Matsumiya Cc: linux-nvme@lists.infradead.org, Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , linux-kernel@vger.kernel.org Subject: Re: [PATCH] nvme-pci: trigger disk activity LED Message-ID: <20220228092215.GA8549@lst.de> References: <20220227234258.24619-1-ematsumiya@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220227234258.24619-1-ematsumiya@suse.de> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I don't think we should add code to the absolutel fast path for blinkenlights.