All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Mateusz Jończyk" <mat.jonczyk@o2.pl>
To: linux-kernel@vger.kernel.org, x86@kernel.org
Cc: "Mateusz Jończyk" <mat.jonczyk@o2.pl>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Ingo Molnar" <mingo@redhat.com>,
	"Borislav Petkov" <bp@alien8.de>,
	"Dave Hansen" <dave.hansen@linux.intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	"Johan Hovold" <johan@kernel.org>,
	"Maciej W. Rozycki" <macro@orcam.me.uk>,
	"Yinghai Lu" <yinghai@kernel.org>
Subject: [PATCH 02/10] x86/apic: fix panic message when x2APIC is not supported
Date: Mon, 28 Feb 2022 22:28:18 +0100	[thread overview]
Message-ID: <20220228212826.27080-3-mat.jonczyk@o2.pl> (raw)
In-Reply-To: <20220228212826.27080-1-mat.jonczyk@o2.pl>

The correct course of action is to enable x2APIC support in the kernel,
not to disable it in the BIOS (which may be impossible).
x2APIC has performance and functionality benefits, so it is best to use
it if it is available on the platform.

Signed-off-by: Mateusz Jończyk <mat.jonczyk@o2.pl>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: x86@kernel.org
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Johan Hovold <johan@kernel.org>
Cc: "Maciej W. Rozycki" <macro@orcam.me.uk>
Cc: Yinghai Lu <yinghai@kernel.org>
---
 arch/x86/kernel/apic/apic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c
index b70344bf6600..840511aadbca 100644
--- a/arch/x86/kernel/apic/apic.c
+++ b/arch/x86/kernel/apic/apic.c
@@ -1899,7 +1899,7 @@ static int __init validate_x2apic(void)
 	/*
 	 * Checkme: Can we simply turn off x2apic here instead of panic?
 	 */
-	panic("BIOS has enabled x2apic but kernel doesn't support x2apic, please disable x2apic in BIOS.\n");
+	panic("Kernel does not support x2APIC, please recompile with CONFIG_X86_X2APIC or disable x2APIC in BIOS");
 }
 early_initcall(validate_x2apic);
 
-- 
2.25.1


  parent reply	other threads:[~2022-02-28 21:29 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-28 21:28 [PATCH 00/10] x86: Kconfig cleanups and help text improvements Mateusz Jończyk
2022-02-28 21:28 ` [PATCH 01/10] x86/Kconfig: enable X86_X2APIC by default and improve help text Mateusz Jończyk
2022-02-28 21:35   ` Randy Dunlap
2022-02-28 21:28 ` Mateusz Jończyk [this message]
2022-02-28 21:28 ` [PATCH 03/10] x86/Kconfig: always enable ARCH_SPARSEMEM_ENABLE Mateusz Jończyk
2022-02-28 21:28 ` [PATCH 04/10] x86/Kconfig: drop X86_32_NON_STANDARD Mateusz Jończyk
2022-02-28 21:28 ` [PATCH 05/10] x86/Kconfig: move all X86_EXTENDED_PLATFORM options together Mateusz Jończyk
2022-02-28 21:28 ` [PATCH 06/10] x86/Kconfig: update lists in X86_EXTENDED_PLATFORM Mateusz Jończyk
2022-02-28 21:28 ` [PATCH 07/10] x86/Kconfig: add help text to CONFIG_PCI_MMCONFIG Mateusz Jończyk
2022-02-28 21:28 ` [PATCH 08/10] x86/Kconfig: improve CONFIG_PCI_CNB20LE_QUIRK doc Mateusz Jończyk
2022-02-28 21:28 ` [PATCH 09/10] x86/Kconfig: document year of release of glibc 2.3.3 Mateusz Jończyk
2022-02-28 21:28 ` [PATCH 10/10] x86/Kconfig: remove CONFIG_ISA_BUS Mateusz Jończyk
2022-02-28 23:26   ` William Breathitt Gray

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220228212826.27080-3-mat.jonczyk@o2.pl \
    --to=mat.jonczyk@o2.pl \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=johan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=macro@orcam.me.uk \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.