From: kernel test robot <lkp@intel.com>
To: Muchun Song <songmuchun@bytedance.com>,
corbet@lwn.net, mike.kravetz@oracle.com,
akpm@linux-foundation.org, mcgrof@kernel.org,
keescook@chromium.org, yzaikin@google.com
Cc: kbuild-all@lists.01.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
duanxiongchun@bytedance.com,
Muchun Song <songmuchun@bytedance.com>
Subject: Re: [PATCH 3/3] mm: hugetlb: add hugetlb_free_vmemmap sysctl
Date: Tue, 1 Mar 2022 01:37:10 +0800 [thread overview]
Message-ID: <202203010141.TqyZvdm5-lkp@intel.com> (raw)
In-Reply-To: <20220228071022.26143-4-songmuchun@bytedance.com>
Hi Muchun,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on hnaz-mm/master]
[also build test ERROR on next-20220225]
[cannot apply to mcgrof/sysctl-next linus/master v5.17-rc6]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Muchun-Song/add-hugetlb_free_vmemmap-sysctl/20220228-151303
base: https://github.com/hnaz/linux-mm master
config: x86_64-randconfig-c022 (https://download.01.org/0day-ci/archive/20220301/202203010141.TqyZvdm5-lkp@intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/a2a3193fd949ff24ed0c138ef495e67373839483
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Muchun-Song/add-hugetlb_free_vmemmap-sysctl/20220228-151303
git checkout a2a3193fd949ff24ed0c138ef495e67373839483
# save the config file to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
mm/hugetlb_vmemmap.c: In function 'hugetlb_vmemmap_sysctl_handler':
>> mm/hugetlb_vmemmap.c:156:55: error: 'memmap_on_memory' undeclared (first use in this function)
156 | if (write && (!is_power_of_2(sizeof(struct page)) || memmap_on_memory))
| ^~~~~~~~~~~~~~~~
mm/hugetlb_vmemmap.c:156:55: note: each undeclared identifier is reported only once for each function it appears in
vim +/memmap_on_memory +156 mm/hugetlb_vmemmap.c
148
149 int hugetlb_vmemmap_sysctl_handler(struct ctl_table *table, int write,
150 void *buffer, size_t *length, loff_t *ppos)
151 {
152 /*
153 * The vmemmap pages cannot be optimized if a "struct page" crosses page
154 * boundaries or memory_hotplug.memmap_on_memory is enabled.
155 */
> 156 if (write && (!is_power_of_2(sizeof(struct page)) || memmap_on_memory))
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
prev parent reply other threads:[~2022-02-28 17:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-28 7:10 [PATCH 0/3] add hugetlb_free_vmemmap sysctl Muchun Song
2022-02-28 7:10 ` [PATCH 1/3] mm: hugetlb: disable freeing vmemmap pages when struct page crosses page boundaries Muchun Song
2022-02-28 7:10 ` [PATCH 2/3] sysctl: allow to set extra1 to SYSCTL_ONE Muchun Song
2022-02-28 7:10 ` [PATCH 3/3] mm: hugetlb: add hugetlb_free_vmemmap sysctl Muchun Song
2022-02-28 14:41 ` Luis Chamberlain
2022-02-28 15:14 ` Muchun Song
2022-02-28 17:35 ` kernel test robot
2022-02-28 17:37 ` kernel test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202203010141.TqyZvdm5-lkp@intel.com \
--to=lkp@intel.com \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=duanxiongchun@bytedance.com \
--cc=kbuild-all@lists.01.org \
--cc=keescook@chromium.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mcgrof@kernel.org \
--cc=mike.kravetz@oracle.com \
--cc=songmuchun@bytedance.com \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.