From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE951C433EF for ; Tue, 1 Mar 2022 15:16:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235622AbiCAPQx (ORCPT ); Tue, 1 Mar 2022 10:16:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58878 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235612AbiCAPQu (ORCPT ); Tue, 1 Mar 2022 10:16:50 -0500 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 747B442A25; Tue, 1 Mar 2022 07:16:09 -0800 (PST) Received: by mail-wr1-f49.google.com with SMTP id ay10so3203029wrb.6; Tue, 01 Mar 2022 07:16:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=BvtC0gtJjFUWH0cUPU8+itqu2Xz/0icFEi9nJd4dxj0=; b=ZMU4dZteagywb0X11gf0O4d7xfEEWUSwOdW6b1c4jompLAJy4D1HHivUkDzspjlODm NB0wIkVVSEkPqZKMfTvgnf5O+OZ5urasnCCXqJfuV/RMlXv+umSZ6jRHBy476wh0Yc6h rH508A+moeH4Vr9ldMtnitxwjBribNUA3sQervaWZW6m5rc00kYT7NiN2ft82Y3XYjU/ 9KiZBsw4gweisjmJySXfTGWwtmN4WpKltlZ2huVJqw+Bw60MybU2gE9/s09oJYFhu3Ll N1VGkuiPitIJ+aFDBAC1YPAif/Eqt1AJ6ceZ7gOeiQ3dW9MiOHBbXEfA59wDonOCiL6n dxPg== X-Gm-Message-State: AOAM531MS6ySu0Ywmu0hp9Y3g/0njtYJNz82p8nje2dwCEO77ZfmoVeW mqTP3JbV5e0KYzH5FXxlcmZJMs4IY9s= X-Google-Smtp-Source: ABdhPJzSrkz1SKdnk0MKW9s1h+j4KxjEFeozL66I9jSHlv61jLchqTMgKweLy1/JLMHGNqJBjPTC7Q== X-Received: by 2002:a5d:550d:0:b0:1ed:c155:6c2a with SMTP id b13-20020a5d550d000000b001edc1556c2amr19809657wrv.470.1646147767945; Tue, 01 Mar 2022 07:16:07 -0800 (PST) Received: from liuwe-devbox-debian-v2 ([51.145.34.42]) by smtp.gmail.com with ESMTPSA id p2-20020a05600c418200b00380e4fa28b8sm2543387wmh.23.2022.03.01.07.16.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Mar 2022 07:16:07 -0800 (PST) Date: Tue, 1 Mar 2022 15:16:05 +0000 From: Wei Liu To: "Michael Kelley (LINUX)" Cc: Anssi Hannula , KY Srinivasan , Haiyang Zhang , Stephen Hemminger , Wei Liu , Dexuan Cui , "linux-hyperv@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] hv_balloon: rate-limit "Unhandled message" warning Message-ID: <20220301151605.j5zymunttpylphyn@liuwe-devbox-debian-v2> References: <20220222141400.98160-1-anssi.hannula@bitwise.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 25, 2022 at 06:59:18PM +0000, Michael Kelley (LINUX) wrote: > From: Anssi Hannula Sent: Tuesday, February 22, 2022 6:14 AM > > > > For a couple of times I have encountered a situation where > > > > hv_balloon: Unhandled message: type: 12447 > > > > is being flooded over 1 million times per second with various values, > > filling the log and consuming cycles, making debugging difficult. > > > > Add rate limiting to the message. > > > > Most other Hyper-V drivers already have similar rate limiting in their > > message callbacks. > > > > The cause of the floods in my case was probably fixed by 96d9d1fa5cd5 > > ("Drivers: hv: balloon: account for vmbus packet header in > > max_pkt_size"). > > > > Fixes: 9aa8b50b2b3d ("Drivers: hv: Add Hyper-V balloon driver") > > Signed-off-by: Anssi Hannula [...] > > Reviewed-by: Michael Kelley Applied to hyperv-next. Thanks.