From: Jakub Kicinski <kuba@kernel.org>
To: Zheyu Ma <zheyuma97@gmail.com>
Cc: m.grzeschik@pengutronix.de, davem@davemloft.net,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: arcnet: com20020: Fix null-ptr-deref in com20020pci_probe()
Date: Tue, 1 Mar 2022 18:28:55 -0800 [thread overview]
Message-ID: <20220301182855.40d4282d@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> (raw)
In-Reply-To: <1646048653-8962-1-git-send-email-zheyuma97@gmail.com>
On Mon, 28 Feb 2022 11:44:13 +0000 Zheyu Ma wrote:
> During driver initialization, the pointer of card info, i.e. the
> variable 'ci' is required. However, the definition of
> 'com20020pci_id_table' reveals that this field is empty for some
> devices, which will cause null pointer dereference when initializing
> these devices.
>
> The following log reveals it:
>
> [ 3.973806] KASAN: null-ptr-deref in range [0x0000000000000028-0x000000000000002f]
> [ 3.973819] RIP: 0010:com20020pci_probe+0x18d/0x13e0 [com20020_pci]
> [ 3.975181] Call Trace:
> [ 3.976208] local_pci_probe+0x13f/0x210
> [ 3.977248] pci_device_probe+0x34c/0x6d0
> [ 3.977255] ? pci_uevent+0x470/0x470
> [ 3.978265] really_probe+0x24c/0x8d0
> [ 3.978273] __driver_probe_device+0x1b3/0x280
> [ 3.979288] driver_probe_device+0x50/0x370
>
> Fix this by checking whether the 'ci' is a null pointer first.
Can we get a Fixes tag pointing to the commit where the problem was
introduced?
prev parent reply other threads:[~2022-03-02 2:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-28 11:44 [PATCH] net: arcnet: com20020: Fix null-ptr-deref in com20020pci_probe() Zheyu Ma
2022-03-02 2:28 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220301182855.40d4282d@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=m.grzeschik@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=zheyuma97@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.