From: kernel test robot <lkp@intel.com>
To: Kumar Kartikeya Dwivedi <memxor@gmail.com>, bpf@vger.kernel.org
Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>
Subject: Re: [PATCH bpf-next v1 6/6] selftests/bpf: Add tests for kfunc register offset checks
Date: Tue, 1 Mar 2022 19:40:31 +0800 [thread overview]
Message-ID: <202203011937.wMLpkfU3-lkp@intel.com> (raw)
In-Reply-To: <20220301065745.1634848-7-memxor@gmail.com>
Hi Kumar,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on bpf-next/master]
url: https://github.com/0day-ci/linux/commits/Kumar-Kartikeya-Dwivedi/Fixes-for-bad-PTR_TO_BTF_ID-offset/20220301-150010
base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
config: s390-randconfig-r021-20220301 (https://download.01.org/0day-ci/archive/20220301/202203011937.wMLpkfU3-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project d271fc04d5b97b12e6b797c6067d3c96a8d7470e)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install s390 cross compiling tool for clang build
# apt-get install binutils-s390x-linux-gnu
# https://github.com/0day-ci/linux/commit/37a0d686bce3b71b14a17ae57364ec45d1405b9e
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Kumar-Kartikeya-Dwivedi/Fixes-for-bad-PTR_TO_BTF_ID-offset/20220301-150010
git checkout 37a0d686bce3b71b14a17ae57364ec45d1405b9e
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=s390 SHELL=/bin/bash net/bpf/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
writesl(PCI_IOBASE + addr, buffer, count);
~~~~~~~~~~ ^
net/bpf/test_run.c:201:14: warning: no previous prototype for function 'bpf_fentry_test1' [-Wmissing-prototypes]
int noinline bpf_fentry_test1(int a)
^
net/bpf/test_run.c:201:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int noinline bpf_fentry_test1(int a)
^
static
net/bpf/test_run.c:208:14: warning: no previous prototype for function 'bpf_fentry_test2' [-Wmissing-prototypes]
int noinline bpf_fentry_test2(int a, u64 b)
^
net/bpf/test_run.c:208:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int noinline bpf_fentry_test2(int a, u64 b)
^
static
net/bpf/test_run.c:213:14: warning: no previous prototype for function 'bpf_fentry_test3' [-Wmissing-prototypes]
int noinline bpf_fentry_test3(char a, int b, u64 c)
^
net/bpf/test_run.c:213:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int noinline bpf_fentry_test3(char a, int b, u64 c)
^
static
net/bpf/test_run.c:218:14: warning: no previous prototype for function 'bpf_fentry_test4' [-Wmissing-prototypes]
int noinline bpf_fentry_test4(void *a, char b, int c, u64 d)
^
net/bpf/test_run.c:218:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int noinline bpf_fentry_test4(void *a, char b, int c, u64 d)
^
static
net/bpf/test_run.c:223:14: warning: no previous prototype for function 'bpf_fentry_test5' [-Wmissing-prototypes]
int noinline bpf_fentry_test5(u64 a, void *b, short c, int d, u64 e)
^
net/bpf/test_run.c:223:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int noinline bpf_fentry_test5(u64 a, void *b, short c, int d, u64 e)
^
static
net/bpf/test_run.c:228:14: warning: no previous prototype for function 'bpf_fentry_test6' [-Wmissing-prototypes]
int noinline bpf_fentry_test6(u64 a, void *b, short c, int d, void *e, u64 f)
^
net/bpf/test_run.c:228:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int noinline bpf_fentry_test6(u64 a, void *b, short c, int d, void *e, u64 f)
^
static
net/bpf/test_run.c:237:14: warning: no previous prototype for function 'bpf_fentry_test7' [-Wmissing-prototypes]
int noinline bpf_fentry_test7(struct bpf_fentry_test_t *arg)
^
net/bpf/test_run.c:237:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int noinline bpf_fentry_test7(struct bpf_fentry_test_t *arg)
^
static
net/bpf/test_run.c:242:14: warning: no previous prototype for function 'bpf_fentry_test8' [-Wmissing-prototypes]
int noinline bpf_fentry_test8(struct bpf_fentry_test_t *arg)
^
net/bpf/test_run.c:242:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int noinline bpf_fentry_test8(struct bpf_fentry_test_t *arg)
^
static
net/bpf/test_run.c:247:14: warning: no previous prototype for function 'bpf_modify_return_test' [-Wmissing-prototypes]
int noinline bpf_modify_return_test(int a, int *b)
^
net/bpf/test_run.c:247:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int noinline bpf_modify_return_test(int a, int *b)
^
static
net/bpf/test_run.c:253:14: warning: no previous prototype for function 'bpf_kfunc_call_test1' [-Wmissing-prototypes]
u64 noinline bpf_kfunc_call_test1(struct sock *sk, u32 a, u64 b, u32 c, u64 d)
^
net/bpf/test_run.c:253:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
u64 noinline bpf_kfunc_call_test1(struct sock *sk, u32 a, u64 b, u32 c, u64 d)
^
static
net/bpf/test_run.c:258:14: warning: no previous prototype for function 'bpf_kfunc_call_test2' [-Wmissing-prototypes]
int noinline bpf_kfunc_call_test2(struct sock *sk, u32 a, u32 b)
^
net/bpf/test_run.c:258:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int noinline bpf_kfunc_call_test2(struct sock *sk, u32 a, u32 b)
^
static
net/bpf/test_run.c:263:24: warning: no previous prototype for function 'bpf_kfunc_call_test3' [-Wmissing-prototypes]
struct sock * noinline bpf_kfunc_call_test3(struct sock *sk)
^
net/bpf/test_run.c:263:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
struct sock * noinline bpf_kfunc_call_test3(struct sock *sk)
^
static
net/bpf/test_run.c:286:1: warning: no previous prototype for function 'bpf_kfunc_call_test_acquire' [-Wmissing-prototypes]
bpf_kfunc_call_test_acquire(unsigned long *scalar_ptr)
^
net/bpf/test_run.c:285:10: note: declare 'static' if the function is not intended to be used outside of this translation unit
noinline struct prog_test_ref_kfunc *
^
static
net/bpf/test_run.c:294:15: warning: no previous prototype for function 'bpf_kfunc_call_test_release' [-Wmissing-prototypes]
noinline void bpf_kfunc_call_test_release(struct prog_test_ref_kfunc *p)
^
net/bpf/test_run.c:294:10: note: declare 'static' if the function is not intended to be used outside of this translation unit
noinline void bpf_kfunc_call_test_release(struct prog_test_ref_kfunc *p)
^
static
>> net/bpf/test_run.c:298:15: warning: no previous prototype for function 'bpf_kfunc_call_memb_release' [-Wmissing-prototypes]
noinline void bpf_kfunc_call_memb_release(struct prog_test_member *p)
^
net/bpf/test_run.c:298:10: note: declare 'static' if the function is not intended to be used outside of this translation unit
noinline void bpf_kfunc_call_memb_release(struct prog_test_member *p)
^
static
net/bpf/test_run.c:340:15: warning: no previous prototype for function 'bpf_kfunc_call_test_pass_ctx' [-Wmissing-prototypes]
noinline void bpf_kfunc_call_test_pass_ctx(struct __sk_buff *skb)
^
net/bpf/test_run.c:340:10: note: declare 'static' if the function is not intended to be used outside of this translation unit
noinline void bpf_kfunc_call_test_pass_ctx(struct __sk_buff *skb)
^
static
net/bpf/test_run.c:344:15: warning: no previous prototype for function 'bpf_kfunc_call_test_pass1' [-Wmissing-prototypes]
noinline void bpf_kfunc_call_test_pass1(struct prog_test_pass1 *p)
^
net/bpf/test_run.c:344:10: note: declare 'static' if the function is not intended to be used outside of this translation unit
noinline void bpf_kfunc_call_test_pass1(struct prog_test_pass1 *p)
^
static
net/bpf/test_run.c:348:15: warning: no previous prototype for function 'bpf_kfunc_call_test_pass2' [-Wmissing-prototypes]
noinline void bpf_kfunc_call_test_pass2(struct prog_test_pass2 *p)
^
net/bpf/test_run.c:348:10: note: declare 'static' if the function is not intended to be used outside of this translation unit
noinline void bpf_kfunc_call_test_pass2(struct prog_test_pass2 *p)
^
static
net/bpf/test_run.c:352:15: warning: no previous prototype for function 'bpf_kfunc_call_test_fail1' [-Wmissing-prototypes]
noinline void bpf_kfunc_call_test_fail1(struct prog_test_fail1 *p)
^
net/bpf/test_run.c:352:10: note: declare 'static' if the function is not intended to be used outside of this translation unit
noinline void bpf_kfunc_call_test_fail1(struct prog_test_fail1 *p)
^
static
net/bpf/test_run.c:356:15: warning: no previous prototype for function 'bpf_kfunc_call_test_fail2' [-Wmissing-prototypes]
noinline void bpf_kfunc_call_test_fail2(struct prog_test_fail2 *p)
^
net/bpf/test_run.c:356:10: note: declare 'static' if the function is not intended to be used outside of this translation unit
noinline void bpf_kfunc_call_test_fail2(struct prog_test_fail2 *p)
^
static
net/bpf/test_run.c:360:15: warning: no previous prototype for function 'bpf_kfunc_call_test_fail3' [-Wmissing-prototypes]
noinline void bpf_kfunc_call_test_fail3(struct prog_test_fail3 *p)
^
net/bpf/test_run.c:360:10: note: declare 'static' if the function is not intended to be used outside of this translation unit
noinline void bpf_kfunc_call_test_fail3(struct prog_test_fail3 *p)
^
static
net/bpf/test_run.c:364:15: warning: no previous prototype for function 'bpf_kfunc_call_test_mem_len_pass1' [-Wmissing-prototypes]
noinline void bpf_kfunc_call_test_mem_len_pass1(void *mem, int mem__sz)
^
net/bpf/test_run.c:364:10: note: declare 'static' if the function is not intended to be used outside of this translation unit
noinline void bpf_kfunc_call_test_mem_len_pass1(void *mem, int mem__sz)
^
static
net/bpf/test_run.c:368:15: warning: no previous prototype for function 'bpf_kfunc_call_test_mem_len_fail1' [-Wmissing-prototypes]
noinline void bpf_kfunc_call_test_mem_len_fail1(void *mem, int len)
^
net/bpf/test_run.c:368:10: note: declare 'static' if the function is not intended to be used outside of this translation unit
noinline void bpf_kfunc_call_test_mem_len_fail1(void *mem, int len)
^
static
net/bpf/test_run.c:372:15: warning: no previous prototype for function 'bpf_kfunc_call_test_mem_len_fail2' [-Wmissing-prototypes]
noinline void bpf_kfunc_call_test_mem_len_fail2(u64 *mem, int len)
^
net/bpf/test_run.c:372:10: note: declare 'static' if the function is not intended to be used outside of this translation unit
noinline void bpf_kfunc_call_test_mem_len_fail2(u64 *mem, int len)
^
static
36 warnings generated.
vim +/bpf_kfunc_call_memb_release +298 net/bpf/test_run.c
297
> 298 noinline void bpf_kfunc_call_memb_release(struct prog_test_member *p)
299 {
300 }
301
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
next prev parent reply other threads:[~2022-03-01 11:41 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-01 6:57 [PATCH bpf-next v1 0/6] Fixes for bad PTR_TO_BTF_ID offset Kumar Kartikeya Dwivedi
2022-03-01 6:57 ` [PATCH bpf-next v1 1/6] bpf: Add check_func_arg_reg_off function Kumar Kartikeya Dwivedi
2022-03-01 6:57 ` [PATCH bpf-next v1 2/6] bpf: Fix PTR_TO_BTF_ID var_off check Kumar Kartikeya Dwivedi
2022-03-01 6:57 ` [PATCH bpf-next v1 3/6] bpf: Disallow negative offset in check_ptr_off_reg Kumar Kartikeya Dwivedi
2022-03-01 6:57 ` [PATCH bpf-next v1 4/6] bpf: Harden register offset checks for release kfunc Kumar Kartikeya Dwivedi
2022-03-02 3:20 ` Martin KaFai Lau
2022-03-02 9:42 ` Kumar Kartikeya Dwivedi
2022-03-02 21:56 ` Martin KaFai Lau
2022-03-02 22:30 ` Kumar Kartikeya Dwivedi
2022-03-02 22:44 ` Alexei Starovoitov
2022-03-02 23:00 ` Kumar Kartikeya Dwivedi
2022-03-02 23:17 ` Alexei Starovoitov
2022-03-02 23:29 ` Kumar Kartikeya Dwivedi
2022-03-02 23:39 ` Alexei Starovoitov
2022-03-02 23:31 ` Martin KaFai Lau
2022-03-01 6:57 ` [PATCH bpf-next v1 5/6] selftests/bpf: Update tests for new errstr Kumar Kartikeya Dwivedi
2022-03-02 22:45 ` Alexei Starovoitov
2022-03-02 23:02 ` Kumar Kartikeya Dwivedi
2022-03-01 6:57 ` [PATCH bpf-next v1 6/6] selftests/bpf: Add tests for kfunc register offset checks Kumar Kartikeya Dwivedi
2022-03-01 11:40 ` kernel test robot [this message]
2022-03-01 11:57 ` Kumar Kartikeya Dwivedi
2022-03-01 11:57 ` Kumar Kartikeya Dwivedi
2022-03-02 22:47 ` Alexei Starovoitov
2022-03-02 22:47 ` Alexei Starovoitov
2022-03-02 23:14 ` Kumar Kartikeya Dwivedi
2022-03-02 23:14 ` Kumar Kartikeya Dwivedi
2022-03-02 23:20 ` Alexei Starovoitov
2022-03-02 23:20 ` Alexei Starovoitov
2022-03-02 23:26 ` Nathan Chancellor
2022-03-02 23:26 ` Nathan Chancellor
2022-03-02 23:37 ` Kumar Kartikeya Dwivedi
2022-03-02 23:37 ` Kumar Kartikeya Dwivedi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202203011937.wMLpkfU3-lkp@intel.com \
--to=lkp@intel.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kbuild-all@lists.01.org \
--cc=llvm@lists.linux.dev \
--cc=memxor@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.