All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Min Hu (Connor)" <humin29@huawei.com>
To: <dev@dpdk.org>
Cc: <ferruh.yigit@intel.com>, <thomas@monjalon.net>
Subject: [PATCH v2] net/hns3: fix the time waiting for PF reset completion
Date: Wed, 2 Mar 2022 08:35:01 +0800	[thread overview]
Message-ID: <20220302003501.43412-1-humin29@huawei.com> (raw)
In-Reply-To: <20220228032146.37407-5-humin29@huawei.com>

From: Huisong Li <lihuisong@huawei.com>

On the case that PF and VF need to be reset, after the hardware reset is
complete, VF needs wait for 1 second to restore the configuration so that
VF does not fail to recover because PF reset isn't complete. But the
estimated time is not sufficient. This patch fixes it to 5 seconds.

Fixes: 2790c6464725 ("net/hns3: support device reset")
Cc: stable@dpdk.org

Signed-off-by: Huisong Li <lihuisong@huawei.com>
---
v2:
* fix syntax.
---
 drivers/net/hns3/hns3_ethdev_vf.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/net/hns3/hns3_ethdev_vf.c b/drivers/net/hns3/hns3_ethdev_vf.c
index 8f18e7dd54..e06a1a41dd 100644
--- a/drivers/net/hns3/hns3_ethdev_vf.c
+++ b/drivers/net/hns3/hns3_ethdev_vf.c
@@ -1875,6 +1875,7 @@ hns3vf_is_reset_pending(struct hns3_adapter *hns)
 static int
 hns3vf_wait_hardware_ready(struct hns3_adapter *hns)
 {
+#define HNS3_WAIT_PF_RESET_READY_TIME 5
 	struct hns3_hw *hw = &hns->hw;
 	struct hns3_wait_data *wait_data = hw->reset.wait_data;
 	struct timeval tv;
@@ -1895,12 +1896,14 @@ hns3vf_wait_hardware_ready(struct hns3_adapter *hns)
 			return 0;
 
 		wait_data->check_completion = NULL;
-		wait_data->interval = 1 * MSEC_PER_SEC * USEC_PER_MSEC;
+		wait_data->interval = HNS3_WAIT_PF_RESET_READY_TIME *
+			MSEC_PER_SEC * USEC_PER_MSEC;
 		wait_data->count = 1;
 		wait_data->result = HNS3_WAIT_REQUEST;
 		rte_eal_alarm_set(wait_data->interval, hns3_wait_callback,
 				  wait_data);
-		hns3_warn(hw, "hardware is ready, delay 1 sec for PF reset complete");
+		hns3_warn(hw, "hardware is ready, delay %d sec for PF reset complete",
+				HNS3_WAIT_PF_RESET_READY_TIME);
 		return -EAGAIN;
 	} else if (wait_data->result == HNS3_WAIT_TIMEOUT) {
 		hns3_clock_gettime(&tv);
-- 
2.33.0


  parent reply	other threads:[~2022-03-02  0:35 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-28  3:21 [PATCH 0/6] bugfixes for hns3 PMD Min Hu (Connor)
2022-02-28  3:21 ` [PATCH 1/6] net/hns3: remove duplicate macro definition Min Hu (Connor)
2022-02-28 17:46   ` Ferruh Yigit
2022-03-02 11:22     ` Ferruh Yigit
2022-02-28  3:21 ` [PATCH 2/6] net/hns3: fix inconsistent enabled RSS behavior Min Hu (Connor)
2022-02-28 16:42   ` Ferruh Yigit
2022-03-02  2:09     ` lihuisong (C)
2022-03-02 14:07       ` Ori Kam
2022-03-02 14:46         ` Thomas Monjalon
2022-03-02 16:59           ` Stephen Hemminger
2022-03-03  2:48             ` lihuisong (C)
2022-03-24  7:16             ` Harold Huang
2022-03-03  2:47         ` lihuisong (C)
2022-03-09  8:03           ` lihuisong (C)
2022-03-09  9:55             ` Ori Kam
2022-03-10  8:08               ` lihuisong (C)
2022-03-21  7:14                 ` lihuisong (C)
2022-03-22 17:13                   ` Thomas Monjalon
2022-03-23  3:05                     ` lihuisong (C)
2022-03-23  9:14                       ` Thomas Monjalon
2022-03-23 11:04                         ` lihuisong (C)
2022-03-23 19:04                           ` Thomas Monjalon
2022-03-23 19:50                             ` Ajit Khaparde
2022-03-24 12:44                               ` lihuisong (C)
2022-05-12 14:13               ` Ferruh Yigit
2022-02-28  3:21 ` [PATCH 3/6] net/hns3: remove unnecessary RSS switch Min Hu (Connor)
2022-02-28  3:21 ` [PATCH 4/6] net/hns3: fix the time waiting for PF reset completion Min Hu (Connor)
2022-02-28 17:09   ` Ferruh Yigit
2022-03-01  6:32     ` Min Hu (Connor)
2022-03-01 10:44       ` Ferruh Yigit
2022-03-02  0:35   ` Min Hu (Connor) [this message]
2022-03-02 11:48     ` [PATCH v2] " Ferruh Yigit
2022-02-28  3:21 ` [PATCH 5/6] net/hns3: fix RSS TC mode entry Min Hu (Connor)
2022-02-28  3:21 ` [PATCH 6/6] net/hns3: fix VF " Min Hu (Connor)
2022-04-06  6:56 ` [PATCH v2 0/2] fix RSS bugs Min Hu (Connor)
2022-04-06  6:57   ` [PATCH v2 1/2] ethdev: fix enabling RSS behavior inconsistent Min Hu (Connor)
2022-05-12 14:13     ` Ferruh Yigit
2022-04-06  6:57   ` [PATCH v2 2/2] net/hns3: remove unnecessary RSS switch Min Hu (Connor)
2022-05-12 14:13   ` [PATCH v2 0/2] fix RSS bugs Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220302003501.43412-1-humin29@huawei.com \
    --to=humin29@huawei.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.