* [PATCH v2 1/1] misc: bcm-vk: Remove viper from device id table
@ 2022-03-02 2:53 Desmond Yan
2022-03-02 18:09 ` Scott Branden
0 siblings, 1 reply; 2+ messages in thread
From: Desmond Yan @ 2022-03-02 2:53 UTC (permalink / raw)
To: Scott Branden, Arnd Bergmann, Greg Kroah-Hartman
Cc: bcm-kernel-feedback-list, linux-kernel, Desmond Yan
[-- Attachment #1: Type: text/plain, Size: 829 bytes --]
As bcm_vk driver is not the production driver for viper, remove
its pci device id from table.
Signed-off-by: Desmond Yan <desmond.yan@broadcom.com>
---
Changes since v1:
- remove Kconfig option and simply remove viper pci id completely
---
drivers/misc/bcm-vk/bcm_vk_dev.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/misc/bcm-vk/bcm_vk_dev.c b/drivers/misc/bcm-vk/bcm_vk_dev.c
index ad639ee85b2a..a16b99bdaa13 100644
--- a/drivers/misc/bcm-vk/bcm_vk_dev.c
+++ b/drivers/misc/bcm-vk/bcm_vk_dev.c
@@ -1633,7 +1633,6 @@ static void bcm_vk_shutdown(struct pci_dev *pdev)
static const struct pci_device_id bcm_vk_ids[] = {
{ PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, PCI_DEVICE_ID_VALKYRIE), },
- { PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, PCI_DEVICE_ID_VIPER), },
{ }
};
MODULE_DEVICE_TABLE(pci, bcm_vk_ids);
--
2.17.1
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4206 bytes --]
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2 1/1] misc: bcm-vk: Remove viper from device id table
2022-03-02 2:53 [PATCH v2 1/1] misc: bcm-vk: Remove viper from device id table Desmond Yan
@ 2022-03-02 18:09 ` Scott Branden
0 siblings, 0 replies; 2+ messages in thread
From: Scott Branden @ 2022-03-02 18:09 UTC (permalink / raw)
To: Desmond Yan, Arnd Bergmann, Greg Kroah-Hartman
Cc: bcm-kernel-feedback-list, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1024 bytes --]
Looks fine - Viper not officially supported by this driver.
On 2022-03-01 18:53, Desmond Yan wrote:
> As bcm_vk driver is not the production driver for viper, remove
> its pci device id from table.
>
> Signed-off-by: Desmond Yan <desmond.yan@broadcom.com>
Acked-by: Scott Branden <scott.branden@broadcom.com>
> ---
> Changes since v1:
> - remove Kconfig option and simply remove viper pci id completely
> ---
> drivers/misc/bcm-vk/bcm_vk_dev.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/misc/bcm-vk/bcm_vk_dev.c b/drivers/misc/bcm-vk/bcm_vk_dev.c
> index ad639ee85b2a..a16b99bdaa13 100644
> --- a/drivers/misc/bcm-vk/bcm_vk_dev.c
> +++ b/drivers/misc/bcm-vk/bcm_vk_dev.c
> @@ -1633,7 +1633,6 @@ static void bcm_vk_shutdown(struct pci_dev *pdev)
>
> static const struct pci_device_id bcm_vk_ids[] = {
> { PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, PCI_DEVICE_ID_VALKYRIE), },
> - { PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, PCI_DEVICE_ID_VIPER), },
> { }
> };
> MODULE_DEVICE_TABLE(pci, bcm_vk_ids);
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4212 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-02 18:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-02 2:53 [PATCH v2 1/1] misc: bcm-vk: Remove viper from device id table Desmond Yan
2022-03-02 18:09 ` Scott Branden
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.