From: Dave Chinner <david@fromorbit.com>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Miklos Szeredi <miklos@szeredi.hu>,
Al Viro <viro@zeniv.linux.org.uk>,
linux-unionfs@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v3 0/6] Generic per-sb io stats
Date: Wed, 2 Mar 2022 17:59:52 +1100 [thread overview]
Message-ID: <20220302065952.GE3927073@dread.disaster.area> (raw)
In-Reply-To: <20220301184221.371853-1-amir73il@gmail.com>
On Tue, Mar 01, 2022 at 08:42:15PM +0200, Amir Goldstein wrote:
> Miklos,
>
> Following your feedback on v2 [1], I moved the iostats to per-sb.
>
> Thanks,
> Amir.
>
> [1] https://lore.kernel.org/linux-unionfs/20220228113910.1727819-1-amir73il@gmail.com/
>
> Changes since v2:
> - Change from per-mount to per-sb io stats (szeredi)
> - Avoid percpu loop when reading mountstats (dchinner)
>
> Changes since v1:
> - Opt-in for per-mount io stats for overlayfs and fuse
Why make it optional only for specific filesystem types? Shouldn't
every superblock capture these stats and export them in exactly the
same place?
Making it properly generic greatly simplifies the implementation,
too...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2022-03-02 6:59 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-01 18:42 [PATCH v3 0/6] Generic per-sb io stats Amir Goldstein
2022-03-01 18:42 ` [PATCH v3 1/6] lib/percpu_counter: add helpers for arrays of counters Amir Goldstein
2022-03-01 18:42 ` [PATCH v3 2/6] fs: add optional iostats counters to struct super_block Amir Goldstein
2022-03-01 18:42 ` [PATCH v3 3/6] fs: collect per-sb io stats Amir Goldstein
2022-03-01 18:42 ` [PATCH v3 4/6] fs: report " Amir Goldstein
2022-03-01 18:42 ` [PATCH v3 5/6] ovl: opt-in for " Amir Goldstein
2022-03-01 18:42 ` [PATCH v3 6/6] fuse: " Amir Goldstein
2022-03-02 6:59 ` Dave Chinner [this message]
2022-03-02 7:43 ` [PATCH v3 0/6] Generic " Amir Goldstein
2022-03-02 8:26 ` Dave Chinner
2022-03-02 8:34 ` Amir Goldstein
2022-03-02 16:59 ` Amir Goldstein
2022-03-02 21:12 ` Dave Chinner
2022-03-02 22:04 ` nfs generic/373 failure after "fs: allow cross-vfsmount reflink/dedupe" J. Bruce Fields
2022-03-02 22:26 ` Josef Bacik
2022-03-02 22:42 ` J. Bruce Fields
2022-03-02 23:45 ` Josef Bacik
2022-03-03 0:07 ` J. Bruce Fields
2022-03-03 0:29 ` Josef Bacik
2022-03-03 0:50 ` J. Bruce Fields
2022-03-04 20:03 ` J. Bruce Fields
2022-03-03 6:50 ` [PATCH v3 0/6] Generic per-sb io stats Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220302065952.GE3927073@dread.disaster.area \
--to=david@fromorbit.com \
--cc=amir73il@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.