From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42C14C433EF for ; Thu, 3 Mar 2022 13:01:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229572AbiCCNBo (ORCPT ); Thu, 3 Mar 2022 08:01:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47008 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233476AbiCCNBn (ORCPT ); Thu, 3 Mar 2022 08:01:43 -0500 Received: from m-r2.th.seeweb.it (m-r2.th.seeweb.it [IPv6:2001:4b7a:2000:18::171]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7EE07186412 for ; Thu, 3 Mar 2022 05:00:57 -0800 (PST) Received: from SoMainline.org (94-209-165-62.cable.dynamic.v4.ziggo.nl [94.209.165.62]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by m-r2.th.seeweb.it (Postfix) with ESMTPSA id 4B66C3F67D; Thu, 3 Mar 2022 14:00:55 +0100 (CET) Date: Thu, 3 Mar 2022 14:00:54 +0100 From: Marijn Suijten To: Dmitry Baryshkov Cc: Andy Gross , Bjorn Andersson , Rob Clark , Sean Paul , Abhinav Kumar , Rob Herring , Stephen Boyd , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, freedreno@lists.freedesktop.org Subject: Re: [PATCH v2 1/6] arm64: dts: qcom: msm8996: Drop flags for mdss irqs Message-ID: <20220303130054.dxrwgq7vpzvgvip2@SoMainline.org> References: <20220302225411.2456001-1-dmitry.baryshkov@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220302225411.2456001-1-dmitry.baryshkov@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 2022-03-03 01:54:06, Dmitry Baryshkov wrote: > The number of interrupt cells for the mdss interrupt controller is 1, > meaning there should only be one cell for the interrupt number, not two. > Drop the second cell containing (unused) irq flags. > > Reviewed-by: Stephen Boyd > Fixes: 12d540375736 ("arm64: dts: qcom: msm8996: Add DSI0 nodes") > Fixes: 3a4547c1fc2f ("arm64: qcom: msm8996.dtsi: Add Display nodes") > Signed-off-by: Dmitry Baryshkov Thanks for adding the Fixes: tag. Reviewed-by: Marijn Suijten > --- > arch/arm64/boot/dts/qcom/msm8996.dtsi | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi > index f0f81c23c16f..0597d865a4a6 100644 > --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi > @@ -788,7 +788,7 @@ mdp: mdp@901000 { > reg-names = "mdp_phys"; > > interrupt-parent = <&mdss>; > - interrupts = <0 IRQ_TYPE_LEVEL_HIGH>; > + interrupts = <0>; > > clocks = <&mmcc MDSS_AHB_CLK>, > <&mmcc MDSS_AXI_CLK>, > @@ -834,7 +834,7 @@ dsi0: dsi@994000 { > reg-names = "dsi_ctrl"; > > interrupt-parent = <&mdss>; > - interrupts = <4 IRQ_TYPE_LEVEL_HIGH>; > + interrupts = <4>; > > clocks = <&mmcc MDSS_MDP_CLK>, > <&mmcc MDSS_BYTE0_CLK>, > @@ -904,7 +904,7 @@ hdmi: hdmi-tx@9a0000 { > "hdcp_physical"; > > interrupt-parent = <&mdss>; > - interrupts = <8 IRQ_TYPE_LEVEL_HIGH>; > + interrupts = <8>; > > clocks = <&mmcc MDSS_MDP_CLK>, > <&mmcc MDSS_AHB_CLK>, > -- > 2.34.1 >