From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88F1BC433F5 for ; Thu, 3 Mar 2022 14:39:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234071AbiCCOjw (ORCPT ); Thu, 3 Mar 2022 09:39:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48114 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230385AbiCCOjw (ORCPT ); Thu, 3 Mar 2022 09:39:52 -0500 Received: from mail.netfilter.org (mail.netfilter.org [217.70.188.207]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 8603D14D736 for ; Thu, 3 Mar 2022 06:39:06 -0800 (PST) Received: from localhost.localdomain (unknown [78.30.32.163]) by mail.netfilter.org (Postfix) with ESMTPSA id D863062FE6 for ; Thu, 3 Mar 2022 15:37:31 +0100 (CET) From: Pablo Neira Ayuso To: netfilter-devel@vger.kernel.org Subject: [PATCH nft,v2 2/2] optimize: incorrect assert() for unexpected expression type Date: Thu, 3 Mar 2022 15:39:00 +0100 Message-Id: <20220303143900.702741-2-pablo@netfilter.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220303143900.702741-1-pablo@netfilter.org> References: <20220303143900.702741-1-pablo@netfilter.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org assert(1) is noop, this should be assert(0) instead. Fixes: 561aa3cfa8da ("optimize: merge verdict maps with same lookup key") Signed-off-by: Pablo Neira Ayuso --- v2: no changes src/optimize.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/optimize.c b/src/optimize.c index cd799e0d3407..c81d19d4739b 100644 --- a/src/optimize.c +++ b/src/optimize.c @@ -362,11 +362,11 @@ static void merge_verdict_stmts(const struct optimize_ctx *ctx, merge_vmap(ctx, stmt_a, stmt_b); break; default: - assert(1); + assert(0); } break; default: - assert(1); + assert(0); break; } } @@ -385,7 +385,7 @@ static void merge_stmts(const struct optimize_ctx *ctx, merge_verdict_stmts(ctx, from, to, merge, stmt_a); break; default: - assert(1); + assert(0); } } -- 2.30.2