All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/1] vhost: Provide a kernel warning if mutex is held whilst clean-up in progress
@ 2022-03-03 15:19 ` Lee Jones
  0 siblings, 0 replies; 16+ messages in thread
From: Lee Jones @ 2022-03-03 15:19 UTC (permalink / raw)
  To: lee.jones, mst, jasowang; +Cc: linux-kernel, kvm, virtualization, netdev

All workers/users should be halted before any clean-up should take place.

Suggested-by:  Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/vhost/vhost.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
index bbaff6a5e21b8..d935d2506963f 100644
--- a/drivers/vhost/vhost.c
+++ b/drivers/vhost/vhost.c
@@ -693,6 +693,9 @@ void vhost_dev_cleanup(struct vhost_dev *dev)
 	int i;
 
 	for (i = 0; i < dev->nvqs; ++i) {
+		/* Ideally all workers should be stopped prior to clean-up */
+		WARN_ON(mutex_is_locked(&dev->vqs[i]->mutex));
+
 		mutex_lock(&dev->vqs[i]->mutex);
 		if (dev->vqs[i]->error_ctx)
 			eventfd_ctx_put(dev->vqs[i]->error_ctx);
-- 
2.35.1.574.g5d30c73bfb-goog


^ permalink raw reply related	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2022-03-04  8:12 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-03 15:19 [PATCH 1/1] vhost: Provide a kernel warning if mutex is held whilst clean-up in progress Lee Jones
2022-03-03 15:19 ` Lee Jones
2022-03-03 19:14 ` Leon Romanovsky
2022-03-03 19:14   ` Leon Romanovsky
2022-03-03 19:38   ` Lee Jones
2022-03-03 19:38     ` Lee Jones
2022-03-03 21:01   ` Michael S. Tsirkin
2022-03-03 21:01     ` Michael S. Tsirkin
2022-03-04  7:08     ` Leon Romanovsky
2022-03-04  7:08       ` Leon Romanovsky
2022-03-04  8:11       ` Lee Jones
2022-03-04  8:11         ` Lee Jones
2022-03-04  7:50     ` Stefano Garzarella
2022-03-04  7:50       ` Stefano Garzarella
2022-03-04  8:12       ` Lee Jones
2022-03-04  8:12         ` Lee Jones

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.