From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA24A7E for ; Fri, 4 Mar 2022 18:09:04 +0000 (UTC) Received: by mail-pg1-f179.google.com with SMTP id bc27so8164508pgb.4 for ; Fri, 04 Mar 2022 10:09:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=yqxK85bZK7xDyQw2uCXi3loaqdFYPJjcAinZfxqk6do=; b=ocz1+Iw2gQLaJb2kUh6BCjlQE8FtpZ7onQytZBB4oTiku41XTQb2azH+A6m4FymENh NAhz4xCeV1dpJWdXtIOLKucZqrbpLU3XDDZnZu/knH/ZFLtyGFMioPHgUmN5h2xuI5s6 CMoiAVi/wR7mULEHHgmDBVlensKUZylG60Y1U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=yqxK85bZK7xDyQw2uCXi3loaqdFYPJjcAinZfxqk6do=; b=I1hOtQWflta2/x0YSkD4m5H0j8YeQq1jAoEDXUebIKRLnakHpGBjvwAUSTZun6pvlw WNVlhoTSxB90pfAidvbSiRCJkoJ0ubye0pjcxZzFJIgj3aVZrpiB/Q14Cs/px0DglMgb wVeG7+9c0pfSzVFfPBzrx7SP/byRxcUdBhgRRJvby8CZiq6vo0aVLvrinh1xob2YOI7D ACoDJYX1JZnHh/U1PAOrKUfyNUQ0XUTqFOHmnXDMmIXNsZKQKQzcDHuRgkJOg51Nv9O6 GGFD6S27N3wBB54i1viMkSR3ZbkZcXEv8vsl4GXNL1pSUxd1S7QyyzCyReJKJNmSN8pJ Temw== X-Gm-Message-State: AOAM533nS4HKSaicxAO3bsTdQKyt97cXBtADqf+fQG06WXSviewfAz+Y YViHc3WxhNaC5Fqklo8RUPFSvw== X-Google-Smtp-Source: ABdhPJx0NCCGjOT8EpZGR6/1/fL3PG5CbdMIqYeA3vaoHL7EPfBcyJQ0doJAvVQog4jtN8Af1IBekQ== X-Received: by 2002:a05:6a00:1312:b0:4e1:58c4:ddfd with SMTP id j18-20020a056a00131200b004e158c4ddfdmr44651556pfu.65.1646417344203; Fri, 04 Mar 2022 10:09:04 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id n18-20020a056a00213200b004e17d967d13sm6276262pfj.124.2022.03.04.10.09.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Mar 2022 10:09:03 -0800 (PST) Date: Fri, 4 Mar 2022 10:09:03 -0800 From: Kees Cook To: Nathan Chancellor Cc: Masahiro Yamada , Nick Desaulniers , Shuah Khan , llvm@lists.linux.dev, linux-kbuild@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Peter Zijlstra Subject: Re: [PATCH v2] kbuild: Make $(LLVM) more flexible Message-ID: <202203041005.A3B985C@keescook> References: <20220304170813.1689186-1-nathan@kernel.org> Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220304170813.1689186-1-nathan@kernel.org> On Fri, Mar 04, 2022 at 10:08:14AM -0700, Nathan Chancellor wrote: > [...] > > Update and reorder the documentation to reflect these new additions. > At the same time, notate that LLVM=0 is not the same as just omitting it > altogether, which has confused people in the past. Is it worth making LLVM=0 actually act the way it's expected to? > Link: https://lore.kernel.org/r/20200317215515.226917-1-ndesaulniers@google.com/ > Link: https://lore.kernel.org/r/20220224151322.072632223@infradead.org/ > Suggested-by: Masahiro Yamada > Suggested-by: Peter Zijlstra > Signed-off-by: Nathan Chancellor Looks good; minor .rst nit below... Reviewed-by: Kees Cook > [...] > -LLVM has substitutes for GNU binutils utilities. Kbuild supports ``LLVM=1`` > -to enable them. :: > - > - make LLVM=1 > - > -They can be enabled individually. The full list of the parameters: :: > +LLVM has substitutes for GNU binutils utilities. They can be enabled individually. > +The full list of supported make variables: :: ": ::" and "::" yield the same result. I think the latter is more readable in non-rendered form. *shrug* -Kees -- Kees Cook