From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 60BE9C433F5 for ; Sun, 6 Mar 2022 11:51:56 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A48BA83BBC; Sun, 6 Mar 2022 12:51:53 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="syGWADQx"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2F27683BB0; Sun, 6 Mar 2022 12:51:52 +0100 (CET) Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id AC2F483BA0 for ; Sun, 6 Mar 2022 12:51:45 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 409E0B80E70; Sun, 6 Mar 2022 11:51:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CA3A7C340EC; Sun, 6 Mar 2022 11:51:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646567504; bh=gMz0320+FNhaT7DfG1bNQAfEyd22GvlC4ORVpT6qvnk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=syGWADQxDByJaHB1PTybX6YeUiUDXRRVsc0RSo8VYa/JOx6nk+x8MRGvTQb0Esdli t1pQ3nhIQjCa/yrj19l2B2X8f96uwBRADLQO8a76slOdQz8H3xqIMNMVOBPcX5B3kI xDSyUJ8YjH6kVu5+OUWBOsQrA4lIwhQ9kfV0hCNuffMGMTmG8wOwRVkjRuJuxLAOXV PKnZaPWC3syRA0R/J/JuLUvnQcke7iZTdbX5ouWi16ptlFJDPfLOGBj5O41wSkNb4q AiUytmxCfWX4YOP55p5SszSZ95pUu3MVxjvOXeaFtATLVTUXYLhzKwcwjBFut1c7VG Z0bwA7HjCil9w== Received: by pali.im (Postfix) id 3E422830; Sun, 6 Mar 2022 12:51:41 +0100 (CET) Date: Sun, 6 Mar 2022 12:51:41 +0100 From: Pali =?utf-8?B?Um9ow6Fy?= To: Anatolij Gustschin Cc: Simon Glass , Tom Rini , u-boot@lists.denx.de Subject: Re: [PATCH] WIP: Nokia RX-51: Convert to CONFIG_DM_VIDEO Message-ID: <20220306115141.gb4y6fsgqmrtg4ce@pali> References: <20220216204219.18539-1-pali@kernel.org> <20220217095339.7d950fe3@crub> <20220217122043.nhjd7o467pkcrnas@pali> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220217122043.nhjd7o467pkcrnas@pali> User-Agent: NeoMutt/20180716 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean PING? On Thursday 17 February 2022 13:20:43 Pali Rohár wrote: > On Thursday 17 February 2022 09:53:39 Anatolij Gustschin wrote: > > Hi Pali, > > > > On Wed, 16 Feb 2022 21:42:19 +0100 > > Pali Rohár pali@kernel.org wrote: > > > > > --- > > > I had to comment "return -ENOSPC;" in video-uclass.c because without it > > > DM_VIDEO does not work and I do not know why. This looks like either > > > false-positive test or a bug in DM_VIDEO code. I have already set > > > PRE_RELOC flag but it has no effect on that code. > > > > Probably the frame buffer memory allocation did not work. > > Could you please try with a bind callback, i.e.: > > > > static int rx51_video_bind(struct udevice *dev) > > { > > struct video_uc_plat *plat = dev_get_uclass_plat(dev); > > > > plat->size = 800 * 480 * 2; > > return 0; > > } > > ... > > U_BOOT_DRIVER(rx51_video) = { > > .name = "rx51_video", > > .id = UCLASS_VIDEO, > > .bind = rx51_video_bind, > > .probe = rx51_video_probe, > > .flags = DM_FLAG_PRE_RELOC, > > }; > > Hello! It does not work too. Here is the output: > > U-Boot 2022.04-rc2-00002-ga2c1a9878375-dirty (Jan 01 1970 - 00:00:00 +0000) > > OMAP35XX-GP ES3.1, CPU-OPP2, L3-165MHz, Max CPU Clock 600 MHz > DRAM: Video frame buffers from 8fe30000 to 8fe30000 > 256 MiB > Video device 'rx51_video' cannot allocate frame buffer memory -ensure the device is set up before relocation > > If "return -ENOSPC;" is not commented then this is the last printed > line. If it is commented then output continues with: > > video_post_bind: Claiming 130000 bytes at 8fd00000 for video device 'rx51_video' > > And framebuffer is working fine like without above rx51_video_bind() > change. > > > > > > > Second thing is that CONFIG_VIDEO_LOGO is broken and does not work even it > > > is enabled in config file. I do not know why too. > > > > > > Any idea? > > > > Not yet. There were some logo related changes recently, but if I > > remember correctly, I tested them on wandboard and nitrogen6q > > targets and with sandbox, and logo drawing worked there. > > > > -- > > Anatolij