All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philippe.mathieu.daude@gmail.com>
To: qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
	"Thomas Huth" <thuth@redhat.com>,
	qemu-block@nongnu.org,
	"Christian Schoenebeck" <qemu_oss@crudebyte.com>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"Cameron Esfahani" <dirty@apple.com>,
	"Roman Bolshakov" <r.bolshakov@yadro.com>,
	"Will Cohen" <wwcohen@gmail.com>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Akihiko Odaki" <akihiko.odaki@gmail.com>,
	"Alex Bennée" <alex.bennee@linaro.org>
Subject: [PATCH v7 04/22] hvf: Make hvf_get_segments() / hvf_put_segments() local
Date: Mon,  7 Mar 2022 00:17:35 +0100	[thread overview]
Message-ID: <20220306231753.50277-5-philippe.mathieu.daude@gmail.com> (raw)
In-Reply-To: <20220306231753.50277-1-philippe.mathieu.daude@gmail.com>

From: Philippe Mathieu-Daudé <f4bug@amsat.org>

Both hvf_get_segments/hvf_put_segments() functions are only
used within x86hvf.c: do not declare them as public API.

Reviewed-by: Roman Bolshakov <r.bolshakov@yadro.com>
Tested-by: Roman Bolshakov <r.bolshakov@yadro.com>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 target/i386/hvf/x86hvf.c | 4 ++--
 target/i386/hvf/x86hvf.h | 2 --
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/target/i386/hvf/x86hvf.c b/target/i386/hvf/x86hvf.c
index 05ec1bddc4..907f09f1b4 100644
--- a/target/i386/hvf/x86hvf.c
+++ b/target/i386/hvf/x86hvf.c
@@ -83,7 +83,7 @@ void hvf_put_xsave(CPUState *cpu_state)
     }
 }
 
-void hvf_put_segments(CPUState *cpu_state)
+static void hvf_put_segments(CPUState *cpu_state)
 {
     CPUX86State *env = &X86_CPU(cpu_state)->env;
     struct vmx_segment seg;
@@ -166,7 +166,7 @@ void hvf_get_xsave(CPUState *cpu_state)
     x86_cpu_xrstor_all_areas(X86_CPU(cpu_state), xsave, xsave_len);
 }
 
-void hvf_get_segments(CPUState *cpu_state)
+static void hvf_get_segments(CPUState *cpu_state)
 {
     CPUX86State *env = &X86_CPU(cpu_state)->env;
 
diff --git a/target/i386/hvf/x86hvf.h b/target/i386/hvf/x86hvf.h
index 99ed8d608d..db6003d6bd 100644
--- a/target/i386/hvf/x86hvf.h
+++ b/target/i386/hvf/x86hvf.h
@@ -26,11 +26,9 @@ void hvf_set_segment(struct CPUState *cpu, struct vmx_segment *vmx_seg,
                      SegmentCache *qseg, bool is_tr);
 void hvf_get_segment(SegmentCache *qseg, struct vmx_segment *vmx_seg);
 void hvf_put_xsave(CPUState *cpu_state);
-void hvf_put_segments(CPUState *cpu_state);
 void hvf_put_msrs(CPUState *cpu_state);
 void hvf_get_xsave(CPUState *cpu_state);
 void hvf_get_msrs(CPUState *cpu_state);
 void vmx_clear_int_window_exiting(CPUState *cpu);
-void hvf_get_segments(CPUState *cpu_state);
 void vmx_update_tpr(CPUState *cpu);
 #endif
-- 
2.34.1



  parent reply	other threads:[~2022-03-06 23:22 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-06 23:17 [PATCH v7 00/22] host: Support macOS 12 Philippe Mathieu-Daudé
2022-03-06 23:17 ` [PATCH v7 01/22] configure: Allow passing extra Objective C compiler flags Philippe Mathieu-Daudé
2022-03-06 23:17 ` [PATCH v7 02/22] tests/fp/berkeley-testfloat-3: Ignore ignored #pragma directives Philippe Mathieu-Daudé
2022-03-09 11:17   ` Alex Bennée
2022-03-06 23:17 ` [PATCH v7 03/22] hvf: Use standard CR0 and CR4 register definitions Philippe Mathieu-Daudé
2022-03-06 23:17 ` Philippe Mathieu-Daudé [this message]
2022-03-06 23:17 ` [PATCH v7 05/22] hvf: Remove deprecated hv_vcpu_flush() calls Philippe Mathieu-Daudé
2022-03-06 23:17 ` [PATCH v7 06/22] hvf: Fix OOB write in RDTSCP instruction decode Philippe Mathieu-Daudé
2022-03-09 10:20   ` Philippe Mathieu-Daudé
2022-03-15 12:58     ` Peter Maydell
2022-03-15 13:00       ` Philippe Mathieu-Daudé
2022-03-06 23:17 ` [PATCH v7 07/22] block/file-posix: Remove a deprecation warning on macOS 12 Philippe Mathieu-Daudé
2022-03-06 23:17 ` [PATCH v7 08/22] audio/coreaudio: " Philippe Mathieu-Daudé
2022-03-06 23:17 ` [PATCH v7 09/22] audio/dbus: Fix building with modules on macOS Philippe Mathieu-Daudé
2022-03-06 23:17 ` [PATCH v7 10/22] audio: Log context for audio bug Philippe Mathieu-Daudé
2022-03-06 23:17 ` [PATCH v7 11/22] coreaudio: Always return 0 in handle_voice_change Philippe Mathieu-Daudé
2022-03-06 23:17 ` [PATCH v7 12/22] audio: Rename coreaudio extension to use Objective-C compiler Philippe Mathieu-Daudé
2022-03-06 23:17 ` [PATCH v7 13/22] osdep: Avoid using Clang-specific __builtin_available() Philippe Mathieu-Daudé
2022-03-07  4:11   ` Akihiko Odaki
2022-03-06 23:17 ` [PATCH v7 14/22] meson: Resolve the entitlement.sh script once for good Philippe Mathieu-Daudé
2022-03-07  4:13   ` Akihiko Odaki
2022-03-06 23:17 ` [PATCH v7 15/22] meson: Log QEMU_CXXFLAGS content in summary Philippe Mathieu-Daudé
2022-03-07  4:13   ` Akihiko Odaki
2022-03-06 23:17 ` [PATCH v7 16/22] configure: Pass filtered QEMU_OBJCFLAGS to meson Philippe Mathieu-Daudé
2022-03-07  4:15   ` Akihiko Odaki
2022-03-06 23:17 ` [PATCH v7 17/22] ui/cocoa: Constify qkeycode translation arrays Philippe Mathieu-Daudé
2022-03-07  4:16   ` Akihiko Odaki
2022-03-06 23:17 ` [PATCH v7 18/22] ui/cocoa: add option to disable left-command forwarding to guest Philippe Mathieu-Daudé
2022-03-06 23:17 ` [PATCH v7 19/22] ui/cocoa: release mouse when user switches away from QEMU window Philippe Mathieu-Daudé
2022-03-06 23:17 ` [PATCH v7 20/22] ui/cocoa: capture all keys and combos when mouse is grabbed Philippe Mathieu-Daudé
2022-03-07 17:01   ` Will Cohen
2022-03-06 23:17 ` [PATCH v7 21/22] ui/cocoa: add option to swap Option and Command Philippe Mathieu-Daudé
2022-03-07 17:00   ` Will Cohen
2022-03-06 23:17 ` [PATCH v7 22/22] gitlab-ci: Support macOS 12 via cirrus-run Philippe Mathieu-Daudé
2022-03-09 10:24   ` Philippe Mathieu-Daudé
2022-03-09 11:58     ` Thomas Huth
2022-03-09 12:33       ` Daniel P. Berrangé
2022-03-09 12:50         ` Philippe Mathieu-Daudé
2022-03-09 12:52           ` Thomas Huth
2022-03-09 12:55             ` Daniel P. Berrangé
2022-03-09 13:02           ` Daniel P. Berrangé
2022-03-09 13:09             ` Peter Maydell
2022-03-09 13:40               ` Philippe Mathieu-Daudé
2022-03-09 10:28   ` Daniel P. Berrangé
2022-03-15 12:48 ` [PATCH v7 00/22] host: Support macOS 12 Philippe Mathieu-Daudé
2022-05-03  9:40 ` Claudio Fontana
2022-05-09 12:31   ` Philippe Mathieu-Daudé via
2022-05-09 13:08     ` Claudio Fontana

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220306231753.50277-5-philippe.mathieu.daude@gmail.com \
    --to=philippe.mathieu.daude@gmail.com \
    --cc=akihiko.odaki@gmail.com \
    --cc=alex.bennee@linaro.org \
    --cc=dirty@apple.com \
    --cc=f4bug@amsat.org \
    --cc=kraxel@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu_oss@crudebyte.com \
    --cc=r.bolshakov@yadro.com \
    --cc=thuth@redhat.com \
    --cc=wwcohen@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.