From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 91AEBC433EF for ; Mon, 7 Mar 2022 09:38:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9WJp+20xb5bhjy2WipVqXLR0N1FpQGd06Qos+5DoFyA=; b=S9ePyItoA5djkY 7DPh+Di8dw1GpUP4zSU+DVcoe4FZ57opegESk/+2eraTpz45/99I/HosNU7kqXGYit7BRyEFDr8/g Nn0uPKMuTJhGkMije3BP8TzhGddXMRR4G779lVEroM1eCWesNHjtdGL/xXg5k/zhOmVO/+aquU6z8 esS7gwA1sn3UstpsnBe//VT2JagfCe6NuoHP6oAHFqVb2Vt+LqrTKqJuPW3CQlc09Od2zjnMhAZCW qargiAHMxYyCR9adZ84MbaJWZ5dGuIq5XkQTMzqXwO7XlYe0CfozTB9TGDvMWqoqmJ4vwTU4+9UtF yokJdOfowdoOh+RXph/g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nR9nc-00Gp6o-0k; Mon, 07 Mar 2022 09:37:04 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nR9jZ-00GnCc-NR for linux-arm-kernel@lists.infradead.org; Mon, 07 Mar 2022 09:32:58 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1E5D061274; Mon, 7 Mar 2022 09:32:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5C83BC340F4; Mon, 7 Mar 2022 09:32:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1646645572; bh=CaKtX6RI701ZDx4Bn/ja5BTKe+943YPz+gM9MRC0pRo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HXtGaXbJIP1KTLvcZg56IZaNxCLuzVsk7+yvlvf1p3AS01yEISQF4Dg3QBBi+XYbW t0fWT0epGe0FY8pPTasCpUHmDK8OxN5iRMZ+V2X+5rXj2rMYZCcHrbFoXUk5mBelh+ 4bmJNv9mlyYuKADyhtc5QeRaVOfbrT2tz3oM13mE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Randy Dunlap , Igor Zhbanov , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , linux-arm-kernel@lists.infradead.org, patches@armlinux.org.uk, "Russell King (Oracle)" Subject: [PATCH 5.10 075/105] ARM: 9182/1: mmu: fix returns from early_param() and __setup() functions Date: Mon, 7 Mar 2022 10:19:18 +0100 Message-Id: <20220307091646.287106770@linuxfoundation.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220307091644.179885033@linuxfoundation.org> References: <20220307091644.179885033@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220307_013253_855202_F4E9EB76 X-CRM114-Status: GOOD ( 13.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org RnJvbTogUmFuZHkgRHVubGFwIDxyZHVubGFwQGluZnJhZGVhZC5vcmc+Cgpjb21taXQgN2I4MzI5 OWU1YjkzODU5NDNhODU3ZDU5ZTE1Y2JhMjcwZGYyMGQ3ZSB1cHN0cmVhbS4KCmVhcmx5X3BhcmFt KCkgaGFuZGxlcnMgc2hvdWxkIHJldHVybiAwIG9uIHN1Y2Nlc3MuCl9fc2V0dXAoKSBoYW5kbGVy cyBzaG91bGQgcmV0dXJuIDEgb24gc3VjY2VzcywgaS5lLiwgdGhlIHBhcmFtZXRlcgpoYXMgYmVl biBoYW5kbGVkLiBBIHJldHVybiBvZiAwIHdvdWxkIGNhdXNlIHRoZSAib3B0aW9uPXZhbHVlIiBz dHJpbmcKdG8gYmUgYWRkZWQgdG8gaW5pdCdzIGVudmlyb25tZW50IHN0cmluZ3MsIHBvbGx1dGlu ZyBpdC4KCi4uL2FyY2gvYXJtL21tL21tdS5jOiBJbiBmdW5jdGlvbiAndGVzdF9lYXJseV9jYWNo ZXBvbGljeSc6Ci4uL2FyY2gvYXJtL21tL21tdS5jOjIxNToxOiBlcnJvcjogbm8gcmV0dXJuIHN0 YXRlbWVudCBpbiBmdW5jdGlvbiByZXR1cm5pbmcgbm9uLXZvaWQgWy1XZXJyb3I9cmV0dXJuLXR5 cGVdCi4uL2FyY2gvYXJtL21tL21tdS5jOiBJbiBmdW5jdGlvbiAndGVzdF9ub2FsaWduX3NldHVw JzoKLi4vYXJjaC9hcm0vbW0vbW11LmM6MjIxOjE6IGVycm9yOiBubyByZXR1cm4gc3RhdGVtZW50 IGluIGZ1bmN0aW9uIHJldHVybmluZyBub24tdm9pZCBbLVdlcnJvcj1yZXR1cm4tdHlwZV0KCkZp eGVzOiBiODQ5YTYwZTA5MDMgKCJBUk06IG1ha2UgY3JfYWxpZ25tZW50IHJlYWQtb25seSAjaWZu ZGVmIENPTkZJR19DUFVfQ1AxNSIpClNpZ25lZC1vZmYtYnk6IFJhbmR5IER1bmxhcCA8cmR1bmxh cEBpbmZyYWRlYWQub3JnPgpSZXBvcnRlZC1ieTogSWdvciBaaGJhbm92IDxpLnpoYmFub3ZAb21w cnVzc2lhLnJ1PgpDYzogVXdlIEtsZWluZS1Lw7ZuaWcgPHUua2xlaW5lLWtvZW5pZ0BwZW5ndXRy b25peC5kZT4KQ2M6IGxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpDYzogcGF0 Y2hlc0Bhcm1saW51eC5vcmcudWsKU2lnbmVkLW9mZi1ieTogUnVzc2VsbCBLaW5nIChPcmFjbGUp IDxybWsra2VybmVsQGFybWxpbnV4Lm9yZy51az4KU2lnbmVkLW9mZi1ieTogR3JlZyBLcm9haC1I YXJ0bWFuIDxncmVna2hAbGludXhmb3VuZGF0aW9uLm9yZz4KLS0tCiBhcmNoL2FybS9tbS9tbXUu YyB8ICAgIDIgKysKIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKykKCi0tLSBhL2FyY2gv YXJtL21tL21tdS5jCisrKyBiL2FyY2gvYXJtL21tL21tdS5jCkBAIC0yMTIsMTIgKzIxMiwxNCBA QCBlYXJseV9wYXJhbSgiZWNjIiwgZWFybHlfZWNjKTsKIHN0YXRpYyBpbnQgX19pbml0IGVhcmx5 X2NhY2hlcG9saWN5KGNoYXIgKnApCiB7CiAJcHJfd2FybigiY2FjaGVwb2xpY3kga2VybmVsIHBh cmFtZXRlciBub3Qgc3VwcG9ydGVkIHdpdGhvdXQgY3AxNVxuIik7CisJcmV0dXJuIDA7CiB9CiBl YXJseV9wYXJhbSgiY2FjaGVwb2xpY3kiLCBlYXJseV9jYWNoZXBvbGljeSk7CiAKIHN0YXRpYyBp bnQgX19pbml0IG5vYWxpZ25fc2V0dXAoY2hhciAqX191bnVzZWQpCiB7CiAJcHJfd2Fybigibm9h bGlnbiBrZXJuZWwgcGFyYW1ldGVyIG5vdCBzdXBwb3J0ZWQgd2l0aG91dCBjcDE1XG4iKTsKKwly ZXR1cm4gMTsKIH0KIF9fc2V0dXAoIm5vYWxpZ24iLCBub2FsaWduX3NldHVwKTsKIAoKCgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2Vy bmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0 cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVs Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2016EC433EF for ; Mon, 7 Mar 2022 09:55:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238449AbiCGJ4X (ORCPT ); Mon, 7 Mar 2022 04:56:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59070 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238644AbiCGJii (ORCPT ); Mon, 7 Mar 2022 04:38:38 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 135646AA76; Mon, 7 Mar 2022 01:33:05 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id EBA58B810C5; Mon, 7 Mar 2022 09:32:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5C83BC340F4; Mon, 7 Mar 2022 09:32:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1646645572; bh=CaKtX6RI701ZDx4Bn/ja5BTKe+943YPz+gM9MRC0pRo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HXtGaXbJIP1KTLvcZg56IZaNxCLuzVsk7+yvlvf1p3AS01yEISQF4Dg3QBBi+XYbW t0fWT0epGe0FY8pPTasCpUHmDK8OxN5iRMZ+V2X+5rXj2rMYZCcHrbFoXUk5mBelh+ 4bmJNv9mlyYuKADyhtc5QeRaVOfbrT2tz3oM13mE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Randy Dunlap , Igor Zhbanov , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , linux-arm-kernel@lists.infradead.org, patches@armlinux.org.uk, "Russell King (Oracle)" Subject: [PATCH 5.10 075/105] ARM: 9182/1: mmu: fix returns from early_param() and __setup() functions Date: Mon, 7 Mar 2022 10:19:18 +0100 Message-Id: <20220307091646.287106770@linuxfoundation.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220307091644.179885033@linuxfoundation.org> References: <20220307091644.179885033@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Randy Dunlap commit 7b83299e5b9385943a857d59e15cba270df20d7e upstream. early_param() handlers should return 0 on success. __setup() handlers should return 1 on success, i.e., the parameter has been handled. A return of 0 would cause the "option=value" string to be added to init's environment strings, polluting it. ../arch/arm/mm/mmu.c: In function 'test_early_cachepolicy': ../arch/arm/mm/mmu.c:215:1: error: no return statement in function returning non-void [-Werror=return-type] ../arch/arm/mm/mmu.c: In function 'test_noalign_setup': ../arch/arm/mm/mmu.c:221:1: error: no return statement in function returning non-void [-Werror=return-type] Fixes: b849a60e0903 ("ARM: make cr_alignment read-only #ifndef CONFIG_CPU_CP15") Signed-off-by: Randy Dunlap Reported-by: Igor Zhbanov Cc: Uwe Kleine-König Cc: linux-arm-kernel@lists.infradead.org Cc: patches@armlinux.org.uk Signed-off-by: Russell King (Oracle) Signed-off-by: Greg Kroah-Hartman --- arch/arm/mm/mmu.c | 2 ++ 1 file changed, 2 insertions(+) --- a/arch/arm/mm/mmu.c +++ b/arch/arm/mm/mmu.c @@ -212,12 +212,14 @@ early_param("ecc", early_ecc); static int __init early_cachepolicy(char *p) { pr_warn("cachepolicy kernel parameter not supported without cp15\n"); + return 0; } early_param("cachepolicy", early_cachepolicy); static int __init noalign_setup(char *__unused) { pr_warn("noalign kernel parameter not supported without cp15\n"); + return 1; } __setup("noalign", noalign_setup);