All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Revert "ARM: dts: sun7i: A20-olinuxino-lime2: Fix ethernet phy-mode"
@ 2022-03-08 12:55 ` Petr Štetiar
  0 siblings, 0 replies; 10+ messages in thread
From: Petr Štetiar @ 2022-03-08 12:55 UTC (permalink / raw)
  To: Rob Herring, Maxime Ripard, Chen-Yu Tsai, Jernej Skrabec
  Cc: Petr Štetiar, stable, Bastien Roucariès, devicetree,
	linux-arm-kernel, linux-sunxi, linux-kernel

This reverts commit 55dd7e059098ce4bd0a55c251cb78e74604abb57 as it
breaks network on my A20-olinuxino-lime2 hardware revision "K" which has
Micrel KSZ9031RNXCC-TR Gigabit PHY. Bastien has probably some previous
hardware revisions which were based on RTL8211E-VB-CG1 PHY and thus this
fix was working on his board.

Cc: stable@vger.kernel.org
Cc: Bastien Roucariès <rouca@debian.org>
References: https://github.com/openwrt/openwrt/issues/9153
References: https://github.com/OLIMEX/OLINUXINO/blob/master/HARDWARE/A20-OLinuXino-LIME2/hardware_revision_changes_log.txt
Signed-off-by: Petr Štetiar <ynezz@true.cz>
---
 arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts
index ecb91fb899ff..8077f1716fbc 100644
--- a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts
+++ b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts
@@ -112,7 +112,7 @@ &gmac {
 	pinctrl-names = "default";
 	pinctrl-0 = <&gmac_rgmii_pins>;
 	phy-handle = <&phy1>;
-	phy-mode = "rgmii-id";
+	phy-mode = "rgmii";
 	status = "okay";
 };
 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH] Revert "ARM: dts: sun7i: A20-olinuxino-lime2: Fix ethernet phy-mode"
@ 2022-03-08 12:55 ` Petr Štetiar
  0 siblings, 0 replies; 10+ messages in thread
From: Petr Štetiar @ 2022-03-08 12:55 UTC (permalink / raw)
  To: Rob Herring, Maxime Ripard, Chen-Yu Tsai, Jernej Skrabec
  Cc: Petr Štetiar, stable, Bastien Roucariès, devicetree,
	linux-arm-kernel, linux-sunxi, linux-kernel

This reverts commit 55dd7e059098ce4bd0a55c251cb78e74604abb57 as it
breaks network on my A20-olinuxino-lime2 hardware revision "K" which has
Micrel KSZ9031RNXCC-TR Gigabit PHY. Bastien has probably some previous
hardware revisions which were based on RTL8211E-VB-CG1 PHY and thus this
fix was working on his board.

Cc: stable@vger.kernel.org
Cc: Bastien Roucariès <rouca@debian.org>
References: https://github.com/openwrt/openwrt/issues/9153
References: https://github.com/OLIMEX/OLINUXINO/blob/master/HARDWARE/A20-OLinuXino-LIME2/hardware_revision_changes_log.txt
Signed-off-by: Petr Štetiar <ynezz@true.cz>
---
 arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts
index ecb91fb899ff..8077f1716fbc 100644
--- a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts
+++ b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts
@@ -112,7 +112,7 @@ &gmac {
 	pinctrl-names = "default";
 	pinctrl-0 = <&gmac_rgmii_pins>;
 	phy-handle = <&phy1>;
-	phy-mode = "rgmii-id";
+	phy-mode = "rgmii";
 	status = "okay";
 };
 

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] Revert "ARM: dts: sun7i: A20-olinuxino-lime2: Fix ethernet phy-mode"
  2022-03-08 12:55 ` Petr Štetiar
@ 2022-03-15  7:28   ` Petr Štetiar
  -1 siblings, 0 replies; 10+ messages in thread
From: Petr Štetiar @ 2022-03-15  7:28 UTC (permalink / raw)
  To: Greg Kroah-Hartman
  Cc: Maxime Ripard, Bastien Roucariès, Chen-Yu Tsai,
	Jernej Skrabec, Rob Herring, stable, devicetree,
	linux-arm-kernel, linux-sunxi, linux-kernel

Petr Štetiar <ynezz@true.cz> [2022-03-08 13:55:30]:

Hi Greg,

one week has passed and as I didn't received any feedback, I'm providing more
details in a hope to make it more clear, why I think, that this fix is wrong
and should be reverted in LTS kernels 5.10 and 5.15.

> This reverts commit 55dd7e059098ce4bd0a55c251cb78e74604abb57 as it breaks
> network on my A20-olinuxino-lime2 hardware revision "K" which has Micrel
> KSZ9031RNXCC-TR Gigabit PHY. Bastien has probably some previous hardware
> revisions which were based on RTL8211E-VB-CG1 PHY and thus this fix was
> working on his board.

Disclaimer, I don't own A20-olinuxino-lime2 board with earlier HW revisions
G/G1/G2 utilizing RTL8211E PHY.

My understanding is, that up to kernel version 5.9 and specifically commit
bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay config") it was
likely possible to use same DTS for A20-olinuxino-lime2 with KSZ9031 or
RTL8211E PHYs (all HW revisions).

At least I was using my A20-olinuxino-lime2 HW revision K with KSZ9031 PHY
just fine with 4.19 kernel. After upgrade to 5.10 LTS kernel my network
stopped working, reverting stable backport commit a90398438517 ("ARM: dts:
sun7i: A20-olinuxino-lime2: Fix ethernet phy-mode") fixed it.

From my POV proper fix for earlier HW revisions G/G1/G2 is introduction of
sun7i-a20-olinuxino-lime2-revG.dts with a proper `phy-mode` for RTL8211E PHY.

Cheers,

Petr

> Cc: stable@vger.kernel.org
> Cc: Bastien Roucariès <rouca@debian.org>
> References: https://github.com/openwrt/openwrt/issues/9153
> References: https://github.com/OLIMEX/OLINUXINO/blob/master/HARDWARE/A20-OLinuXino-LIME2/hardware_revision_changes_log.txt
> Signed-off-by: Petr Štetiar <ynezz@true.cz>
> ---
>  arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts
> index ecb91fb899ff..8077f1716fbc 100644
> --- a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts
> +++ b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts
> @@ -112,7 +112,7 @@ &gmac {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&gmac_rgmii_pins>;
>  	phy-handle = <&phy1>;
> -	phy-mode = "rgmii-id";
> +	phy-mode = "rgmii";
>  	status = "okay";
>  };

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] Revert "ARM: dts: sun7i: A20-olinuxino-lime2: Fix ethernet phy-mode"
@ 2022-03-15  7:28   ` Petr Štetiar
  0 siblings, 0 replies; 10+ messages in thread
From: Petr Štetiar @ 2022-03-15  7:28 UTC (permalink / raw)
  To: Greg Kroah-Hartman
  Cc: Maxime Ripard, Bastien Roucariès, Chen-Yu Tsai,
	Jernej Skrabec, Rob Herring, stable, devicetree,
	linux-arm-kernel, linux-sunxi, linux-kernel

Petr Štetiar <ynezz@true.cz> [2022-03-08 13:55:30]:

Hi Greg,

one week has passed and as I didn't received any feedback, I'm providing more
details in a hope to make it more clear, why I think, that this fix is wrong
and should be reverted in LTS kernels 5.10 and 5.15.

> This reverts commit 55dd7e059098ce4bd0a55c251cb78e74604abb57 as it breaks
> network on my A20-olinuxino-lime2 hardware revision "K" which has Micrel
> KSZ9031RNXCC-TR Gigabit PHY. Bastien has probably some previous hardware
> revisions which were based on RTL8211E-VB-CG1 PHY and thus this fix was
> working on his board.

Disclaimer, I don't own A20-olinuxino-lime2 board with earlier HW revisions
G/G1/G2 utilizing RTL8211E PHY.

My understanding is, that up to kernel version 5.9 and specifically commit
bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay config") it was
likely possible to use same DTS for A20-olinuxino-lime2 with KSZ9031 or
RTL8211E PHYs (all HW revisions).

At least I was using my A20-olinuxino-lime2 HW revision K with KSZ9031 PHY
just fine with 4.19 kernel. After upgrade to 5.10 LTS kernel my network
stopped working, reverting stable backport commit a90398438517 ("ARM: dts:
sun7i: A20-olinuxino-lime2: Fix ethernet phy-mode") fixed it.

From my POV proper fix for earlier HW revisions G/G1/G2 is introduction of
sun7i-a20-olinuxino-lime2-revG.dts with a proper `phy-mode` for RTL8211E PHY.

Cheers,

Petr

> Cc: stable@vger.kernel.org
> Cc: Bastien Roucariès <rouca@debian.org>
> References: https://github.com/openwrt/openwrt/issues/9153
> References: https://github.com/OLIMEX/OLINUXINO/blob/master/HARDWARE/A20-OLinuXino-LIME2/hardware_revision_changes_log.txt
> Signed-off-by: Petr Štetiar <ynezz@true.cz>
> ---
>  arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts
> index ecb91fb899ff..8077f1716fbc 100644
> --- a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts
> +++ b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts
> @@ -112,7 +112,7 @@ &gmac {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&gmac_rgmii_pins>;
>  	phy-handle = <&phy1>;
> -	phy-mode = "rgmii-id";
> +	phy-mode = "rgmii";
>  	status = "okay";
>  };

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] Revert "ARM: dts: sun7i: A20-olinuxino-lime2: Fix ethernet phy-mode"
  2022-03-15  7:28   ` Petr Štetiar
@ 2022-03-15  7:37     ` Corentin Labbe
  -1 siblings, 0 replies; 10+ messages in thread
From: Corentin Labbe @ 2022-03-15  7:37 UTC (permalink / raw)
  To: Petr Štetiar
  Cc: Greg Kroah-Hartman, Maxime Ripard, Bastien Roucariès,
	Chen-Yu Tsai, Jernej Skrabec, Rob Herring, stable, devicetree,
	linux-arm-kernel, linux-sunxi, linux-kernel

Le Tue, Mar 15, 2022 at 08:28:58AM +0100, Petr Štetiar a écrit :
> Petr Štetiar <ynezz@true.cz> [2022-03-08 13:55:30]:
> 
> Hi Greg,
> 
> one week has passed and as I didn't received any feedback, I'm providing more
> details in a hope to make it more clear, why I think, that this fix is wrong
> and should be reverted in LTS kernels 5.10 and 5.15.
> 
> > This reverts commit 55dd7e059098ce4bd0a55c251cb78e74604abb57 as it breaks
> > network on my A20-olinuxino-lime2 hardware revision "K" which has Micrel
> > KSZ9031RNXCC-TR Gigabit PHY. Bastien has probably some previous hardware
> > revisions which were based on RTL8211E-VB-CG1 PHY and thus this fix was
> > working on his board.
> 
> Disclaimer, I don't own A20-olinuxino-lime2 board with earlier HW revisions
> G/G1/G2 utilizing RTL8211E PHY.
> 
> My understanding is, that up to kernel version 5.9 and specifically commit
> bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay config") it was
> likely possible to use same DTS for A20-olinuxino-lime2 with KSZ9031 or
> RTL8211E PHYs (all HW revisions).
> 
> At least I was using my A20-olinuxino-lime2 HW revision K with KSZ9031 PHY
> just fine with 4.19 kernel. After upgrade to 5.10 LTS kernel my network
> stopped working, reverting stable backport commit a90398438517 ("ARM: dts:
> sun7i: A20-olinuxino-lime2: Fix ethernet phy-mode") fixed it.
> 
> From my POV proper fix for earlier HW revisions G/G1/G2 is introduction of
> sun7i-a20-olinuxino-lime2-revG.dts with a proper `phy-mode` for RTL8211E PHY.
> 
> Cheers,
> 
> Petr
> 

Hello

If your patch is applied, older revisions will stop working, right ?

What about adding a new dtb like sun7i-a20-olinuxino-lime2-revk.dts ?

Regards

> > Cc: stable@vger.kernel.org
> > Cc: Bastien Roucariès <rouca@debian.org>
> > References: https://github.com/openwrt/openwrt/issues/9153
> > References: https://github.com/OLIMEX/OLINUXINO/blob/master/HARDWARE/A20-OLinuXino-LIME2/hardware_revision_changes_log.txt
> > Signed-off-by: Petr Štetiar <ynezz@true.cz>
> > ---
> >  arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts
> > index ecb91fb899ff..8077f1716fbc 100644
> > --- a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts
> > +++ b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts
> > @@ -112,7 +112,7 @@ &gmac {
> >  	pinctrl-names = "default";
> >  	pinctrl-0 = <&gmac_rgmii_pins>;
> >  	phy-handle = <&phy1>;
> > -	phy-mode = "rgmii-id";
> > +	phy-mode = "rgmii";
> >  	status = "okay";
> >  };
> 

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] Revert "ARM: dts: sun7i: A20-olinuxino-lime2: Fix ethernet phy-mode"
@ 2022-03-15  7:37     ` Corentin Labbe
  0 siblings, 0 replies; 10+ messages in thread
From: Corentin Labbe @ 2022-03-15  7:37 UTC (permalink / raw)
  To: Petr Štetiar
  Cc: Greg Kroah-Hartman, Maxime Ripard, Bastien Roucariès,
	Chen-Yu Tsai, Jernej Skrabec, Rob Herring, stable, devicetree,
	linux-arm-kernel, linux-sunxi, linux-kernel

Le Tue, Mar 15, 2022 at 08:28:58AM +0100, Petr Štetiar a écrit :
> Petr Štetiar <ynezz@true.cz> [2022-03-08 13:55:30]:
> 
> Hi Greg,
> 
> one week has passed and as I didn't received any feedback, I'm providing more
> details in a hope to make it more clear, why I think, that this fix is wrong
> and should be reverted in LTS kernels 5.10 and 5.15.
> 
> > This reverts commit 55dd7e059098ce4bd0a55c251cb78e74604abb57 as it breaks
> > network on my A20-olinuxino-lime2 hardware revision "K" which has Micrel
> > KSZ9031RNXCC-TR Gigabit PHY. Bastien has probably some previous hardware
> > revisions which were based on RTL8211E-VB-CG1 PHY and thus this fix was
> > working on his board.
> 
> Disclaimer, I don't own A20-olinuxino-lime2 board with earlier HW revisions
> G/G1/G2 utilizing RTL8211E PHY.
> 
> My understanding is, that up to kernel version 5.9 and specifically commit
> bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay config") it was
> likely possible to use same DTS for A20-olinuxino-lime2 with KSZ9031 or
> RTL8211E PHYs (all HW revisions).
> 
> At least I was using my A20-olinuxino-lime2 HW revision K with KSZ9031 PHY
> just fine with 4.19 kernel. After upgrade to 5.10 LTS kernel my network
> stopped working, reverting stable backport commit a90398438517 ("ARM: dts:
> sun7i: A20-olinuxino-lime2: Fix ethernet phy-mode") fixed it.
> 
> From my POV proper fix for earlier HW revisions G/G1/G2 is introduction of
> sun7i-a20-olinuxino-lime2-revG.dts with a proper `phy-mode` for RTL8211E PHY.
> 
> Cheers,
> 
> Petr
> 

Hello

If your patch is applied, older revisions will stop working, right ?

What about adding a new dtb like sun7i-a20-olinuxino-lime2-revk.dts ?

Regards

> > Cc: stable@vger.kernel.org
> > Cc: Bastien Roucariès <rouca@debian.org>
> > References: https://github.com/openwrt/openwrt/issues/9153
> > References: https://github.com/OLIMEX/OLINUXINO/blob/master/HARDWARE/A20-OLinuXino-LIME2/hardware_revision_changes_log.txt
> > Signed-off-by: Petr Štetiar <ynezz@true.cz>
> > ---
> >  arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts
> > index ecb91fb899ff..8077f1716fbc 100644
> > --- a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts
> > +++ b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts
> > @@ -112,7 +112,7 @@ &gmac {
> >  	pinctrl-names = "default";
> >  	pinctrl-0 = <&gmac_rgmii_pins>;
> >  	phy-handle = <&phy1>;
> > -	phy-mode = "rgmii-id";
> > +	phy-mode = "rgmii";
> >  	status = "okay";
> >  };
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] Revert "ARM: dts: sun7i: A20-olinuxino-lime2: Fix ethernet phy-mode"
  2022-03-15  7:28   ` Petr Štetiar
@ 2022-03-15  7:51     ` Greg Kroah-Hartman
  -1 siblings, 0 replies; 10+ messages in thread
From: Greg Kroah-Hartman @ 2022-03-15  7:51 UTC (permalink / raw)
  To: Petr Štetiar
  Cc: Maxime Ripard, Bastien Roucariès, Chen-Yu Tsai,
	Jernej Skrabec, Rob Herring, stable, devicetree,
	linux-arm-kernel, linux-sunxi, linux-kernel

On Tue, Mar 15, 2022 at 08:28:58AM +0100, Petr Štetiar wrote:
> Petr Štetiar <ynezz@true.cz> [2022-03-08 13:55:30]:
> 
> Hi Greg,
> 
> one week has passed and as I didn't received any feedback, I'm providing more
> details in a hope to make it more clear, why I think, that this fix is wrong
> and should be reverted in LTS kernels 5.10 and 5.15.

Why not reverted in Linus's tree first?  Shouldn't that be also broken
here?

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] Revert "ARM: dts: sun7i: A20-olinuxino-lime2: Fix ethernet phy-mode"
@ 2022-03-15  7:51     ` Greg Kroah-Hartman
  0 siblings, 0 replies; 10+ messages in thread
From: Greg Kroah-Hartman @ 2022-03-15  7:51 UTC (permalink / raw)
  To: Petr Štetiar
  Cc: Maxime Ripard, Bastien Roucariès, Chen-Yu Tsai,
	Jernej Skrabec, Rob Herring, stable, devicetree,
	linux-arm-kernel, linux-sunxi, linux-kernel

On Tue, Mar 15, 2022 at 08:28:58AM +0100, Petr Štetiar wrote:
> Petr Štetiar <ynezz@true.cz> [2022-03-08 13:55:30]:
> 
> Hi Greg,
> 
> one week has passed and as I didn't received any feedback, I'm providing more
> details in a hope to make it more clear, why I think, that this fix is wrong
> and should be reverted in LTS kernels 5.10 and 5.15.

Why not reverted in Linus's tree first?  Shouldn't that be also broken
here?

thanks,

greg k-h

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] Revert "ARM: dts: sun7i: A20-olinuxino-lime2: Fix ethernet phy-mode"
  2022-03-15  7:37     ` Corentin Labbe
@ 2022-03-15  8:02       ` Petr Štetiar
  -1 siblings, 0 replies; 10+ messages in thread
From: Petr Štetiar @ 2022-03-15  8:02 UTC (permalink / raw)
  To: Corentin Labbe
  Cc: Greg Kroah-Hartman, Maxime Ripard, Bastien Roucariès,
	Chen-Yu Tsai, Jernej Skrabec, Rob Herring, stable, devicetree,
	linux-arm-kernel, linux-sunxi, linux-kernel

Corentin Labbe <clabbe.montjoie@gmail.com> [2022-03-15 08:37:06]:

Hi,

> If your patch is applied, older revisions will stop working, right ?

correct, in the same way new revisions stopped working when that wrong fix was
applied.

> What about adding a new dtb like sun7i-a20-olinuxino-lime2-revk.dts ?

From my POV proper fix for earlier HW revisions G/G1/G2 is introduction of
sun7i-a20-olinuxino-lime2-revG.dts with a proper `phy-mode` for RTL8211E PHY.

Cheers,

Petr

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] Revert "ARM: dts: sun7i: A20-olinuxino-lime2: Fix ethernet phy-mode"
@ 2022-03-15  8:02       ` Petr Štetiar
  0 siblings, 0 replies; 10+ messages in thread
From: Petr Štetiar @ 2022-03-15  8:02 UTC (permalink / raw)
  To: Corentin Labbe
  Cc: Greg Kroah-Hartman, Maxime Ripard, Bastien Roucariès,
	Chen-Yu Tsai, Jernej Skrabec, Rob Herring, stable, devicetree,
	linux-arm-kernel, linux-sunxi, linux-kernel

Corentin Labbe <clabbe.montjoie@gmail.com> [2022-03-15 08:37:06]:

Hi,

> If your patch is applied, older revisions will stop working, right ?

correct, in the same way new revisions stopped working when that wrong fix was
applied.

> What about adding a new dtb like sun7i-a20-olinuxino-lime2-revk.dts ?

From my POV proper fix for earlier HW revisions G/G1/G2 is introduction of
sun7i-a20-olinuxino-lime2-revG.dts with a proper `phy-mode` for RTL8211E PHY.

Cheers,

Petr

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2022-03-15  8:03 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-08 12:55 [PATCH] Revert "ARM: dts: sun7i: A20-olinuxino-lime2: Fix ethernet phy-mode" Petr Štetiar
2022-03-08 12:55 ` Petr Štetiar
2022-03-15  7:28 ` Petr Štetiar
2022-03-15  7:28   ` Petr Štetiar
2022-03-15  7:37   ` Corentin Labbe
2022-03-15  7:37     ` Corentin Labbe
2022-03-15  8:02     ` Petr Štetiar
2022-03-15  8:02       ` Petr Štetiar
2022-03-15  7:51   ` Greg Kroah-Hartman
2022-03-15  7:51     ` Greg Kroah-Hartman

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.