[PATCH] ASoC: Intel: boards: fix randconfig issue

[PATCH] ASoC: Intel: boards: fix randconfig issue

[Pierre-Louis Bossart]

on x86_64:

ERROR: modpost: "sof_dai_get_bclk"
[sound/soc/intel/boards/snd-soc-intel-sof-cirrus-common.ko] undefined!

ERROR: modpost: "sof_dai_get_mclk"
[sound/soc/intel/boards/snd-soc-intel-sof-realtek-common.ko]
undefined!

This comes from a missing dependency on at least ONE SOF platform
being selected. This dependency exists for all other machine drivers,
this was missed in the earlier reviews.

Fixes: 2fe14ff61bd6 ("ASoC: Intel: sof_ssp_amp: rename driver and support cs35l41 amplifier")
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
 sound/soc/intel/boards/Kconfig | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/sound/soc/intel/boards/Kconfig b/sound/soc/intel/boards/Kconfig
index a62785893bec..f3873b5bea87 100644
--- a/sound/soc/intel/boards/Kconfig
+++ b/sound/soc/intel/boards/Kconfig
@@ -616,6 +616,8 @@ config SND_SOC_INTEL_SOF_DA7219_MAX98373_MACH
 
 endif ## SND_SOC_SOF_JASPERLAKE
 
+if SND_SOC_SOF_HDA_LINK
+
 config SND_SOC_INTEL_SOF_SSP_AMP_MACH
 	tristate "SOF with amplifiers in I2S Mode"
 	depends on I2C && ACPI
@@ -632,6 +634,7 @@ config SND_SOC_INTEL_SOF_SSP_AMP_MACH
 	   with RT1308/CS35L41 I2S audio codec.
 	   Say Y if you have such a device.
 	   If unsure select "N".
+endif ## SND_SOC_SOF_HDA_LINK
 
 if SND_SOC_SOF_ELKHARTLAKE
 
-- 
2.30.2

Re: [PATCH] ASoC: Intel: boards: fix randconfig issue

[Randy Dunlap]

On 3/8/22 12:23, Pierre-Louis Bossart wrote:
> on x86_64:
> 
> ERROR: modpost: "sof_dai_get_bclk"
> [sound/soc/intel/boards/snd-soc-intel-sof-cirrus-common.ko] undefined!
> 
> ERROR: modpost: "sof_dai_get_mclk"
> [sound/soc/intel/boards/snd-soc-intel-sof-realtek-common.ko]
> undefined!
> 
> This comes from a missing dependency on at least ONE SOF platform
> being selected. This dependency exists for all other machine drivers,
> this was missed in the earlier reviews.
> 
> Fixes: 2fe14ff61bd6 ("ASoC: Intel: sof_ssp_amp: rename driver and support cs35l41 amplifier")
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>

Acked-by: Randy Dunlap <rdunlap@infradead.org>
Tested-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.

> ---
>  sound/soc/intel/boards/Kconfig | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/sound/soc/intel/boards/Kconfig b/sound/soc/intel/boards/Kconfig
> index a62785893bec..f3873b5bea87 100644
> --- a/sound/soc/intel/boards/Kconfig
> +++ b/sound/soc/intel/boards/Kconfig
> @@ -616,6 +616,8 @@ config SND_SOC_INTEL_SOF_DA7219_MAX98373_MACH
>  
>  endif ## SND_SOC_SOF_JASPERLAKE
>  
> +if SND_SOC_SOF_HDA_LINK
> +
>  config SND_SOC_INTEL_SOF_SSP_AMP_MACH
>  	tristate "SOF with amplifiers in I2S Mode"
>  	depends on I2C && ACPI
> @@ -632,6 +634,7 @@ config SND_SOC_INTEL_SOF_SSP_AMP_MACH
>  	   with RT1308/CS35L41 I2S audio codec.
>  	   Say Y if you have such a device.
>  	   If unsure select "N".
> +endif ## SND_SOC_SOF_HDA_LINK
>  
>  if SND_SOC_SOF_ELKHARTLAKE
>  

-- 
~Randy

Re: [PATCH] ASoC: Intel: boards: fix randconfig issue

[Cezary Rojewski]

On 2022-03-08 9:23 PM, Pierre-Louis Bossart wrote:
> on x86_64:
> 
> ERROR: modpost: "sof_dai_get_bclk"
> [sound/soc/intel/boards/snd-soc-intel-sof-cirrus-common.ko] undefined!
> 
> ERROR: modpost: "sof_dai_get_mclk"
> [sound/soc/intel/boards/snd-soc-intel-sof-realtek-common.ko]
> undefined!
> 
> This comes from a missing dependency on at least ONE SOF platform
> being selected. This dependency exists for all other machine drivers,
> this was missed in the earlier reviews.
> 
> Fixes: 2fe14ff61bd6 ("ASoC: Intel: sof_ssp_amp: rename driver and support cs35l41 amplifier")
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>


Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com>

>   sound/soc/intel/boards/Kconfig | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/sound/soc/intel/boards/Kconfig b/sound/soc/intel/boards/Kconfig
> index a62785893bec..f3873b5bea87 100644
> --- a/sound/soc/intel/boards/Kconfig
> +++ b/sound/soc/intel/boards/Kconfig
> @@ -616,6 +616,8 @@ config SND_SOC_INTEL_SOF_DA7219_MAX98373_MACH
>   
>   endif ## SND_SOC_SOF_JASPERLAKE
>   
> +if SND_SOC_SOF_HDA_LINK
> +
>   config SND_SOC_INTEL_SOF_SSP_AMP_MACH
>   	tristate "SOF with amplifiers in I2S Mode"
>   	depends on I2C && ACPI
> @@ -632,6 +634,7 @@ config SND_SOC_INTEL_SOF_SSP_AMP_MACH
>   	   with RT1308/CS35L41 I2S audio codec.
>   	   Say Y if you have such a device.
>   	   If unsure select "N".
> +endif ## SND_SOC_SOF_HDA_LINK
>   
>   if SND_SOC_SOF_ELKHARTLAKE
>   

Re: [PATCH] ASoC: Intel: boards: fix randconfig issue

[Mark Brown]

On Tue, 8 Mar 2022 14:23:18 -0600, Pierre-Louis Bossart wrote:
> on x86_64:
> 
> ERROR: modpost: "sof_dai_get_bclk"
> [sound/soc/intel/boards/snd-soc-intel-sof-cirrus-common.ko] undefined!
> 
> ERROR: modpost: "sof_dai_get_mclk"
> [sound/soc/intel/boards/snd-soc-intel-sof-realtek-common.ko]
> undefined!
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: Intel: boards: fix randconfig issue
      commit: 9779a8e61a83916ccfe7e6ddabcc7638d4bc2ae1

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark